Monday, 2016-03-21

« Sunday, 2016-03-20 Index Tuesday, 2016-03-22 »
*** salmon_ has quit IRC00:22
*** openstackgerrit has quit IRC06:17
*** openstackgerrit_ is now known as openstackgerrit06:17
*** openstackgerrit_ has joined #openstack-solar06:18
*** openstackgerrit_ is now known as openstackgerrit06:18
*** openstackgerrit_ has joined #openstack-solar06:19
*** salmon_ has joined #openstack-solar08:18
*** dshulyak has joined #openstack-solar08:34
*** dshulyak has quit IRC10:31
*** dshulyak has joined #openstack-solar10:48
pigmejdshulyak: salmon_ I need short summary about last week changes in f2s stuff10:50
dshulyakno changes in f2s from me10:51
dshulyakexcept this one - https://github.com/Mirantis/f2s/commit/9d40ed5dee56598ceaacc3b97c1396c10770841110:51
pigmejyeah but this is also in solar reviews10:51
pigmej;)10:51
dshulyakbut until solar part is merged - it is mostly irrelevant10:52
pigmejdoes something block us from merging?10:52
dshulyaki dont think so, riak and hosts example passed on both riak and pg backends10:54
dshulyakand i did some manual testing, that i can re-stage or process partially10:55
pigmejsalmon_: opinions?10:55
salmon_pigmej: about?10:57
pigmejhttps://review.openstack.org/#/c/291675/10:57
pigmejdshulyak: normal workflow is not affected at all, right?10:57
salmon_I didn't test it10:57
pigmejI did, it works, (at least it didn't break anything)11:00
salmon_then merge it :P11:02
salmon_or add +211:02
pigmejk, merging then11:05
pigmejdshulyak: merged11:05
dshulyakcan someone run solar/test/test_events.py on master?11:05
dshulyakthey are failing somehow :)11:06
pigmejon that refactored stuff?11:06
dshulyaknope11:06
dshulyakbefore that11:06
pigmejI wish I could now, but libvirt broke...11:06
pigmej;d11:06
pigmejok checking11:08
pigmejdshulyak: works for me11:10
dshulyakfrom_dict constructor is broken for me11:10
pigmejhow?11:10
dshulyakTypeError: key must be a string, instead got {'name': 'riak_service1', 'key': 'riak_service1'}11:10
pigmejeeeeeee11:10
pigmejwerird11:11
pigmejweird11:11
dshulyakcan u check if u have latest master?11:11
pigmejI do have11:11
pigmejwhat test is failing exactly ?11:11
dshulyakalmost all of them in test_events, for example test_nova_api11:12
pigmejhttps://bpaste.net/show/2bbc9e3d24a211:13
pigmejalso jenkins says that everything works...11:13
dshulyakpigmej: http://paste.openstack.org/show/491241/11:13
dshulyakbackend maybe?11:14
pigmejwtf11:14
pigmejchecking11:15
pigmejbut it shouldn't depend on backend11:15
dshulyaki am on riak11:15
pigmejoh11:15
pigmejit fails on riak11:15
pigmejwtf11:16
dshulyakfrom_dict usage in test_events is definitely broken11:16
pigmejwhy?11:16
pigmejit should be fine, because if key is a dict, then key == dict['key']11:16
pigmejweird11:17
dshulyakthe problem in on L838 in solar_models.py :)11:19
pigmejyeah11:19
dshulyak83711:19
pigmejbut it's because of get_or_create11:19
dshulyakno11:19
dshulyakbecause you passed key and not ret[0]11:19
dshulyakand key is dict11:19
pigmejhmm, we have different files...11:19
openstackgerritMerged openstack/solar: Rework staging procedure to support both implicit and explicit stages  https://review.openstack.org/29167511:20
dshulyakpigmej: https://github.com/openstack/solar/blob/master/solar/dblayer/solar_models.py#L836-L83711:20
dshulyakhttps://github.com/openstack/solar/blob/master/solar/dblayer/solar_models.py#L839-L84011:20
dshulyak:)11:20
pigmejah fuck11:20
pigmejit should return 2 items :D11:20
pigmejhmm11:20
pigmejwait11:20
pigmejit's ok11:20
pigmejdshulyak: this one is ok11:21
dshulyak839 returns ret, but on next like you do .get(key) and key is dict11:21
pigmejhttps://github.com/openstack/solar/blob/master/solar/dblayer/model.py#L87311:21
pigmejah...11:21
pigmejright11:21
pigmejret should be key, data11:22
pigmejand return should be return key, data11:22
pigmej:)11:22
pigmejgood spot11:22
pigmejdshulyak: are you going to fix it11:22
pigmej?11:22
dshulyakpigmej: yeap, will do in a moment11:25
pigmejcool :)11:26
pigmejI will merge it immediately :)11:26
pigmejwhat a stupid error by me :D:D:D11:26
openstackgerritDmitry Shulyak proposed openstack/solar: Fix typo in Resource._pre_from_dict_check  https://review.openstack.org/29522411:30
pigmejdshulyak: thx!!11:31
dshulyakjust wait until ci will pass :)11:31
pigmejI checked it by hand :P11:33
openstackgerritMerged openstack/solar: Fix typo in Resource._pre_from_dict_check  https://review.openstack.org/29522411:47
dshulyakpigmej: :D https://github.com/openstack/solar/blob/master/solar/dblayer/proxy.py#L3712:37
salmon_:)12:38
pigmejoh that was fucking smart..12:38
pigmej;D12:39
pigmej Nov 23, 2015 nice ...12:39
dshulyakcrap, scheduling based on subgraph is not easy, i need to be able to filter inprogress tasks for each policy type14:24
pigmej?14:25
openstackgerritDmitry Shulyak proposed openstack/solar: Refactoring of graph.py and usage of it in scheduler  https://review.openstack.org/29460514:48
openstackgerritDmitry Shulyak proposed openstack/solar: Refactoring of graph.py and usage of it in scheduler  https://review.openstack.org/29460514:51
openstackgerritDmitry Shulyak proposed openstack/solar: Implement traversal based on number of childs  https://review.openstack.org/29534815:20
dshulyakpigmej: nevermind :) it will take too long to explan in chat15:22
*** dshulyak has quit IRC15:22
pigmej:D15:22
pigmejand he went :P15:22
pigmejsalmon_: ^ :D15:22
salmon_:)15:39
*** dshulyak has joined #openstack-solar15:41
*** dshulyak has quit IRC16:34
*** angdraug has joined #openstack-solar19:31
*** openstackgerrit has quit IRC23:03
*** openstackgerrit_ is now known as openstackgerrit23:03
*** openstackgerrit has quit IRC23:03
*** openstackgerrit_ has joined #openstack-solar23:03
*** openstackgerrit_ is now known as openstackgerrit23:04
*** openstackgerrit_ has joined #openstack-solar23:08
*** salmon_ has quit IRC23:13
« Sunday, 2016-03-20 Index Tuesday, 2016-03-22 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!