| reed | I think I need to just get hieroglyph installed in the venv, no need to change the setup.py arguments | 00:06 |
|---|---|---|
| clarkb | https://review.openstack.org/138209 is a first draft of running jobs withzuul | 00:07 |
| jeblair | reed: oh, then probably we change setup.py to build both html and hieroglyph targets | 00:07 |
| reed | jeblair, that sounds more appropriate ... | 00:08 |
| jeblair | i just added a new large topic for developers.rst to the wiki for working with branches (eg, stable, proposed, feature) | 00:11 |
| jeblair | er, s/wiki/etherpad/ | 00:11 |
| pleia2 | it's been a long day and I have some home things to do, will be back later tonight or early tomorrow | 00:12 |
| clarkb | hrm the ref:`stuff` linking didn't work` | 00:12 |
| clarkb | gah I fail | 00:15 |
| pleia2 | missing : at the beginning of ref | 00:16 |
| clarkb | ya | 00:17 |
| clarkb | updated | 00:17 |
| clarkb | also its a warning if you don't prefix a header so I moved the target | 00:17 |
| reed | ERROR: Unknown directive type "slide". makes me think that hieroglyph is not installed in the venv. Am I right? | 00:17 |
| anteaya | clarkb: thanks for all your help today | 00:19 |
| jeblair | reed: probably so; would need to add the pypi package to requirements.txt | 00:19 |
| anteaya | clarkb: oh sorry that was pleia2, you are the same colour | 00:19 |
| anteaya | pleia2: enjoy home things, and thanks for all the help today | 00:19 |
| clarkb | reed: probably. did you put hieroglyph in requirements.txt? | 00:19 |
| reed | jeblair, I did | 00:19 |
| jeblair | reed: looks like it's https://pypi.python.org/pypi/hieroglyph, so just add 'hieroglyph' to that file... | 00:20 |
| jeblair | reed: oh, you may need to do "tox -r" ? | 00:20 |
| clarkb | you have to tox -re docs to make it rebuild the venv | 00:20 |
| jeblair | that ^ :) | 00:20 |
| reed | ah | 00:20 |
| jeblair | i have to run now; thanks everyone! | 00:21 |
| * reed does tox -re | 00:21 | |
| reed | uhm... same failure | 00:21 |
| clarkb | reed: is there code pushed I can poke at too? | 00:22 |
| reed | I can push a wip | 00:22 |
| reed | give me a sec | 00:22 |
| reed | https://review.openstack.org/#/c/138210/ not sure the approach makes sense, don't waste too much time on it | 00:25 |
| * clarkb tries a thing | 00:26 | |
| clarkb | reed: try adding hieroglyph to the list of extensions in doc/source/conf.py | 00:27 |
| clarkb | reed: this seems to make it build | 00:27 |
| reed | ah! | 00:27 |
| reed | thanks | 00:28 |
| clarkb | np | 00:28 |
| anteaya | yeah, I'm done | 00:30 |
| anteaya | I will be back tomorrow | 00:31 |
| anteaya | thanks everyone I think we made great progress today | 00:31 |
| anteaya | yay us \o/ | 00:31 |
| reed | clarkb, did you manage to get something in build/slides ? | 00:33 |
| clarkb | reed: no, I only got it to not fail let me dig more | 00:33 |
| reed | k, same here... it's not puking but that's it | 00:34 |
| clarkb | reed: one sec I will push a patch on top of yours with a tox target that works | 00:36 |
| reed | hieroglyph creates a makefile and uses sphinx-build instead | 00:36 |
| reed | so my tests so far have been with that setup... thanks clarkb | 00:37 |
| sweston | I'd be willing to write the section on project gating. Anybody have some ideas on what that section should include? | 00:38 |
| clarkb | reed: pushed, I think that is as good as it will get in the near future since pbr doesn't support a slides output with its build_sphinx target | 00:40 |
| clarkb | sweston: http://ci.openstack.org/zuul/gating.html probably the relevant bits of that | 00:41 |
| sweston | clarkb: ok, will do. thanks! | 00:42 |
| reed | thanks clarkb | 00:52 |
| reed | that looks very different from what I imagined reading the (sparse) doc | 00:54 |
| reed | when I try to disable the generation of slides from the whole document, as instructed on http://docs.hieroglyph.io/en/latest/config.html#confval-autoslides, build fails badly | 01:03 |
| reed | i'm tempted to give up | 01:03 |
| reed | it looks complicated to make slides content co-exist with narrative | 01:03 |
| reed | the text ends up being complicated to read, IMO | 01:04 |
| reed | and the rst file is already very long | 01:04 |
| jeblair | reed: what about doing explicit slides with '..slide::' instead of autoslides? | 01:06 |
| reed | jeblair, tried that but the build fails on core.rst | 01:07 |
| reed | and I'm not sure it makes sense... maybe it's an optimization that is worth considering later on, once we have content more stable | 01:07 |
| jeblair | reed: agreed on that; though i'm curious what a simple 5 slide deck on the basic getting started looks like incorporated into the doc | 01:08 |
| jeblair | at least getting that far would let us see what that would look like | 01:09 |
| reed | jeblair, ok, let me spend more time | 01:09 |
| jeblair | i have to run again, but i might be able to pitch in a bit tomorrow morning; | 01:10 |
| jeblair | reed: worst case for right now you could just remove core.rst from your test patch :) | 01:10 |
| jeblair | (or remove it from the toctree in index.rst) | 01:10 |
| reed | it's strange because it's not only core.rst but others, too... same error: AssertionError: Losing "ids" attribute: ['core-reviewer-s-guide', 'core-manual'] | 01:17 |
| reed | http://paste.openstack.org/show/143070/ | 01:18 |
| reed | and the actual log http://paste.openstack.org/show/143071/ | 01:18 |
| reed | and that only appears if autoslides = False | 01:19 |
| reed | uhm... | 01:20 |
| reed | I'm pushing up what I have, it's past my skills :( | 01:28 |
| *** chandankumar has joined #openstack-sprint | 02:04 | |
| *** chandankumar has quit IRC | 03:21 | |
| *** chandankumar has joined #openstack-sprint | 03:29 | |
| *** chandankumar has quit IRC | 04:48 | |
| *** chandankumar has joined #openstack-sprint | 05:31 | |
| *** chandankumar has quit IRC | 06:09 | |
| *** chandankumar has joined #openstack-sprint | 06:22 | |
| *** chandankumar has quit IRC | 06:27 | |
| *** chandankumar has joined #openstack-sprint | 06:44 | |
| *** reed has quit IRC | 06:54 | |
| AJaeger | good morning! | 07:04 |
| clarkb | morning | 07:20 |
| AJaeger | clarkb, take some rest! | 07:23 |
| clarkb | about to | 07:25 |
| *** nibalizer has quit IRC | 08:08 | |
| *** nibalizer has joined #openstack-sprint | 08:09 | |
| *** hashar has joined #openstack-sprint | 10:23 | |
| *** chandankumar has quit IRC | 11:28 | |
| *** chandankumar has joined #openstack-sprint | 11:28 | |
| *** hashar has quit IRC | 12:09 | |
| AJaeger | I've updated my patches and reviewed all the great patches you've done. I'll be back later (18:00 UTC or so). | 13:43 |
| *** chandankumar has quit IRC | 13:51 | |
| anteaya | I'm around | 14:19 |
| * anteaya starts to review patches | 14:24 | |
| * anteaya starts with dhellmann's patch :D | 14:26 | |
| anteaya | reed on dhellmann's patchset 9 you commented: This content is useful. I think it should go somewhere and be considered for a larger effort to create a proper place with meaningful navigation for contributors. | 14:44 |
| anteaya | reed: my understanding is that that is what this patch is doing, are you confirming that is patch is useful or are you saying that you feel something additional or different needs to happen | 14:45 |
| anteaya | fungi: do we care that puppet module names don't like hyphens? | 14:51 |
| anteaya | in that they were advocating for puppet-openstackci_apache at one point | 14:52 |
| fungi | anteaya: i expect whether we care about something like that is fairly context-specific | 14:53 |
| anteaya | fair enough, I guess we can catch that in review if there is an issue | 14:55 |
| dhellmann | anteaya: I addressed your comment on https://review.openstack.org/#/c/138094/ in a follow-up so I wouldn't lose the +2 I have. | 15:20 |
| anteaya | dhellmann: thanks +1 on both | 15:28 |
| fungi | dhellmann: anteaya: ahh, there's the context i was missing | 15:30 |
| dhellmann | ? | 15:30 |
| fungi | hah, nevermind. clearly i need a second cup of coffee | 15:30 |
| fungi | i read the diff backwards | 15:30 |
| fungi | anteaya: what was your nit on 138163? looks like it didn't save (maybe a comment on an earlier patchset?) | 15:32 |
| *** chandankumar has joined #openstack-sprint | 15:32 | |
| anteaya | it didn't save | 15:34 |
| anteaya | my nit is the empty last line at the end of the file | 15:34 |
| anteaya | and I can't find a draft on an earlier patchset either | 15:34 |
| fungi | weird | 15:34 |
| fungi | maybe a gertty bug? | 15:34 |
| anteaya | odd, maybe I didn't save the comment before I navigated away | 15:34 |
| fungi | or that | 15:34 |
| anteaya | let's go with my fault this time | 15:34 |
| anteaya | I think it is just morning brain | 15:35 |
| fungi | i too suffer from this affliction | 15:35 |
| anteaya | glad I'm not alone | 15:36 |
| anteaya | fungi: oh and I wasn't using gertty, just the gerrit ui | 15:39 |
| * anteaya needs to be using gertty | 15:39 | |
| jeblair | yay it's not my fault for once! :) | 16:01 |
| * nibalizer tries to review | 16:01 | |
| anteaya | jeblair: yay | 16:02 |
| anteaya | nibalizer: thank you | 16:02 |
| anteaya | pretty sure it was my fault | 16:02 |
| clarkb | I will get up and review comments on my changes shortly | 16:03 |
| anteaya | hey clarkb | 16:03 |
| clarkb | morning | 16:03 |
| anteaya | okay I now figured out how to link to a random file that isn't a guide in itself: http://docs-draft.openstack.org/51/104951/16/check/gate-infra-manual-docs/5dd41eb/doc/build/html/developers.html#getting-started | 16:04 |
| anteaya | click Here are some additional details. | 16:05 |
| anteaya | it needs some cleanup but I think this will solve the 'provide hand holding details without frustrating experience devs' problem | 16:05 |
| *** reed has joined #openstack-sprint | 16:14 | |
| anteaya | so for my git clone url: http://docs-draft.openstack.org/51/104951/16/check/gate-infra-manual-docs/5dd41eb/doc/build/html/developers.html#learn-the-gerrit-workflow-in-the-sandbox it is rendering with backticks | 16:23 |
| anteaya | which was not my intention | 16:23 |
| clarkb | fungi can normal gerrit users (with the right acls) not delete branches in the gerrit ui? | 16:23 |
| anteaya | I'll try double quotes | 16:25 |
| fungi | clarkb: after discussing it with ttx it sounds like he has the ability to delete proposed/* branches, so need to figure out what the right acl is to allow branch deletion | 16:25 |
| fungi | from what we saw in the past, it requires more than branch creation does | 16:25 |
| clarkb | oh I remember. it requires ownership | 16:26 |
| clarkb | and we don't want to delegate that out everywhere because it comes with other rights | 16:26 |
| clarkb | so ya your suggestion is good | 16:26 |
| fungi | do we have owner set on refs/heads/proposed/* which is making this possible for ttx? | 16:26 |
| clarkb | I think that must e it | 16:26 |
| fungi | i'm looking to see if i can figure it out | 16:27 |
| fungi | yep, we do | 16:27 |
| jeblair | fungi: yes, release managers owns refs/heads/proposed/* | 16:27 |
| fungi | i see that in all-projects | 16:27 |
| fungi | so right, this is not something we're going to be able to extend to stackforge project teams | 16:28 |
| clarkb | my change is updated | 16:28 |
| fungi | awesome | 16:28 |
| clarkb | all three of my changes have been updated at this point | 16:35 |
| fungi | clarkb: sprint-ish, see comments on 137240 | 16:36 |
| clarkb | fungi: thank you will address | 16:38 |
| anteaya | I'm feeling like it would make more sense to abandon https://review.openstack.org/#/c/104951/17 and create a new patch since all I am doing is generalizing the URL to use <projectname> rather than nova and add a link to the sandbox file | 16:57 |
| anteaya | jeblair: 6 | 16:58 |
| anteaya | ^ | 16:58 |
| clarkb | anteaya: might be nice to just do it within the same change so you can see review history of it | 16:58 |
| pleia2 | AJaeger: thanks re: cross-project dependencies | 16:58 |
| anteaya | I'm uncertain how to wipe out all my changes and just return to the way it was before I started | 16:59 |
| clarkb | anteaya: git reset --hard sha1 is one way | 17:00 |
| anteaya | I'll try that, thanks | 17:01 |
| anteaya | no that takes me back to the last commit in the log and removes my commit message and change id | 17:05 |
| pleia2 | I just copy the commit message again from gerrit (incl change id) | 17:08 |
| anteaya | that is another option | 17:15 |
| anteaya | jeblair: you don't think we need a new directory to house random files that are not guides? https://review.openstack.org/#/c/138195/4//COMMIT_MSG | 17:51 |
| anteaya | I'm picturing quite a few tutorial kind of files that are stand alone linked content | 17:52 |
| anteaya | am I wrong? | 17:52 |
| *** AJaeger_ has joined #openstack-sprint | 17:53 | |
| AJaeger_ | Good morning! | 17:53 |
| AJaeger_ | I've updated https://review.openstack.org/138272 with all the review comments. Looking at developers.rst I still notice many places that use patch instead of change. Should we change that as well? | 17:54 |
| anteaya | morning AJaeger_ | 17:54 |
| jeblair | anteaya: i'm not seeing the need for a directory now. but if we did want subdirs, i'd expect that we would either want to split them up based on the 3/4/5 guides. or perhaps a directory for 'tutorials'. a directory named content (that's one level down from most of the content) doesn't seem necessary. | 17:55 |
| anteaya | okay I can remove it for now | 17:59 |
| anteaya | I think we could use a directory for tutorials | 17:59 |
| anteaya | AJaeger_: I didn't know we were losing patch :( | 18:00 |
| AJaeger_ | anteaya: see the review comments on 138272 | 18:01 |
| AJaeger_ | The suggestion was to use "change" instead of "patch". | 18:01 |
| pleia2 | morning AJaeger_ | 18:01 |
| anteaya | AJaeger_: yes I saw | 18:02 |
| AJaeger_ | the gerrit documentation uses "change". | 18:03 |
| pleia2 | we do use "patchset" a lot elsewhere | 18:03 |
| AJaeger_ | yeah, seems a change consists of several patchsets... | 18:04 |
| AJaeger_ | let me send a patch and then discuss it there... | 18:05 |
| anteaya | you mean a change | 18:05 |
| jeblair | so if we're being technical... | 18:05 |
| AJaeger_ | thanks, anteaya ! | 18:05 |
| jeblair | git works with 'patchsets' | 18:05 |
| jeblair | when you push one of those to gerrit, you have a 'change' which is a potential commit (of a patchset) that may be merged to the repo | 18:06 |
| jeblair | a change has a collection of one or more alternate patchsets, only the latest of which might be merged | 18:06 |
| *** chandankumar has quit IRC | 18:07 | |
| AJaeger_ | jeblair: thanks for the explanation | 18:07 |
| AJaeger_ | jeblair: https://review.openstack.org/138467 is the change that changes patch to patchset or change | 18:10 |
| AJaeger_ | dhellmann: I used numbered lists to give a procedure like display for your mega change - see https://review.openstack.org/138470 | 18:20 |
| AJaeger_ | Reviews on 138470 and feedback whether I should continue changing the rest of the file is appreciated. | 18:22 |
| pleia2 | AJaeger: what's the difference between #. and using 1, 2, etc? | 18:26 |
| pleia2 | I'd imagine you'd always want to use #. | 18:26 |
| clarkb | I have updated my changes that got -1s. | 18:27 |
| clarkb | pleia2: nibalizer jeblair ^ | 18:27 |
| pleia2 | thanks clarkb | 18:27 |
| AJaeger_ | pleia2: #. is autonumbering | 18:27 |
| AJaeger_ | pleia2: I could not use #. in the one case, the note breaks the list, so the one after it was a 1 again. | 18:27 |
| pleia2 | gotcha :) | 18:27 |
| pleia2 | thanks | 18:27 |
| jeblair | reed: i think the slide errors come from files that have no slidse; if you put a slide in them, it works | 18:27 |
| reed | jeblair, that's surprising | 18:28 |
| jeblair | reed: so i think if we want to have files without slides, we may need to figure out a way to tell sphinx-build to run on specific files, not all of them | 18:28 |
| nibalizer | clarkb: thanks | 18:29 |
| AJaeger_ | thanks, clarkb. Looks fine! | 18:29 |
| reed | jeblair, do you think it's a bug? | 18:29 |
| jeblair | reed: but if you want to continue playing around, you could just stick an empty slide in each file | 18:29 |
| reed | jeblair, got it... ok, I'll spend some more time on that test this afternoon | 18:29 |
| reed | jeblair, thanks for trying out | 18:30 |
| clarkb | dhellmann: when oslo concurrency is sorted out do you want to update https://review.openstack.org/#/c/138094/14 to address pleia2's concerns or maybe write a second follow up patch? | 18:30 |
| jeblair | reed: i'm not entirely sure if it's a bug; i'm not sure if this is a use-case that they designed for. | 18:30 |
| nibalizer | clarkb: you have my votes, and they are positive | 18:31 |
| reed | autoslides = false looks to me like 'don't build slides unless there is the slide directive' | 18:31 |
| jeblair | reed: yep, though it looks like they were expecting all the files (or at least all the top level sections) to have at least one slide. | 18:36 |
| jeblair | reed: the code goes through and removes sections without slides, but the error it hits is a failsafe where it's refusing to remove a section with a linkable identifier. | 18:37 |
| clarkb | pleia2: would you be ok with a follow up patch to dhellmann's 138094 change? | 18:38 |
| anteaya | I had to fix a heating issue, back now | 18:38 |
| clarkb | pleia2: I kinda want 138094 to get in since its huge then we can refine with those additional improvements | 18:38 |
| pleia2 | clarkb: that's fine | 18:38 |
| AJaeger_ | clarkb: let's get it 138094 in... | 18:39 |
| pleia2 | they weren't major issues, just clarifications | 18:39 |
| anteaya | meeting in 21 minutes | 18:39 |
| clarkb | jeblair: anything else you wanted to look at on 138094 before we approve it? | 18:42 |
| AJaeger_ | fungi, thanks for fixing my patch! | 18:44 |
| jeblair | clarkb: i'll give it a once over and +2 | 18:45 |
| clarkb | jeblair: thanks | 18:45 |
| fungi | AJaeger_: i hate leaving a nit-picky -1 for a single character. easier to just fix it myself | 18:46 |
| fungi | if there were more substantial changes needed i'd have let you handle it | 18:47 |
| jeblair | approved 138094 | 18:48 |
| clarkb | jeblair: gerrit says you only +2'd | 18:49 |
| clarkb | gertty bug or maybe you hit 2 instead of 3? | 18:50 |
| jeblair | clarkb: hrm, i thought i hit 2 then 3 after i saw your vote. i may have missed it. anyway fixed. | 18:50 |
| jeblair | clarkb: do you want to review 138177; it's ready | 18:51 |
| clarkb | sure | 18:51 |
| jeblair | AJaeger_: did you switch from autonumbering to explicit numbering because of the .. note:: ? | 18:54 |
| pleia2 | yeah, he explained that to me earlier | 18:54 |
| jeblair | AJaeger_: if so, maybe the .. note:: could be indented so it's under the list item, and then maybe it would work? | 18:54 |
| clarkb | fungi: in 138177 you describe how gerrit admins can do all the things. for reseting votes is there a better way than using the DB? you seem to imply there is and I am unaware of what the non db option is | 18:55 |
| jeblair | AJaeger_: yeah, that works. i think that's better too. will leave comment | 18:56 |
| fungi | clarkb: gerrit admins generally at least have solutions open to them that core reviewers and change owners on the whole may not | 18:57 |
| fungi | clarkb: what do you mean by "resetting votes" in this sense? | 18:57 |
| clarkb | fungi: remove the -2 | 18:57 |
| fungi | clarkb: as in delete the vote? the little [x] next to it | 18:57 |
| clarkb | wow how have I never known about this? I guess I don't spend much time in super power mode | 18:58 |
| pleia2 | hehe | 18:58 |
| jeblair | clarkb: it's there all the time :( | 18:58 |
| fungi | clarkb: yeah, just having your account in the administrators group makes it available | 18:58 |
| jeblair | it's like the one thing that leaks into daily life for admins :/ | 18:58 |
| clarkb | wait | 18:59 |
| clarkb | thats what that does | 18:59 |
| clarkb | wow how did I never notice | 18:59 |
| * fungi literally lol'd | 18:59 | |
| jeblair | clarkb: now pretend it's not there :) | 18:59 |
| AJaeger_ | jeblair: yeah, will do - thanks! | 18:59 |
| fungi | once you've seen it, you can't un-see it | 18:59 |
| pleia2 | glad I'm not the only one learning things from reading these reviews :D | 19:00 |
| clarkb | jeblair: I will do my best | 19:00 |
| clarkb | meeting time | 19:00 |
| fungi | yup | 19:00 |
| AJaeger_ | pleia2: I learn as well ;) | 19:00 |
| dhellmann | clarkb, pleia2: I hadn't seen the comments so sorry for any delay. A couple of follow-up patches would be appropriate. I'm not sure I'll have time to do those today (meetings). | 19:11 |
| clarkb | dhellmann: ya we can handle it | 19:11 |
| pleia2 | dhellmann: no worries | 19:11 |
| dhellmann | clarkb, pleia2 : ok, thanks | 19:12 |
| anteaya | thanks AJaeger_ for the patch -> change catches, I had thought I got them | 19:19 |
| anteaya | AJaeger_: can we discuss punctuation at the end of a URL if the URL is at the end of the sentence? | 19:20 |
| anteaya | personally I don't like putting a . at the end of a URL if the URL is at the end of the sentence | 19:20 |
| AJaeger_ | anteaya: let me experiment with your patch before discussion... | 19:20 |
| anteaya | it gets interpreted as part of the URL rahter thank part of the sentence | 19:20 |
| anteaya | sure | 19:20 |
| pleia2 | hm, it shouldn't | 19:21 |
| AJaeger_ | anteaya: it shouldn't - that's why I want to check it | 19:21 |
| anteaya | okay thanks | 19:21 |
| AJaeger_ | if you write the text as "http://URL." the period will be part of the URL, it needs an extra space to work | 19:25 |
| pleia2 | so at the end of http://docs.openstack.org/infra/manual/developers.html#working-on-specifications-and-blueprints the specs url doesn't include the period | 19:26 |
| AJaeger_ | anteaya: you could also make "sandbox repository" the name of the link and remove it | 19:26 |
| pleia2 | maybe because it ended in / | 19:26 |
| AJaeger_ | pleia2, anteaya: The text is currently "http://URL/", if you change it to "http://URL/.", the "." is part of the URL but if you write "http://URL." it's not | 19:27 |
| anteaya | AJaeger_: I can do URL . | 19:27 |
| AJaeger_ | pleia2: exactly | 19:27 |
| pleia2 | aha :) | 19:27 |
| anteaya | if that is what you want, or I can remove the / | 19:27 |
| AJaeger_ | pleia2: good spotting - I verified quickly ;) | 19:27 |
| anteaya | I did want them to see the URL | 19:27 |
| anteaya | I'll remove the / | 19:27 |
| AJaeger_ | anteaya: remove the "/" | 19:27 |
| anteaya | thanks | 19:27 |
| AJaeger_ | thanks, anteaya | 19:27 |
| anteaya | thank you | 19:28 |
| *** hashar has joined #openstack-sprint | 20:03 | |
| *** hashar has quit IRC | 20:04 | |
| pleia2 | ok, I think I'm caught up with reviews | 20:06 |
| pleia2 | anteaya: thoughts on when we wrap this up? | 20:08 |
| pleia2 | I'm going to grab lunch now, and have some other work I really need to get to this afternoon, and am out the door in 5 hours (5pm my time) for an event this evening | 20:08 |
| anteaya | we said 48 hours from 1500 utc monday | 20:09 |
| pleia2 | ok | 20:09 |
| anteaya | so if we have anybody keen to keep going beyond end of day today, that is great | 20:09 |
| anteaya | but I think mostly end of day today | 20:09 |
| anteaya | what ever that means to each person | 20:09 |
| pleia2 | we've made good progress, is there anything specific we want to tackle before the end? | 20:10 |
| AJaeger_ | I'll finish at the hour - have no plans to send in another patch but stay up to date with reviews and fixes | 20:10 |
| AJaeger_ | pleia2: thanks for the whitespace spotting | 20:13 |
| anteaya | pleia2: ah sorry was in meeting | 20:22 |
| anteaya | I think we hit the highlights | 20:22 |
| anteaya | noone picked up snippets but that is okay obviously we didn't need them this time | 20:22 |
| anteaya | and we merged many things | 20:22 |
| anteaya | and addressed some manual wide pain points so that is good | 20:22 |
| * pleia2 nods | 20:24 | |
| pleia2 | tomorrow morning I'll grab stats for what we got done and share them | 20:24 |
| clarkb | I am waiting on AJaeger_'s change to pblish drafts to see the number list | 20:24 |
| clarkb | pleia2: do we have a change for your suggestion against dhellmann's change? I can write it if not | 20:25 |
| pleia2 | clarkb: I don't | 20:25 |
| clarkb | ok let me do that then you can review it | 20:25 |
| pleia2 | clarkb: for my first comment, I don't know the answer :) | 20:25 |
| pleia2 | thanks | 20:26 |
| AJaeger_ | anteaya: we should review the final content and see whether snippets would help. For me it's time to step back and reread everything in context. | 20:26 |
| AJaeger_ | I'm impressed by the number and quality of patches I've seen - and great reviews! | 20:26 |
| clarkb | pleia2: I think for the first one its going to be look up email in gerrit/git, email to that address | 20:26 |
| clarkb | its going to be somewhat handwavy | 20:27 |
| AJaeger_ | clarkb: which change? | 20:27 |
| clarkb | AJaeger_: 138470 | 20:27 |
| AJaeger_ | clarkb: that has built already some time ago, hasn't it? | 20:28 |
| AJaeger_ | ah, 4 minutes ago... | 20:28 |
| AJaeger_ | just when you mentioned it;) | 20:28 |
| clarkb | oh let me look | 20:29 |
| clarkb | I just rebase my re-approval change as it conflicted with the WIP change | 20:29 |
| anteaya | AJaeger_: good plan | 20:30 |
| anteaya | yes I think all in all the sprint has been a roaring success | 20:31 |
| anteaya | I don't think we could do more than 2 days though | 20:31 |
| anteaya | I see folks being pulled away in different directions | 20:31 |
| pleia2 | yeah | 20:32 |
| clarkb | pleia2: rereading I think its saying just get someone with credentials. Which maybe its better to remove that and suggest people create credentials if they are doing this work | 20:33 |
| clarkb | pleia2: because really if you ware managing releases on pypi even via our tooling you should probabl have that | 20:33 |
| pleia2 | wfm | 20:34 |
| pleia2 | AJaeger_: are we going to merge 138470 as is, or will you do the whole page in that patch? | 20:36 |
| anteaya | I'm going to see if I can get a walk in | 20:36 |
| anteaya | I should be back in an hour | 20:36 |
| pleia2 | anteaya: enjoy! | 20:36 |
| anteaya | thanks | 20:36 |
| AJaeger_ | "project gating" has still a TBD | 20:37 |
| pleia2 | it's a little unclear to me what content is wanted there | 20:37 |
| AJaeger_ | pleia2: For 138470 I did all the numbers where sections were procedures, so yes, it's done - and merged ;) | 20:38 |
| AJaeger_ | pleia2: If you think I missed some, let's do a followup | 20:38 |
| pleia2 | AJaeger_: ok, great :) | 20:38 |
| fungi | there are still a few non-wip changes in https://review.openstack.org/#/q/project:openstack-infra/infra-manual+status:open,n,z which need a second (not-me) core review/approval | 20:40 |
| clarkb | pleia2: ok uploaded those two changes | 20:42 |
| pleia2 | cool, reviewing now | 20:42 |
| clarkb | fungi: I got the one I haven't written :) | 20:43 |
| fungi | i'll also upload a polished 138206 and +2 it in a moment | 20:43 |
| clarkb | fungi: maybe you should approve my changes if they appear non controversial? eg have a few +1s too? | 20:43 |
| fungi | will do in just a sec' | 20:43 |
| * pleia2 waits for mr jenkins to do his thing | 20:48 | |
| pleia2 | lunchtime | 20:55 |
| AJaeger_ | pleia2: enjoy! | 20:55 |
| * AJaeger_ waves good bye! Thanks for a fun sprint! | 20:56 | |
| *** AJaeger_ has quit IRC | 20:56 | |
| clarkb | jeblair's release management doc says you can push new branches to gerrit | 20:58 |
| clarkb | I thought that required force push which we give to no one | 20:58 |
| fungi | oh, i thought it walked through using the webui only | 20:59 |
| jeblair | let's ask ttx about it, he suggested we add that. perhaps it may be that if you can create a branch, you can push an initial commit to it in order to create it but otherwise can not push once it exists? | 20:59 |
| clarkb | line 50ish | 21:00 |
| clarkb | oh I bet | 21:00 |
| fungi | ahh, right, not sure if that requires push --force or not | 21:00 |
| fungi | i didn't think it did | 21:00 |
| clarkb | ya if you are just attaching a branch to existing sha1 that may not require force | 21:00 |
| clarkb | force is needed for pushing in code that doesn't exist yet | 21:00 |
| fungi | i'm going to approve clarkb's 138204 and 138530 changes unless anyone has any last-minute objections | 21:34 |
| fungi | those are the only open non-wip infra manual changes at this point, and they have no negative votes or inline comments | 21:35 |
| clarkb | I am biased but go for it :) | 21:35 |
| fungi | oh, pleia2 had an inline meh on 138530 | 21:35 |
| fungi | pleia2: worth changing that, or okay as-is? | 21:36 |
| fungi | i'm going to assume your +1 means you're fine there | 21:36 |
| pleia2 | yeah, it's fine | 21:43 |
| fungi | both approved | 21:46 |
| * fungi looks forward to seeing the sprint stats tomorrow | 21:46 | |
| fungi | i feel like we grew more documentation in the past two days than in the entire juno dev cycle ;) | 21:46 |
| fungi | the infra-manual changes had a follow-on effect in our other projects too, for example dhellmann's change to add published docs for git-review https://review.openstack.org/138160 | 21:48 |
| anteaya | yay | 22:11 |
| anteaya | let's see if our stats can reflect that too, can we pleia2? | 22:12 |
| pleia2 | could probably figure out LoC change across rst files | 22:32 |
| *** reed has quit IRC | 22:59 | |
| *** reed has joined #openstack-sprint | 23:11 | |
| *** reed has quit IRC | 23:11 | |
| *** reed has joined #openstack-sprint | 23:11 | |
| anteaya | that would be interesting | 23:15 |
| anteaya | I see nothing in my infra-manual review queue, it took me two days to get my one patch beaten mostly into shape for which I am ashamed | 23:45 |
| anteaya | and I have mostly no energy left | 23:45 |
| anteaya | we did merge a lot of code though | 23:45 |
| anteaya | yay us | 23:45 |
| sweston | anteaya: that's nothing to be ashamed of, we are all learning ... I just spend the better part of two days learning mock | 23:50 |
| anteaya | sweston: great, how is mock treating you? | 23:51 |
| sweston | just getting started on the gating section now ... this morning at 10 after being up for two days I decided to get a little rest .. anyway, should have an initial draft pushed in an hour or less. | 23:51 |
| anteaya | you have to get regular sleep | 23:54 |
| anteaya | not sleeping doesn't scale | 23:54 |
| sweston | anteaya: any library that does reflection is difficult to work with, but in consideration of other code which attempts to do this, it works rather well | 23:54 |
| anteaya | and you don't do good work with no sleep | 23:54 |
| anteaya | good | 23:54 |
| sweston | anteaya: so true about the regular rest .. hopefully things will slow down a bit here soon | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!