fungi | also, if some patches don't make it in before the end of the sprint, the remainder will be a lot easier to knock out over the next couple days | 00:00 |
---|---|---|
asselin_ | jenkins failed on this one: https://review.openstack.org/#/c/150960/ | 00:00 |
clarkb | I will have to pop out to brave traffic shortly | 00:00 |
clarkb | but will be back and reviewing this evening too | 00:00 |
clarkb | looks like most of the things are either approved or waiting for git repos to show up right now | 00:00 |
fungi | asselin_: looks like more git connectivity problems | 00:01 |
fungi | "fatal: Could not read from remote repository" | 00:01 |
clarkb | ya I really wonder if glibc broke something | 00:01 |
jeblair | i think you can actually just 'recheck' that | 00:01 |
clarkb | +1 to recheck | 00:01 |
asselin_ | ok will recheck | 00:01 |
clarkb | show errors against haproxy doesn't list any errors so haproxy claims to be happy | 00:04 |
* asselin_ going out for an hour or so | 00:06 | |
clarkb | yup me too | 00:07 |
nibalizer | rebasing 150905 | 00:22 |
fungi | nibalizer: thanks--i'll reapprove when you're done | 00:23 |
fungi | nibalizer: don't forget that it's got 150857 stacked on it so you want to make sure to rebase both of them | 00:24 |
nibalizer | oh i just pulled it off 857 and restacked it on master | 00:25 |
nibalizer | im confused aout 857's status | 00:26 |
nibalizer | since it seems to have been told to 'go' | 00:26 |
nibalizer | but i dont see it being checked in zuul's status page | 00:26 |
nibalizer | but it has the -2 verified | 00:26 |
nibalizer | but no tests seem to have failed, and it doesn' thave the 'merge conflict' | 00:26 |
fungi | 150857 depends on the previous patchset of 150905 | 00:26 |
fungi | they were stacked on one another presumably because they otherwise merge-conflict with one another | 00:27 |
fungi | though looks like they shouldn't at this point. they modify opposite ends of the list | 00:28 |
fungi | so rebase 150857 on tip of master and it'll likely be fine | 00:28 |
fungi | though it might merge-conflict with something else in flight, that would happen regardless | 00:28 |
mmedvede | I have remaining modules that all depend on 151041. Should I wait for it to get merged? | 00:28 |
nibalizer | ok | 00:33 |
* nibalizer rebases 150857 | 00:35 | |
nibalizer | rebased | 00:39 |
jeblair | i'm back for a few mins | 00:39 |
jeblair | looks like 882 932 and 960 have failures | 00:41 |
jeblair | fixing 882 | 00:42 |
jeblair | i'll fix the others too | 00:43 |
nibalizer | cool | 00:45 |
jeblair | nibalizer: can you look at http://logs.openstack.org/32/150932/3/check/gate-infra-puppet-apply-precise/ac43b74/console.html | 00:46 |
jeblair | that's for 932... i can't find what went wrong there | 00:46 |
jeblair | it's a bit of a train wreck :( | 00:46 |
nibalizer | sure | 00:48 |
jeblair | clarkb, fungi, jhesketh: can you aprv 150889? | 00:54 |
nibalizer | jeblair: ya idunno | 00:54 |
nibalizer | this maybe ? http://logs.openstack.org/32/150932/3/check/gate-infra-puppet-apply-precise/ac43b74/console.html#_2015-01-28_23_03_08_813 | 00:54 |
clarkb | jeblair repo exists? | 00:55 |
jeblair | nibalizer: if that's the case, we might be in trouble | 00:55 |
jeblair | nibalizer: the change is just adding a new repo, so it shouldn't fail on something like that | 00:55 |
jeblair | clarkb: yes, but considering that the active cores are about to go offline, i think we should go ahead and approve all of those changes | 00:56 |
nibalizer | also the maillist type is in puppet core | 00:57 |
nibalizer | so we could only get that if puppet felt it was unable to manipulate the underlying mail system | 00:57 |
nibalizer | anyways i kinda doubt its the error | 00:57 |
nibalizer | is anyone rebasing 150917 ? if not I will | 00:59 |
nibalizer | Error: Could not find a suitable provider for maillist appears in successful apply-test runs | 01:00 |
jhesketh | jeblair: it's in a conflict | 01:02 |
* jhesketh will rebase | 01:02 | |
jeblair | we just got a batch of results in; a few merges and a few -2s | 01:04 |
jeblair | working on 150881 | 01:04 |
jhesketh | 150889 is rebased and ready for re-review | 01:05 |
jeblair | jhesketh: aprvd (but feel free to self-reapprove after a rebase (and a double-check in review)) most of these are simple enough for that | 01:06 |
jhesketh | noted | 01:07 |
jeblair | 150881 rebased | 01:08 |
jeblair | rebasing 150962 | 01:08 |
jeblair | win 21 | 01:08 |
* jhesketh is doing 150852 | 01:09 | |
* nibalizer just did 150917 | 01:09 | |
jeblair | rebasing 150972 | 01:10 |
jhesketh | er, 150852 doesn't need a rebase... moving onto 150972 | 01:10 |
jhesketh | *150892 (pastfail) | 01:11 |
jeblair | rebasing 151041 | 01:12 |
jhesketh | rebasing 150983 | 01:13 |
jeblair | mmedvede: still around? | 01:15 |
mmedvede | jeblair: still here | 01:15 |
jeblair | mmedvede: 151041 failed: https://jenkins07.openstack.org/job/gate-project-config-layout/437/consoleFull | 01:15 |
jeblair | mmedvede: | 01:15 |
jeblair | 2015-01-29 00:56:03.824 | Job gate-puppet-openssl-puppet-lint not defined | 01:15 |
jeblair | 2015-01-29 00:56:03.824 | Job gate-puppet-openssl-puppet-syntax not defined | 01:15 |
jeblair | mmedvede: so probably need to add that to the jjb config | 01:16 |
mmedvede | jeblair: ok | 01:17 |
nibalizer | hrm | 01:18 |
* asselin_ back | 01:18 | |
nibalizer | did we end up with an openssl module? | 01:18 |
nibalizer | i had thought i'd refactored that out | 01:18 |
jeblair | nibalizer: oh, that was to fix up an error from the "pre-merge" change, but maybe we should just remove that rather than fix it then. :) | 01:20 |
jeblair | mmedvede: ^ | 01:20 |
mmedvede | nibalizer: factored out? can somebody confirm? | 01:21 |
mmedvede | I saw leftover from openssl in project-config | 01:21 |
jeblair | mmedvede: I36a27c5cddd2c4cbdd95cdcc015e54780fd441ae | 01:22 |
mmedvede | jeblair: ok, my bad... removing | 01:23 |
jeblair | mmedvede: no prob; lots of stuff is changing :) | 01:23 |
mmedvede | :) | 01:24 |
nibalizer | 150886 rebased | 01:24 |
jhesketh | hmm, centos puppet apply seems to be timing out... | 01:24 |
jeblair | wait time for nodes is down to about 20 mins now | 01:24 |
jeblair | jhesketh: yeah, we've noticed that happening a lot. we haven't figured out why. we're wondering if the libc update had something to do with it. or maybe it's been happening for a while and we're only noticing it because we're looking at a lot of changes that do a lot of cloning from centos... | 01:25 |
jeblair | jhesketh: seems to mostly be on the centos nodes though (and related to git clones) | 01:26 |
jhesketh | interesting | 01:26 |
jeblair | 150966 is ready for approval | 01:33 |
asselin_ | anyone who what the status 'review' is supposed to indicate in storyboard? | 01:34 |
jeblair | asselin_: i think it is supposed to be 'in review' | 01:34 |
jeblair | we seem to have lost the word 'in' for that one and 'in progress' | 01:34 |
jeblair | asselin_: (not too important now; eventually gerrit will auto-update it when someone posts a patch) | 01:35 |
asselin_ | ok | 01:35 |
jeblair | 150977 is ready for approval | 01:36 |
asselin_ | I'll rebase https://review.openstack.org/#/c/150888/ | 01:36 |
jeblair | asselin_: i don't think your rebase of 888 is right (see comments) | 01:40 |
asselin_ | jeblair, yes, fixing | 01:41 |
mmedvede | I think I would abandon 151041, and just get those in the module patches themselves. | 01:42 |
jeblair | mmedvede: either way ... but isn't 151041 correct now? if it doesn't need further work, why not just merge it? | 01:44 |
asselin_ | fixed | 01:44 |
asselin_ | will rebase https://review.openstack.org/#/c/150881/ | 01:44 |
mmedvede | jeblair: it should be correct | 01:44 |
jeblair | mmedvede: let's go ahead and do that then. if it doesn't work out this time, then abandon it :) | 01:44 |
mmedvede | jeblair: ok. Actually I was under impression it my get in conflict. But I am wrong, because it does not touch the same files | 01:45 |
jeblair | mmedvede: right, and it makes the other ones so much easier to review | 01:45 |
jeblair | (and rebase, etc) | 01:45 |
jeblair | i'll rebase 150932 | 01:46 |
clarkb | ok I am back from driving the vehicle. Anything I should jump on right away? | 01:48 |
jeblair | clarkb: review 151041 ? | 01:49 |
clarkb | that was an easy one. done | 01:51 |
jhesketh | I'll rebase 150917, 150889, 150881 | 01:51 |
asselin_ | I'm doing 150881 | 01:51 |
jhesketh | noted | 01:51 |
asselin_ | but running into issues trying to rebase it ontop of ulimit to avoid another merge conflict... | 01:52 |
jeblair | rebasing 150983 | 01:53 |
clarkb | jeblair: and you figure approve things now so they can be rechecked if the repos aren't ready? | 01:57 |
jeblair | clarkb: i've been at least +2ing them and planned to leave them all with approvals before we got down to <= 1 core | 01:57 |
clarkb | kk | 01:58 |
jeblair | clarkb, jhesketh: 150959 is ready for aprv | 01:58 |
clarkb | done | 01:59 |
clarkb | 150964 too looking at it now | 01:59 |
jhesketh | jeblair, clarkb: rebased 150959 | 01:59 |
asselin_ | https://review.openstack.org/#/c/150881/ is ready for approval | 02:00 |
clarkb | looks like jeblair just approved ^ | 02:00 |
jeblair | i'm just sitting in f3 in gertty and reviewing any changes that light up :) | 02:10 |
jeblair | it's eod for me; i'm going to forage for food; i might pop in later and see if i can unblock anything | 02:20 |
jhesketh | seeya! | 02:20 |
asselin_ | I need to get going. Amazing how many patches went through. | 02:21 |
asselin_ | about 107! | 02:22 |
jeblair | this has been really fun, btw :) (and anyone who says we aren't supposed to be having fun is wrong!) | 02:22 |
asselin_ | merged/open/abonded, etc. :) | 02:23 |
mmedvede | :) | 02:23 |
pleia2 | had to step away for some travel+talk prep and the backscroll is eek, has anyone looked at updating the docs yet? | 02:23 |
clarkb | pleia2: no, but that brings up a good qusetion. What is our prescribed way for adding a new thing | 02:24 |
clarkb | at this point I suppose its propose a new repo not new module in system-config | 02:24 |
pleia2 | yeah, I was thinking a simpler update for tonight, getting rid of our module/foo references in system-config to point at puppet-foo | 02:25 |
clarkb | +1 | 02:25 |
pleia2 | ok, I'll get that started | 02:27 |
clarkb | I need to step out and put together a few things amazon delivered. I now have a robot vacuum and a coat rack and a drying rack | 02:27 |
clarkb | its amazing what you can get delivered to your door for free | 02:27 |
pleia2 | hehe | 02:27 |
pleia2 | have fun | 02:28 |
clarkb | (free delivery, you have to pay for the things) | 02:28 |
pleia2 | alright, first passthrough https://review.openstack.org/#/c/151078/ | 02:48 |
pleia2 | noted in etherpad, please don't hesitate to fix things as I'll be fosdeming | 02:49 |
nibalizer | pleia2++ im glad you're thinking about this | 02:50 |
nibalizer | clarkb: so i kindof actually like the idea of new modules being proposed as modules in system-config | 02:50 |
nibalizer | just because then the entire patch can be viewed and we can decide if we want to carry this module around | 02:50 |
*** mrmartin has joined #openstack-sprint | 02:51 | |
jhesketh | clarkb: are you around? | 03:01 |
clarkb | jhesketh ya | 03:04 |
jhesketh | clarkb: any thoughts on this error here: http://logs.openstack.org/61/150861/3/gate/gate-infra-puppet-apply-trusty/619bce7/console.html#_2015-01-29_02_48_33_805 | 03:06 |
jhesketh | the master ref exists so I would have thought that'd be enough | 03:06 |
clarkb | maybe one of the git mirroe backends doesnt have it? | 03:07 |
nibalizer | or mabye the test ran before the repo was set up? | 03:07 |
clarkb | you can check directly at http://git0X.o.o:8080 | 03:07 |
* jhesketh will look | 03:09 | |
jhesketh | clarkb: http://git04.openstack.org:8080/cgit/openstack-infra/puppet-planet/refs/ is empty while the rest have it | 03:12 |
jhesketh | might need to manually bring git04 into line? | 03:13 |
clarkb | ya probably need to trigger replication. willdo that as soon as I am done with this pizza | 03:14 |
jhesketh | nom nom nom :-) | 03:14 |
* jhesketh will go find some lunch then | 03:14 | |
clarkb | I am going to kick replication now | 03:32 |
nibalizer | i think https://review.openstack.org/#/c/150964/ is ready to go | 03:32 |
clarkb | thats been fired off | 03:32 |
nibalizer | maybe it just got lucky | 03:32 |
clarkb | nibalizer: 150964 has been approved | 03:36 |
jhesketh | cool, looks good thanks | 03:37 |
*** mrmartin has quit IRC | 03:39 | |
clarkb | jhesketh: looks like http://git04.openstack.org:8080/cgit/openstack-infra/puppet-planet/refs/ is alive now | 03:41 |
jhesketh | yep, I've fired off a bunch of rechecks | 03:42 |
jhesketh | but the queue is large so it may take a while | 03:42 |
clarkb | ya | 03:42 |
jeblair | oh, there was a moment when we were under capacity. that has passed :) | 03:47 |
jhesketh | jeblair: is splitting out the project config module something we actually want to do? (re 151091) | 03:55 |
jeblair | jhesketh: yeah, i also had an initial reaction where i wasn't sure, but i think we do. it's basically just a module that clones anyone's project config repo (so not just ours), and provides some variables that are used by other modules | 03:58 |
jeblair | jhesketh: i think all the pieces aren't in place yet, but i suspect that clean re-use of our stuff might involve that as a separate module. | 03:59 |
jeblair | (already at this point, it shouldn't actually have anything openstack specific in it) | 03:59 |
jhesketh | okay, fair enough | 03:59 |
jhesketh | I guess there is no harm | 03:59 |
jhesketh | just lots of overhead in all these repos | 03:59 |
jeblair | jhesketh: a little, but one more won't hurt us :) | 04:00 |
jhesketh | heh, I guess the question is where do we draw the line, and given the line is after this one, there probably isn't a line (ie any module will be on its own no matter how openstack specific) | 04:01 |
jeblair | jhesketh: yep, that's the idea. nothing we think is openstack specific stays that way for long, so our best bet is splitting everything out for easy re-use and automating the overhead to a minimum | 04:03 |
jhesketh | yep makes sense | 04:03 |
clarkb | the amazing thing is that this is how you are supposed to puppet :) | 04:03 |
clarkb | but I can't come up with something that is functionaly better | 04:04 |
jhesketh | it's okay, monty will port it all to ansible in a drunken rage one night | 04:04 |
jeblair | unfortunately, all our repos now have 'puppet' in the name. we should have thought ahead and called them 'config-management-system-foo' | 04:05 |
jeblair | rebasing 150959 | 04:06 |
jhesketh | lol | 04:07 |
nibalizer | clarkb: this is going to make it much easier to be a downstream i think | 04:08 |
clarkb | nibalizer: ya | 04:08 |
nibalizer | jhesketh: is right though that its a burden | 04:08 |
jeblair | rebasing 150910 | 04:08 |
jeblair | rebasing 151095 | 04:09 |
*** timrc has joined #openstack-sprint | 04:14 | |
jeblair | jhesketh: 150886 should be ready for aprv | 04:17 |
jeblair | rebasing 150889 | 04:18 |
jhesketh | rebasing 150968 | 04:18 |
jeblair | rebasing 150902 | 04:19 |
jhesketh | rebasing 150935 | 04:19 |
jhesketh | rebasing 150959 | 04:21 |
jhesketh | rebasing 150934 | 04:34 |
jhesketh | rebasing 150858 | 04:35 |
jeblair | here's the list of repos we've added: https://review.openstack.org/#/c/151100/ | 04:39 |
jeblair | (i'm anticpating 2 of them will merge by the time that is reviewed) | 04:40 |
jeblair | okay, i'm going to eod again :) | 04:40 |
jhesketh | nice stuff :-) | 04:41 |
jhesketh | I'll keep pushing these through the review process.. now the nodes have freed up and we fixed that git replication issue it's going a bit faster | 04:41 |
asselin_ | I'm back | 05:02 |
asselin_ | i'll rebase https://review.openstack.org/#/c/151095/ | 05:08 |
jhesketh | rebasing 151091 | 05:09 |
jhesketh | rebasing 150852 | 05:10 |
asselin_ | actually just reverified that instead | 05:11 |
asselin_ | jhesketh, can you / should you update topic to module-split here: https://review.openstack.org/#/c/151100/2 ? | 05:13 |
jhesketh | asselin_: I think that's a separate thing that needs to be approved by the TC | 05:14 |
jhesketh | so not really part of the sprint | 05:15 |
asselin_ | ok, but should we review it. ok fair enough | 05:15 |
*** mestery has quit IRC | 05:15 | |
jhesketh | clarkb: https://review.openstack.org/#/c/150881/ has merged and the puppet-sudoers repo has been created, but it didn't pull in the seed contents | 05:15 |
*** mestery has joined #openstack-sprint | 05:16 | |
asselin_ | rebasing 150945 | 05:19 |
asselin_ | done rebasing. needs reapproval: https://review.openstack.org/#/c/150945/ | 05:23 |
*** timrc is now known as timrc-zzz | 05:28 | |
asselin_ | https://git.openstack.org/openstack-infra/puppet-sudoers is empty | 05:40 |
jhesketh | asselin_: yeah I know... not sure why though | 05:41 |
jhesketh | was hoping clarkb might be able to help but he seems away | 05:41 |
jhesketh | I'm waiting for the rest of the post merge jobs to complete to see if that helps | 05:42 |
jhesketh | although that's just docs jobs, so it's more likely on a cron | 05:42 |
asselin_ | ok...I'm going to sleep. not sure who's around for the 2nd shift, but I'll help finish whatever's left tomorrow morning | 05:44 |
jhesketh | cool | 05:47 |
jhesketh | I'm hanging if others are here fyi | 05:48 |
jhesketh | awesome work btw asselin_ :-) | 05:48 |
*** reed has quit IRC | 06:26 | |
nibalizer | jhesketh: are you still approving things? | 07:23 |
jhesketh | nibalizer: yep, although things seem stuck with jeepyb creating repos | 07:24 |
*** mrmartin has joined #openstack-sprint | 07:28 | |
nibalizer | seems like https://review.openstack.org/#/c/151089/ could go? | 07:34 |
mrmartin | morning, nibalizer, still here? | 07:36 |
nibalizer | mrmartin: ya | 07:41 |
nibalizer | sup | 07:41 |
*** mestery has quit IRC | 08:29 | |
*** mestery has joined #openstack-sprint | 08:31 | |
*** hashar has joined #openstack-sprint | 10:46 | |
*** hashar has quit IRC | 10:50 | |
*** rfolco has joined #openstack-sprint | 10:54 | |
jhesketh | so the puppet-sudoers and puppet-openafs repos haven't pulled in properly from the seed | 11:32 |
jhesketh | anywho, not many outstanding changes, so I'm going to call it a night | 11:32 |
fungi | i'll have a look at what's left and try to get it crammed through once i have breakfast | 13:12 |
omrim | krtaylor: Hi | 14:45 |
krtaylor | omrim, hi | 14:50 |
timrc-zzz | y'all I screwed up and didn't push the change with the right topic... I'm not the owner, so it doesn't look like I can change the topic without making a change and review -t'ing? https://review.openstack.org/#/c/151097/ | 14:55 |
*** timrc-zzz is now known as timrc | 14:55 | |
*** rcarrillocruz has joined #openstack-sprint | 15:01 | |
rcarrillocruz | duh | 15:02 |
rcarrillocruz | my changes on several puppet manifests for etherpad and others are now unmergeable | 15:02 |
rcarrillocruz | puppet split! | 15:02 |
mmedvede | timrc: I have already updated the 151097 | 15:06 |
timrc | mmedvede, Thanks much! | 15:07 |
asselin_ | good morning | 15:44 |
asselin_ | looks like lots went through overnight! | 15:44 |
rcarrillocruz | indeed | 15:45 |
krtaylor | yes! | 15:45 |
rcarrillocruz | i noticed by the -1 from Jenkins saying 'please rebase' :P | 15:46 |
mmedvede | Most got merged. Problematic one is mysql_proxy, which we are trying to rename into simpleproxy, probably would be left for later | 15:46 |
asselin_ | over 100 changes merged! just a handful left | 15:47 |
asselin_ | still need to see which new modules are missing the standard puppet module files | 15:48 |
asselin_ | mmedvede, saw you did quite a few. thanks! | 15:48 |
mmedvede | asselin_: thanks, it was fun :) | 15:49 |
mmedvede | you did well yourself | 15:49 |
asselin_ | sprint technically ends in 10 minutes, but I think we can finish the rest pretty easily now | 15:50 |
asselin_ | mmedvede, thanks :) | 15:50 |
asselin_ | ok, I'm going to go enjoy breakfast. Will be back in an hour | 15:51 |
asselin_ | thanks everyone! ) | 15:51 |
jeblair | fungi: did you replicate sudoers and openafs? | 15:54 |
fungi | jeblair: i did | 15:54 |
fungi | jeblair: i kicked off a replicate --all in gerrit earlier | 15:55 |
*** rcarrillocruz has left #openstack-sprint | 15:55 | |
fungi | because with the push collision behavior we've been seeing in recent weeks who knows what else might not have been fully replicated | 15:55 |
jeblair | ++ | 15:56 |
fungi | i wanted to make sure it completed before image updates kicked off so that they wouldn't tank | 15:56 |
*** krtaylor has quit IRC | 16:08 | |
*** krtaylor has joined #openstack-sprint | 16:22 | |
*** mrmartin has quit IRC | 16:28 | |
*** mrmartin has joined #openstack-sprint | 16:28 | |
*** mrmartin has quit IRC | 16:32 | |
*** krtaylor has quit IRC | 17:03 | |
*** krtaylor has joined #openstack-sprint | 17:05 | |
*** rfolco has quit IRC | 17:25 | |
*** rfolco has joined #openstack-sprint | 17:40 | |
nibalizer | oh wow yea | 17:47 |
*** krtaylor has quit IRC | 17:51 | |
*** reed has joined #openstack-sprint | 18:00 | |
*** krtaylor has joined #openstack-sprint | 18:05 | |
*** krtaylor has quit IRC | 18:43 | |
*** krtaylor has joined #openstack-sprint | 18:54 | |
*** reed has quit IRC | 19:27 | |
*** clarkb has quit IRC | 19:56 | |
*** rfolco has quit IRC | 20:04 | |
*** clarkb has joined #openstack-sprint | 20:06 | |
*** mrmartin has joined #openstack-sprint | 21:01 | |
*** mrmartin has quit IRC | 21:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!