*** david-lyle has quit IRC | 00:44 | |
*** reed has quit IRC | 00:58 | |
*** hashar has joined #openstack-sprint | 09:04 | |
*** hashar has quit IRC | 09:05 | |
*** hashar_ has joined #openstack-sprint | 09:05 | |
*** asselin has quit IRC | 09:10 | |
*** asselin has joined #openstack-sprint | 09:11 | |
*** asselin has quit IRC | 09:14 | |
*** asselin has joined #openstack-sprint | 09:14 | |
*** hashar_ is now known as hashar | 09:44 | |
*** rdopiera has joined #openstack-sprint | 10:57 | |
*** hashar has quit IRC | 11:23 | |
*** rfolco has joined #openstack-sprint | 12:08 | |
*** hashar has joined #openstack-sprint | 13:29 | |
*** krtaylor has quit IRC | 13:50 | |
*** krtaylor has joined #openstack-sprint | 13:56 | |
*** krtaylor has quit IRC | 14:54 | |
*** krtaylor has joined #openstack-sprint | 14:56 | |
*** mrmartin has joined #openstack-sprint | 14:59 | |
*** hashar has quit IRC | 15:41 | |
*** matt-borland has joined #openstack-sprint | 16:02 | |
*** matt-borland has left #openstack-sprint | 16:05 | |
*** matt-borland has joined #openstack-sprint | 16:05 | |
*** matt-borland has left #openstack-sprint | 16:05 | |
*** rdopiera has quit IRC | 16:27 | |
*** mrmartin has quit IRC | 16:29 | |
*** david-lyle has joined #openstack-sprint | 16:36 | |
*** mrmartin has joined #openstack-sprint | 16:46 | |
*** krtaylor has quit IRC | 18:16 | |
*** lhcheng has joined #openstack-sprint | 18:22 | |
*** krtaylor has joined #openstack-sprint | 18:53 | |
*** ongk has joined #openstack-sprint | 19:41 | |
*** tyr_ has joined #openstack-sprint | 19:55 | |
*** matt-borland has joined #openstack-sprint | 19:58 | |
*** TravT has joined #openstack-sprint | 20:00 | |
david-lyle | Anyone here for a little sprinting? | 20:00 |
---|---|---|
*** tqtran has joined #openstack-sprint | 20:00 | |
TravT | Hello! | 20:01 |
tqtran | Hello! | 20:01 |
david-lyle | say on, angular work in Horizon | 20:01 |
tqtran | ok so hp myroom? | 20:01 |
tqtran | or join.me | 20:01 |
david-lyle | There are a couple of resources set up | 20:01 |
*** mwhagedorn has joined #openstack-sprint | 20:01 | |
*** mrunge has joined #openstack-sprint | 20:01 | |
david-lyle | https://etherpad.openstack.org/p/horizon-kilo-virtual-sprint | 20:01 |
david-lyle | #topic Horizon AngularJS sprint | 20:02 |
TravT | so this is logged? | 20:02 |
david-lyle | FYI this is a logged channel | 20:02 |
TravT | can we make it logged if not? | 20:02 |
david-lyle | logged all the time | 20:02 |
tyr_ | I'm most interested in the Re-Sync on AngularJS strategy | 20:02 |
*** r1chardj0n3s_afk has joined #openstack-sprint | 20:03 | |
david-lyle | The location of the logs is in the room topic | 20:03 |
mrunge | david-lyle, maybe you need to start a meeting? | 20:03 |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:03 | |
david-lyle | no logged all the time | 20:03 |
mrunge | I see, great! | 20:04 |
*** sqchen has joined #openstack-sprint | 20:04 | |
*** matt-borland has quit IRC | 20:04 | |
TravT | mrunge: | 20:04 |
david-lyle | https://etherpad.openstack.org/p/horizon-kilo-virtual-sprint | 20:04 |
TravT | can you join our virtual room | 20:04 |
david-lyle | on there is a link to a recordable collaboration tool | 20:04 |
mrunge | TravT, which of the proposed ones? | 20:05 |
david-lyle | myroom | 20:05 |
david-lyle | hmm fedora | 20:05 |
TravT | hp myroom | 20:05 |
david-lyle | tell us if that isn't supported | 20:05 |
*** matt-borland has joined #openstack-sprint | 20:05 | |
david-lyle | there is an RPM | 20:06 |
*** robcresswell has joined #openstack-sprint | 20:06 | |
david-lyle | looks like | 20:06 |
mrunge | what kind of license is "Property"? | 20:06 |
TravT | property? | 20:06 |
r1chardj0n3s | myroom keeps dying on trying to access the room (OS X) | 20:06 |
mrunge | Yes, it's the listed licences | 20:06 |
mrunge | nevermind, it doesn't work | 20:07 |
*** rdopiera has joined #openstack-sprint | 20:07 | |
r1chardj0n3s | I'm gonna try rebooting | 20:07 |
TravT | hmm... I'm on OS X Yosemite | 20:07 |
rdopiera | hi | 20:07 |
TravT | hey rdopiera: we're trying out a conference solution | 20:07 |
TravT | can you try? | 20:07 |
mrunge | TravT, rdopiera it doesn't work for me. | 20:08 |
rdopiera | TravT: how? | 20:08 |
clarkb | vlc can do screen sharing iirc might be a simple ad hoc solution if that is what you need | 20:08 |
TravT | mrgune: bummer | 20:08 |
*** drupalmonkey has joined #openstack-sprint | 20:08 | |
TravT | anybody tried the join me? | 20:08 |
TravT | join.me | 20:08 |
TravT | for screen sharing + voice | 20:09 |
rdopiera | TravT: what's the code? | 20:10 |
david-lyle | it's on the etherpad | 20:10 |
TravT | for join me? | 20:10 |
david-lyle | H..... | 20:10 |
TravT | for HP HAXHF2IWD | 20:10 |
mrunge | rdopiera, https://etherpad.openstack.org/p/horizon-kilo-virtual-sprint | 20:10 |
mrunge | it's listed there | 20:10 |
*** btully has joined #openstack-sprint | 20:11 | |
rdopiera | mrunge: thanks | 20:11 |
mrunge | rdopiera, does it work for you? | 20:11 |
r1chardj0n3s | welp, sorry, but I've rebooted and myroom doesn't work any more (yes, it worked when we tried it out a week ago or whenever) | 20:11 |
david-lyle | join me is just mac or windows | 20:12 |
rdopiera | mrunge: downloading... | 20:12 |
TravT | so mrunge: no luck for you? | 20:12 |
mrunge | nope | 20:12 |
mrunge | missing dependency | 20:12 |
r1chardj0n3s | I'm gonna try reinstalling (not that that shold make any difference, but I'm flailing here) | 20:12 |
rdopiera | lol | 20:13 |
rdopiera | Selecting previously unselected package gcc-4.9-base:i386. | 20:13 |
TravT | ok | 20:13 |
rdopiera | for an amd64 version XD | 20:13 |
TravT | r1chardj0n3s: what about vidyo? | 20:13 |
david-lyle | looking for a dial-in option | 20:13 |
TravT | can you host a session? | 20:13 |
rdopiera | why does it need gcc? | 20:13 |
*** clu_ has joined #openstack-sprint | 20:13 | |
mrunge | yeah, at least for recent fedora, this requires too old libraries | 20:13 |
robcresswell | I imagine I'll draw some anger for saying it works fine on Ubuntu 14.10, if you love Amazon ads | 20:14 |
mrunge | &(/&/ยง%$&/% | 20:15 |
mrunge | (and some other swear words) | 20:15 |
david-lyle | tqtran or TravT do you have a dial-in that we could use instead and just use the etherpad for collab? | 20:15 |
TravT | so, guys | 20:15 |
rdopiera | No such schema 'com.canonical.Unity.Panel' | 20:15 |
TravT | at the bottom of: https://etherpad.openstack.org/p/horizon-kilo-virtual-sprint | 20:15 |
TravT | we're going to list out the works being done to enable angular right now | 20:15 |
mrunge | hahahaha rdopiera | 20:15 |
david-lyle | my corporate solution is Lync, so I'm no help | 20:16 |
tqtran | yep, let me look up the number again | 20:16 |
mrunge | I could offer a phone dial in | 20:16 |
clarkb | tgere is an asterisk server... | 20:16 |
TravT | try to figure out what the dependency path is. | 20:16 |
david-lyle | install ubuntu | 20:16 |
tqtran | here is the dial in number for all countries: https://www.teleconference.att.com/servlet/glbAccess?process=1&accessCode=89441695&accessNumber=2158616239#C2 | 20:16 |
rdopiera | ok, I'm in | 20:16 |
clarkb | https://wiki.openstack.org/wiki/Infrastructure/Conferencing | 20:16 |
tqtran | passcode is: 89441695 | 20:16 |
* mrunge swears louder | 20:17 | |
r1chardj0n3s | TravT: can you access https://vc.rackspace.com/download.html and download the vidyo client? | 20:17 |
TravT | does vidyo also have dial in optin? | 20:18 |
TravT | i can access it | 20:18 |
TravT | i've already got it installed | 20:18 |
TravT | from glance sessions that rackspace hosted | 20:18 |
r1chardj0n3s | ok, connect to extension 7832 | 20:18 |
r1chardj0n3s | see if that works | 20:18 |
david-lyle | r1chardj0n3s: no host | 20:20 |
david-lyle | BTW this is a logged channel | 20:20 |
mwhagedorn | r1chardj0n3s: its asking for a vidyvoportal/username/pwd | 20:20 |
r1chardj0n3s | hm. sorry, I don't know the magic for that :/ | 20:20 |
TravT | can you ask nikhil_k? | 20:21 |
david-lyle | thai has a dial in, should we use that? | 20:21 |
TravT | he hosted one | 20:21 |
r1chardj0n3s | TravT has done this more times than I have :( | 20:21 |
TravT | nikhil_k is glance PTL. He's hosted a couple mini summits with vidyo | 20:21 |
r1chardj0n3s | TravT: don't know nikhil_k :9 | 20:21 |
r1chardj0n3s | hm | 20:21 |
TravT | from rackspace | 20:21 |
*** matt-borland has quit IRC | 20:21 | |
*** matt-borland has joined #openstack-sprint | 20:22 | |
*** matt-borland has quit IRC | 20:22 | |
*** matt-borland has joined #openstack-sprint | 20:22 | |
TravT | so we're trying to identify dependencies on the angular work on the etherpad | 20:23 |
TravT | and then ask outstanding questions on any of them. | 20:23 |
TravT | come up with a strategy | 20:24 |
matt-borland | TravT: I just put up a review that allows us to do automated dashboard Jasmine tests | 20:24 |
TravT | can you add that to the etherpad? | 20:24 |
matt-borland | yep | 20:24 |
david-lyle | ok, switching to dial in | 20:25 |
TravT | we are all jumping to your phone tqtran: | 20:25 |
tqtran | ok | 20:25 |
david-lyle | mrunge: good with that? | 20:25 |
david-lyle | should have international numbers and VoIP works | 20:25 |
mrunge | which one? david-lyle ? | 20:25 |
david-lyle | https://www.teleconference.att.com/servlet/glbAccess?process=1&accessCode=89441695&accessNumber=2158616239#C2 | 20:25 |
tqtran | for US: 888-426-6840, Passcode: 89441695 | 20:26 |
mrunge | ok, great | 20:26 |
tqtran | for interntaional: follow link above | 20:26 |
david-lyle | r1chardj0n3s: we're just going to use phone for now | 20:26 |
TravT | 89441695 | 20:27 |
TravT | https://www.teleconference.att.com/servlet/glbAccess?process=1&accessCode=89441695&accessNumber=2158616239#C2 | 20:28 |
mwhagedorn | cool in the teleconf room | 20:28 |
r1chardj0n3s | ok people with vidyo clicky https://vc.rackspace.com/flex.html?roomdirect.html&key=uCOKAs5c8G1tQ3UUHRlIOffw | 20:28 |
r1chardj0n3s | oh, | 20:28 |
TravT | let's do that next time | 20:28 |
david-lyle | yeah technology | 20:28 |
TravT | anybody not in the call ?that's still coming | 20:28 |
mrunge | plaon old tech works :D | 20:29 |
david-lyle | clarkb: will ask about asterisk after this | 20:29 |
david-lyle | thought we had a solution | 20:29 |
r1chardj0n3s | no screen sharing :/ | 20:29 |
TravT | anybody not in the call? | 20:29 |
mwhagedorn | I am here | 20:29 |
r1chardj0n3s | I'm in | 20:30 |
matt-borland | I'm in | 20:30 |
r1chardj0n3s | also my speaker phone sucks | 20:30 |
rdopiera | it doesn't let me in, is that this openstack sip teleconference thing? | 20:31 |
TravT | that's an IBM conference line | 20:31 |
rdopiera | what's the sip address for that? | 20:32 |
mrunge | rdopiera, plain old telephone | 20:32 |
TravT | all i see is 0-0-800-111-1929 for poland | 20:32 |
mrunge | rdopiera, access numbers https://www.teleconference.att.com/servlet/glbAccess?process=1&accessCode=89441695&accessNumber=2158616239#C2 | 20:32 |
rdopiera | sigh | 20:33 |
* rdopiera duct-tapes his cellphone to his head | 20:33 | |
mrunge | put the phone under your hat | 20:33 |
david-lyle | thanks rdopiera | 20:34 |
lhcheng | rdopiera, thanks for the idea. I have to ducttape my phone too | 20:34 |
matt-borland | TravT: Agreed | 20:34 |
rdopiera | "the number you have dialed does not exist" | 20:35 |
TravT | ropiera: brainstorming here. i could put it on speaker and do a google hangout. | 20:38 |
TravT | rdopiera: nevermind you joined. | 20:38 |
TravT | :) | 20:38 |
mrunge | :D | 20:38 |
TravT | https://review.openstack.org/#/c/156359/ | 20:40 |
*** ybathia has joined #openstack-sprint | 20:43 | |
robcresswell | I think there's some feedback | 20:44 |
mwhagedorn | call breaking up.... | 20:44 |
r1chardj0n3s | nasty feedback from somone :/ | 20:44 |
robcresswell | can everyone mute if not speaking? | 20:44 |
mrunge | +1 | 20:44 |
rdopiera | that was me, sorry | 20:45 |
*** matt-borland has quit IRC | 20:45 | |
tqtran | https://review.openstack.org/#/c/150573/ | 20:46 |
*** matt-borland has joined #openstack-sprint | 20:47 | |
mwhagedorn | the neutron stuff is basically done.. needs one more pass through to make sure didnt miss any functionality | 20:47 |
matt-borland | we're just all on mute to keep the noise down... | 20:48 |
mwhagedorn | https://review.openstack.org/#/c/151313/ - | 20:48 |
robcresswell | TravT: Is everything needed for launch instance currently upstream (in one form or another?) | 20:48 |
mwhagedorn | yeah travis that was my thought oo | 20:48 |
mwhagedorn | too | 20:48 |
tqtran | r1chardj0n3s: i think im ready to take another stab at the identities user table | 20:49 |
tqtran | TravT: are there patches that you want us to focus on? | 20:49 |
r1chardj0n3s | tqtran: ok. I'm happy to try to help out with launch instance, but I'm not sure I can | 20:49 |
TravT | https://review.openstack.org/#/c/151468/ | 20:50 |
mwhagedorn | https://review.openstack.org/#/c/151313/ is ready.. just may have to add some function points | 20:50 |
*** harshs has joined #openstack-sprint | 20:51 | |
tqtran | base wizard patch: https://review.openstack.org/#/c/156359/ | 20:52 |
TravT | r1chardj0n3s: maybe you could do one of the steps | 20:54 |
robcresswell | +1 to phone (dont want to interrupt), we need to separate absolute dependencies from nice-to-have | 20:56 |
r1chardj0n3s | https://review.openstack.org/#/c/141273/ is not un-TravT'ed :) | 20:57 |
r1chardj0n3s | s/not/now | 20:57 |
TravT | Thanks! | 20:57 |
robcresswell | nice | 20:57 |
*** rfolco has quit IRC | 20:59 | |
TravT | r1chardj0n3s: your voice is fading | 21:05 |
robcresswell | As a side note, are the guidelines for JS (Angular specifically) up to date and reasonable? | 21:06 |
robcresswell | Just in terms of reviewing, it'd be good to know the reference is right | 21:06 |
mrunge | when I was reconnected, I was number 14 | 21:07 |
TravT | https://vc.rackspace.com/flex.html?roomdirect.html&key=uCOKAs5c8G1tQ3UUHRlIOffw | 21:08 |
TravT | you are very faint | 21:10 |
tqtran | yep, cant really hear you | 21:10 |
mrunge | is someone talking? | 21:10 |
TravT | mrunge: not that I know of | 21:10 |
mrunge | :D | 21:10 |
*** rbertram has joined #openstack-sprint | 21:11 | |
david-lyle | I saw mrunge, then he went | 21:12 |
mrunge | yeah, application crashed | 21:12 |
clu_ | it's asking for portal/username/password? | 21:14 |
mrunge | yupp | 21:14 |
mrunge | at some point, the log in window went away | 21:14 |
TravT | i can see r1chardj0n3s about to blow his top | 21:14 |
mrunge | lucky you... | 21:14 |
r1chardj0n3s | are people being booted out? | 21:15 |
mrunge | sure | 21:15 |
mrunge | and unable to connect again | 21:15 |
robcresswell | I read mike/thai's comments and thought they meant 11 people | 21:15 |
mrunge | asks for registration | 21:16 |
mwhagedorn | aruba | 21:16 |
*** hashar has joined #openstack-sprint | 21:16 | |
mrunge | so, that doesn't work either | 21:17 |
mrunge | 9536 Segmentation fault (core dumped) | 21:21 |
mrunge | cool | 21:21 |
david-lyle | we're going to just review | 21:21 |
david-lyle | you're still on dial in? | 21:21 |
mwhagedorn | @travis neutron is doneโฆ there might be a couple of endpoint calls that need to be added | 21:21 |
mrunge | nope, disconnected in favor of video | 21:21 |
mwhagedorn | but I think we got them all | 21:22 |
robcresswell | This one? https://review.openstack.org/#/c/141273/ | 21:22 |
david-lyle | video solution 3 also a bust | 21:22 |
david-lyle | dial in still open | 21:22 |
david-lyle | we're going to review an API patch, then look at the outline for the wizard | 21:23 |
david-lyle | deciding on the API patch | 21:23 |
r1chardj0n3s | trying to get applications working on random linux builds is always going to be a challenge :/ | 21:23 |
david-lyle | we're looking at glance API patch | 21:23 |
tqtran | https://review.openstack.org/#/c/151468/ | 21:23 |
david-lyle | what he said | 21:24 |
robcresswell | I'll see what Cisco can offer tomorrow and try a practice run if I find a suitable one. I remember Webex being funny on Linux distros. | 21:24 |
david-lyle | })(); | 21:24 |
david-lyle | or }()); | 21:24 |
mrunge | red hat is using bluejeans | 21:25 |
TravT | launch instance step layout: https://review.openstack.org/#/c/156359/ | 21:25 |
mrunge | it somehow works | 21:25 |
TravT | mrunge: do you want to try it out now? | 21:26 |
mrunge | i was connected as number 13 to the telco. what's the limit for hangouts? | 21:26 |
david-lyle | 10 | 21:26 |
TravT | the other day we seemed to cap at 10 | 21:26 |
david-lyle | :( | 21:26 |
mrunge | darn | 21:26 |
TravT | :( | 21:26 |
r1chardj0n3s | yeah, vidyo shouldn't have a limit of 10 - we regularly have >10 in meetings. not sure why it's limiting now | 21:26 |
mrunge | TravT, I would try bluejeans tomorrow in the mornging to prepare a proper call rather than trying this now with all folks waiting | 21:27 |
TravT | ok | 21:27 |
robcresswell | r1chardj0n3s: Is it unregistered vs registered users? | 21:28 |
r1chardj0n3s | *shrug* | 21:28 |
r1chardj0n3s | I'll ask around | 21:28 |
TravT | r1chardj0n3s: not sure if you are talking on phone or not | 21:28 |
TravT | i dropped vidyo | 21:29 |
r1chardj0n3s | he's on vidypo | 21:29 |
tqtran | its really hard to hear you rdopiera | 21:29 |
mrunge | who is talking? | 21:30 |
tqtran | i think rdopiera is talking | 21:30 |
mrunge | I thought it was just white noise | 21:30 |
TravT | :( | 21:30 |
mrunge | we can lift people to the moon, but a simple telco is not possible | 21:30 |
tqtran | sounds like a startup idea | 21:31 |
robcresswell | So I think Radomir is concerned about the minification of parameters vs passing in a list of strings | 21:31 |
matt-borland | exactly | 21:31 |
tqtran | r1chardj0n3s: you know you can use skype to dial in? | 21:32 |
tqtran | so you dont have to hold onto the phone :) | 21:32 |
TravT | i just joined vidyo | 21:35 |
rdopiera | http://django-compressor.readthedocs.org/en/latest/ | 21:35 |
r1chardj0n3s | brb, just rebooting so maybe my laptop can recognise "localhost" once again | 21:37 |
robcresswell | https://review.openstack.org/#/c/151468/30/openstack_dashboard/api/rest/glance.py | 21:39 |
robcresswell | L123 | 21:39 |
robcresswell | ? | 21:39 |
tqtran | https://review.openstack.org/#/c/151468/30/openstack_dashboard/api/rest/glance.py L123 | 21:40 |
tqtran | https://review.openstack.org/#/c/151468/30/horizon/static/horizon/js/angular/services/hz.api.glance.js L146 | 21:40 |
tqtran | rdopiera: might be better if you type, we cant hear you at all | 21:46 |
rdopiera | sorry | 21:46 |
rdopiera | so everything that's specific to openstack, should go to openstack_dashboard | 21:46 |
rdopiera | horizon should be a general-purpose library | 21:46 |
mrunge | +1 | 21:47 |
david-lyle | right | 21:47 |
rdopiera | so we can have some generally useful JavaScript stuff in horizon, actually | 21:48 |
tqtran | horizon.instances.js for example | 21:48 |
tqtran | all of our js currently reside in horizon | 21:48 |
rbertram | TravT: Which patch has an example of APIs being used, in hz.api.glance.js ? | 21:48 |
rdopiera | tqtran: yeah, that's because there was a problem having it in the dashboard at some point | 21:49 |
mrunge | rbertram, this one: https://review.openstack.org/#/c/155556/ ? | 21:49 |
rdopiera | tqtran: but that's solved already | 21:49 |
rbertram | thx | 21:49 |
tqtran | rdopiera: yep | 21:50 |
tqtran | sqchen, matt-borland: can you guys link the patch? | 21:53 |
r1chardj0n3s | yeah, sqchen please also where is that js configuration file located in openstack_dashboard? | 21:53 |
r1chardj0n3s | oh, is that the _enabled directory | 21:53 |
tqtran | as i understand it, we already have a mechanism for including js in dashboard, as rdopiera mentioned | 21:54 |
tqtran | we don't have to go with the enabled mechanism that sqchen mentioned as of now | 21:54 |
TravT | tqtran: take a look again at the glance. removed that line. https://review.openstack.org/#/c/151468/31/openstack_dashboard/api/rest/glance.py | 21:55 |
tqtran | looks good TravT, just need to go over your unit tests, and if that looks good, I'm ready to +2 it | 21:57 |
robcresswell | Dropping off the call. I'll get reviewing tomorrow on some the API patches that still need work. Night all. | 21:58 |
david-lyle | thanks robcresswell | 21:59 |
*** robcresswell is now known as robcresswell_afk | 21:59 | |
rdopiera | I have to run, sorry | 21:59 |
david-lyle | thanks rdopiera | 21:59 |
rdopiera | I will review the patches first thing in the morning though! :) | 22:00 |
david-lyle | timing is rough | 22:00 |
*** rdopiera has quit IRC | 22:00 | |
mrunge | I dropped off from the call too. | 22:00 |
mrunge | actually quite a few mins ago | 22:00 |
david-lyle | ok, thanks mrunge | 22:00 |
mrunge | sorry, that it didn't really work | 22:01 |
david-lyle | please express any concerns or issues | 22:01 |
david-lyle | yeah, technology | 22:01 |
mrunge | I think, we should give bluejeans a try tomorrow | 22:01 |
david-lyle | if you have it ready to go, I'm happy to try | 22:01 |
david-lyle | tomorrow | 22:01 |
mrunge | sounds good | 22:01 |
david-lyle | you should sleep :) | 22:01 |
tqtran | blue jeans? i dont get it. i always wear PJs | 22:02 |
mrunge | thanks everyone | 22:02 |
matt-borland | lol | 22:02 |
mrunge | tqtran, something like this: https://redhat.bluejeans.com/ | 22:02 |
tqtran | oooo | 22:03 |
tqtran | its a collab tool | 22:03 |
mrunge | yes, something like that | 22:03 |
mrunge | and quite a few extensions: http://bluejeans.com/downloads | 22:03 |
tqtran | i get it now :) thanks for clarification | 22:03 |
mrunge | :D | 22:04 |
tqtran | TravT: https://review.openstack.org/#/c/151468/30/openstack_dashboard/test/api_tests/glance_rest_tests.py | 22:07 |
tqtran | last request =) | 22:08 |
TravT | tqtran: looking now... i debated on that at the time... | 22:08 |
tqtran | lol | 22:08 |
lhcheng | TravT, so the review priority starts from line :60 in etherpad? | 22:10 |
david-lyle | lhcheng: yes | 22:11 |
tqtran | lhcheng: and line 62 | 22:11 |
tqtran | for the APIs | 22:11 |
david-lyle | although we will likely take a look at line 60 in a minute | 22:11 |
david-lyle | somehow 60 was moved up :| | 22:11 |
lhcheng | david-lyle: okay, I've already looked at the glance api. After tqtran gives his +2, I think that's good to go. | 22:12 |
TravT | tqtran: making brain hurt to try to combine tests and answer questions at same time... | 22:12 |
david-lyle | lhcheng: LGTM too | 22:12 |
matt-borland | I will have to duck out in about 5 minutes, any questions or concerns about the Jasmine work at this point? | 22:13 |
matt-borland | It was hasty, but I really wanted something that would work in the automated environment. | 22:14 |
david-lyle | thanks matt-borland | 22:15 |
*** mrmartin has quit IRC | 22:15 | |
matt-borland | thanks everyone! later. | 22:18 |
*** matt-borland has quit IRC | 22:18 | |
*** mrunge has quit IRC | 22:18 | |
tqtran | r1chardj0n3s: https://review.openstack.org/#/c/141273/40/openstack_dashboard/api/rest/nova.py L53 | 22:22 |
tqtran | is there a reason why we're using DATA instead of POST? | 22:22 |
r1chardj0n3s | um, no? | 22:22 |
r1chardj0n3s | I just tend to use DATA :) | 22:23 |
r1chardj0n3s | brb | 22:23 |
mwhagedorn | and I copied richard :) | 22:23 |
tqtran | https://docs.djangoproject.com/en/1.7/ref/request-response/ | 22:24 |
tqtran | so in the docs, there isnt a mention of DATA | 22:24 |
tqtran | might be a better idea to use POST as its more recognized? | 22:24 |
mwhagedorn | its probably more sementic | 22:25 |
tqtran | r1chardj0n3s: https://review.openstack.org/#/c/151468/32/openstack_dashboard/api/rest/glance.py L 80 | 22:25 |
tqtran | while we're on the subject, is it possible to follow this format for listing params as well? makes it easier to read | 22:25 |
r1chardj0n3s | . | 22:27 |
r1chardj0n3s | tqtran: seems reasonable | 22:27 |
tqtran | :D awesome blossom | 22:27 |
lhcheng | r1chardj0n3s: what is the difference between request.DATA and request.POST data? | 22:27 |
tqtran | i was afraid you were gonna kill me | 22:27 |
r1chardj0n3s | lhcheng: DATA looks at both POST and GET | 22:28 |
r1chardj0n3s | it's just a common interface, nicer imo | 22:28 |
lhcheng | r1chardj0n3s: is that something recently added? | 22:28 |
r1chardj0n3s | no, wait | 22:28 |
r1chardj0n3s | what the hell am I talking about | 22:28 |
r1chardj0n3s | request.DATA is the decoded json payload | 22:28 |
r1chardj0n3s | what the hell are you talking about tqtran :) | 22:28 |
r1chardj0n3s | I'm all confused now :) | 22:28 |
tqtran | lol i believe your first comment was correct | 22:29 |
tqtran | data contains both get and post | 22:29 |
r1chardj0n3s | no | 22:29 |
r1chardj0n3s | # decode the JSON body if present | 22:29 |
r1chardj0n3s | request.DATA = None | 22:29 |
r1chardj0n3s | if request.body: | 22:29 |
r1chardj0n3s | try: | 22:29 |
r1chardj0n3s | request.DATA = json.loads(request.body) | 22:29 |
r1chardj0n3s | except (TypeError, ValueError) as e: | 22:29 |
r1chardj0n3s | return JSONResponse('malformed JSON request: %s' % e, 400) | 22:29 |
lhcheng | r1chardj0n3s: okay, found it in the rest utils | 22:30 |
tqtran | http://www.django-rest-framework.org/tutorial/2-requests-and-responses/ | 22:30 |
tqtran | so apparently data works for post, put and patch | 22:30 |
tqtran | while post only works for post | 22:30 |
r1chardj0n3s | yeah, but I overrode it to have the JSON data | 22:31 |
r1chardj0n3s | I actually forgot about that thing about DATA being all of those things when I wrote the rest util decorator, or I would have chosen a different name | 22:31 |
tqtran | yep thats fine, ok make sense to keep it as DATA then | 22:31 |
r1chardj0n3s | actually, isn't it "request.data" (lowercase)? | 22:32 |
lhcheng | tqtran: but we're not using that rest framework right? | 22:32 |
tqtran | r1chardj0n3s: ooo good catch | 22:32 |
r1chardj0n3s | also, we're not using that rest framework ;) | 22:32 |
david-lyle | :) | 22:32 |
r1chardj0n3s | so now I'm even more confused :) | 22:32 |
lhcheng | ha | 22:33 |
tqtran | LOL | 22:33 |
r1chardj0n3s | agh, so does django even have that request.DATA is POST+GET+PATCH or not? :) | 22:33 |
r1chardj0n3s | or was I correct in copying the pattern over from that framework (which I clearly did) | 22:34 |
r1chardj0n3s | in other news, I *still* can't log into my local horizon test server :/ | 22:34 |
r1chardj0n3s | fffuuuu computers why do we even | 22:34 |
tqtran | maybe your keystone is hosed | 22:34 |
david-lyle | r1chardj0n3s: does is just return you to the login page? | 22:34 |
david-lyle | no failure? | 22:34 |
r1chardj0n3s | david-lyle: it just hangs on the login | 22:34 |
david-lyle | but you can put values in and submit? | 22:35 |
r1chardj0n3s | I'm gonna start poking directly at keystone to see what's up | 22:35 |
r1chardj0n3s | david-lyle: yup | 22:35 |
david-lyle | your cookie is overflowing | 22:35 |
r1chardj0n3s | my cookie is overflowing | 22:35 |
r1chardj0n3s | oooh, now I need a cookie | 22:35 |
lhcheng | one general comment, we should me moving out of unittest2 in favor of testtools | 22:35 |
lhcheng | there is a patch up that is removing the unittest2 in horizon | 22:36 |
* r1chardj0n3s tries deleting his cookie, to take his mind off there being no cookies in the hose | 22:36 | |
r1chardj0n3s | house even | 22:36 |
david-lyle | add SESSION_ENGINE = 'django.contrib.sessions.backends.cache' in your local_settings.py | 22:36 |
r1chardj0n3s | ok | 22:36 |
david-lyle | will use memcache for session store | 22:36 |
tqtran | lhcheng: can that be done in subsequent patches? | 22:37 |
tqtran | lhcheng: all of our tests are written in unittest2 atm | 22:37 |
david-lyle | if this is happening all the time in devstack now, I really need to change the default | 22:37 |
lhcheng | yeah, we just need to update the base test class | 22:37 |
david-lyle | back to trying to get the devstack patch moving again | 22:37 |
lhcheng | which probably would have been nice if we have a base test class for rest :) | 22:37 |
r1chardj0n3s | "CacheKeyWarning: Cache key will cause errors if used with memcached ... " and then horizon vomited all over my terminal for 40 lines | 22:38 |
tqtran | so testtool have a lot of the same funciton calls as unittest2? | 22:38 |
tqtran | lhcheng: yep, r1chardj0n3s has volunteered to write that base class and refactor once nova and glance api are in | 22:38 |
lhcheng | https://review.openstack.org/#/c/152869/ | 22:38 |
r1chardj0n3s | tqtran: wait what? | 22:39 |
r1chardj0n3s | :) | 22:39 |
tqtran | r1chardj0n3s: ops... i just volunteered you by accident | 22:39 |
tqtran | lol | 22:39 |
lhcheng | lol | 22:39 |
r1chardj0n3s | I will refactor all the things just as soon as I get my bloody local horizon working again! | 22:39 |
r1chardj0n3s | (nice try with the session cookie thing david-lyle, but no dice. back to figuring out how to poke at keystone) | 22:40 |
david-lyle | really? | 22:40 |
david-lyle | you've really made a mess for yourself | 22:40 |
TravT | tqtran: its done | 22:40 |
r1chardj0n3s | I know right? | 22:40 |
david-lyle | ah, you're not using devstack | 22:40 |
r1chardj0n3s | david-lyle: I am using a remote devstack as the endpoint, but locally a clone of horizon | 22:41 |
david-lyle | you can use sqllite for session store then | 22:42 |
david-lyle | already there | 22:42 |
lhcheng | r1chardj0n3s: posted comments on nova patch: https://review.openstack.org/#/c/141273/ some minor comments, easy to fix | 22:42 |
r1chardj0n3s | I really should update my remote devstack - it's a few months old now ;) | 22:42 |
r1chardj0n3s | lhcheng: on a style issue: actually I have adopted a common pattern where the imports are split into three groups: standard library, 3rd party packages and then application | 22:43 |
david-lyle | r1chardj0n3s: well your devstack should be fine, but you have sqllite locally with horizon | 22:43 |
david-lyle | updating devstack is a scary proposition always | 22:44 |
r1chardj0n3s | david-lyle: so I should undo that SESSION_ENGINE change? | 22:44 |
r1chardj0n3s | david-lyle: nuke and rebuild :) | 22:44 |
david-lyle | if you don't have memcached yes | 22:44 |
TravT | https://review.openstack.org/#/c/152243/ | 22:44 |
david-lyle | and the set it to use sqlite | 22:44 |
r1chardj0n3s | yup | 22:44 |
david-lyle | I need to find the value for SESSION_ENGINE for that | 22:44 |
r1chardj0n3s | I'm just gonna address lhcheng's comments on the nova patch | 22:45 |
lhcheng | r1chardj0n3s: are you referring to the comment here? https://review.openstack.org/#/c/141273/40/openstack_dashboard/api/rest/nova.py | 22:45 |
r1chardj0n3s | yep | 22:45 |
lhcheng | yeah line 21 and 23 should be grouped together? | 22:45 |
r1chardj0n3s | oh, d'oh, I see now. sorry! | 22:46 |
lhcheng | heh :) | 22:46 |
lhcheng | no worries | 22:46 |
lhcheng | ok, glance api ready to ship | 22:47 |
TravT | :D | 22:48 |
TravT | tqtran: curious what you had in mind. | 22:49 |
tqtran | just a helper function | 22:50 |
tqtran | that runs the 3 common lines | 22:50 |
TravT | ah, i thought about that too, but then had this odd that that i'd need to write a test to test the test helper function | 22:50 |
tqtran | haha, well.... if thats the case, then you need to test every line in the test function | 22:51 |
tqtran | and that will be one hell of a test | 22:51 |
* TravT thinks "tough crowd" | 22:51 | |
* tqtran nods. | 22:53 | |
* TravT can't stop thinking about cookies. will be back in 1 minute. | 22:54 | |
r1chardj0n3s | great, now TravT will have a cookie and I won't | 22:58 |
TravT | nom nom nom | 22:59 |
r1chardj0n3s | TravT: you owe me a cookie | 23:08 |
r1chardj0n3s | tqtran: have updated the docs in the nova py | 23:08 |
tqtran | r1chardj0n3s: i think TravT owes you a drink at the next summit | 23:08 |
TravT | tqtran: tru 'dat | 23:10 |
TravT | can't wait to mark "done" on buying r1chardj0n3s a drink. | 23:10 |
*** drupalmonkey has quit IRC | 23:19 | |
tyr_ | What is a good way to write to this group? I have some questions that are too complicated to ask over the phone, but I'm interested in feedback from those more experienced with Angular. | 23:23 |
lhcheng | dropping off the call, will continue reviewing based on priority when I get the chance. | 23:24 |
lhcheng | good work everyone! | 23:24 |
TravT | lhcheng: thanks for joining in | 23:24 |
TravT | hope to see you on next one | 23:24 |
lhcheng | will there be anyone tomorrow? | 23:25 |
lhcheng | TravT, sorry to have you deliver the bad news to Mohan/Amogh .. | 23:25 |
david-lyle | thanks lhcheng | 23:26 |
*** rbertram has left #openstack-sprint | 23:30 | |
TravT | Thank you everybody! I think we made really good progress today! | 23:35 |
r1chardj0n3s | thanks everyone! | 23:35 |
*** r1chardj0n3s has left #openstack-sprint | 23:35 | |
david-lyle | Thanks everyone! | 23:35 |
*** tqtran has left #openstack-sprint | 23:36 | |
*** hashar has quit IRC | 23:37 | |
*** krtaylor has quit IRC | 23:40 | |
*** ongk has left #openstack-sprint | 23:40 | |
*** btully has left #openstack-sprint | 23:40 | |
*** sqchen has quit IRC | 23:46 | |
*** mwhagedorn has quit IRC | 23:51 | |
*** sqchen has joined #openstack-sprint | 23:55 | |
*** mwhagedorn has joined #openstack-sprint | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!