*** rfolco has joined #openstack-sprint | 00:21 | |
*** rfolco has quit IRC | 00:26 | |
*** mrmartin has joined #openstack-sprint | 06:02 | |
*** mrmartin has quit IRC | 06:42 | |
*** _degorenko|afk is now known as degorenko | 09:56 | |
*** rfolco has joined #openstack-sprint | 10:56 | |
EmilienM | o/ | 12:16 |
---|---|---|
*** sbadia has joined #openstack-sprint | 13:16 | |
EmilienM | dhellmann: hey! I have 2 patches that you could review for using reno: https://review.openstack.org/#/c/272261/ and https://review.openstack.org/#/c/272203/ | 14:26 |
*** yarkot has quit IRC | 14:35 | |
EmilienM | chem: how is your progress on CI? | 14:37 |
chem | ok, I upload the new version, I tryed harder to understand what I was doing. Sorry for the delay. | 14:39 |
EmilienM | don't be sorry, I'm asking if you need help | 14:40 |
EmilienM | and if you managed to work on it with mwhahaha | 14:40 |
chem | EmilienM: that should be ok, I'll ask him when this new version is up if there are optimization to be done | 14:41 |
EmilienM | chem: fyi, this is what I did yesterday for our gem CI: https://review.openstack.org/#/c/272546/ | 14:50 |
EmilienM | (see the 2 jobs) | 14:50 |
EmilienM | the code is here: https://github.com/openstack/puppet-openstack_spec_helper/blob/master/run_beaker_tests.sh | 14:51 |
EmilienM | and https://github.com/openstack/puppet-openstack_spec_helper/blob/master/run_unit_tests.sh | 14:51 |
chem | thanks | 14:53 |
EmilienM | so I thought we could 1/ re-use the bits from bootstrap.sh to generate a module in cookiecutter | 14:59 |
EmilienM | and 2/ run beaker/unit tests after that | 14:59 |
chem | EmilienM: I think the validation from the created module directory ought to be enough | 15:00 |
EmilienM | chem: did you forget to push on https://review.openstack.org/#/c/272146/ ? or just not ready yet? | 15:05 |
EmilienM | just wondering since you replied you took comments in consideration | 15:05 |
chem | had hard time rebasing, and then slipped away and recheck my code. Uploading in the next 15min | 15:06 |
EmilienM | no pressure, just checking | 15:06 |
chem | mwhahaha: when zuul trigger the jenkins the workspace is already populated with the source code or do I need the zuul clone macro ? | 15:31 |
chem | mwhahaha: when zuul trigger the jenkins' job, is the workspace already populated with the source code or do I need the zuul clone macro ? | 15:31 |
mwhahaha | it's already populated with that project's code | 15:31 |
mwhahaha | but you'd need to pull down your dependencies | 15:31 |
mwhahaha | which is where zuul cloner comes in | 15:31 |
chem | mwhahaha: thanks | 15:35 |
_ody | Got my PR in for our production cloud before heading the gym yesterday. All sprint all day today. | 15:55 |
_ody | Can I insert myself into something already being worked on or just grab something off the stack? | 15:56 |
EmilienM | degorenko, mwhahaha: can we land https://review.openstack.org/#/c/272553/ please ? | 16:13 |
EmilienM | and https://review.openstack.org/#/c/272552/ | 16:13 |
degorenko | EmilienM, done :) | 16:15 |
EmilienM | _ody: we're tracking the work on https://etherpad.openstack.org/p/puppet-happy-new-year-2016 | 16:16 |
EmilienM | _ody: degorenko wanted to make progress on Mitaka deprecations + removals | 16:17 |
EmilienM | maybe you guys can work together on it | 16:17 |
degorenko | sure, _ody if here is anything that i can help you - you're welcome | 16:18 |
degorenko | i'm sorry, that i can't lead this activity as it was planned, but i have unexpected internal stuff :( | 16:18 |
_ody | Ok. Sounds good to me. I doubt we have a way to identify deprecations added post liberty besides "git blame" | 16:18 |
_ody | degorenko: np. As did I yesterday. I'll start digging into it. | 16:19 |
degorenko | _ody, ok, please ping me or add to review in case of you need help :) | 16:19 |
chem | mwhahaha: if you have time to review https://review.openstack.org/#/c/272156/, that would be great. I let a comment inside the code, I don't know if it doable... | 17:11 |
chem | mwhahaha: I have to go right now, but I will check back later on gerrit | 17:11 |
mwhahaha | sure | 17:12 |
_ody | degorenko: You called out specifically keytone endpoint types in you mitaka deprecation topic but all master branches seemt to already have them set in their corresponding *::keystone::auth classes. | 17:19 |
_ody | Did you have a specific example? | 17:19 |
degorenko | _ody, it wasn't me :( it was mfisch | 17:20 |
mfisch | what did I do? | 17:20 |
mfisch | oh | 17:20 |
mfisch | yeah that was fixed in between the time I wrote that and now | 17:20 |
mfisch | we can delete it | 17:20 |
_ody | Ok. Check! | 17:21 |
* _ody goes back to one module at a time | 17:21 | |
*** EmilienM has quit IRC | 17:30 | |
*** EmilienM has joined #openstack-sprint | 17:34 | |
mfisch | _ody: whats the docs scrub? | 17:35 |
*** degorenko is now known as _degorenko|afk | 17:56 | |
_ody | mfisch: I just recalled last sprint when hunner and I were doing the PL module approved thing, docs weren't complete enough to actually use them as a source of information as a beginner operator/automator. | 18:01 |
_ody | I do not have a specific example. | 18:01 |
_ody | mfisch, EmilienM https://github.com/openstack/puppet-cinder/blob/master/manifests/api.pp#L158-L159 | 18:26 |
_ody | You were the last two to touch those lines. | 18:26 |
_ody | Is the parameter on line 159 actually deprecated? | 18:26 |
_ody | The rest of the code doesn't indicate as such. | 18:26 |
_ody | Neither does the documentation. | 18:26 |
EmilienM | I think we can drop this code | 18:26 |
EmilienM | I'm sure nobody use the validation | 18:27 |
_ody | oh. You mean all together. | 18:27 |
EmilienM | and we can send a warning first | 18:27 |
_ody | So take it out of openstacklib. | 18:27 |
EmilienM | _ody: yeah we can | 18:42 |
EmilienM | I tried to do something after paris summit | 18:42 |
EmilienM | but it was useless | 18:42 |
EmilienM | we could drop the code | 18:42 |
EmilienM | what do you think about https://review.openstack.org/#/c/272203/ ? Specially the fact we have python code in the puppet module | 19:34 |
EmilienM | crinkle: ^ | 19:34 |
crinkle | EmilienM: i think using reno is good | 19:35 |
EmilienM | nice | 19:35 |
crinkle | EmilienM: you're the only one who would have to make releases, so it's only you who needs to interact with the python stuff right? | 19:36 |
EmilienM | crinkle: dhellmann helped me to make it work in puppet-keystone, the patch is ready for review | 19:36 |
EmilienM | crinkle: yes | 19:36 |
crinkle | we don't need to require our developers to have both python and ruby environments set up, so it seems fine to me | 19:36 |
EmilienM | crinkle: and our gate, that build doc | 19:36 |
crinkle | right | 19:36 |
EmilienM | nibalizer: when you around, could you look https://review.openstack.org/#/c/272261/ please? | 19:50 |
nibalizer | sure | 19:54 |
mfisch | EmilienM: reading your email | 19:56 |
mfisch | why switch to IPv6? | 19:56 |
mfisch | I'd like to keep both rather than switch | 19:56 |
EmilienM | it was an idea | 19:56 |
mfisch | I would show you the "Why Not Both?" meme but the commercial probably doesnt show in Canada ;) | 19:58 |
*** rfolco has quit IRC | 19:59 | |
mwhahaha | fortunately there's this thing called youtube, https://www.youtube.com/watch?v=vqgSO8_cRio | 20:00 |
mfisch | lol | 20:01 |
EmilienM | nice one | 20:01 |
mfisch | thats in the original spanish even | 20:01 |
EmilienM | mfisch: how do you see it? | 20:02 |
EmilienM | dual stack? | 20:02 |
mfisch | well I'm thinking about that | 20:02 |
mfisch | I dont have a good solution | 20:02 |
mfisch | are lots of people using ipv6 these days? | 20:02 |
EmilienM | mfisch: redhat deploys openstack on ipv6 networks for customers | 20:03 |
EmilienM | we added ipv6 support in tripleo | 20:03 |
EmilienM | might be worth to investigate | 20:03 |
mfisch | its probably ok for loopback ayway | 20:05 |
mfisch | anyway | 20:05 |
_ody | deprecations are time consumeing. | 21:15 |
mwhahaha | yes | 21:23 |
_ody | I am going to be lucky to finish even two modules. | 21:29 |
EmilienM | _ody: can I help? | 21:41 |
_ody | EmilienM: Nothing right now. Just having to go through each file one at a time takes time. | 21:51 |
_ody | Removing any tests related to deprecated things that I am removing then I'll have a part 1 for cinder. | 21:52 |
mfisch | do any of our modules make openrc files? | 22:18 |
EmilienM | nope | 22:18 |
_ody | Only openstack_extras. | 22:18 |
mfisch | Im using the ancient puppet-openstack module but am about to just do it myself | 22:18 |
mfisch | ah extras | 22:18 |
_ody | Hmm...afternoon tea or coffee. | 22:19 |
* _ody has already had morning tea and coffee | 22:20 | |
mfisch | openstack extras doesnt handle some of the more advanced settings for openstack client | 22:20 |
mfisch | like identity api version | 22:20 |
mfisch | _ody: tea | 22:20 |
_ody | mfisch: Nope. It actually pretty much breaks stuff. | 22:20 |
_ody | I wouldn't be offended if we deprecated that from extras. | 22:21 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!