*** y_sawai has joined #openstack-stable | 00:17 | |
*** y_sawai has quit IRC | 00:18 | |
*** takedakn has left #openstack-stable | 00:23 | |
*** openstack has joined #openstack-stable | 00:33 | |
*** asahlin has quit IRC | 03:46 | |
*** asahlin has joined #openstack-stable | 03:47 | |
*** RaySun has joined #openstack-stable | 05:21 | |
*** RaySun has quit IRC | 06:20 | |
*** mrunge has joined #openstack-stable | 06:31 | |
*** e0ne has joined #openstack-stable | 06:52 | |
*** e0ne has quit IRC | 07:45 | |
*** derekh has joined #openstack-stable | 08:09 | |
*** e0ne has joined #openstack-stable | 09:08 | |
*** e0ne has quit IRC | 09:18 | |
*** e0ne has joined #openstack-stable | 09:23 | |
*** ihrachyshka has joined #openstack-stable | 09:33 | |
*** eharney has joined #openstack-stable | 13:00 | |
*** mriedem has joined #openstack-stable | 13:03 | |
*** ihrachyshka has quit IRC | 13:04 | |
*** takedakn has joined #openstack-stable | 13:04 | |
*** ihrachyshka has joined #openstack-stable | 13:16 | |
*** bknudson has joined #openstack-stable | 13:38 | |
*** moon_ has joined #openstack-stable | 13:52 | |
*** ihrachyshka has quit IRC | 13:53 | |
*** eharney has quit IRC | 14:02 | |
*** ihrachyshka has joined #openstack-stable | 14:05 | |
*** takedakn has quit IRC | 14:22 | |
*** lifeless1 has joined #openstack-stable | 14:23 | |
*** lifeless has quit IRC | 14:24 | |
*** eharney has joined #openstack-stable | 14:37 | |
*** liam__ has joined #openstack-stable | 14:46 | |
*** liam__ has quit IRC | 14:53 | |
*** xaeth_afk is now known as xaeth | 14:53 | |
ihrachyshka | mriedem, so I had a silly typo in https://review.openstack.org/216328 before | 15:22 |
---|---|---|
ihrachyshka | could you please check again? | 15:22 |
mriedem | heh that is silly | 15:25 |
mriedem | +2 | 15:25 |
mriedem | ihrachyshka: btw, i'll trade you https://review.openstack.org/#/q/I204c6f61194bef6eba01ab0525bc80fa2e323acd,n,z | 15:27 |
ihrachyshka | mriedem, +A both | 15:32 |
ihrachyshka | mriedem, fyi "Each backported commit proposed to gerrit should be reviewed and +2ed by two $PROJECT-stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval. " | 15:34 |
mriedem | ihrachyshka: yeah | 15:36 |
mriedem | i don't +2 my own backports to stable though | 15:37 |
ihrachyshka | mriedem, sure you don't. I only mean when you review smth that is sent by another stable-maint member, you can go with +A it | 15:37 |
mtreinish | ihrachyshka: wait that's in the stable branch policy page, that seems kinda weird | 15:43 |
-openstackstatus- NOTICE: restarting gerrit due to a slow memory leak | 15:45 | |
mriedem | mtreinish: yeah | 15:49 |
ihrachyshka | mtreinish, weird? what specifically? the rule? | 15:49 |
mtreinish | ihrachyshka: yes that specific line you quoted, it's contrary to the culture everywhere else | 15:51 |
ihrachyshka | mtreinish, I think it reflects the lack of stable resources | 15:51 |
mriedem | that's why i show up here asking for reviews | 15:52 |
mriedem | or in the specific projects for their stable branch maintainers | 15:52 |
mriedem | like claudiub was backporting hyper-v things to stable in nova and then +2ing his own backports | 15:52 |
mriedem | to indicate this guideline | 15:53 |
mriedem | i told him i thought that was kind of uncool | 15:53 |
ihrachyshka | mriedem, ok, you can send an email to change it | 15:53 |
mriedem | i guess i don't have a huge problem with that guideline, assuming people are not breaking the stable proposal rules, | 15:55 |
mriedem | i just kind of had an issue with the +2s on one's own changes | 15:55 |
ihrachyshka | mriedem, how is it different that you have two +2, one from the owner, or one +2 that is of a different reviewer? | 16:19 |
ihrachyshka | apart from stats | 16:19 |
*** moon_ has quit IRC | 16:23 | |
mriedem | it was more a thing that surprised me in the dashboard | 16:24 |
mriedem | i pulled up a dashboard of all nova stable/kilo changes and there were a bunch of self +2s from the person that proposed the backport | 16:24 |
mriedem | just took me by surprise | 16:24 |
*** derekh has quit IRC | 16:46 | |
*** e0ne has quit IRC | 17:15 | |
*** ihrachyshka has quit IRC | 17:22 | |
*** federico3 has joined #openstack-stable | 17:50 | |
*** mrunge has quit IRC | 18:11 | |
*** mrunge has joined #openstack-stable | 18:16 | |
*** e0ne has joined #openstack-stable | 18:25 | |
*** lifeless1 is now known as lifeless | 18:39 | |
*** e0ne has quit IRC | 18:50 | |
*** e0ne has joined #openstack-stable | 19:13 | |
*** ihrachyshka has joined #openstack-stable | 19:25 | |
*** y_sawai has joined #openstack-stable | 19:59 | |
*** y_sawai has quit IRC | 20:09 | |
*** e0ne has quit IRC | 20:28 | |
*** y_sawai has joined #openstack-stable | 20:35 | |
*** y_sawai has quit IRC | 20:36 | |
*** fesp has joined #openstack-stable | 20:52 | |
*** mrunge has quit IRC | 21:10 | |
*** jamielennox has quit IRC | 21:36 | |
*** jamielennox has joined #openstack-stable | 21:38 | |
*** mriedem has quit IRC | 21:40 | |
*** fesp has quit IRC | 21:45 | |
*** eharney has quit IRC | 21:53 | |
*** bknudson has quit IRC | 22:08 | |
*** xaeth is now known as xaeth_afk | 22:12 | |
*** ihrachys1ka has joined #openstack-stable | 22:28 | |
*** ihrachyshka has quit IRC | 22:28 | |
*** ihrachys1ka has quit IRC | 22:28 | |
*** ihrachyshka has joined #openstack-stable | 22:28 | |
*** ihrachyshka has quit IRC | 22:36 | |
*** ihrachyshka has joined #openstack-stable | 22:38 | |
*** ihrachyshka has quit IRC | 22:41 | |
*** ihrachyshka has joined #openstack-stable | 22:42 | |
*** ihrachyshka is now known as ihrachys | 22:47 | |
*** ihrachys has quit IRC | 22:50 | |
*** ihrachys has joined #openstack-stable | 22:51 | |
*** arif-ali has quit IRC | 23:19 | |
*** arif-ali has joined #openstack-stable | 23:19 | |
*** mriedem has joined #openstack-stable | 23:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!