| takashi_ | eranrom: Thank you for your review! I'll check it. | 00:34 |
|---|---|---|
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 01:05 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 01:11 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 01:21 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Use logger.exception instead of original method https://review.openstack.org/276543 | 01:22 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Improve handling about Timeout in storlet_handler https://review.openstack.org/276545 | 01:29 |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 02:05 |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 02:32 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: Fix redundant call of get_vaco in storlet_handler https://review.openstack.org/277285 | 05:36 |
| *** takashi_ is now known as takashi | 07:15 | |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: [WIP] Refactor test_storlet_handler https://review.openstack.org/277322 | 08:51 |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** openstackgerrit has joined #openstack-storlets | 09:03 | |
| takashi | kota_: Does the patch 277322 make sence to you? | 09:12 |
| patchbot | takashi: https://review.openstack.org/#/c/277322/ - storlets - [WIP] Refactor test_storlet_handler | 09:12 |
| takashi | I haven't finished it yet (because I know I shoud rebase it soon), but I'm glad to hear your opinion about it. | 09:12 |
| kota_ | why not moving some common "init and registers" into "def setUp"? | 09:16 |
| kota_ | most likely def setUp: self.app = FakeApp() self.app.register(xxx) | 09:17 |
| kota_ | s/setUp/setup(self)/ | 09:18 |
| takashi | kota_: Thanks. I should consider that. | 09:23 |
| takashi | but we have to be carefule to do that, because each unittests require defferent request pathes. | 09:31 |
| takashi | and that's why I've not done it yet... I'm going to think more about this. :-) | 09:32 |
| kota_ | takashi at least, we can initialize the FakeApp in setUp | 09:41 |
| takashi | kota_: You are right. I'll do it soon, not to forget it. | 09:47 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: [WIP] Refactor test_storlet_handler https://review.openstack.org/277322 | 09:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!