| openstackgerrit | Merged openstack/storlets: Remove redundant passing container id in daemon factory https://review.openstack.org/375581 | 02:07 |
|---|---|---|
| *** takashi has joined #openstack-storlets | 06:06 | |
| *** takashi has quit IRC | 06:50 | |
| *** takashi has joined #openstack-storlets | 07:56 | |
| eranrom | Hi | 09:00 |
| kota_ | moving | 09:00 |
| takashi | hi | 09:00 |
| eranrom | ok, my only concern is that it will slow us down. | 09:01 |
| eranrom | I mean having two reviewers per patch | 09:01 |
| kota_ | got it your concern | 09:01 |
| eranrom | Suggestion: How about the patch author to state whether he wants one or two +2? | 09:02 |
| takashi | IMO, | 09:03 |
| eranrom | Clearly at some point we will always require 2X +2 | 09:03 |
| takashi | we should have two +2s as a basic rule | 09:03 |
| takashi | however, in some cases, we need to skip that (ex. need quick fix for the problem) | 09:04 |
| takashi | in that case we can discuss on irc or other way, and should record that it is agreed approval | 09:04 |
| kota_ | basically, I think, it's ok for small thing, in particular, doc change. | 09:04 |
| kota_ | fix type or etc... | 09:04 |
| takashi | 'TrivialFix' can be a mark which needs one +2 | 09:04 |
| eranrom | takashi: ok, and the string 'TrivialFix' will be in the commit meddage? | 09:05 |
| takashi | like this https://review.openstack.org/#/c/376549/ | 09:05 |
| eranrom | go it | 09:05 |
| eranrom | Sounds good to me! | 09:05 |
| takashi | eranrom: AFAIK this is usually used in the other projects | 09:05 |
| kota_ | takashi: looks good to me. | 09:05 |
| kota_ | so author can suggest that this is "trivial" but the first core als can judge if it's *really* trivial or not. | 09:06 |
| eranrom | Agreed. | 09:06 |
| takashi | kota_: yes | 09:07 |
| kota_ | if the fist judge doesn't agree if it's trivial, then, make -1 with comment like 'this is not trivial one so need 2x +2 to land' | 09:08 |
| kota_ | it seems to work to me :-D | 09:08 |
| eranrom | +1 | 09:08 |
| takashi | Let's work on this rule, and if we find any problems, let's dicsuss what we can do | 09:09 |
| kota_ | sure | 09:09 |
| eranrom | sure | 09:09 |
| eranrom | One thing I expect we would like to treat as 'TrivialFix' is code that is not central or influences much, such as a SampleStorlet. But we can discuss this when we get there | 09:10 |
| eranrom | BTW - once we are official, we may want to move the samples to another repo, but this is a different discussion :-) | 09:11 |
| kota_ | eranrom: is that requierement from TC? | 09:11 |
| takashi | kota_: It is mentioned in the discussion with TC | 09:12 |
| kota_ | ok | 09:12 |
| kota_ | thanks | 09:12 |
| eranrom | right. My take is that for now they are ok with one reviewer | 09:12 |
| takashi | I remeber that they used the work 'single core approval' | 09:13 |
| takashi | s/work/word/ | 09:13 |
| eranrom | it was raised as a concern, but not as a 'must have' for being official. At least this is my understanding | 09:13 |
| kota_ | sorry leaving for a while, will be back in half hour. | 09:13 |
| eranrom | kota_: sure. | 09:13 |
| eranrom | see u | 09:14 |
| eranrom | thanks for joining | 09:14 |
| takashi | eranrom: I think it's good chance to think about the review process | 09:14 |
| eranrom | takashi: agree. Let me summarize | 09:14 |
| takashi | it passed about a half year after we started current review process (I mean, after you invited us as core reviewers) | 09:14 |
| eranrom | takashi: yep. | 09:15 |
| takashi | eranrom: ok | 09:15 |
| eranrom | 1. As a rule we require two +2s | 09:15 |
| eranrom | 2. There may be exceptions (such as 'TrivialFix', doc fix, etc), in which case the author can ask for one +2. | 09:16 |
| eranrom | 3. In any case the first reviewer can decide that it requires two +2s and we can always discuss on IRC | 09:17 |
| eranrom | 3 is actually continuation of 2. | 09:17 |
| eranrom | end of summary. | 09:17 |
| takashi | eranrom: agree | 09:18 |
| takashi | maybe we can add them on big tent etherpad | 09:18 |
| eranrom | takashi: good idea! | 09:18 |
| eranrom | Should I? | 09:19 |
| takashi | eranrom: I'll do that | 09:19 |
| eranrom | takashi: thanks! | 09:20 |
| eranrom | so anything else for now? | 09:20 |
| takashi | eranrom: nothing from my side | 09:21 |
| eranrom | ok so thanks for joining! | 09:23 |
| *** takashi has quit IRC | 10:29 | |
| *** openstackgerrit has quit IRC | 15:18 | |
| *** openstackgerrit has joined #openstack-storlets | 15:19 | |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: WIP: Create storlets package https://review.openstack.org/370332 | 16:11 |
| openstackgerrit | Takashi Kajinami proposed openstack/storlets: DO NOT MERGE: Fix ant deploy_*_engine https://review.openstack.org/377828 | 16:11 |
| *** mattoliverau has quit IRC | 16:37 | |
| *** matt6434 has joined #openstack-storlets | 16:37 | |
| *** eranrom_ has joined #openstack-storlets | 16:45 | |
| *** eranrom has quit IRC | 16:47 | |
| *** mattoliverau has joined #openstack-storlets | 16:47 | |
| *** matt6434 has quit IRC | 16:48 | |
| *** kota_ has quit IRC | 19:34 | |
| *** kota_ has joined #openstack-storlets | 19:35 | |
| *** mattoliverau has quit IRC | 19:36 | |
| *** matt6434 has joined #openstack-storlets | 19:36 | |
| *** matt6434 has quit IRC | 19:45 | |
| *** matt6434 has joined #openstack-storlets | 19:45 | |
| *** kota_ has quit IRC | 20:21 | |
| *** kota_ has joined #openstack-storlets | 20:22 | |
| *** matt6434 has quit IRC | 20:23 | |
| *** matt6434 has joined #openstack-storlets | 20:24 | |
| *** matt6434 has quit IRC | 20:32 | |
| *** matt6434 has joined #openstack-storlets | 20:33 | |
| *** kota_ has quit IRC | 20:42 | |
| *** kota_ has joined #openstack-storlets | 20:45 | |
| *** matt6434 has quit IRC | 20:46 | |
| *** matt6434 has joined #openstack-storlets | 20:46 | |
| *** matt6434 is now known as mattoliverau | 21:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!