Tuesday, 2017-04-04

kota_eranrom: quick report for py3, patch 452673 works well with tox -e py35 in my local xenial01:44
kota_i've had concern about the fd leak yet but if it doesn't leak the fd, i think it's the best for now01:45
openstackgerritKota Tsuyuzaki proposed openstack/storlets master: Fix py3 unit test failures  https://review.openstack.org/45267301:53
eranromkota_: Thanks for the update. I do not see how we can leak the fd, given that we are inside a with statement.06:23
eranromkota_: I will not be able to join the meeting today. Can you run it? There are no special items from my side06:24
eranromAlso, I have squashed all ipython stuff into https://review.openstack.org/#/c/452649/06:26
kota_eranrom: ok, will do that07:06
kota_eranrom: IIRC, the with context should be a solution to prevent un-closed file (and it's fd) and it's preferred than call open like `f = open(file)`07:08
kota_eranrom: FWIW, what i can tell you is the py3 failure is from the os.close was called more than we expected.07:10
kota_eranrom: i think, it's from the diff between py2-py3 but it seems like py3 is using os.close to close the fd in the with context07:10
kota_eranrom: so that I'm realizing to think the best way is to leave the open file handling to the native handler as possible07:11
openstackgerritMerged openstack/storlets master: Fix py3 unit test failures  https://review.openstack.org/45267307:59
*** takashi has joined #openstack-storlets08:25
takashifyi, talking about a little future stuff, I do not attend to Boston summit08:26
takashiwhile I don't know any kind of developer discussion can happen there08:27
*** takashi has quit IRC08:29
eranromTakashi, thanks for the update14:55
eranromI will also not attend14:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!