| openstackgerrit | Brian Cline proposed openstack/swauth: Use correct content type on JSON responses https://review.openstack.org/279955 | 11:02 |
|---|---|---|
| *** briancline has joined #openstack-swauth | 11:27 | |
| onovy | briancline: hi | 12:07 |
| onovy | ad json content-type | 12:08 |
| onovy | only nit in unit tests i'm thinking about. self.assertEqual(resp.content_type, auth.CONTENT_TYPE_JSON) // not sure if it's correct to us auth.CONTENT_TYPE_JSON. i think you should create own const in unit tests | 12:08 |
| onovy | it's much safer | 12:09 |
| onovy | what do you think? | 12:09 |
| onovy | briancline: i wrote it inside review, thanks for your contribution | 12:25 |
| briancline | onovy: yeah, i dont know that its particularly unsafe as a const and we want to test the presence, but i do see the stylistic concern over keeping them separate. i'll push up another changeset :) | 12:39 |
| onovy | perfect, thanks :) | 12:39 |
| openstackgerrit | Brian Cline proposed openstack/swauth: Use correct content type on JSON responses https://review.openstack.org/279955 | 12:42 |
| onovy | briancline: one of two nits :) | 12:48 |
| onovy | ah sry, comment | 12:48 |
| onovy | i need to fix my saio+swauth first, don't know why it's not working. then i will reply | 12:51 |
| briancline | cool, no rush | 12:52 |
| onovy | ad your question: Should we change the content type on the underlying objects as well? // i think yes | 13:01 |
| onovy | do you want to work on it as follow up? :) | 13:02 |
| briancline | sure, no problem | 13:04 |
| briancline | and i agree :) | 13:04 |
| openstackgerrit | Merged openstack/swauth: Use correct content type on JSON responses https://review.openstack.org/279955 | 13:05 |
| onovy | perfect | 13:05 |
| briancline | thanks for the quick review and merge | 13:07 |
| onovy | you are welcome | 13:07 |
| openstackgerrit | Ondřej Nový proposed openstack/swauth: Fixed E127 and E131 hacking. https://review.openstack.org/279975 | 13:27 |
| *** nadeem has joined #openstack-swauth | 18:49 | |
| *** nadeem has quit IRC | 19:07 | |
| *** nadeem has joined #openstack-swauth | 19:22 | |
| *** nadeem has quit IRC | 19:37 | |
| *** nadeem has joined #openstack-swauth | 20:13 | |
| *** nadeem has quit IRC | 20:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!