| *** ppai has joined #openstack-swauth | 05:06 | |
| *** ppai is now known as ppai|afk | 08:09 | |
| openstackgerrit | Merged openstack/swauth: Don't pass unicode to hmac.new() https://review.openstack.org/282191 | 08:36 |
|---|---|---|
| openstackgerrit | Merged openstack/swauth: Document swift3 compatibility https://review.openstack.org/282300 | 08:45 |
| peterlisak | ppai|afk, patch 285195, do you know why the setting up a salt was canceled before? Or what older version supported that? I'm just curious | 08:46 |
| ppai|afk | peterlisak, I can point you to the commit that did it | 08:48 |
| *** ppai|afk is now known as ppai | 08:49 | |
| peterlisak | ppai, great, thanks | 08:49 |
| ppai | peterlisak, https://github.com/openstack/swauth/commit/e14a7b3 | 08:51 |
| ppai | peterlisak, my rationale behind reintroducing it is that it's necessary for fixing swift3 compatibility and it's a tunable now (default off) for anyone paranoid about security | 08:54 |
| peterlisak | yes, I understand. It makes sense | 08:58 |
| openstackgerrit | Merged openstack/swauth: Allow configuring salt manually https://review.openstack.org/285195 | 09:27 |
| ppai | peterlisak, thanks for the quick merge! Please have a look at 285292 as well when you've got time. | 09:32 |
| peterlisak | of course, i'm working on that ;) | 09:35 |
| peterlisak | ppai, In general it's a good and working solution but IMHO it would be more clear to have two common complementary functions for building and parsing credentials string (I mean this string "auth_type:key") ... It's just my thought, now I'm going to give +A. | 10:13 |
| ppai | peterlisak, Ah, I see. | 10:16 |
| ppai | peterlisak, sorry about the loop in tests, it's easy and makes sure all combinations are tested | 10:17 |
| peterlisak | ppai: reviews done, thanks for your help! | 10:21 |
| ppai | peterlisak, np, thanks for the reviews. | 10:22 |
| openstackgerrit | Merged openstack/swauth: Fix changing of auth_type in existing deployments https://review.openstack.org/285292 | 10:26 |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** openstackgerrit has joined #openstack-swauth | 10:33 | |
| *** ppai has quit IRC | 10:36 | |
| *** nadeem has joined #openstack-swauth | 14:06 | |
| *** nadeem has quit IRC | 15:21 | |
| *** nadeem has joined #openstack-swauth | 16:25 | |
| *** nadeem has quit IRC | 17:30 | |
| *** nadeem has joined #openstack-swauth | 17:31 | |
| *** nadeem has quit IRC | 19:59 | |
| *** nadeem has joined #openstack-swauth | 20:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!