Wednesday, 2015-04-22

*** annegentle has joined #openstack-swift00:01
*** annegentle has quit IRC00:06
*** yuan has quit IRC00:07
claygtorgomatic: so this ring builder debug - it makes my test output sorta scrolly00:09
*** tsg has quit IRC00:17
*** david-lyle has quit IRC00:24
*** david-lyle has joined #openstack-swift00:27
*** tsg has joined #openstack-swift00:29
torgomaticclayg: when a test fails, you mean?00:31
claygtorgomatic: yeah :D00:31
torgomaticclayg: yeah, I noticed that, but I didn't end up doing anything about it :p00:32
torgomaticI'm not sure why everything's at debug-level, but I'm guessing it's the testrunner doing something to the root logger00:33
claygtorgomatic: yeah - we could maybe try to squelch something in the test setup?00:33
torgomaticclayg: yeah, that could work... lemme see00:34
*** kota_ has quit IRC00:36
*** lcurtis has joined #openstack-swift00:47
*** annegentle has joined #openstack-swift01:03
*** annegentle has quit IRC01:08
mattoliverauFYI, my boss is actually in my city today (rare cause he lives and works in a different city) so will be in and out most the day in meetings etc.01:10
*** gyee has quit IRC01:12
*** zhill has quit IRC01:45
*** lcurtis has quit IRC01:46
*** bill_az has quit IRC01:54
*** tsg has quit IRC01:59
*** annegentle has joined #openstack-swift02:00
openstackgerritSamuel Merritt proposed openstack/swift: Bulk upload: treat user xattrs as object metadata  https://review.openstack.org/17616102:05
*** imkarrer_ has joined #openstack-swift02:07
*** annegentle has quit IRC02:09
*** annegentle has joined #openstack-swift02:27
*** esker has joined #openstack-swift02:38
*** jamielennox is now known as jamielennox|away02:39
*** Vinsh has joined #openstack-swift02:57
*** Vinsh has quit IRC03:01
*** annegentle has quit IRC03:10
*** annegentle has joined #openstack-swift03:13
*** annegentle has quit IRC03:20
*** annegentle has joined #openstack-swift03:21
*** annegentle has quit IRC03:26
*** MVenesio has quit IRC03:51
*** km_ has joined #openstack-swift03:57
*** km has quit IRC03:59
*** kei_yama has quit IRC04:01
*** kei_yama has joined #openstack-swift04:02
*** imkarrer__ has joined #openstack-swift04:04
*** imkarrer_ has quit IRC04:06
*** jrichli has joined #openstack-swift04:10
*** evanjfraser has quit IRC04:11
*** jrichli has quit IRC04:17
*** evanjfraser has joined #openstack-swift04:21
*** annegentle has joined #openstack-swift04:22
*** ppai has joined #openstack-swift04:27
*** annegentle has quit IRC04:28
*** ppai has quit IRC04:55
*** km_ has quit IRC05:22
*** kei_yama has quit IRC05:23
*** annegentle has joined #openstack-swift05:24
*** SkyRocknRoll has joined #openstack-swift05:24
*** SkyRocknRoll has joined #openstack-swift05:24
*** kei_yama has joined #openstack-swift05:25
*** annegentle has quit IRC05:29
*** yuan has joined #openstack-swift05:33
*** bkopilov has quit IRC05:35
*** bkopilov has joined #openstack-swift05:37
*** km has joined #openstack-swift05:38
*** silor has joined #openstack-swift05:44
*** haigang has joined #openstack-swift05:44
*** tsg has joined #openstack-swift05:45
*** zaitcev has quit IRC05:53
*** tsg has quit IRC05:58
*** tsg has joined #openstack-swift05:59
*** tsg has quit IRC06:14
*** annegentle has joined #openstack-swift06:25
*** annegentle has quit IRC06:29
*** proteusguy has joined #openstack-swift06:54
*** kota_ has joined #openstack-swift06:59
kota_wow, all rc2paches got -1 verified at granade gate...why...07:09
*** imkarrer__ has quit IRC07:16
*** annegentle has joined #openstack-swift07:25
*** annegentle has quit IRC07:31
*** acoles_away is now known as acoles07:37
*** slo_ has quit IRC07:43
*** jistr has joined #openstack-swift07:50
*** proteusguy has quit IRC07:55
acoleskota_: hmmm, i just put recheck on them all, looks like bug 1446847 had a fix committed so maybe they will pass07:56
openstackbug 1446847 in OpenStack-Gate "stable/juno gate is busted on Oslo releases on 4/21" [Undecided,New] https://launchpad.net/bugs/144684707:56
*** jordanP has joined #openstack-swift08:09
kota_acoles: Thanks to make the recheck :) I didn't know the command "reverify".08:16
kota_acoles: FYI, I'm joining mid-cycle ops meetup report in Japan :P08:17
kota_leaving until irc meeting time for dinner and sleep08:18
*** kota_ has quit IRC08:18
*** sandywalsh has quit IRC08:24
*** sandywalsh has joined #openstack-swift08:24
*** annegentle has joined #openstack-swift08:26
*** breitz has quit IRC08:27
*** breitz has joined #openstack-swift08:29
*** ndk has quit IRC08:30
*** ndk has joined #openstack-swift08:31
*** annegentle has quit IRC08:31
*** haigang has quit IRC08:32
*** ppai has joined #openstack-swift08:35
*** haigang has joined #openstack-swift08:41
*** proteusguy has joined #openstack-swift08:43
*** haigang has quit IRC08:46
*** haigang has joined #openstack-swift08:47
*** haigang has quit IRC08:52
*** haigang has joined #openstack-swift08:58
*** kei_yama has quit IRC09:00
*** km has quit IRC09:02
*** ppai has quit IRC09:19
*** annegentle has joined #openstack-swift09:27
*** annegentle has quit IRC09:31
*** ppai has joined #openstack-swift09:33
*** silor has quit IRC09:53
*** aix has joined #openstack-swift10:00
*** slo_ has joined #openstack-swift10:04
slo_At the Swift install point - having multi storage server (let's say 5 of them). I am interested is it OK to call swift-ring-builder CREATE command (for setting replica count at acc/cont/obj) just at one storage node and than copy all al *.ring.gz files to all storage nodes within /etc/swift directory or do I have to call the same create command also on other storage nodes?10:08
acolesslo_: yes, its ok to create ring files on one node and then copy to all others, see http://docs.openstack.org/juno/install-guide/install/apt/content/swift-initial-rings.html10:12
slo_acoles: thx for confirmation10:18
*** annegentle has joined #openstack-swift10:28
*** annegentle has quit IRC10:33
*** proteusguy has quit IRC10:34
*** geaaru has joined #openstack-swift10:42
*** haigang has quit IRC10:58
*** erlon has joined #openstack-swift10:59
*** aix has quit IRC11:07
*** haigang has joined #openstack-swift11:08
*** proteusguy has joined #openstack-swift11:09
*** annegentle has joined #openstack-swift11:28
*** annegentle has quit IRC11:34
*** esker has quit IRC11:38
*** aix has joined #openstack-swift11:58
*** haigang has quit IRC12:02
*** haigang has joined #openstack-swift12:03
*** ppai has quit IRC12:06
*** haigang has quit IRC12:12
*** tsg has joined #openstack-swift12:18
*** ppai has joined #openstack-swift12:18
*** annegentle has joined #openstack-swift12:29
slo_acoles: are you there12:38
*** SkyRocknRoll has quit IRC12:40
slo_i am interested about *.builder files, should I also copy them to other servers, just as i did this *.gz?12:40
slo_i guess verifiying the ring content is possible just on node, where builder files also exist at the same time, for example i am calling  swift-ring-builder object.builder command (http://docs.openstack.org/juno/install-guide/install/yum/content/swift-initial-rings-object.html) to list the content on the node to which i just copied *.ring.gz files and I get no results. It works just on the node, where *.builder files are prese12:44
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/12915412:47
acolesslo_: you don't need the *.builder files on all the nodes, but you do need them on the node(s) where you run swift-ring-builder. so, yes, you guessed right.12:52
slo_acoles: ok thx12:57
acolesslo_: welcome12:57
*** ppai has quit IRC13:01
*** mahatic has joined #openstack-swift13:18
*** annegentle has quit IRC13:20
*** dencaval has joined #openstack-swift13:20
jordanPtest_tempurl_keys_hidden_from_acl_readonly fail on a fresh devstack+swift install13:20
jordanPResponseError: 403: 'Forbidden'13:20
*** pberis has joined #openstack-swift13:21
*** Gu_______ has joined #openstack-swift13:21
*** esker has joined #openstack-swift13:24
*** annegentle has joined #openstack-swift13:29
*** Vinsh has joined #openstack-swift13:30
jordanPprobably a devstack bug though13:31
*** annegentle has quit IRC13:32
*** annegentle has joined #openstack-swift13:32
*** Vinsh has quit IRC13:39
*** annegentle has quit IRC13:57
*** annegentle has joined #openstack-swift13:59
*** Gu_______ has quit IRC14:02
*** jrichli has joined #openstack-swift14:08
*** lcurtis has joined #openstack-swift14:09
*** petertr7 has joined #openstack-swift14:12
*** haomaiwang has quit IRC14:12
*** haomaiwang has joined #openstack-swift14:13
*** wbhuber has joined #openstack-swift14:18
*** Vinsh has joined #openstack-swift14:23
*** imkarrer_ has joined #openstack-swift14:30
*** pberis has quit IRC14:31
*** pberis has joined #openstack-swift14:39
*** Vinsh_ has joined #openstack-swift14:42
*** tsg has quit IRC14:45
*** Vinsh has quit IRC14:45
openstackgerritJanie Richling proposed openstack/swift: FakeFooters middleware  https://review.openstack.org/16551714:49
openstackgerritJanie Richling proposed openstack/swift: Allow middleware to override metadata header checking  https://review.openstack.org/16380614:49
openstackgerritJanie Richling proposed openstack/swift: WIP - working on the encryption feature.  https://review.openstack.org/15790714:49
openstackgerritJanie Richling proposed openstack/swift: Enable middleware to set metadata on object POST  https://review.openstack.org/15840114:49
*** bsdkurt has joined #openstack-swift14:49
*** pberis has quit IRC14:52
*** Guest_ has joined #openstack-swift14:53
*** bill_az has joined #openstack-swift14:55
*** Guest_ has quit IRC14:56
notmynameclayg: on https://review.openstack.org/#/q/I34747094a645201e52da7081d9215d5b2cb5d9ff,n,z is that not tested with probe tests?15:05
bill_aztdasilva: ping15:05
notmynamebill_az: FYI tdasilva probably won't be around for a while. he's on paternity leave15:06
openstackgerritMerged openstack/swift: Don't apply the wrong Etag validation to rebuilt fragments  https://review.openstack.org/17455215:06
*** annegentle has quit IRC15:06
*** annegentle has joined #openstack-swift15:06
bill_aznotmyname:  ok - the right priority!15:06
notmynamebill_az: anything I can help with?15:07
bill_aznotmyname:  I have a question about change https://github.com/openstack/swift/commit/fa89064933fefa33702520b40734c11f08b2c56915:07
bill_azthis adds a check that device directory exists -15:08
bill_azwhere as previously if device directory did not exist it would be created15:08
bill_azFor our deployment on clustered filesystem backend, we did not create the "virtual devices", and would like object server create these on first access15:09
bill_azIs this the intended behavior?15:09
bill_aznotmyname: line 646-654 in the commit reference15:11
notmynamebill_az: in get_hashes?15:13
*** annegentle has quit IRC15:13
notmynameI'm just looking for references to mkdirs() in that github diff15:14
bill_azget_dev_path15:14
bill_aznotmyname:  the mount_check logic adds check_dir15:14
bill_aznotmyname: we have in the past set mount_check=False, and directories would be created;15:15
bill_azbut now the check_dir will fail because device directory is not created initially15:16
bill_azif the first test (line 647) were based on sef.mount_test rather than mount_test that is passed to the function, we would be ok,15:19
swifterdarrellbill_az: if the device dirs are mount points (like most swift deployments), it can be pretty bad to let them get auto-vivified and start jamming data into them when the data disk is accidentally not mounted; I'd bet preventing that was the reason for the change15:21
swifterdarrellbill_az: I think the right thing to do is to change to ensure those dirs exist in your deployment; you must have referenced them in the ring, right?  So they must be known15:21
bill_aznotmyname:  yep - we can do that, I wanted to first understand the intent of the change.  Got it now - thanks!15:22
notmynameswifterdarrell: thanks15:22
swifterdarrellbill_az: no prob :)15:23
*** imkarrer_ has quit IRC15:24
bill_azswifterdarrell:  I think the issue still exists for account & container data, though it's a lot smaller problem there15:25
*** minwoob has joined #openstack-swift15:32
*** annegentle has joined #openstack-swift15:33
*** silor has joined #openstack-swift15:34
*** zaitcev has joined #openstack-swift15:37
*** ChanServ sets mode: +v zaitcev15:37
notmynameclayg: FWIW, with that patch you put a -2 on, probe tests pass. hmm...but I don't have different replication IPs, so it might be passing by accident15:38
*** annegentle has quit IRC15:39
*** annegentle has joined #openstack-swift15:40
*** gyee has joined #openstack-swift15:44
*** zhill has joined #openstack-swift15:46
acolesnotmyname: pardon me eavesdropping..., i think clayg is right (he always is!) GET is not decorated to be a replication method so an object server configured to be a replication server should not allow to GETs15:48
notmynameacoles: right. so therefore that actually will fail in real clusters but work in my saio where it's all kindof fakey15:49
notmynamealso, it means that (1) it shoudl stay as the main IP for now and (2) later we should actually change it so that the background traffic stays on the "replication" network15:50
acolesnotmyname: yes, i'm not sure where, or if at all, probe tests use separate replication servers15:50
notmynamedo you agree?15:50
acolesyes, i think i agree15:51
notmynamewe should probably update the saio to use more than one network and some separate replication-only storage servers15:52
notmynameok, but the point is that for today, that patch should NOT be in the RC215:52
acolesagree15:53
*** patchbot has quit IRC15:55
*** patchbot has joined #openstack-swift15:57
claygacoles: if I was *always* right I would have seen that peluse had done it right the first time15:59
acolesheh16:00
claygswifterdarrell was all like "and they all use replication_ip - *right*" - and I was like "of course!"  /me goes to check16:00
claygnotmyname: I was going to try to add some second replication servers to my saio today on a different port - tought it would be easier than setting up a seperate network16:01
notmynamecool16:01
swifterdarrellheh16:01
claygnotmyname: i believe that would have caused probetests to fail16:01
notmynameclayg: you're just giving me less and less reasons to not use vSAIO16:01
notmynameanyone know about http://www.dotscale.io? looks interesting16:03
*** proteusguy has quit IRC16:03
* notmyname wonders if I could convince people to let me go and then do field trips to visit acoles and cschwede16:03
notmynameclayg: acoles: also, I guess we can't call it a "replication network" any more16:07
acolesnotmyname: we may need a whole session on 'naming' in vancouver ;)16:08
notmynameok, looks like our RC2 patches are all in the gate and moving forward. we should have the tag soon16:08
notmynameacoles: definitely a fishbowl session. more people to contribute naming ideas will make it easier ;-)16:09
cschwedenotmyname: field trip? sounds awesome! :)16:09
* cschwede orders sunny weather for June in Hamburg16:09
acolesnotmyname: well if you go to paris i think *i* might need to make the trip to meet you16:10
notmynamecschwede: or we could all meet in paris for that conference16:10
acoles^^ idea there16:10
*** jistr has quit IRC16:12
notmynameif I understand the gate issues from yesterday, the capping of requirements on stable/* versions caused the problem. a dependency pulled in it's own dependencies (with different versions) and that's what conflicted.16:13
notmynameeg foo-server pulls A<=v1 and B, but B also pulls in B>v116:14
notmynamesomething like that16:14
*** Guest___ has joined #openstack-swift16:15
notmynameand recently all of the stable releases have had their versions capped. so if we release kilo with Foo.dependency >= v1.0.1, it will be capped to also have <v2.0.016:16
notmyname(which I find slightly ironic that openstack, which doesn't use semver for releases, is trusting that all the dependencies do follow semver properly)16:16
*** Guest___ has quit IRC16:23
*** Guest___ has joined #openstack-swift16:23
*** haomaiwang has quit IRC16:28
*** Guest___ has quit IRC16:28
*** haomaiwang has joined #openstack-swift16:28
*** thumpba has joined #openstack-swift17:01
*** thumpba_ has joined #openstack-swift17:02
*** Vinsh_ has quit IRC17:04
*** thumpba has quit IRC17:05
*** peluse has quit IRC17:07
*** annegentle has quit IRC17:13
*** mahatic has quit IRC17:15
*** jordanP has quit IRC17:15
hurricanerixmorning17:20
clayghurricanerix: morning!17:22
clayghump day!17:22
claygwe might even have a swift meeting later17:23
clayg... wonder what we'll talk about17:23
hurricanerixThey are opening an in-n-out across the street from us tomorrow.  I expect to be wfh the rest of the week... =)17:23
clayghurricanerix: oh goodness - people go nuts for the in-and-out's17:25
hurricanerixclayg: yeah, i mean, it's ok, but i think when they opened the one in Austin, they had like a 45 min wait at the drive through and it backed up traffic on the highway.17:26
hurricanerixor maybe that was Dallas or something.  It was somewhere in Texas.17:26
claygnotmyname: we go to the one down 19th from us sometimes (on the way to target)  - always busy17:26
clayghurricanerix: yeah that sounds about right17:27
hurricanerixclayg: I think the only thing I don't like is the lack of bacon.17:27
claygyou know i never noticed that - but I now have a big issue with in-and-out17:27
claygit's basically not 'merican to offer me the option of adding bacon to my double cheeseburger17:28
hurricanerixguess it's byob17:28
clayglol17:28
claygnotmyname: torgomatic: acoles: so the one part of that ill fated replication_ip change I liked was the fix in FakeRing17:28
hurricanerixV2!tnD%l6cEswaj%v0wecJiO*XaV@b1cT2Hk3uLF17:29
hurricanerixwhoops that was the wrong window17:29
claygnotmyname: torgomatic: acoles: I'm also not 100% sure that at somepoint we may want to move the fragment rebuilding to the replication network17:29
claygnot sure if that means we decorate GET @replication - or turn off the repliation-server option or ... something else?17:30
clayger.... consistency network?17:30
claygick17:30
acolesfixer-upper-network ;)17:31
claygeven-more-not-for-customers-network17:31
acolesclayg: so gerrit didn't announce this here https://review.openstack.org/#/c/176403/ WIP Revert to another handoff when primary is unavailable17:32
acolesclayg: i ripped off your probe test and started playing with ssync changes17:32
acolesclayg: just first baby steps though17:32
-openstackstatus- NOTICE: gerrit is restarting to clear hung stream-events tasks. any review events between 16:48 and 17:32 utc will need to be rechecked or have their approval votes reapplied to trigger testing in zuul17:33
claygok, I think I finally only now understand the "on the next pass" part17:34
claygacoles: i'm sorta worried that on the 409 the sender still wants to send the object and the reciever may not be prepared to drain the object body?17:34
*** zhill_ has joined #openstack-swift17:35
acolesyeah, more tests would be good and thats a good example ^^17:36
*** gyee is now known as chinese_gyee17:37
*** chinese_gyee is now known as gyee17:38
acolesclayg: i also managed to rebase my ssync+POST patch which *may* be a basis for the rx sending back hints during missing_checks, but I need to add some support to ECDiskFileManager still, so thats WIP17:38
claygacoles: was your update to patch 175076 just a rebase?  oh i see patch 176403 was dependent17:38
patchbotclayg: https://review.openstack.org/#/c/175076/17:38
*** mahatic has joined #openstack-swift17:38
acolesyes, my +2 survived so only rebase17:39
claygacoles: awesome - you know crunch time is over - you can stop showing us up now if you want to17:39
claygacoles: did you see what torgomatic is working on?  deepcopy rings and extracing object metadata from tarball uploads?17:40
claygthese are things you piddle with post EC17:40
clayg:)17:40
acolesclayg: lol. saw them fly by but not looked close yet.17:41
claygheh17:41
acolesaway for dinner, back for meeting17:41
acolesclayg: you see , i *am* taking it easier ^^17:41
claygacoles: even notmyname is slipping - we've got "merged" changes on the priority reviews dashboard17:41
claygheh17:41
clayggood17:42
*** david-lyle has quit IRC17:42
openstackgerritMerged openstack/swift: Bump PyECLib version from 1.0.3 to 1.0.7  https://review.openstack.org/17552517:50
notmynameclayg: I'm just trying to give you an excuse to not put in so many late hours :-)17:51
notmyname(also, they merged while I was on my bike) ;-)17:51
claygnotmyname: uhhhhhh huhhhhhh17:52
notmynamelooks like we're about ~1hour from having RC2, if the zuul status is to be believed17:55
*** annegentle has joined #openstack-swift17:58
*** annegentle has quit IRC18:01
*** geaaru has quit IRC18:01
*** annegentle has joined #openstack-swift18:02
*** aix has quit IRC18:21
*** Vinsh has joined #openstack-swift18:22
*** Guest_ has joined #openstack-swift18:32
*** zhill_ has quit IRC18:40
torgomaticclayg: exactly. working on little self-contained features is relaxing as heck compared to EC :)18:41
claygtorgomatic: :D18:43
notmynameclayg: FYI, I think keystone changed the default token expiry time to 1 hour18:44
openstackgerritMerged openstack/swift: Use reconstruct insetad of decode/encode  https://review.openstack.org/17574118:45
openstackgerritMerged openstack/swift: Release Import of Translations from Transifex  https://review.openstack.org/17532418:45
notmynamecool. I think we have the RC2 patches landed now18:46
claygwhoot!18:47
notmynameclayg: SHA f8dee761bd36f857aa1288c27e095907032fad68 look good for RC2?18:48
notmynameif so, then I'll pass it on to ttx18:48
notmynametorgomatic: ^18:48
notmynameanyone ^18:48
torgomaticnotmyname: confirmed; that looks like a SHA18:48
torgomatic;)18:48
notmynametorgomatic: you're learning too much from oslo.uuid.is_uud() methods18:49
claygbill_az: swifterdarrell: I have an outstanding change that fixes the mount check to include a dir check for account and container - somewhere - I think18:49
torgomaticnotmyname: also, http://www.bzarg.com/p/how-to-pronounce-hexadecimal/18:49
claygbill_az: swifterdarrell: I do think we *justified* the change because of how terrible things behave with mount_check = false - but *honestly* the reason was to support probetests making disks 507 when mount_check = False on swift-all-in-ones18:50
*** cutforth has joined #openstack-swift18:50
claygbill_az: swifterdarrell: internally swift tests picked up some churn in the change but I think everyone assumed real systems always ruan mount_check = True and the False option was only for development environments18:51
claygbill_az: swifterdarrell: so... good to know!18:51
*** ho has joined #openstack-swift18:52
hogood morning!18:53
notmynametorgomatic: wonderful18:54
notmynamemeetign in #openstack-meeting in 3 minutes18:57
*** kota_ has joined #openstack-swift18:58
kota_morning18:58
clayghttps://wiki.openstack.org/wiki/Meetings/Swift18:59
claygswift-bench!?18:59
mattoliveraumorning18:59
claygthis is going to be crazy - i better plug into a power source and get moar coffee18:59
notmynameclayg: yeah, rememeber that one?18:59
claygnotmyname: of course, it comes installed with a default bench.conf on a vagrant-swift-all-in-one19:00
notmynamelol19:00
notmynamemeeting starting19:01
cschwedewow, good participation in the meeting!19:01
*** Guest_ has quit IRC19:03
*** ryshah has joined #openstack-swift19:03
*** Guest_ has joined #openstack-swift19:06
*** ryshah has quit IRC19:06
*** ryshah has joined #openstack-swift19:07
*** dmorita has joined #openstack-swift19:08
*** annegentle has quit IRC19:14
*** Guest_ has quit IRC19:17
*** annegentle has joined #openstack-swift19:18
claygi'm not really sure I want to make seperate replication servers the default in vagrant-swift-all-in-one - but making it optional adds it's own complexity19:18
*** dencaval has quit IRC19:21
acolescschwede: hi! did you publish your durability calculations or calculator tool anywhere?19:21
*** dencaval has joined #openstack-swift19:22
cschwedeacoles: Hi Alistair! Indeed: http://enovance.github.io/swift-durability-calculator/19:22
acolescschwede: wow! thank you19:23
*** Guest_ has joined #openstack-swift19:24
cschwedeacoles: you’re welcome! let me know if you have any questions19:24
*** sandywalsh has quit IRC19:30
*** sandywalsh has joined #openstack-swift19:31
*** ryshah has quit IRC19:35
*** Guest_ has quit IRC19:35
*** Guest_ has joined #openstack-swift19:39
*** shakamunyi has joined #openstack-swift19:40
*** Fin1te has joined #openstack-swift19:42
*** proteusguy has joined #openstack-swift19:50
*** Guest_ has quit IRC19:51
*** annegentle has quit IRC19:52
*** dmorita has quit IRC19:54
*** openstackgerrit has quit IRC19:54
*** openstackgerrit has joined #openstack-swift19:55
*** cutforth has quit IRC19:55
mattoliveraucools, thatnks all, I'm going back to bed for a while.19:55
claygthat was fun!19:55
claygmattoliverau: g'night19:55
kota_me, too, good night.19:56
acolesmattoliverau: me too19:56
claygkota_: mattoliverau: acoles: thanks - sleep tight!19:56
*** kota_ has quit IRC19:56
*** mahatic has quit IRC19:57
cschwedealso leaving - have a good night / day everyone! bye19:57
*** acoles is now known as acoles_away19:57
jrichlicschwede: you too!20:02
*** dencaval has quit IRC20:05
*** Fin1te has quit IRC20:07
*** annegentle has joined #openstack-swift20:14
*** silor has quit IRC20:16
*** annegentle has quit IRC20:28
*** annegentle has joined #openstack-swift20:29
*** sandywalsh has quit IRC20:33
*** sandywalsh has joined #openstack-swift20:34
*** Gu_______ has joined #openstack-swift20:34
*** Gu_______ has quit IRC20:55
*** Fin1te has joined #openstack-swift21:06
claygman seperate replication servers is getting sorta hairy - i mean it'd probably be pretty managable if I didn't make it optional - but you need a fair bit more RAM in the box to turn them on by default and there's a config *explosion*21:08
claygok, it may be some sort of sin against the chef gods - but I'm going to go with a dumber recipe smarter template approach21:14
swifterdarrellclayg: there are only chef devils21:16
zaitcevLike Rachael Ray21:18
*** gyee has quit IRC21:20
claygzaitcev: i didn't know who that was - but after a quick search I've decided that's funny21:24
zaitcevclayg: Only now I realized that it was not a typo for "chief gods" and you meant a deployment tool called "Chef".21:25
zaitcevWe're a Puppet show here.21:26
*** gyee has joined #openstack-swift21:26
*** openstackgerrit has quit IRC21:29
*** openstackgerrit has joined #openstack-swift21:30
*** Fin1te has quit IRC21:31
*** ho has quit IRC21:32
openstackgerritSamuel Merritt proposed openstack/swift: Make RingBuilders deep-copy-able  https://review.openstack.org/17556721:35
*** wbhuber has quit IRC21:41
*** annegentle has quit IRC21:45
bill_azswifterdarrell: clayg: thanks for explanations21:53
swifterdarrellbill_az: yw21:54
swifterdarrellclayg: torgomatic: what are the relative merits of type(self) vs. self.__class__  ?21:56
swifterdarrellclayg: torgomatic: (thinking of the builder __deepcopy__, of course)21:57
*** jrichli has quit IRC22:06
*** esker has quit IRC22:07
mattoliverauMorning22:09
notmynamehello again22:09
*** openstackgerrit has quit IRC22:11
*** openstackgerrit has joined #openstack-swift22:11
claygswifterdarrell: self.__class__ is how you do it if you're *old-skewl*22:11
claygswifterdarrell: that is old style classes won't give you the class back when you type them (I think they're?  like type - type?)22:12
claygswifterdarrell: someone dinged me on it the other day - and somewhere on stack overflow it agreed the canonical way to get the class of an instances is type(thing) - which does read fairly nicely22:13
claygso I'm trying it out!22:13
swifterdarrellclayg: wacky22:16
claygswifterdarrell: ok well - i mis-spoke, type of instance of old-style class is just 'instance' - which I guess is some primative22:18
swifterdarrellclayg: so does that mean self.__class__ works in more cases than type(self)?22:19
claygswifterdarrell: yeah22:19
clayglike I said - *old-skewl*22:19
swifterdarrellclayg: k, we should probably use that, then22:19
claygswifterdarrell: meh, old style classes are balls22:20
claygyou can't even have them in python322:20
swifterdarrellclayg: does self.__class__ still work in python3?22:20
*** erlon has quit IRC22:21
claygswifterdarrell: yeah it appears so22:21
swifterdarrellclayg: (I don't even care *that* much, unlike the location of deep copying, which I think is more important)22:22
*** annegentle has joined #openstack-swift22:22
swifterdarrelltorgomatic: ^^^^^^^^^^^^22:22
claygswifterdarrell: i don't know the relevant stackoverflows with commentary from the likes of Alex Martelli seem to prefer the use of type with new style classes - althrough perhaps mostly for stylistic reasoning22:27
claygswifterdarrell: i'm sure it's not as important as the deepcopy thing - but I honestly don't understand what that memo bit is all about :\22:27
swifterdarrellclayg: it's a mechanism to detect and handle cycles22:28
claygswifterdarrell: this much i gathered from the docs :P22:28
swifterdarrellclayg: oh22:28
swifterdarrellclayg: I mean, maybe we know we don't have cycles, but we should probably still code the __deepcopy__ like it wants and use deepcopy(sub_thing, memo) inside of it?22:29
claygswifterdarrell: calling deepcopy(to_dict, memo) seems pretty sane22:30
claygbut I'd honestly have to setup some sort of scenario with a custom class that needs to implement deepcopy and has the cycle scenario so that I could a) implement it in correctly and undestand the failure then b) implement it correctly and verify the failure mode is averted22:31
*** fbo has quit IRC22:31
claygseems like a bunch of effort just to strip off the logging attribute?22:31
swifterdarrellclayg: sure... I also wasn't sure, but I think you'd ideally want to have an instance of the new thing, put its id(...) into memo, *then* call your deepcopy(self.xyz, memo)22:32
swifterdarrellclayg: but maybe only relevant if a sub-thign could have a reference to the thing being copied (a big cycle)22:32
* swifterdarrell shrugs22:32
claygmy guess is whatever our ring builder code is doing would be happier with deepcopy(builder.to_dict()) than with deepcopy(builder) and this whacked out __deepcopy__ thing?22:32
claygswifterdarrell: do we even *do* deepcopy in to_dict?22:33
swifterdarrellclayg: agreed; I was planning on doing that anyway if this patch doesn't land in time (i.e. remove our call to deepcopy on the instance that has the logger thing)22:33
claygno of course not - that would have been insane - yeah I think as long as to_dict returns only python primatives it's just better22:33
swifterdarrellclayg: we don't currently, it's just shallow assignments of {'replicas': self.replicas, ... }22:34
torgomaticI'm pretty sure the memo dict is just there to stop deepcopy from recursing forever, so the only time it'd really matter is if you had a data structure with two RingBuilders that shared internal arrays22:34
claygyup *shurg*22:34
torgomaticif you deepcopy with the code we have now, the copy will have two RingBuilders that don't share arrays because we don't pass along the memoizer dict22:34
swifterdarrelltorgomatic: ya, i'm just saying that it's slightly better (less confusing to a new reader, if nothing else) to do the plumbing like the docs say you should22:35
torgomaticswifterdarrell: sure22:35
torgomaticone sec22:35
torgomaticfix made, running tests now22:35
swifterdarrelltorgomatic: ya, i don't think it's a correctness issue at all22:35
swifterdarrelltorgomatic: clayg: and I can totally live w/o pushing deepcopy crap into to_dict()22:36
torgomaticswifterdarrell: sounds good to me22:36
torgomaticI just passed the memo dict to deepcopy() like the docs say22:36
torgomaticand that way we don't need to copy all this stuff just to serialize it to disk22:37
torgomaticwhich is nice22:37
*** fbo has joined #openstack-swift22:37
claygfor sure +1 there22:37
openstackgerritSamuel Merritt proposed openstack/swift: Make RingBuilders deep-copy-able  https://review.openstack.org/17556722:39
torgomaticswifterdarrell: clayg: there you go ^^22:39
claygswifterdarrell: torgomatic: how do you know you have the placement of memo update in the right place?22:45
claygswifterdarrell: torgomatic: if I have a list of ring builders and I deepcopy it - will I get a fresh copy of each builder even if the same builder appears in the original list twice?!22:45
*** annegentle has quit IRC22:45
claygthese are things I start to think about as soon as you start poking at doing it "right"22:46
swifterdarrellclayg: torgomatic: I think for cycle detection you sort of want   new_thing = some_class(); mem[id(old_thing)] = new_thing; <deepcopy-old_thing-into-new_thing>22:46
*** shakamunyi has quit IRC22:46
claygswifterdarrell: you stepped in it now bro - better go ahead and shoot torgomatic a diff with a test :P22:46
openstackgerritDenis Cavalcante proposed openstack/swift: Add storage policy support for sorting method  https://review.openstack.org/16087722:47
swifterdarrellclayg: ...wondered what that smell was22:47
openstackgerritDenis Cavalcante proposed openstack/swift: Add storage policy support for sorting method  https://review.openstack.org/16087722:59
*** jd__ has quit IRC23:08
openstackgerritDenis Cavalcante proposed openstack/swift: Add storage policy support for sorting method  https://review.openstack.org/16087723:08
*** jd__ has joined #openstack-swift23:08
*** david-lyle has joined #openstack-swift23:24
*** petertr7 has quit IRC23:31
*** minwoob has quit IRC23:58
*** thumpba_ has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!