*** darrenc is now known as darrenc_afk | 00:26 | |
*** jamielennox is now known as jamielennox|away | 00:26 | |
*** DericHorn-HP has joined #openstack-swift | 00:28 | |
*** jamielennox|away is now known as jamielennox | 00:30 | |
*** bill_az has quit IRC | 00:36 | |
*** DericHorn-HP has quit IRC | 00:40 | |
*** dmorita has joined #openstack-swift | 00:47 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/swift: Updated from global requirements https://review.openstack.org/88736 | 00:48 |
---|---|---|
*** darrenc_afk is now known as darrenc | 00:58 | |
*** blmartin has joined #openstack-swift | 01:05 | |
blmartin | Hello all | 01:10 |
*** kota_ has joined #openstack-swift | 01:13 | |
*** ChanServ sets mode: +v kota_ | 01:13 | |
kota_ | good morning, Monday | 01:20 |
openstackgerrit | Matthew Oliver proposed openstack/swift: Make ssync_sender a better HTTP client https://review.openstack.org/195458 | 01:39 |
*** jasondotstar has joined #openstack-swift | 01:40 | |
mattoliverau | blmartin: greetings! | 01:42 |
mattoliverau | kota_: morning | 01:42 |
*** asettle is now known as asettle-afk | 01:46 | |
*** kota_ has quit IRC | 02:04 | |
blmartin | mattoliverau: Good day! | 02:07 |
blmartin | I'm playing with git right now. If I can get it to behave, I will have a bugfix for you | 02:09 |
*** nadeem has joined #openstack-swift | 02:14 | |
mattoliverau | \o/ | 02:17 |
*** nexusz99 has joined #openstack-swift | 02:42 | |
blmartin | Alright its up. It was almost as much work getting the fix in the right branch :\ | 02:49 |
mattoliverau | lol | 02:54 |
*** haomaiwang has joined #openstack-swift | 02:59 | |
*** nadeem has quit IRC | 03:05 | |
*** pksingh has joined #openstack-swift | 03:05 | |
blmartin | I updated the code for popping_iter, I don't know why I took the scenic route on iterating. | 03:06 |
*** asettle-afk is now known as asettle | 03:07 | |
blmartin | are you using build_full_shard_trie in the backend.py file? I don't see it being called and it looks build_shard_trie replaces it (or could). | 03:10 |
*** haomaiwang has quit IRC | 03:19 | |
*** haomaiwang has joined #openstack-swift | 03:19 | |
*** asettle has quit IRC | 03:29 | |
*** jasondotstar has quit IRC | 03:32 | |
*** jasondotstar has joined #openstack-swift | 03:33 | |
*** haomaiwang has quit IRC | 03:34 | |
*** jrichli has quit IRC | 03:36 | |
*** haomaiwang has joined #openstack-swift | 03:37 | |
*** haomaiwang has quit IRC | 04:13 | |
mattoliverau | blmartin: sorry was at lunch. No not using that anymore.. that can be removed. | 04:22 |
mattoliverau | that was to test on larger containers when testing algorithms. cause I was lazy.. it's done a bit at a time (CONTAINER_LISTING_LIMIT) | 04:23 |
*** blmartin has quit IRC | 04:24 | |
*** kota_ has joined #openstack-swift | 04:29 | |
*** ChanServ sets mode: +v kota_ | 04:29 | |
*** DericHorn-HP has joined #openstack-swift | 04:30 | |
*** vinsh has quit IRC | 04:30 | |
*** DericHorn-HP has quit IRC | 04:41 | |
*** DericHorn-HP has joined #openstack-swift | 05:02 | |
*** DericHorn-HP has quit IRC | 05:06 | |
*** vinsh has joined #openstack-swift | 05:07 | |
*** jasondotstar has quit IRC | 05:53 | |
*** DericHorn-HP has joined #openstack-swift | 06:01 | |
*** DericHorn-HP has quit IRC | 06:05 | |
openstackgerrit | ZhiQiang Fan proposed openstack/swift: fix api overview document https://review.openstack.org/196545 | 06:07 |
cschwede | Good Morning! | 06:11 |
kota_ | cschwede: good morning :) | 06:12 |
* cschwede is training for Texas this week. Temperatures are raising, forecasted upper nineties at the end of the week \o/ | 06:19 | |
mattoliverau | cschwede: morning. Lol nice work on the training! | 06:44 |
*** haomaiwang has joined #openstack-swift | 06:46 | |
*** breitz1 has joined #openstack-swift | 07:08 | |
*** breitz has quit IRC | 07:08 | |
*** rledisez has joined #openstack-swift | 07:09 | |
*** kota_ has quit IRC | 07:14 | |
*** knl has joined #openstack-swift | 07:14 | |
*** madhuri_ has joined #openstack-swift | 07:23 | |
*** ho has joined #openstack-swift | 07:25 | |
*** acoles_away is now known as acoles | 07:26 | |
acoles | good morning! | 07:27 |
acoles | cschwede: going to be warm in UK too this week | 07:27 |
ho | acoles: good morning! | 07:31 |
*** pksingh has quit IRC | 07:32 | |
*** jistr has joined #openstack-swift | 07:32 | |
mattoliverau | acoles: morning! | 07:33 |
acoles | ho mattoliverau hi! | 07:40 |
*** joeljwright has joined #openstack-swift | 07:41 | |
*** ChanServ sets mode: +v joeljwright | 07:41 | |
*** pksingh has joined #openstack-swift | 07:44 | |
*** dmorita has quit IRC | 07:48 | |
*** dmorita has joined #openstack-swift | 07:53 | |
*** joeljwright1 has joined #openstack-swift | 07:55 | |
*** joeljwright1 has quit IRC | 07:55 | |
*** joeljwright1 has joined #openstack-swift | 07:55 | |
*** joeljwright1 has quit IRC | 07:56 | |
*** joeljwright1 has joined #openstack-swift | 07:56 | |
*** joeljwright has quit IRC | 07:57 | |
*** joeljwright1 is now known as joeljwright | 08:00 | |
*** ChanServ sets mode: +v joeljwright | 08:00 | |
*** jordanP has joined #openstack-swift | 08:20 | |
*** CR7 has joined #openstack-swift | 09:02 | |
*** knl has quit IRC | 09:03 | |
*** tab___ has joined #openstack-swift | 09:08 | |
*** dmorita has quit IRC | 09:25 | |
*** breitz1 has quit IRC | 09:28 | |
*** breitz has joined #openstack-swift | 09:30 | |
*** CR7 has quit IRC | 09:31 | |
*** SkyRocknRoll has joined #openstack-swift | 09:34 | |
*** nexusz99_ has joined #openstack-swift | 09:41 | |
*** ho has quit IRC | 09:42 | |
*** nexusz99 has quit IRC | 09:43 | |
*** gar1 has quit IRC | 09:49 | |
*** aix has joined #openstack-swift | 09:53 | |
*** openstackgerrit has quit IRC | 09:53 | |
*** openstackgerrit has joined #openstack-swift | 09:53 | |
*** nexusz99 has joined #openstack-swift | 09:53 | |
*** nexusz99 has quit IRC | 09:54 | |
*** nexusz99_ has quit IRC | 09:57 | |
*** uschreiber_ has joined #openstack-swift | 10:03 | |
*** uschreiber_ has quit IRC | 10:05 | |
*** haomaiwang has quit IRC | 10:26 | |
*** pksingh has quit IRC | 10:34 | |
*** gar has joined #openstack-swift | 10:46 | |
*** gar has joined #openstack-swift | 10:46 | |
*** jistr_ has joined #openstack-swift | 10:49 | |
*** jistr has quit IRC | 10:51 | |
*** jistr_ has quit IRC | 10:54 | |
*** jistr_ has joined #openstack-swift | 11:06 | |
*** knl has joined #openstack-swift | 11:18 | |
*** a1|away has joined #openstack-swift | 11:55 | |
*** ohno13 has joined #openstack-swift | 11:59 | |
*** AbyssOne has joined #openstack-swift | 12:11 | |
*** slo_ has quit IRC | 12:11 | |
*** kei_yama has quit IRC | 12:19 | |
*** knl has quit IRC | 12:27 | |
*** km has quit IRC | 12:28 | |
*** knl has joined #openstack-swift | 12:31 | |
*** NM has joined #openstack-swift | 12:40 | |
*** mtreinish has quit IRC | 12:40 | |
*** mtreinish has joined #openstack-swift | 12:40 | |
*** knl has quit IRC | 12:41 | |
*** bill_az has joined #openstack-swift | 12:45 | |
*** cazino has joined #openstack-swift | 12:50 | |
*** DericHorn-HP has joined #openstack-swift | 12:59 | |
*** fifieldt has joined #openstack-swift | 13:06 | |
*** knl has joined #openstack-swift | 13:14 | |
*** rvasilets_ has joined #openstack-swift | 13:18 | |
*** petertr7_away is now known as petertr7 | 13:20 | |
*** jrichli has joined #openstack-swift | 13:20 | |
*** vinsh_ has joined #openstack-swift | 13:25 | |
*** vinsh has quit IRC | 13:28 | |
*** nllrte has joined #openstack-swift | 13:33 | |
*** vinsh_ has quit IRC | 13:35 | |
*** vinsh has joined #openstack-swift | 13:35 | |
tdasilva | good morning! | 13:38 |
NM | Godd :) | 13:39 |
*** CaioBrentano has joined #openstack-swift | 13:46 | |
*** geaaru has joined #openstack-swift | 13:48 | |
notmyname | good morning | 13:51 |
* notmyname is sitting in DFW waiting for a flight back to SFO | 13:51 | |
*** acampbell has joined #openstack-swift | 13:53 | |
rvasilets_ | good morning) | 13:56 |
*** DericHorn-HP has quit IRC | 13:59 | |
*** knl_ has joined #openstack-swift | 14:00 | |
*** jlhinson has joined #openstack-swift | 14:01 | |
*** DericHorn-HP has joined #openstack-swift | 14:02 | |
*** knl has quit IRC | 14:03 | |
*** vinsh_ has joined #openstack-swift | 14:05 | |
*** blmartin has joined #openstack-swift | 14:08 | |
*** vinsh has quit IRC | 14:08 | |
*** vinsh has joined #openstack-swift | 14:14 | |
*** vinsh_ has quit IRC | 14:17 | |
*** annegentle has joined #openstack-swift | 14:37 | |
*** annegentle has quit IRC | 14:38 | |
*** mwheckmann has joined #openstack-swift | 14:39 | |
*** annegentle has joined #openstack-swift | 14:39 | |
*** DericHorn-HP has quit IRC | 14:41 | |
*** knl_ has quit IRC | 14:43 | |
*** knl has joined #openstack-swift | 14:44 | |
*** petertr7 is now known as petertr7_away | 14:47 | |
*** petertr7_away is now known as petertr7 | 14:48 | |
*** mwheckmann has quit IRC | 14:48 | |
*** mwheckmann has joined #openstack-swift | 14:53 | |
*** fthiagogv has joined #openstack-swift | 14:58 | |
*** fthiagogv_ has joined #openstack-swift | 14:58 | |
*** acoles is now known as acoles_away | 15:02 | |
*** minwoob has joined #openstack-swift | 15:13 | |
*** DericHorn-HP has joined #openstack-swift | 15:25 | |
*** nadeem has joined #openstack-swift | 15:26 | |
*** david-ly_ is now known as david-lyle | 15:27 | |
*** nadeem has quit IRC | 15:28 | |
notmyname | boarding time... | 15:30 |
*** annegentle has quit IRC | 15:48 | |
*** annegentle has joined #openstack-swift | 15:49 | |
*** SkyRocknRoll has quit IRC | 15:51 | |
*** lcurtis has joined #openstack-swift | 15:55 | |
*** pgbridge has joined #openstack-swift | 15:56 | |
*** Fin1te has joined #openstack-swift | 15:56 | |
*** lcurtis has quit IRC | 15:57 | |
*** lcurtis has joined #openstack-swift | 15:57 | |
*** jistr_ has quit IRC | 15:59 | |
*** gyee has joined #openstack-swift | 16:00 | |
*** janonymous_ has joined #openstack-swift | 16:02 | |
*** theoharr has quit IRC | 16:04 | |
*** petertr7 is now known as petertr7_away | 16:05 | |
*** SkyRocknRoll has joined #openstack-swift | 16:05 | |
*** annegentle has quit IRC | 16:07 | |
openstackgerrit | janonymous proposed openstack/swift: Adding bandit for security static analysis testing in swift https://review.openstack.org/196395 | 16:09 |
*** petertr7_away is now known as petertr7 | 16:13 | |
*** DericHorn-HP has quit IRC | 16:14 | |
*** DericHorn-HP has joined #openstack-swift | 16:17 | |
*** theoharr has joined #openstack-swift | 16:19 | |
*** zaitcev has joined #openstack-swift | 16:21 | |
*** ChanServ sets mode: +v zaitcev | 16:21 | |
*** jordanP has quit IRC | 16:22 | |
*** theoharr has quit IRC | 16:29 | |
*** nadeem has joined #openstack-swift | 16:31 | |
*** nadeem has quit IRC | 16:31 | |
*** nadeem has joined #openstack-swift | 16:32 | |
*** rledisez has quit IRC | 16:39 | |
*** petertr7 is now known as petertr7_away | 16:42 | |
*** DericHorn-HP has quit IRC | 16:49 | |
*** Fin1te has quit IRC | 16:50 | |
*** ohno13 has quit IRC | 16:51 | |
*** knl has quit IRC | 16:52 | |
*** lyrrad has joined #openstack-swift | 16:52 | |
*** DericHorn-HP has joined #openstack-swift | 16:53 | |
*** mutoulbj has joined #openstack-swift | 16:56 | |
*** nllrte has quit IRC | 17:02 | |
*** nllrte has joined #openstack-swift | 17:03 | |
*** donagh has quit IRC | 17:10 | |
*** mfalatic has joined #openstack-swift | 17:10 | |
*** annegentle has joined #openstack-swift | 17:12 | |
*** donagh has joined #openstack-swift | 17:15 | |
clayg | acoles_away: good morning to all | 17:18 |
clayg | notmyname: you're traveling again today? | 17:18 |
*** geaaru has quit IRC | 17:23 | |
*** NM has quit IRC | 17:31 | |
*** dontalton has joined #openstack-swift | 17:32 | |
*** petertr7_away is now known as petertr7 | 17:33 | |
*** zhill has joined #openstack-swift | 17:34 | |
clayg | yes this -> https://github.com/openstack/neutron-specs/blob/master/specs/template.rst | 17:35 |
openstackgerrit | janonymous proposed openstack/swift: Adding bandit for security static analysis testing in swift https://review.openstack.org/196395 | 17:36 |
clayg | mattoliverau: i'm excited to see continued work on the slim down the spec process | 17:36 |
*** NM has joined #openstack-swift | 17:38 | |
*** acampbel11 has joined #openstack-swift | 17:41 | |
*** petertr7 is now known as petertr7_away | 17:43 | |
openstackgerrit | Christian Schwede proposed openstack/swift: Add notification middleware https://review.openstack.org/196755 | 17:44 |
clayg | minwoob: yeah we're in a bit of a bookkeepping nightmare here | 17:44 |
clayg | minwoob: lp bug #1452553 is sorta obviously about not rebuilding existing fragments - which is exactly what patch 193279 punts on | 17:45 |
openstack | Launchpad bug 1452553 in OpenStack Object Storage (swift) "don't rebuild existing fragments" [Critical,In progress] https://launchpad.net/bugs/1452553 - Assigned to Minwoo Bae (minwoob) | 17:45 |
patchbot | clayg: https://review.openstack.org/#/c/193279/ | 17:45 |
clayg | patch 193279 does *fix* the duplicate issue (which I don't think has a bug open for it) and is *related* to lp bug #1452553 (in that it includes the cheap work-around to avoid the handoff by doing inefficient work) | 17:46 |
patchbot | clayg: https://review.openstack.org/#/c/193279/ | 17:46 |
*** petertr7_away is now known as petertr7 | 17:47 | |
*** SkyRocknRoll has quit IRC | 17:47 | |
clayg | minwoob: ok ok - since we have lp bug #1469815 now - and it's a little more clear on the plan anyway - I'm going to refine the description for lp bug #1452553 to more closely match what was in the associated patch and now in gerrit as patch #193279 | 17:47 |
openstack | Launchpad bug 1469815 in OpenStack Object Storage (swift) "If the fragment needing to be reconstructed already exists, let the handoff node push it to the primary." [Undecided,In progress] https://launchpad.net/bugs/1469815 - Assigned to Minwoo Bae (minwoob) | 17:47 |
openstack | Launchpad bug 1452553 in OpenStack Object Storage (swift) "don't rebuild existing fragments" [Critical,In progress] https://launchpad.net/bugs/1452553 - Assigned to Minwoo Bae (minwoob) | 17:47 |
*** annegentle has quit IRC | 17:49 | |
*** annegentle has joined #openstack-swift | 17:51 | |
clayg | minwoob: mattoliverau: there you go lp bug #1452553 describes exactly the issue fixed by patch 193279 | 17:52 |
openstack | Launchpad bug 1452553 in OpenStack Object Storage (swift) "Skip over extra fragments that are not useful to reconstruct" [Critical,In progress] https://launchpad.net/bugs/1452553 - Assigned to Minwoo Bae (minwoob) | 17:52 |
patchbot | clayg: https://review.openstack.org/#/c/193279/ | 17:52 |
minwoob | clayg: Thanks. I'll update you with status on it in a bit. | 18:02 |
*** joeljwright has quit IRC | 18:16 | |
openstackgerrit | Greg Lange proposed openstack/swift: go: check err on call to get free space on object puts https://review.openstack.org/196770 | 18:16 |
*** joeljwright has joined #openstack-swift | 18:17 | |
*** ChanServ sets mode: +v joeljwright | 18:17 | |
*** mutoulbj has quit IRC | 18:24 | |
openstackgerrit | Greg Lange proposed openstack/swift: go: check err on call to get free space on object sync https://review.openstack.org/196782 | 18:28 |
*** openstackgerrit has quit IRC | 18:30 | |
*** openstackgerrit has joined #openstack-swift | 18:30 | |
openstackgerrit | Greg Lange proposed openstack/swift: go: check err on call to get free space on object sync https://review.openstack.org/196782 | 18:33 |
*** nllrte has quit IRC | 18:34 | |
*** nllrte has joined #openstack-swift | 18:35 | |
*** geaaru has joined #openstack-swift | 18:36 | |
*** geaaru has quit IRC | 18:38 | |
*** proteusguy has joined #openstack-swift | 18:38 | |
*** mutoulbj has joined #openstack-swift | 18:43 | |
minwoob | clayg: Is raising a DiskFileError really the best way to handle this? | 18:48 |
*** mutoulbj has quit IRC | 18:48 | |
minwoob | clayg: Technically, it looks like it'll work, but semantically an error might mislead someone who is looking at the code. | 18:49 |
minwoob | clayg: I'll go ahead and post a gerrit review with it, though. | 18:50 |
*** knl has joined #openstack-swift | 18:50 | |
clayg | minwoob: if it works it works - if there's a better way to get out of it that'd be great - if it looks akward you can add a comment | 18:54 |
clayg | I sort of think there's no way to know ahead of time that we can't rebuild it - so once the ssync says "ok I'm ready for object xyz" - and then we go looking to rebuild it and say "oops" - either we need to push out some sort of error ("I'm not going to rebuild this object because xyz") or we need to give ssync the fragment data. | 18:55 |
clayg | we could try to make a third state like "I could do what you asked, but i'm not going to, but it's not an error, i'm doing you a favor *trust me*" | 18:56 |
clayg | but | 18:56 |
clayg | minwoob: I don't think ssync really *cares* - either you're going to give me the data I want to sync - or your not - if not - it's an error as far as I care - i'll skip it and go onto the next one | 18:56 |
clayg | quiet today | 19:03 |
*** zhill has quit IRC | 19:05 | |
* peluse can hear a pin drop | 19:06 | |
*** petertr7 is now known as petertr7_away | 19:09 | |
*** petertr7_away is now known as petertr7 | 19:10 | |
*** knl has quit IRC | 19:11 | |
clayg | maybe.... maybe.... maybe.... i'm a ghost!? | 19:19 |
minwoob | clayg: Thanks for clarifying. | 19:22 |
minwoob | (Just got back from a meeting). | 19:22 |
clayg | np | 19:22 |
clayg | minwoob: I think it's just me and you today | 19:23 |
minwoob | clayg: Lol. I was wondering why it was so quiet this morning. | 19:23 |
clayg | timburke: i can probably manage a swiftclient review today - you got any patches that need a -1? | 19:23 |
timburke | clayg: hey, thanks! how about https://review.openstack.org/#/c/184148/ (decode filesystem paths on PY2) and https://review.openstack.org/#/c/184146/ (properly test raw writes)? | 19:25 |
timburke | clayg: oh, and i'd also love to see https://review.openstack.org/#/c/160283/ land! | 19:39 |
*** annegentle has quit IRC | 19:45 | |
*** annegentle has joined #openstack-swift | 19:50 | |
*** acampbell has quit IRC | 19:54 | |
clayg | timburke: I'm going to pull https://review.openstack.org/#/c/160283 since it already has Joel's +2 on it and is basically waiting on another +2 - THANKS! | 19:55 |
*** annegent_ has joined #openstack-swift | 19:58 | |
*** nllrte has quit IRC | 19:59 | |
openstackgerrit | Victor Stinner proposed openstack/swift: Use six to fix imports on Python 3 https://review.openstack.org/185453 | 20:00 |
openstackgerrit | Victor Stinner proposed openstack/swift: Replace urllib with six.moves.urllib https://review.openstack.org/196835 | 20:00 |
*** annegentle has quit IRC | 20:01 | |
*** gar has quit IRC | 20:03 | |
*** rvasilets_ has quit IRC | 20:04 | |
*** zhill has joined #openstack-swift | 20:11 | |
*** fthiagogv has quit IRC | 20:14 | |
*** fthiagogv_ has quit IRC | 20:14 | |
*** JTen has quit IRC | 20:17 | |
*** JTen has joined #openstack-swift | 20:19 | |
*** JTen has quit IRC | 20:26 | |
*** dontalton has quit IRC | 20:26 | |
*** jlhinson has quit IRC | 20:27 | |
*** jlhinson_ has joined #openstack-swift | 20:27 | |
clayg | timburke: see - i'm always good for a -1 | 20:28 |
*** annegent_ has quit IRC | 20:28 | |
*** annegentle has joined #openstack-swift | 20:29 | |
openstackgerrit | Minwoo Bae proposed openstack/swift: EC: Handoff node to push existing fragment to the correct location. https://review.openstack.org/196848 | 20:32 |
clayg | what's going on with patch 161972 - i feel like jenkins isn't listening to us | 20:37 |
patchbot | clayg: https://review.openstack.org/#/c/161972/ | 20:37 |
clayg | torgomatic: do you know how to work gerrit? | 20:37 |
timburke | clayg: well, since the gate's still broken, even a +2 eventually turns into a -1 :( | 20:37 |
clayg | as;lkdfj;aslkdjf;lkajsdf;lkja;lsdjkf | 20:38 |
clayg | why is the gate still broken!? | 20:38 |
timburke | clayg: the screwy thing is, assuming the devstacklog.txt is telling the truth, the version of pip on the gate should totally be able to handle the environment markers that are causing us grief | 20:40 |
clayg | timburke: i punch it in the FACE | 20:40 |
clayg | timburke: is there a lp bug for the gate issue? | 20:41 |
clayg | most of the time they open them on -infra | 20:41 |
timburke | clayg: not that i'm aware of, but i haven't gone looking | 20:41 |
*** marzif_ has joined #openstack-swift | 20:43 | |
*** petertr7 is now known as petertr7_away | 20:45 | |
*** annegentle has quit IRC | 20:46 | |
*** petertr7_away is now known as petertr7 | 20:47 | |
*** acampbel11 has quit IRC | 20:48 | |
clayg | minwoob: so did you functionally test patch 196848 ? | 20:49 |
patchbot | clayg: https://review.openstack.org/#/c/196848/ | 20:49 |
*** jrichli has quit IRC | 20:50 | |
clayg | minwoob: I sorta feel like if you went just a hair further and did something to make the GreenPile dig into handoffs when it couldn't get enough fragments from the primaries you'd have a good shot at making a go for a probetest | 20:51 |
clayg | maybe it's not worth it - doesn't really address the rebalance situation when only one fragment will move - still a race to revert or rebuilt :\ | 20:51 |
minwoob | clayg: The part you brought up about making GreenPile dig into handoffs when not enough fragments are found -- I'm surprised that isn't implemented yet ... should that be a new bug to tackle? I'd be happy to open one up. | 20:56 |
minwoob | clayg: It's your call :) | 20:56 |
minwoob | clayg: I'll implement. | 20:56 |
minwoob | clayg: It looks to me that it would be a separate issue. | 20:57 |
*** marzif_ has quit IRC | 20:58 | |
clayg | minwoob: well I just don't like how the change adds a DiskFileError and then the verifies that DiskFileError is raised :\ | 20:59 |
clayg | minwoob: it doesn't do anything to test that the *issue* is resolved - theres an integration piece thats missing | 20:59 |
clayg | minwoob: looking for the fragment on handoffs may be a seperate issue | 21:00 |
clayg | i can functionally test it manually - i'm just trying to think if there maybe a place to codify that process | 21:01 |
*** JTen has joined #openstack-swift | 21:05 | |
*** annegentle has joined #openstack-swift | 21:05 | |
*** petertr7 is now known as petertr7_away | 21:09 | |
*** zhill has quit IRC | 21:12 | |
*** blmartin has quit IRC | 21:15 | |
*** benny_ has joined #openstack-swift | 21:18 | |
clayg | joeljwright: !!! | 21:27 |
clayg | i hadn't considered --prefix /path/to/folder/structure/i/want --output-remove-prefix /path/to | 21:28 |
clayg | I think yeah - as long as prefix.startswith(options.output_remove_prefix) we're golden - then if someone wants to add a short hand for --remove-prefix when you want prefix === output_remove_prefix that'd be an add on! | 21:28 |
clayg | joeljwright: as far as the os.path.join - the example paste I had there was taken from the terminal - so I'm not sure how I managed to make it do that - but I got the expected output when made the change | 21:29 |
clayg | joeljwright: ... maybe your point was that the structure on disk was still correct - it was only the text output that left the paths with the double-slashes - which is definately true. | 21:30 |
*** jlhinson_ has quit IRC | 21:42 | |
openstackgerrit | Michael Barton proposed openstack/swift: go: fix unpickling problem https://review.openstack.org/196882 | 21:54 |
joeljwright | clayg: sorry was watching tv | 22:04 |
joeljwright | I knew I could hear pinging from somewhere! | 22:04 |
joeljwright | clayg: I thought they'd fixed the double-slash issue by using .lstrip('/') but there must have been endless ways for that to get back through | 22:05 |
joeljwright | clayg: have to be honest, I hadn't considered the case when the removed prefix was longer than —prefix | 22:05 |
joeljwright | timburke: you around? | 22:09 |
timburke | joeljwright: yeah | 22:09 |
*** wshao has joined #openstack-swift | 22:09 | |
*** mwheckmann has quit IRC | 22:10 | |
joeljwright | timburke: wanted a quick chat about 184148 | 22:10 |
timburke | joeljwright: sure...lemme pull it up... | 22:10 |
mattoliverau | Morning | 22:10 |
timburke | joeljwright: right! decoding filesystem paths | 22:11 |
joeljwright | timburke: basically, what do we do when decode() goes pop | 22:11 |
joeljwright | mattoliverau: greetings from last night | 22:11 |
mattoliverau | Lol, well greetings from tomorrow morning ;p | 22:12 |
joeljwright | :) | 22:12 |
mattoliverau | clayg: I'll go take a look at the updated bug :) | 22:12 |
timburke | joeljwright: i'm having trouble figuring out a way to have such a thing happen...my gut is saying that if your filesystem is so hosed that that decoding fails, we're so far off the rails that very little good will come of trying to recover | 22:13 |
*** joeljwright1 has joined #openstack-swift | 22:14 | |
timburke | joeljwright: i'll look into what python3 does in such a case | 22:14 |
timburke | joeljwright: though i know that it'll blow up badly if you try to pass it a commandline arg that won't decode | 22:15 |
joeljwright1 | timburke: :( | 22:16 |
*** joeljwright has quit IRC | 22:16 | |
*** joeljwright1 has quit IRC | 22:16 | |
*** joeljwright has joined #openstack-swift | 22:17 | |
*** ChanServ sets mode: +v joeljwright | 22:17 | |
joeljwright | timburke: sadly this is something I've had to work around a few times | 22:17 |
timburke | python3 -c 'import sys; print(sys.argv[1])' $(echo -e '\xff') | 22:18 |
timburke | yields | 22:18 |
timburke | UnicodeEncodeError: 'utf-8' codec can't encode character '\udcff' in position 0: surrogates not allowed | 22:18 |
joeljwright | timburke: so we'll get further but still blow up? | 22:18 |
*** NM has quit IRC | 22:18 | |
joeljwright | timburke: or will it just fail an individual upload? | 22:18 |
joeljwright | timburke: my concern was that we were trading one failed object upload for an entire folder failure | 22:20 |
*** annegentle has quit IRC | 22:22 | |
*** annegentle has joined #openstack-swift | 22:23 | |
*** wbhuber has joined #openstack-swift | 22:28 | |
timburke | joeljwright: so actually, that didn't blow up as early as i feared that it would. it'll decode with errors='surrogateescape', then fail to encode. i can certainly make the py2 behavior match py3, but i'm interested in hearing about when you needed to work around this (something involving files with utf-8 encoded names but accessed from Windows, or something?) and what the work-around entailed | 22:28 |
clayg | gosh i haven't even really considered the interaction of the --prefix and --output-remove-prefix options with account level downloads :\ | 22:28 |
joeljwright | timburke: I can't give you too many details because it's from a customer archive | 22:29 |
timburke | joeljwright: sure. but i'd love to make it so your workaround is upstream, or at least simplified :) | 22:29 |
joeljwright | but a redhat system with a GPFS mounted filesystem mounted that has had files on it created by a windows system can cause… fun | 22:29 |
joeljwright | timburke: my workaround isn't generally applicable and is a bit horrible (I used url encoding to store/retrieve the original bytes of the filename) | 22:30 |
joeljwright | but I was basically attempting the decode, and working around it in the case of a fail | 22:32 |
timburke | joeljwright: interesting...that's actually what my mac does when i try to, say, mkdir `echo -e '\xff'` | 22:32 |
joeljwright | timburke: right, sorry, but it's after 11:30pm and I need to go | 22:35 |
timburke | joeljwright: no worries. i think i've got something of a plan | 22:35 |
*** annegentle has quit IRC | 22:35 | |
joeljwright | timburke: cool, I look forward to seeing it :) | 22:35 |
*** joeljwright has quit IRC | 22:36 | |
*** wbhuber has quit IRC | 22:37 | |
*** benny_ has quit IRC | 22:49 | |
*** annegentle has joined #openstack-swift | 22:50 | |
openstackgerrit | Clay Gerrard proposed openstack/python-swiftclient: Add ability to download objects to particular folder. https://review.openstack.org/160283 | 23:00 |
*** lcurtis has quit IRC | 23:03 | |
*** km has joined #openstack-swift | 23:04 | |
notmyname | new swift contributor activity graph: http://d.not.mn/contrib_activity.png | 23:08 |
* notmyname isn't really here | 23:08 | |
*** annegentle has quit IRC | 23:13 | |
mattoliverau | Whoa ghost notmyname is back! Either that or another PTL power is the Jedi mind trick ;) | 23:14 |
notmyname | mattoliverau: I just got home today, and I'm still officially off. so I'm doing my best there :-) | 23:14 |
mattoliverau | notmyname: Lol, fair enough, go enjoy your lovely family :) | 23:17 |
*** kei_yama has joined #openstack-swift | 23:23 | |
clayg | notmyname: that's cute | 23:24 |
*** jasondotstar has joined #openstack-swift | 23:31 | |
*** asettle has joined #openstack-swift | 23:32 | |
*** ho has joined #openstack-swift | 23:49 | |
ho | good morning! | 23:55 |
clayg | a'ight - i gotta bounce | 23:59 |
mattoliverau | ho: morning | 23:59 |
mattoliverau | clayg: o/ | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!