Wednesday, 2016-06-29

*** diogogmt has quit IRC00:02
*** diogogmt has joined #openstack-swift00:03
*** diogogmt has quit IRC00:16
*** diogogmt has joined #openstack-swift00:21
*** niknakpaddywak has joined #openstack-swift00:26
claygnotmyname: well crap; or awesome - depending on if you're on timburke's side or torgomatic's00:32
claygi forget who was on what side00:32
zaitcevnotmyname: Not sure when it was, but it goes down at 00:00 UTC for a few minutes every day.00:33
*** tqtran has quit IRC00:34
*** lyrrad has quit IRC00:39
*** Suyash has quit IRC00:41
*** zul has joined #openstack-swift00:45
*** asettle has joined #openstack-swift00:45
notmynameclayg: line 167 in crypto_utils.py (https://review.openstack.org/#/c/328208/11/swift/common/middleware/crypto_utils.py)00:45
patchbotnotmyname: patch 328208 - swift (feature/crypto-review) - Enable object body and metadata encryption00:45
*** asettle has quit IRC00:50
kota_good morning.01:06
mattoliveraukota_: morning01:13
kota_mattolivearu: o/01:14
*** Suyash has joined #openstack-swift01:14
kota_mattoliverau: now I'm tracking last night's talk and etherpad, https://etherpad.openstack.org/p/swift_encryption_meta_headers01:14
*** Jeffrey4l has joined #openstack-swift01:15
mattoliveraukota_: yeah, i just did the same :)01:17
*** mwheckmann has joined #openstack-swift01:17
*** arch-nemesis has quit IRC01:18
*** openstack has joined #openstack-swift01:24
*** ukaynar has joined #openstack-swift01:26
*** raildo is now known as raildo-afk01:27
*** raildo-afk is now known as raildo01:27
*** ouchkernel has joined #openstack-swift01:28
*** tqtran has joined #openstack-swift01:31
*** hosanai has joined #openstack-swift01:32
*** ChanServ sets mode: +v hosanai01:32
*** tqtran has quit IRC01:36
*** ManojK has quit IRC01:43
*** mwheckmann has quit IRC01:54
*** circ-user-iTmQ4 has joined #openstack-swift01:57
*** circ-user-iTmQ4 has left #openstack-swift01:58
*** rminmin has joined #openstack-swift01:59
*** mwheckmann has joined #openstack-swift01:59
*** okdas has quit IRC02:22
*** okdas has joined #openstack-swift02:24
*** okdas has joined #openstack-swift02:24
*** ouchkernel has quit IRC02:24
*** ukaynar has quit IRC02:25
*** ouchkernel has joined #openstack-swift02:31
*** ouchkernel has quit IRC02:36
*** ouchkernel has joined #openstack-swift02:42
*** sheel has joined #openstack-swift02:48
claygbriancline: did you put unicode device names in your ring again?  lp bug #158067802:48
openstackLaunchpad bug 1580678 in OpenStack Object Storage (swift) "UnicodeDecodeError when rebalancing a ring" [Undecided,In progress] https://launchpad.net/bugs/1580678 - Assigned to Christian Schwede (cschwede)02:48
*** ouchkernel has quit IRC02:50
brianclineclayg: lol02:52
brianclinei wish that was why, would be a much quicker fix02:52
*** ouchkernel has joined #openstack-swift02:56
brianclineI'm about to try cschwede's patch 323950 in our real-ish staging env to see how things go02:57
patchbotbriancline: https://review.openstack.org/#/c/323950/ - swift - Refactor locale tests and fix unicode issue02:57
*** gyee has quit IRC03:02
claygbriancline: tests seem reasonable ;)03:06
*** jamielennox is now known as jamielennox|away03:07
*** jamielennox|away is now known as jamielennox03:07
brianclinei certainly can't blame it for failing :P03:12
*** rminmin has quit IRC03:13
*** tqtran has joined #openstack-swift03:32
*** mwheckmann has quit IRC03:33
*** tqtran has quit IRC03:36
*** chsc has joined #openstack-swift03:43
*** chsc has joined #openstack-swift03:43
*** chsc has quit IRC03:53
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380103:59
*** ppai has joined #openstack-swift04:10
*** links has joined #openstack-swift04:22
*** SkyRocknRoll has joined #openstack-swift04:41
brianclinehmm... no go.. and no luck with an en_US.UTF-8 locale either04:46
brianclinemaybe a different bug that just looks the same?04:46
brianclinestill fails even when i make _gettext return the msg that was passed in04:48
briancline*gettext_04:48
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873604:48
*** SkyRocknRoll has quit IRC04:52
*** rcernin has joined #openstack-swift04:53
*** pcaruana has quit IRC04:58
*** ChubYann has quit IRC04:59
*** flwang1 has quit IRC05:00
*** ppai has quit IRC05:04
timburkekota_: mattoliverau: does it make sense? i think i like this idea...05:14
*** zaitcev has quit IRC05:17
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380105:17
*** SkyRocknRoll has joined #openstack-swift05:18
*** baojg has joined #openstack-swift05:29
*** rcernin has quit IRC05:33
mattoliverautimburke: yeah, I like it. I especially like the joining of crypto meta  with the encrypted data so its atomic.05:40
timburkeyeah, that's the big win i saw, too. if we ever try to tackle updateable object metadata, we'll definitely want those combined05:41
timburkethe fact that we can kick the constraints-handling can down the road a ways is just icing :-)05:42
*** psachin has joined #openstack-swift05:45
*** McMurlock1 has joined #openstack-swift05:45
mattoliverautimburke: yeah, our future selves can deal with that latter and potential fallout, in the mean time we are adding a new meta namespace, so lets use it :)05:45
timburkefwiw, clayg seemed to have some good idea about how to deal with it (since we'll need to deal with it for account/container user-meta encryption) -- basically, send down a header with additional prefixes that should be considered when checking user-meta counts05:48
*** McMurlock1 has quit IRC05:49
mattoliverauyeah ok, that way it's the middleware responsiblilty. So long as other middlewares append to the list if they have anything else to add.05:55
mattoliverauwhich sounds like another internal API... we could almost use the env rather then an actual header then, but it's probably same same really.05:56
*** baojg has quit IRC05:58
psachinping clayg, Regarding https://review.openstack.org/#/c/334238/06:02
patchbotpsachin: patch 334238 - swift - Fix swift-get-nodes arg parsing for missing ring06:02
*** baojg has joined #openstack-swift06:02
*** rcernin has joined #openstack-swift06:05
*** ppai has joined #openstack-swift06:05
*** arcimboldo has joined #openstack-swift06:10
*** pcaruana has joined #openstack-swift06:16
*** rminmin has joined #openstack-swift06:18
*** pcaruana is now known as pcaruana|afk|06:19
*** rminmin has quit IRC06:20
*** rfeusi has quit IRC06:42
*** Suyash has quit IRC06:44
*** pcaruana|afk| is now known as pcaruana06:49
*** hseipp has joined #openstack-swift06:52
kota_timburke: I'm now taking a look to patch 335209, it loosk good to me so far. i think the change to B is a good idea for now.06:53
patchbotkota_: https://review.openstack.org/#/c/335209/ - swift (feature/crypto-review) - Switch to transient sysmeta for stashing encrypted...06:53
*** ChanServ sets mode: +v cschwede06:59
*** baojg has quit IRC07:01
*** kei_yama has quit IRC07:04
*** mmcardle has joined #openstack-swift07:04
*** kei_yama has joined #openstack-swift07:04
*** baojg has joined #openstack-swift07:06
*** tesseract- has joined #openstack-swift07:09
*** hseipp has quit IRC07:13
*** klrmn has quit IRC07:15
*** rledisez has joined #openstack-swift07:23
*** geaaru has joined #openstack-swift07:25
*** flwang1 has joined #openstack-swift07:26
*** arcimboldo has quit IRC07:30
*** jhyang has joined #openstack-swift07:30
openstackgerritVictor Stinner proposed openstack/swift: Update dnspython to 1.14  https://review.openstack.org/33534707:31
*** jhyang is now known as derekjhyang07:32
*** hseipp has joined #openstack-swift07:33
*** hseipp has quit IRC07:38
*** hseipp has joined #openstack-swift07:42
*** arcimboldo has joined #openstack-swift07:43
openstackgerritYaoZheng proposed openstack/swift: make print python3 compatible  https://review.openstack.org/33380107:44
*** kei_yama_ has joined #openstack-swift07:45
*** kei_yama has quit IRC07:45
*** arcimboldo has quit IRC07:48
*** kei_yama_ has quit IRC07:56
*** tqtran has joined #openstack-swift08:00
*** mvk has joined #openstack-swift08:02
*** tqtran has quit IRC08:05
*** wanghua has joined #openstack-swift08:29
*** arcimboldo has joined #openstack-swift08:33
openstackgerritBrian Cline proposed openstack/swift: Prevent down nodes failing PUTs on utf8 obj names  https://review.openstack.org/33537308:34
*** baojg has quit IRC08:36
*** flwang1 has quit IRC08:39
*** dmk0202 has joined #openstack-swift08:39
*** baojg has joined #openstack-swift08:39
*** acoles_ is now known as acoles08:43
acolesgood morning08:45
*** asettle has joined #openstack-swift08:46
acolesok looks like we have consensus on patch 335209, so I will be merging that into patch 328208 today, and then bringing the doc up to date with recent changes in header names08:47
patchbotacoles: https://review.openstack.org/#/c/335209/ - swift (feature/crypto-review) - Switch to transient sysmeta for stashing encrypted...08:47
patchbotacoles: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption08:47
*** chlong has quit IRC09:04
*** chlong has joined #openstack-swift09:17
*** flwang1 has joined #openstack-swift09:26
*** baojg has quit IRC09:34
*** mvk has quit IRC09:35
*** mvk has joined #openstack-swift09:36
*** baojg has joined #openstack-swift10:24
*** baojg has quit IRC10:29
*** hosanai has quit IRC10:41
*** sanchitmalhotra has quit IRC11:05
*** sanchitmalhotra has joined #openstack-swift11:05
*** asettle has quit IRC11:26
*** ppai has quit IRC11:28
*** asettle has joined #openstack-swift11:29
*** McMurlock1 has joined #openstack-swift11:40
*** ppai has joined #openstack-swift11:41
*** manous has joined #openstack-swift11:41
*** fifieldt has quit IRC11:47
*** manous has quit IRC11:56
*** fifieldt has joined #openstack-swift12:02
*** tqtran has joined #openstack-swift12:02
*** tqtran has quit IRC12:06
*** manous has joined #openstack-swift12:09
*** ppai has quit IRC12:16
*** diogogmt has quit IRC12:38
*** manous has quit IRC12:43
*** ManojK has joined #openstack-swift12:45
*** urth has quit IRC12:47
*** urth has joined #openstack-swift12:49
*** takashi has joined #openstack-swift12:52
*** diogogmt has joined #openstack-swift12:52
*** ManojK has quit IRC12:55
*** manous has joined #openstack-swift12:57
*** SkyRocknRoll has quit IRC13:07
*** SkyRocknRoll has joined #openstack-swift13:08
*** ManojK has joined #openstack-swift13:10
*** diogogmt has quit IRC13:32
*** links has quit IRC13:36
*** ManojK has quit IRC13:38
*** ManojK has joined #openstack-swift13:40
openstackgerritAlistair Coles proposed openstack/swift: Switch to transient sysmeta for stashing encrypted user metadata  https://review.openstack.org/33520913:40
*** thumpba has joined #openstack-swift13:50
*** thumpba has quit IRC13:51
*** thumpba has joined #openstack-swift13:51
*** arcimboldo has quit IRC13:53
jrichliacoles: i am still nervous about not saving the key id anywhere. it just seems like that means crypto+tiering would then be hopeless.13:55
jrichliacoles: but i want to hear more about your view.  maybe i am just not understanding something13:56
*** ametts has joined #openstack-swift13:56
*** arcimboldo has joined #openstack-swift13:58
acolesjrichli: at this point I am ok with leaving it there, because we can always remove it later if it is deemed unnecessary, and worst case some objects and container dbs have unnecessary metadata13:58
acolesjrichli: but for the record, my doubt is based on it not helping fix conditional requests for relocated objects, and it being a relatively large amount of extra metadata.14:00
acolesjrichli: it is still there on gerrit! I will not act unilaterally on it, so it will stay there unless others vote it down.14:01
jrichliacoles: I do understand we dont have a fix for conditional requests in that regard.  but again, I am holding out hope that we might someday find a solution.  and i think having this piece would increase those chances.14:02
acolesjrichli: having a test with max length object path (or modifying a test) might be sensible, perhaps in test_encrypter_decrypter.py?14:02
*** chsc has joined #openstack-swift14:03
*** chsc has joined #openstack-swift14:03
jrichliacoles: ok, I can take a look14:04
acolesjrichli: thanks. just modifying a path should be sufficient14:05
*** asettle has quit IRC14:05
admin6Hello everyone. I have these error message in my object-server.log started from 3 hours ago. (I’m running swift v2.7, and theses disks are in an erasure coded ring)14:06
admin6Jun 29 12:15:27 STACO2 object-server: Problem writing durable state file /srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable ([Errno 2] No such file or directory: '/srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable'): #012Traceback (most recent call last):#012  File "/usr/lib/python2.7/dist-packages/swift/obj/diskfile.py", line14:07
admin62517, in _finalize_durable#012    with open(durable_file_path, 'w') as _fp:#012IOError: [Errno 2] No such file or directory: '/srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable'14:07
admin6Jun 29 12:15:27 STACO2 object-server: ERROR __call__ error with PUT /s02z2ecd03/237162/AUTH_Joomeo/20160602_O0/53848/11959730/original.JPG : #012Traceback (most recent call last):#012  File "/usr/lib/python2.7/dist-packages/swift/obj/server.py", line 1032, in __call__#012    res = method(req)#012  File "/usr/lib/python2.7/dist-packages/swift/common/utils.py", line 1412, in _timing_stats#012    resp = func(ctrl, *args,14:07
admin6**kwargs)#012  File "/usr/lib/python2.7/dist-packages/swift/obj/server.py", line 764, in PUT#012    writer.commit(request.timestamp)#012  File "/usr/lib/python2.7/dist-packages/swift/obj/diskfile.py", line 2555, in commit#012    self._finalize_durable, durable_file_path)#012  File "/usr/lib/python2.7/dist-packages/swift/common/utils.py", line 3342, in force_run_in_thread#012    return self._run_in_eventlet_tpool(func, *arg14:07
admin6**kwargs)#012  File "/usr/lib/python2.7/dist-packages/swift/common/utils.py", line 3322, in _run_in_eventlet_tpool#012    raise result#012DiskFileError: Problem writing durable state file /srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable ([Errno 2] No such file or directory: '/srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable14:07
admin6It happened around 10 times during the last 3 hours on different ACO servers and different disks. However, the directory and files exists14:08
admin6root@STACO2:~# ls -al /srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690*14:08
admin6-rw------- 1 swift swift 389196 Jun 29 12:15 /srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522#7.data14:08
admin6-rw-r--r-- 1 swift swift      0 Jun 29 12:15 /srv/node/s02z2ecd03/objects-1/237162/8d4/e79a86e8d6263576adb7ec7aa9ff08d4/1466543690.44522.durable14:08
admin6And I have this log from another ACO server at the same time :14:12
admin6Jun 29 12:15:27 STACO4 object-reconstructor: 10.10.2.52:6000/s02z2ecd03/237162 Unexpected response: ":ERROR: 500 'ERROR: With :UPDATES: 1 failures to 14 successes'"14:12
*** _JZ_ has joined #openstack-swift14:17
*** arcimboldo has quit IRC14:17
*** klamath has joined #openstack-swift14:19
*** mwheckmann has joined #openstack-swift14:21
*** takashi has quit IRC14:31
*** arcimboldo has joined #openstack-swift14:34
*** psachin has quit IRC14:40
*** arch-nemesis has joined #openstack-swift14:51
acolesadmin6: could you log that as a bug on launchpad? (or I can if thats not convenient for you). looks like it could be a race when reconstructing an object that another process has removed (presumably because it got moved or deleted). But it doesn't immediately strike me as being the same as https://bugs.launchpad.net/swift/+bug/1554378.14:54
openstackLaunchpad bug 1554378 in OpenStack Object Storage (swift) "EC: Durable frag_set is reclaimable in racing condition" [Undecided,In progress] - Assigned to Kota Tsuyuzaki (tsuyuzaki-kota)14:54
admin6acoles: I’ll do that, yes14:54
acolesadmin6: thank you. sorry, I don't have an immediate answer as to what the cause is.14:55
*** ukaynar has joined #openstack-swift14:55
admin6acoles: no problem.14:56
*** ukaynar has quit IRC15:00
*** ukaynar has joined #openstack-swift15:00
*** thumpba has quit IRC15:04
*** tesseract- has quit IRC15:12
*** cdelatte has joined #openstack-swift15:13
*** rcernin has quit IRC15:14
*** sheel has quit IRC15:15
*** catintheroof has joined #openstack-swift15:16
*** pcaruana has quit IRC15:17
*** chsc has quit IRC15:19
*** klrmn has joined #openstack-swift15:26
*** hseipp has quit IRC15:27
*** asettle has joined #openstack-swift15:29
*** rcernin has joined #openstack-swift15:30
*** pcaruana has joined #openstack-swift15:32
*** ManojK has quit IRC15:38
*** ManojK has joined #openstack-swift15:40
*** thumpba has joined #openstack-swift15:41
*** Suyash has joined #openstack-swift15:42
*** jmccarthy has quit IRC15:44
*** jmccarthy has joined #openstack-swift15:45
*** rledisez has quit IRC15:46
*** ukaynar has quit IRC15:47
*** sheel has joined #openstack-swift15:49
*** ukaynar has joined #openstack-swift15:51
*** baojg has joined #openstack-swift15:53
*** baojg has quit IRC15:54
*** diogogmt has joined #openstack-swift15:55
*** hseipp has joined #openstack-swift15:57
*** ukaynar has quit IRC15:57
*** ukaynar_ has joined #openstack-swift15:57
*** cdelatte has quit IRC15:57
*** ukaynar_ has quit IRC15:58
*** cdelatte has joined #openstack-swift15:59
*** ukaynar has joined #openstack-swift16:03
*** tqtran has joined #openstack-swift16:03
*** lyrrad has joined #openstack-swift16:06
notmynamegood morning16:08
*** tqtran has quit IRC16:08
*** Suyash has quit IRC16:13
*** HenryG has quit IRC16:16
*** HenryG has joined #openstack-swift16:16
*** geaaru has quit IRC16:18
*** raildo is now known as raildo-afk16:23
notmynameemails read, IRC buffers read, calendar checked. time ti dive back into crypto reviews :-)16:24
*** cdelatte has quit IRC16:25
*** klrmn has quit IRC16:26
*** raildo-afk is now known as raildo16:26
*** arcimboldo has quit IRC16:28
*** geaaru has joined #openstack-swift16:30
*** Suyash has joined #openstack-swift16:31
*** dmk0202 has quit IRC16:31
*** asettle has quit IRC16:33
*** pcaruana has quit IRC16:36
notmynameacoles: what's the plan with patch 328207? are we keeping it now that the user metadata is moving to transient sysmeta?16:38
patchbotnotmyname: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking16:38
acolesnotmyname: no its gone, new patch chain coming soon (just working through timburke's doc review)16:38
notmynamegot it. thanks :-)16:39
notmynameacoles: how much have we talked about unifying encrypter and decrypter into a single encryption middleware?16:40
tdasilvawouldn't you need to ask unify the keymaster?16:41
tdasilvas/ask/also16:41
notmynameI know timburke and clayg and I talked some around the office yesterday, but I'm not sure how much our thinking has been passed on to you and jrichli16:41
*** cdelatte has joined #openstack-swift16:42
*** ChubYann has joined #openstack-swift16:42
acolesnotmyname: timburke and I discussed it a little. I think it is very do-able. It is next on my list but I'd prefer to publish the changes I have so far then embark upon that.16:42
notmynameright, that makes sense16:42
acolesnotmyname: IIUC timburke's idea was (for simplicity and avoiding code churn) to simply have a single filter factory that chains the two middlewares16:43
notmynametdasilva: actually, no16:43
notmynameacoles: right! (pretty clever, actually)16:43
acolestdasilva: we could but its probably not such a good/useful change, since we anticpate the keymaster being interchangeable like auth16:43
acolesnotmyname: anything that avoid code churn is clever at this moment ;)16:43
notmynameit turns out that the decrypter doesn't have to be to the left of keymaster. the response for decrypter is decorated with the crypto envvar because the response is built from the request16:44
notmynameacoles: :-)16:44
timburkegood morning16:44
notmynameso we'd end up with one new file that only implements the unified filter_factory, and that entrypoint would be in setup.cfg instead of the 2 existing ones16:44
*** rcernin has quit IRC16:45
acolesnotmyname: I'd value torgomatic's thoughts since it is a significant deviation from the original spec16:45
notmynameyeah, definitely. I'd expect him to be able to comment within the hour16:46
notmyname(torgomatic doesn't really exist before 10am ;-)16:46
acolesnotmyname: not sure we need a new file, just have the encrypter filter_factory return Encrypter(Decrypter(app, conf), conf) and expunge decrypter from the conf samples16:48
acolesnotmyname:  later we could merge the code into one module maybe16:48
notmynametdasilva: the idea is to effectively do a pipeline of "... keymaster decrypter encrypter ...", but instead of letting pastedeploy do the pipeline wrapping, we'd have one filter factory that would do encrypter(decrypter())16:48
*** cdelatte has quit IRC16:48
timburkejrichli: out of curiosity, what are the next steps for encryption after this? account/container user-meta? key rotation?16:49
notmynameacoles: right. wouldn't have to be a new file, but keeping the encrypter and decrypter modules separate seems reasonable IMO.16:49
acolesnotmyname: for now definitely. no churn!16:49
notmynameacoles: and IMO if we have 2 modules, then there isn't an obvious benefit of having the unified filter facotry in either one, so make a new file that would end up being really short16:50
timburkeor stick it in crypto_utils16:50
tdasilvanotmyname, acoles: nice, i'm starting to understand what you mean16:50
acolestimburke: that works too16:51
notmynametdasilva: oh yeah, that's the thing16:52
*** fifieldt has quit IRC16:55
acolesnotmyname: did I see a comment somewhere from you about making a test name shorter? I've lost track of it, or did I dream that?17:01
acolesmaybe I even processed it already and forgot17:02
timburkedef test_magic(self):17:02
acolestimburke: was it you? where is that?17:02
timburkeit was notmyname, in channel a couple days ago17:03
notmynameno, I left a comment. looking for it17:04
acolesam I the only one getting burnt by https://bugs.launchpad.net/swift/+bug/1589994 ?17:04
openstackLaunchpad bug 1589994 in OpenStack Object Storage (swift) "test_container_update_async fails intermittently" [Undecided,New]17:04
timburkenotmyname: no, i'm pretty sure it was just http://eavesdrop.openstack.org/irclogs/%23openstack-swift/%23openstack-swift.2016-06-27.log.html#t2016-06-27T18:44:2117:05
notmynameah ok. it was more a comment on me looking at it and thinking, "Up, those are indeed numbers." rather than a comment on the test name length17:06
notmyname*yup17:08
*** mvk has quit IRC17:08
notmynameit's rather non-obvious (to me) what that test is doing. or why is passes or fails17:09
acolesnotmyname: but renaming it would make it even less obvious. no? but I could add some comments.17:09
acolesthat is, if I even understand what it is doing ;)17:09
notmynameacoles: IMO "test_magic" is just as descriptive as the current name ;-)17:10
acolesnotmyname: oh :(17:10
notmynameno, don't go change the test name. I'm just admitting that right now I have no idea what's going on with it17:10
*** Jeffrey4l has quit IRC17:11
notmynameI'm guessing that given that key and those iv values, AES is producing some known output and that's what's being checked17:12
*** asettle has joined #openstack-swift17:12
*** hseipp has quit IRC17:12
*** klrmn has joined #openstack-swift17:16
*** dmk0202 has joined #openstack-swift17:16
acolesnotmyname: yes, I just added a comment to test17:18
timburkenotmyname: as i recall, we're just checking that the iv offset and position within the initial block are getting calculated correctly17:19
openstackgerritAlistair Coles proposed openstack/swift: Enable object body and metadata encryption  https://review.openstack.org/32820817:19
openstackgerritAlistair Coles proposed openstack/swift: Add encryption overview doc  https://review.openstack.org/32820917:19
notmynametimburke: well, obviously! ;-)17:19
acoles^^ latest updates, changes confined to the crypto and the doc patches, patch 328207 is no longer needed17:21
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking17:21
acolesjrichli: kota_ mattoliverau timburke mahatic_ notmyname ^^17:22
notmynameacoles: that's actually kinda cool that the updates to the whole patch chain are now just 2 patches (and abandoning another)17:22
*** chsc has joined #openstack-swift17:22
acolesnotmyname: yeah, if we abandon one per day we'll be done ahead of schedule :P17:23
notmynamehmm..gerrit topic changed. not really a problem, but it means `git review -d` doesn't reuse the existing local branch17:24
acolesnotmyname: ugh, sorry. that's cos my script numbers the topics and we lost a patch17:26
notmynameno worries :-)17:26
*** manous has quit IRC17:31
*** vinsh_ has joined #openstack-swift17:31
*** vinsh has quit IRC17:34
*** tqtran has joined #openstack-swift17:36
*** gyee has joined #openstack-swift17:37
*** gyee has quit IRC17:37
*** ManojK has quit IRC17:40
*** ManojK has joined #openstack-swift17:40
*** tqtran has quit IRC17:43
*** manous has joined #openstack-swift17:44
*** rcernin has joined #openstack-swift17:44
*** McMurlock1 has quit IRC17:46
notmynameacoles: why'd you add the elif back in on patch 328208? (constraints.py)17:48
patchbotnotmyname: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption17:48
notmynamehttps://review.openstack.org/#/c/328208/11..12/swift/common/constraints.py17:49
patchbotnotmyname: patch 328208 - swift (feature/crypto-review) - Enable object body and metadata encryption17:49
*** chlong has quit IRC17:52
acolesnotmyname: I didn't so much add it back, it's just no longer removed because patch 328207 removed it, so it's back to how it is on master.17:52
patchbotacoles: https://review.openstack.org/#/c/328207/ - swift (feature/crypto-review) - Allow middleware to override metadata header checking17:52
notmynameah, ok17:52
acolesargh, I forgot to reduce the MAX_HEADER_COUNT17:53
acolesnm17:53
*** gyee has joined #openstack-swift17:53
jrichlitimburke: re - next steps for encryption: great topic for hackathon :-)17:55
notmynameoh yeah, I was meaning to set up an etherpad for that...17:55
openstackgerritMerged openstack/swift: Add a global fix for anything that involves GetHashPrefixAndSuffix  https://review.openstack.org/33310817:55
notmynamejrichli:17:56
notmynamejrichli: https://etherpad.openstack.org/p/swift_austin_hackathon_201617:56
notmynamelol, nm17:56
notmynameit's not in austin ;-)17:56
notmynamelet's try https://etherpad.openstack.org/p/swift_SA_hackathon_201617:56
*** permalac has quit IRC17:57
jrichlinotmyname: re - not in austin: good, i have run out of new places to show you guys ;-)17:59
notmynameheh17:59
*** mvk has joined #openstack-swift18:00
notmynamejrichli: timburke: I added that topic to the etherpad18:00
*** ChanServ changes topic to "Time to review feature/crypto-review https://review.openstack.org/#/q/status:open+project:openstack/swift+branch:feature/crypto-review | Logs: http://eavesdrop.openstack.org/irclogs/%23openstack-swift/ | Meetings: https://wiki.openstack.org/wiki/Meetings/Swift | Hackathon: https://etherpad.openstack.org/p/swift_SA_hackathon_2016"18:03
notmynameetherpad link added to the channel topic18:03
*** manous has quit IRC18:05
openstackgerritBrian Cline proposed openstack/swift: Prevent down nodes failing PUTs on utf8 obj names  https://review.openstack.org/33537318:07
*** siva_krish has joined #openstack-swift18:15
*** siva_krish has quit IRC18:16
*** siva_krish has joined #openstack-swift18:16
*** manous has joined #openstack-swift18:17
*** tqtran has joined #openstack-swift18:23
*** geaaru has quit IRC18:23
*** mmcardle has quit IRC18:24
openstackgerritTim Burke proposed openstack/python-swiftclient: Fix unicode issues in tempurl command  https://review.openstack.org/33561518:25
claygheyoh!18:29
timburkestupid unicode18:29
openstackgerritBrian Cline proposed openstack/swift: Prevent down nodes failing PUTs on utf8 obj names  https://review.openstack.org/33537318:31
*** dmk0202 has quit IRC18:32
*** dmk0202 has joined #openstack-swift18:34
*** dmk0202 has quit IRC18:37
*** asettle has quit IRC18:37
claygcschwede: see patch 335373 for another test to add to the18:43
patchbotclayg: https://review.openstack.org/#/c/335373/ - swift - Prevent down nodes failing PUTs on utf8 obj names18:43
clayger... sorry - the translation patch you have going18:44
claygwhen I looked at the tests it seemed to test some unicode strings on the rhs but maybe they didn't have enough unicode-y chars in them?18:44
*** manous has quit IRC18:48
cschwedeclayg: thx, saw Brians patch and was already looking at it18:48
*** thumpba has quit IRC18:54
*** ManojK has quit IRC18:54
*** sheel has quit IRC18:55
*** notmyname has quit IRC19:01
*** mmotiani has quit IRC19:01
*** mmotiani_ is now known as mmotiani19:01
*** stevemar has quit IRC19:02
*** clarkb has quit IRC19:02
*** manous has joined #openstack-swift19:02
*** clarkb has joined #openstack-swift19:02
*** stevemar has joined #openstack-swift19:03
*** notmyname has joined #openstack-swift19:04
*** ChanServ sets mode: +v notmyname19:04
claygcschwede: of course you were - sorry :P19:05
*** thumpba has joined #openstack-swift19:07
*** thumpba has quit IRC19:07
*** thumpba has joined #openstack-swift19:08
*** mmotiani_ has joined #openstack-swift19:09
*** manous has quit IRC19:10
*** SkyRocknRoll has quit IRC19:11
*** thumpba_ has joined #openstack-swift19:11
*** thumpba has quit IRC19:11
*** thumpba has joined #openstack-swift19:14
*** ManojK has joined #openstack-swift19:15
*** thumpba_ has quit IRC19:15
*** mwheckmann has quit IRC19:16
*** thumpba has quit IRC19:19
*** thumpba has joined #openstack-swift19:19
*** thumpba has quit IRC19:20
*** thumpba has joined #openstack-swift19:20
*** manous has joined #openstack-swift19:22
cschwedeclayg: i’m wondering if there are maybe more issues hidden in the code base that need a decode…19:22
*** thumpba_ has joined #openstack-swift19:23
openstackgerritTim Burke proposed openstack/swift: Remove some unnecessary error handling in healthcheck  https://review.openstack.org/33563919:23
cschwedeclayg: well, indeed, it seems there are… need to do some tests19:23
*** thumpba_ has quit IRC19:24
acolestimburke: notmyname: I'm going to push a new patch for the change single middleware, based off the top of chain. I can squash the changes into other patches if we like it but I think its cleaner to see and discuss the change separately first. Plus it impacts the doc as much as the code.19:24
*** thumpba_ has joined #openstack-swift19:24
openstackgerritAlistair Coles proposed openstack/swift: Use a single wsgi filter for the encrypter and decrypter  https://review.openstack.org/33564119:25
*** thumpba_ has quit IRC19:25
*** thumpba_ has joined #openstack-swift19:25
*** thumpba has quit IRC19:25
*** thumpba_ has quit IRC19:25
acolestorgomatic: appreciate your opinion on that change ^^19:28
acolestimburke: notmyname if you have improvements then it would be ok to push over patch 335641 since it is top of the chain, just don't rebase it!!19:29
patchbotacoles: https://review.openstack.org/#/c/335641/ - swift (feature/crypto-review) - Use a single wsgi filter for the encrypter and dec...19:29
*** cdelatte has joined #openstack-swift19:30
*** mwheckmann has joined #openstack-swift19:30
*** cdelatte has quit IRC19:32
* acoles back later for meeting19:33
*** cdelatte has joined #openstack-swift19:33
*** cdelatte has quit IRC19:33
timburkeacoles: should we (at least temporarily) put keymaster & encryption in the sample proxy config? just for the sake of having the gate test the new entrypoint19:34
openstackgerritBrian Cline proposed openstack/swift: Prevent down nodes failing PUTs on utf8 obj names  https://review.openstack.org/33537319:34
acolestimburke: k19:34
openstackgerritAlistair Coles proposed openstack/swift: Use a single wsgi filter for the encrypter and decrypter  https://review.openstack.org/33564119:37
acolestimburke: done ^^ good idea19:38
*** asettle has joined #openstack-swift19:38
timburkethanks19:38
*** acoles is now known as acoles_19:38
*** asettle has quit IRC19:42
*** catintheroof has quit IRC19:43
*** asettle has joined #openstack-swift19:59
*** ukaynar has quit IRC20:00
*** cschwede has quit IRC20:03
*** tmoreira has quit IRC20:04
*** ukaynar has joined #openstack-swift20:04
jrichliacoles: I have seen https://bugs.launchpad.net/swift/+bug/1589994 before.  I more often have unit test errors like https://bugs.launchpad.net/swift/+bug/157957820:14
openstackLaunchpad bug 1589994 in OpenStack Object Storage (swift) "test_container_update_async fails intermittently" [Undecided,New]20:14
openstackLaunchpad bug 1579578 in OpenStack Object Storage (swift) "test_unlink_* unittests fail intermittently" [Undecided,New]20:14
*** asettle has quit IRC20:19
*** ukaynar has quit IRC20:20
openstackgerritTim Burke proposed openstack/swift: Fix intermittent SLO unit test failures  https://review.openstack.org/33565820:22
*** asettle has joined #openstack-swift20:26
*** arcimboldo has joined #openstack-swift20:28
*** kei_yama has joined #openstack-swift20:33
*** dmorita has joined #openstack-swift20:34
*** flwang1 has quit IRC20:36
*** _JZ_ has quit IRC20:46
mattoliverauMorning20:50
dmoritamattoliverau: Morning20:51
*** asettle has quit IRC20:51
*** dmk0202 has joined #openstack-swift20:54
*** cschwede has joined #openstack-swift20:55
kota_morning20:57
*** asettle has joined #openstack-swift20:57
pdardeaumattoliverau: morning20:57
pdardeaukota: morning20:57
kota_pdardeau: o/20:57
notmynameacoles_: aside from the small changes in the docs that christian mentions and the small changes I commented on in patch 328208, I think I'm pretty happy with crypto and I think I'm happy with it landing20:57
patchbotnotmyname: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption20:57
jrichliyay :-)20:58
*** manous has quit IRC20:59
notmynamemeeting time in #openstack-meeting20:59
notmynamejrichli: well except for the the knowledge timburke just dropped in the comment that I still need to grok ;-)21:00
*** raildo is now known as raildo-afk21:03
notmynamehurricanerix: ping (hackathon questions in the meeting)21:06
*** asettle has quit IRC21:11
*** acoles_ is now known as acoles21:12
*** ManojK has quit IRC21:13
*** mmcardle has joined #openstack-swift21:13
*** mmcardle has quit IRC21:14
*** ManojK has joined #openstack-swift21:15
openstackgerritTim Burke proposed openstack/swift: Fix intermittent bulk delete unit test failures  https://review.openstack.org/33567421:31
clayggood times21:41
notmynameacoles: thanks for reminding me about the docs21:41
*** cschwede has quit IRC21:42
acolesnotmyname: np21:45
*** tqtran has quit IRC21:45
*** tqtran has joined #openstack-swift21:46
*** ManojK has quit IRC21:48
*** acoles is now known as acoles_21:50
*** diogogmt has quit IRC21:53
*** rcernin has quit IRC21:54
brianclineuh oh21:58
brianclinefinding more unicode exceptions. sigh21:58
brianclinesame thing, additional places22:00
claygtimburke: torgomatic: so what was wrong with the transcyrpter unification patch?  is that going to get into the next pipeline?22:00
clayger... patch chain22:00
timburkeclayg: i know *i* want it in. as well as some improvements to the keymaster callback, but i suppose that could wait until we're on master22:01
torgomaticclayg: someone pointed out that, if your keymaster needs to inspect object metadata on a GET, having keymaster to the left of decrypter precludes that22:01
torgomaticunless the things passed from decrypter to keymaster includes the user metadata22:01
torgomatic(I don't know if it does or not)22:01
timburkeit does not currently22:02
claygtorgomatic: timburke: what about maybe having the crypto have a keymaster = #egg:path option and it just loads up the filter factory and does Decrypter(Keymaster(Encrypter(app, conf), conf), conf)22:04
torgomaticclayg: at that point, just make people type "decrypter some-keymaster encrypter" into their pipeline and save us the trouble22:05
claygtorgomatic: I'm +2 on that idea!22:05
claygtorgomatic: making the signature of the keymaster callback at least robust enough that we *could* add new kwargs into it later is probably smart22:06
torgomaticclayg: true that22:06
*** nadeem has joined #openstack-swift22:07
*** dmk0202 has quit IRC22:08
*** asettle has joined #openstack-swift22:12
*** cdelatte has joined #openstack-swift22:12
*** acoles_ is now known as acoles22:13
*** ametts has quit IRC22:16
*** asettle has quit IRC22:17
*** chlong has joined #openstack-swift22:17
acolesclayg: timburke torgomatic notmyname I think I am seeing +ve for patch 335642, subject to moving to another file to avoid the in-function import. I just left a reply re future keymaster concerns.22:18
patchbotacoles: https://review.openstack.org/#/c/335642/ - keystone - Improve keystone.conf [eventlet_server] documentation22:18
acolesno not that! patch 33564122:19
patchbotacoles: https://review.openstack.org/#/c/335641/ - swift (feature/crypto-review) - Use a single wsgi filter for the encrypter and dec...22:19
acolesif you guys decide otherwise while I sleep, push a change over or leave a clear -ve vote22:19
*** cdelatte has quit IRC22:19
notmynamewhat's "ve"?22:25
*** siva_krish has quit IRC22:27
brianclineecho negative | sed -e 's/negati/-//'22:27
acolesnotmyname: as in +ve -ve? positive negative?22:28
acolesbriancline understands :)22:28
notmynameoh. yeah. you're still an EE at heart ;-)22:28
*** mwheckmann has quit IRC22:29
acolesnotmyname: fixed my washing machine motor brushes last night !22:29
acolesgood night22:30
*** acoles is now known as acoles_22:30
claygtorgomatic: did you have a specific suggestion to fix the cirular import thing?22:35
*** _JZ_ has joined #openstack-swift22:38
*** cdelatte has joined #openstack-swift22:42
*** cdelatte has quit IRC22:51
*** arcimboldo has quit IRC22:55
*** diogogmt has joined #openstack-swift22:56
torgomaticclayg: chuck it in another module? that's why common.request_helpers exists22:58
*** arch-nemesis has quit IRC23:04
claygk, it wasn't super clear that your -1 was for "create a new module" (to me)23:06
*** jamielennox is now known as jamielennox|away23:13
*** peluse has joined #openstack-swift23:17
*** ChanServ sets mode: +v peluse23:17
*** peluse is now known as peluse123:19
*** peluse1 has quit IRC23:20
*** peluse has joined #openstack-swift23:21
*** ChanServ sets mode: +v peluse23:21
hurricanerixnotmyname sorry i missed the meeting.  but yeah, as far as i know the hotel runs a shuttle, and i will have my car, so three lucky people can alway ride with me.23:23
claygwhere's zitcev!?23:27
*** asettle has joined #openstack-swift23:28
claygis the format of other-requirements.txt supported by *any* other tools because openstack ci?23:29
*** asettle has quit IRC23:33
claygoh, we have crypto helpers and utils23:34
*** chsc has quit IRC23:34
*** jamielennox|away is now known as jamielennox23:51
*** siva_krish has joined #openstack-swift23:54
*** NM has joined #openstack-swift23:56
* NM is watching tdsilva giving a class of Swift 101.23:58
notmynamenice!23:58
notmynameNM: take a picture :-)23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!