Wednesday, 2017-01-11

*** jamielennox is now known as jamielennox|away00:07
*** jamielennox|away is now known as jamielennox00:11
*** ogelbukh has quit IRC00:11
*** remix_tj has quit IRC00:12
*** ogelbukh has joined #openstack-swift00:13
*** jroll has quit IRC00:14
*** remix_tj has joined #openstack-swift00:14
mattoliverauMooingLemur: wow, there is a patch hurricanerix is working on revamp the object expiry in Swift and remove the need for the expirer daemon00:17
MooingLemuroh, nice :)00:18
MooingLemurI have that split across 8 hosts now, myself.00:18
*** jroll has joined #openstack-swift00:21
*** tqtran has quit IRC00:23
claygmattoliverau: is hurricanerix still working on that?  I thought aerwin3 took that over but then got caught up on other stuff?00:41
mattoliverauclayg: yeah he is, it's one of his OSIC tasks00:46
claygmattoliverau: awesome!00:59
claygmattoliverau: gtk!00:59
kota_good morning01:05
* kota_ is now at office01:05
kota_mattoliverau, clayg: https://review.openstack.org/#/c/252085/ <- that one for object-expier? or new another one comming?01:08
patchbotpatch 252085 - swift - Refactoring the expiring objects feature01:08
*** _JZ__ has quit IRC01:17
*** _JZ_ has quit IRC01:17
*** sams-gleb has joined #openstack-swift01:22
*** sgundur_ has joined #openstack-swift01:26
*** sams-gleb has quit IRC01:26
*** cppforlife_ has joined #openstack-swift01:34
*** briancurtin has joined #openstack-swift01:35
*** cdelatte has quit IRC01:54
*** dmorita has quit IRC01:57
*** dmorita has joined #openstack-swift01:58
*** sgundur_ has quit IRC02:13
claygkota_: mattoliverau: I'm glad that patch 283946 merged to fix lp bug #1488608 - but I feel like I'm missing a test to demonstrate the change in stats output?  all of the test changes look related the refactoring (why did the replicator need a router again?)02:15
openstackLaunchpad bug 1488608 in OpenStack Object Storage (swift) "stats output in reconstructor.py gives wrong device count" [Low,Fix released] https://launchpad.net/bugs/1488608 - Assigned to Bill Huber (wbhuber)02:15
patchbothttps://review.openstack.org/#/c/283946/ - swift - Fix stats calculation in object-reconstructor (MERGED)02:15
*** asettle has joined #openstack-swift02:16
kota_clayg: lemme check...02:17
claygit's maybe NBD - I have a branch where I started to suss out an unrelated stats output thing (we increment the x/y parts as soon as we *start* working on x instead as we finish) - I think I fixed the device count thing as a drive by - i'm sure it'll all come back to me I dust that off02:18
*** dmorita has quit IRC02:18
*** sgundur_ has joined #openstack-swift02:19
kota_ah, exactly, it looks like it's missing for output assertions while reviewing process.02:21
claygprobalby nbd02:22
*** asettle has quit IRC02:23
kota_yeah, patch set 1 has draft output check :/ https://review.openstack.org/#/c/283946/1/test/unit/obj/test_reconstructor.py02:23
patchbotpatch 283946 - swift - Fix stats calculation in object-reconstructor (MERGED)02:23
mattoliveraukota_: yeah that's it. Hurricanerix is taking it over and will revise and continue it on.02:25
kota_and iirc, it's a bit strong-arm and i changed something...02:25
kota_and missing output assertion, maybe?02:25
*** JimCheung has quit IRC02:26
kota_mattoliverau: nice02:26
*** dmorita has joined #openstack-swift02:27
kota_notmyname: could you add me (kota3) to swift-team in trello? I didn't work on symlink staff yet but I'd get subscribed the change and progress from trello.02:30
kota_to track upstream.02:30
*** chlong has quit IRC02:32
*** sgundur_ has quit IRC02:34
*** sgundur_ has joined #openstack-swift02:40
*** sgundur_ has quit IRC02:46
*** sgundur_ has joined #openstack-swift02:47
*** winggundamth has quit IRC02:47
*** sgundur_ has quit IRC03:04
*** dmorita has quit IRC03:06
*** winggundamth has joined #openstack-swift03:07
kota_tdasilva: thanks for adding me to the symlink board03:19
*** tqtran has joined #openstack-swift03:21
*** tqtran has quit IRC03:23
*** sams-gleb has joined #openstack-swift03:25
*** dschultz has joined #openstack-swift03:25
*** sams-gleb has quit IRC03:29
*** dmorita has joined #openstack-swift03:32
*** chosafine has joined #openstack-swift03:36
*** chosafine has joined #openstack-swift03:36
*** dmorita has quit IRC03:36
*** chosafin_ has joined #openstack-swift03:39
*** chosafine has quit IRC03:40
*** chosafin_ is now known as chosafine03:41
*** chosafine has joined #openstack-swift03:41
* MooingLemur is now seeing if bindfs will run at scale03:44
MooingLemurchanging from gentoo's swift uid/gid of 404 to CentOS's standard of 16003:45
*** links has joined #openstack-swift03:47
*** sgundur_ has joined #openstack-swift03:48
MooingLemurand chowning all the files underneath before the conversion to centos :)03:49
*** dmorita has joined #openstack-swift03:50
*** dmorita has quit IRC03:54
*** sgundur_ has quit IRC04:01
*** sgundur_ has joined #openstack-swift04:01
*** sgundur_ has quit IRC04:12
*** padkrish has joined #openstack-swift04:17
*** padkrish has left #openstack-swift04:18
*** varunsomani has joined #openstack-swift04:19
*** manij has joined #openstack-swift04:20
*** varunsomani has quit IRC04:20
* kota_ is starting to pick up the critical bug reported by acoles for looking.04:22
openstackgerritMahati Chamarthy proposed openstack/swift: Cleanup tests from empty suffix quarantined db fix  https://review.openstack.org/40513404:23
*** chsc has joined #openstack-swift04:25
*** chsc has joined #openstack-swift04:25
*** manij has quit IRC04:32
*** ppai has joined #openstack-swift04:33
*** sheel has joined #openstack-swift04:34
*** ppai has quit IRC04:35
*** chsc has quit IRC04:38
*** SkyRocknRoll has joined #openstack-swift04:40
*** psachin has joined #openstack-swift04:40
*** tqtran has joined #openstack-swift04:40
*** tqtran has quit IRC04:42
*** manij has joined #openstack-swift04:50
*** manij has quit IRC04:55
timburke404 seems like an ominous uid for a web service... particularly one often used to archive backups...05:12
mattoliveraulol05:25
*** sams-gleb has joined #openstack-swift05:27
claygkota_: the suffix hashing one?05:30
kota_clayg: yup05:30
*** ppai has joined #openstack-swift05:30
kota_clayg: did you already start that one?05:30
claygi *just* finished - took me three days - i have... three branches and 17 draft comments and 4 change-sets (3 mostly indpedent branches)05:31
kota_clayg: awesome05:31
*** sams-gleb has quit IRC05:32
kota_clayg: no worries to push your +2 if it's great. I didn't spent much my time yet.05:32
kota_i'm just made sense with the bug description.05:33
claygwell... umm... no i'm not sure it should merge - I had to pull it apart to wrap my head around it - i'm hoping we maybe merge the smaller indepdent fixes05:36
kota_yeah, i'm feeling the commit log compolicated a bit because that closes a bug but the title is "Optimize".05:39
kota_complicated05:39
openstackgerritClay Gerrard proposed openstack/swift: Extract test pattern to helper  https://review.openstack.org/41868905:39
openstackgerritClay Gerrard proposed openstack/swift: Fix race in new partitions detecting new/invalid suffixes.  https://review.openstack.org/41869005:39
openstackgerritClay Gerrard proposed openstack/swift: Fix performance regression with hash invalidations  https://review.openstack.org/41869105:39
openstackgerritClay Gerrard proposed openstack/swift: Optimize noop case for suffix rehash  https://review.openstack.org/41869205:39
kota_clayg: are they for replacing the patch 402043?05:40
patchbothttps://review.openstack.org/#/c/402043/ - swift - Optimize hash calculation when suffix hash invalid...05:40
claygkota_: it depends what acoles_ and pavel want to do?05:41
kota_clayg: alright but probably i like that idea because each change (e.g. closing critical bug, https://review.openstack.org/#/c/418690/) smaller than the original.05:43
patchbotpatch 418690 - swift - Fix race in new partitions detecting new/invalid s...05:43
claygkota_: right, and that critical fix is acctually better (IMHO) than the change in patch 40204305:43
patchbothttps://review.openstack.org/#/c/402043/ - swift - Optimize hash calculation when suffix hash invalid...05:43
claygwhich FWIW, again IMHO, address the performance issue better than patch 41869105:44
patchbothttps://review.openstack.org/#/c/418691/ - swift - Fix performance regression with hash invalidations05:44
claygfor some measure of "better" - I think part of the reason patch 418691 exists like it does is because it makes the problem/fix obvious - even thought it still needs some tweeks - I think even after addressing the race thing it'll still be "less stuff" that the entirty of patch 40204305:45
patchbothttps://review.openstack.org/#/c/418691/ - swift - Fix performance regression with hash invalidations05:45
patchbothttps://review.openstack.org/#/c/402043/ - swift - Optimize hash calculation when suffix hash invalid...05:45
claygi'm sure breaking it is the right thing to do - i'm not sure if not merging fixes purely on astetics is a wise choice05:46
kota_clayg: sure, i'll try to look at your 4 patches, thanks for letting me to head up.05:48
*** manij has joined #openstack-swift05:51
*** bkopilov has joined #openstack-swift06:06
*** dims has quit IRC06:13
*** dfflanders has quit IRC06:19
openstackgerritJanie Richling proposed openstack/swift: Symlink API documentation  https://review.openstack.org/41594306:25
*** pcaruana has joined #openstack-swift06:25
jrichliI will squash into the impl tomorrow ^^06:25
*** sheel has quit IRC06:37
*** geaaru has joined #openstack-swift06:46
*** chsc has joined #openstack-swift06:47
*** chsc has joined #openstack-swift06:47
*** chosafine has quit IRC06:51
*** chsc has quit IRC06:52
openstackgerritClay Gerrard proposed openstack/swift: Fix performance regression with hash invalidations  https://review.openstack.org/41869107:04
*** cbartz has joined #openstack-swift07:08
*** tesseract has joined #openstack-swift07:08
claygshit - I think I messed up on patch 402043 - I +1 +A'd it :\07:10
patchbothttps://review.openstack.org/#/c/402043/ - swift - Optimize hash calculation when suffix hash invalid...07:10
*** ChubYann has quit IRC07:15
*** sams-gleb has joined #openstack-swift07:29
*** sams-gleb has quit IRC07:34
*** sams-gleb has joined #openstack-swift07:46
openstackgerritClay Gerrard proposed openstack/swift: Fix race in new partitions detecting new/invalid suffixes.  https://review.openstack.org/41869007:50
*** bkopilov has quit IRC07:55
*** hogepodge has quit IRC07:56
*** winggundamth has quit IRC07:56
*** hseipp has joined #openstack-swift07:59
*** tmoreira has quit IRC08:06
*** sams-gleb has quit IRC08:07
*** sams-gleb has joined #openstack-swift08:07
*** tmoreira has joined #openstack-swift08:08
*** rledisez has joined #openstack-swift08:11
*** sams-gleb has quit IRC08:11
zaitcevtsk tsk :-)08:26
*** kei_yama has quit IRC08:45
*** bkopilov has joined #openstack-swift08:51
kota_clayg: woow, the patch 402043 stops to get merged at Jenkis +2. Should I add -2 or workflow -1 for safety to prevent the merge?08:52
patchbothttps://review.openstack.org/#/c/402043/ - swift - Optimize hash calculation when suffix hash invalid...08:52
*** oshritf has joined #openstack-swift08:56
mahatickota_: if it can prevent the merge, maybe? But IDK..clayg didn't seem to suggest that?08:59
kota_mahatic: i'm not sure too if it's a way.09:00
*** cbartz has quit IRC09:00
mahatickota_: oh. clayg's latest comment seem to suggest that though - wait to see how the splitting up of patches work for others09:01
*** jordanP has joined #openstack-swift09:02
kota_mahatic: splitting patches has existed already09:04
kota_mahatic: 4 patches since https://review.openstack.org/41868909:04
patchbotpatch 418689 - swift - Extract test pattern to helper09:04
mahatickota_: yeah I saw that, that's why he doesn't want this to be merged yet. Maybe you can give it a shot at workflow -1?09:05
kota_mahatic: yeah, i can do that but idk he wants me to do that for now because he also is able to do...09:06
mahatickota_: ah yeah, okay09:06
*** asettle has joined #openstack-swift09:09
*** cbartz has joined #openstack-swift09:10
*** mvk has quit IRC09:32
*** tqtran has joined #openstack-swift09:44
*** tqtran has quit IRC09:45
*** sams-gleb has joined #openstack-swift09:59
*** geaaru has quit IRC10:07
*** geaaru has joined #openstack-swift10:09
*** hseipp has quit IRC10:09
*** mvk has joined #openstack-swift10:10
*** acoles_ is now known as acoles10:14
*** cbartz has quit IRC10:46
*** hseipp has joined #openstack-swift10:48
*** vint_bra has joined #openstack-swift10:49
*** cbartz has joined #openstack-swift10:52
*** ukaynar has joined #openstack-swift10:56
*** ppai has quit IRC11:08
kota_clayg: sorry, I couldn't finish all your patches today but only one patch which seems the most significant reviewed11:09
kota_clayg: https://review.openstack.org/#/c/418690 <- this one11:10
patchbotpatch 418690 - swift - Fix race in new partitions detecting new/invalid s...11:10
kota_clayg: hope my comment would be worth11:10
* kota_ is getting back home11:10
*** vint_bra has quit IRC11:14
*** ppai has joined #openstack-swift11:26
*** ukaynar has quit IRC11:27
*** ukaynar has joined #openstack-swift11:39
*** dims has joined #openstack-swift11:39
*** onboard has joined #openstack-swift11:58
*** hseipp has quit IRC12:00
*** mvk has quit IRC12:03
*** ukaynar has quit IRC12:03
*** mvk has joined #openstack-swift12:15
*** vint_bra has joined #openstack-swift12:24
*** SkyRocknRoll has quit IRC12:48
*** ganders has joined #openstack-swift12:48
*** hseipp has joined #openstack-swift12:51
*** chlong has joined #openstack-swift13:07
*** mvk has quit IRC13:21
*** mvk has joined #openstack-swift13:33
gandersis there anyone who had change the python interpreter from cpython to pypy on an already running swift cluster with juno version?13:38
*** Jeffrey4l_ has quit IRC13:45
*** AnxiousGarlic has joined #openstack-swift13:51
*** AnxiousGarlic_ has joined #openstack-swift13:51
*** david-lyle has quit IRC13:56
*** tongli has joined #openstack-swift13:59
*** david-lyle has joined #openstack-swift13:59
*** links has quit IRC14:02
*** AnxiousGarlic_ has quit IRC14:05
*** dmorita has joined #openstack-swift14:08
tdasilvagood morning14:09
*** dmorita has quit IRC14:13
*** klamath has joined #openstack-swift14:14
*** jamielennox is now known as jamielennox|away14:14
*** klamath has quit IRC14:14
*** klamath has joined #openstack-swift14:15
*** david-lyle has quit IRC14:16
*** chlong has quit IRC14:37
*** chsc has joined #openstack-swift14:38
*** chsc has joined #openstack-swift14:38
*** chsc has quit IRC14:44
*** chosafine has joined #openstack-swift14:47
*** tongli has quit IRC14:49
*** ganders has quit IRC14:51
*** chosafine has quit IRC14:51
*** cloudm2 has joined #openstack-swift14:52
*** ppai has quit IRC14:52
*** ppai has joined #openstack-swift15:05
openstackgerritJanie Richling proposed openstack/swift: Symlink API documentation  https://review.openstack.org/41594315:05
*** ppai has quit IRC15:06
*** sams-gleb has quit IRC15:09
*** sams-gleb has joined #openstack-swift15:09
*** ganders has joined #openstack-swift15:10
*** sams-gleb has quit IRC15:14
*** psachin has quit IRC15:14
*** _JZ_ has joined #openstack-swift15:15
*** chosafine has joined #openstack-swift15:24
*** adu has joined #openstack-swift15:24
*** sams-gleb has joined #openstack-swift15:31
*** Jeffrey4l has joined #openstack-swift15:40
timburkeganders: i know notmyname has done some work with pypy... not sure it was as far back as juno, though15:42
timburkei seem to remember him saying things about how sockets are handled differently?15:43
gandersthanks a lot timburke, i'll try it on a lab cluster and see how things go with that..15:44
*** sgundur_ has joined #openstack-swift15:47
*** mvk has quit IRC15:48
notmynamegood morning15:49
notmynamekota_: done. I added you15:49
*** sgundur_ has quit IRC15:54
*** AnxiousGarlic has quit IRC15:54
*** sgundur_ has joined #openstack-swift15:55
*** Shashikant86 has joined #openstack-swift16:01
notmynameganders: cool. what are you doing with swift and pypy16:02
*** sgundur_ has quit IRC16:03
ganderswe're hosting millions and millions of images of our site, and we've a clus that consumes that, and the problem is that our disks are at 100% almost all the time.. we've 6 data nodes and 3 proxy servers, and for example, the three proxies had more or less 5.5M GET ops per day each16:06
ganders800k put req, and the thing is that we don't have budget for expanding the cluster.. so.. it's a little bit hard to improve that condition16:07
*** chosafine has quit IRC16:08
*** chosafine has joined #openstack-swift16:11
*** chosafine has joined #openstack-swift16:11
*** chlong has joined #openstack-swift16:11
rledisezganders: try to stop all the account/container/object auditor and replicator (just temporarily!). if it helps, tune their interval and speed to slow them down a bit16:11
*** bkopilov has quit IRC16:16
*** hseipp has quit IRC16:23
gandersthanks rledisez, i'll try that out16:25
*** sgundur_ has joined #openstack-swift16:25
*** ganders has quit IRC16:27
*** bkopilov has joined #openstack-swift16:28
*** sgundur_ has quit IRC16:32
*** chsc has joined #openstack-swift16:35
*** chsc has joined #openstack-swift16:35
openstackgerritJanie Richling proposed openstack/swift: Symlink API documentation  https://review.openstack.org/41594316:39
acolesjrichli: re you failing api ref test - the yaml definitions need to be alphabetical16:40
jrichliacoles: yes, i think ill get it right this time.16:40
acolesjrichli: oh, did you just fix that? :) it's a pain, burnt me too a while back.16:41
jrichliwe shall see if is really *fixed*  ;-)16:41
jrichlionce i know it builds successfully, i will squash16:42
*** winggundamth has joined #openstack-swift16:47
notmynametdasilva: you're going to change your time zone? http://turnto10.com/ri-mass-lawmakers-propose-changing-time-zones16:47
*** silor has joined #openstack-swift16:48
tdasilvanotmyname: i do hate the fact that (especially in december) it is pitch black dark at 4m16:49
tdasilva4pm16:49
*** sgundur_ has joined #openstack-swift16:50
notmynameyeah, that doesn't sound good.16:50
notmynamebut what about summer? light until mignith?16:51
notmynamewhat was that word? *midnight16:51
tdasilvaheh16:51
tdasilvasummer gets dark around 9pm16:51
notmynameacoles: where does a "yaml definition must be alphabetical" get enforced?16:53
*** caiobrentano_ has joined #openstack-swift16:54
notmynameis that a linter a la pep8 that's in an openstack project somewhere? is that enforced by sphinx/whatever?16:55
acolesnotmyname: not sure, sorry. well in tox api-ref env but not sure what the root of it is.16:56
*** acoles is now known as acoles_16:57
notmynameok. no worries16:57
notmynamejust seems like a wierd constraint16:57
*** cloudm2 has quit IRC17:03
*** caiobrentano_ has left #openstack-swift17:08
*** caiobrentano_ has joined #openstack-swift17:08
*** ganders has joined #openstack-swift17:09
*** briancurtin has quit IRC17:11
*** Shashikant86 has quit IRC17:12
*** pcaruana has quit IRC17:12
*** tqtran has joined #openstack-swift17:16
dimsacoles_ : looks like it's from os-api-ref https://github.com/openstack/os-api-ref/blame/master/os_api_ref/__init__.py#L28117:18
*** tesseract has quit IRC17:20
*** klrmn has quit IRC17:26
*** asettle has quit IRC17:26
timburkeso the only way (currently) to validate it is to try building docs :-/17:31
notmynametimburke: but that's possible locally, right? I mean, "try building docs" is pretty much the way any docs patch is validated, right?17:32
*** rledisez has quit IRC17:32
timburkeyeah, i just appreciate how much faster `flake8 <file i actually editted>` is than `tox -e pep8`17:33
*** dmorita has joined #openstack-swift17:42
*** cbartz has quit IRC17:42
claygmorning!17:43
claygkota_: I can't remember what test failed that prompted me to add that mkdirs calls - I agree it looks stupid - probably worth further investigation.17:44
claygkota_: did you try to pull it out and see what failed?  I sort of remember it prompted me to "un-tpool" the _get_hashes call so I could get a better traceback17:44
*** dmorita has quit IRC17:47
*** dmorita has joined #openstack-swift17:49
*** jordanP has quit IRC17:50
claygganders: how many parts per device?  one thing that *loves* to eat up the iops is lots and lots of small files in lots and lots of sprase dirs.17:55
claygwell i guess that's two things17:55
*** hseipp has joined #openstack-swift17:55
gandersclayg: one part per device17:56
claygthere's some games you can play with memory and filesystem inode caching tunings17:56
claygganders: i'm sorry - what what?17:56
tdasilvafs partition != swift parts17:56
claygmaybe one unit of weight?  like if you ls /srv/node/d1/objects there's only a single integer dir in there?17:56
claygtdasilva: lol - omg thank you - i'm such a swift snob :'(17:56
ganderssorry my bad, i mean os part per dev17:56
claygganders: I like to just put the filesystem right on the block device!  mbr's are a tool for people that don't eat harddrives for breakfast ;)17:57
ganders547 parts17:58
claygthat's not bad!17:58
claygsorta good acctually :\17:58
claygthere's some /proc stats I think you can start to monitor that have to do with xfs inode reads and cahce hit rates17:58
*** mvk has joined #openstack-swift17:59
claygmostly its the little file system updates/reads that chew on the iops - i mean disks obviously *can* get throughput saturated - but it's not the common case when you're bumping into utilization17:59
clayghow well distributed is the access patterns is 5.5M GET ops in a day for 5.5M different objects?18:00
claygor is the working set like <1M or something?18:00
ganders<2M18:00
claygstill a lot - I think there's some caching options you can play with18:01
gandersdo you have some detail info on those cache opts18:01
claygnotmyname: what is the one stupidly named option on the object server's that's like "dont_drop_unauthenticated_cahes_unless_they_are_big_or_not_maybe_what_does_this_do" option?18:01
claygkeep_cache_private defaults to false - changing it to true does "something"18:02
*** JimCheung has joined #openstack-swift18:02
notmynameclayg:  is it the https://github.com/openstack/swift/blob/master/etc/object-server.conf-sample#L104-L109 stuff?18:02
*** tqtran has quit IRC18:03
gandersthnks!, i will take a look on that18:03
claygdefault keep_cache_size is 5M - if your objects are 5.1M on average that might be annoying18:04
patchbotError: 'supybot.keep_cache_size' is not a valid configuration variable.18:04
gandersbig question..those opts.. keep_cache_size and keep_cache_private work on juno?18:04
claygOTOH if you have a bunch of requests for objects 10K and a few for objects 4.9M - that might be annoying too?18:04
openstackgerritMerged openstack/swift: Update the tag for Swift tox test  https://review.openstack.org/41056018:04
claygwhat is juno?  did they have indoor plumbing back then?18:05
notmynameFWIW juno = swift 2.218:05
notmyname2 years ago18:05
claygoh yeah, swift 2.2 is great18:05
claygnot as good as swift 2.12 - but still - pretty good18:05
claygbetter than swift 1.13!?  you remember that!?  lol18:05
gandersyeah sorry guys.. update procs here are not very common lol...18:06
claygganders: doesn't matter swift 2.13 will be the best one yet - you can just wait and upgrade to that18:07
*** chosafine has quit IRC18:07
claygdoes anyone here use vsaio?  of that set of people does anyone like docs?  of that set of people does anyone know api-ref docs?  of that set of people (is there anyone left?) does anyone have time to consider -> https://github.com/swiftstack/vagrant-swift-all-in-one/issues/5418:09
claygnotmyname: or did you say you were going to merge all that under the normal sphix tree anyway?18:10
notmynameclayg: https://review.openstack.org/#/c/386834/  <-- I need to update it18:11
patchbotpatch 386834 - swift - Unify docs trees18:11
claygnotmyname: that looks *amazing* - can we *do* that?18:12
clayglike we don't *have* to have install-guide and api-ref TLD?18:13
notmynamewell...seems like the CI isnt' set up to do it that way, so I don't know?18:13
claygbummer18:13
*** david-lyle has joined #openstack-swift18:16
*** hseipp has quit IRC18:16
tdasilvaclayg: hello, what do you mean by enforce that the etag of a symlink is always a zero-byte object? we currently validate that the sym is a zero-byte object, but by validating the content-length, not the etag18:18
notmynamebut I think we should do it, so I need to look at what's actually blocking. IIRC mattoliverau had found the thing that was breaking so I'll look in to it18:18
*** klrmn has joined #openstack-swift18:23
claygtdasilva: if i do a zero-byte PUT the etag is always ... d41d8cd98f00b204e9800998ecf8427e18:26
claygit's probably NBD but like we could set an ETag header on all symlink put's even if the client didn't send it18:26
claygbut i suppose that's always true when content-length is 018:27
claygi'm not really sure why I wrote it down18:27
claygwe were thinking about it when talking about container listings18:27
tdasilvaclayg: right, and if the client tries to send somethign else an error is returned18:27
clayg< HTTP/1.1 422 Unprocessable Entity18:28
tdasilvayep18:28
timburkeganders: since i didn't notice a reply to your question: yeah, those options were available in 2.2.0 https://github.com/openstack/swift/blob/2.2.0/etc/object-server.conf-sample#L78-L8318:28
claygidk, it's w/e - just delete that story - or ask timburke he's pretty smart - maybe he can up with a reason to do ... something?18:28
*** sgundur_ has quit IRC18:29
timburketdasilva: i saw the bit about checking for a content-length... if the client sends a transfer-encoding:chunked request, do we do anything to bail out when there's real content? forcing the etag would take care of it... though the error wouldn't be super helpful18:31
tdasilvatimburke: good point, but couldn't we just not allow transfer-encoding:chunked request for symlink PUT request18:32
timburketdasilva: and *if* we still wanted to support post-as-copy, i think we actually *could* start bypassing slo validation -- take a look at https://review.openstack.org/#/c/348495/18:33
patchbotpatch 348495 - swift - Make container sync copy SLO manifests (MERGED)18:33
timburkemaybe? depends on how much control the user really has over their client. maybe it *always* does chunked transfers, even for zero-byte request bodies. i know i've run into it with swift3 and some s3 client before18:34
*** chosafine has joined #openstack-swift18:35
*** chosafine has joined #openstack-swift18:35
*** chosafine has quit IRC18:37
tdasilvatimburke: was just checking dlo and copy, unfortunately it seems we are pretty inconsistent with how we validate our zero-byte objects18:43
timburkei don't believe we *do* validate that dlos are zero bytes. i seem to recall that you can turn *any* object into a dlo with a post18:44
timburke(maybe those are two separate issues?)18:44
*** chosafine has joined #openstack-swift18:45
*** chosafine has joined #openstack-swift18:45
timburkei'm all for making it a *hard requirement* that symlinks be zero bytes, though. if somebody can think of a reason to allow data in them, we can walk it back later18:45
*** chlong has quit IRC18:46
tdasilvatimburke: yes on the dlo, i was just pointing out that I think the expecation is that a dlo manifest *should* be a zero byte object, it was just never enforced. But I'm not disagreeing with making it a hard requirement for syms, just trying to think of the best way to do it...18:50
*** sgundur_ has joined #openstack-swift18:51
timburketry reading a byte? either it comes back '' or we fail the request18:51
timburkeidk18:51
openstackgerritRichard Hawkins proposed openstack/swift: Refactoring the expiring objects feature  https://review.openstack.org/25208518:55
*** tqtran has joined #openstack-swift18:57
openstackgerritMerged openstack/swift: Add test for object updater user-agent header  https://review.openstack.org/39852318:58
*** chlong has joined #openstack-swift18:58
*** dmorita has quit IRC18:59
*** manij has quit IRC19:02
openstackgerritRichard Hawkins proposed openstack/swift: Refactoring the expiring objects feature  https://review.openstack.org/25208519:03
*** briancurtin has joined #openstack-swift19:09
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873619:10
*** dmorita has joined #openstack-swift19:14
*** ChubYann has joined #openstack-swift19:16
*** dmorita has quit IRC19:19
openstackgerritClay Gerrard proposed openstack/swift: Move documented reclaim_age option to correct location  https://review.openstack.org/37441919:25
*** dmorita has joined #openstack-swift19:26
*** chosafine has quit IRC19:28
openstackgerritTim Burke proposed openstack/swift: Tighten the move-one-replica test  https://review.openstack.org/41910719:29
openstackgerritGábor Antal proposed openstack/swift: Reduced complexity of _response_iter() method  https://review.openstack.org/24756019:30
openstackgerritTim Burke proposed openstack/swift: Move documented reclaim_age option to correct location  https://review.openstack.org/37441919:33
timburkeclayg: fwiw, i cleaned up that break in https://review.openstack.org/#/c/419107/, where i also realized we only need one more rebalance19:38
patchbotpatch 419107 - swift - Tighten the move-one-replica test19:38
claygtimburke: that parts_with_moved_count test fails when you add/fix the breaks?19:42
timburkewhich? is it over in test_ring.py? :-/19:43
claygpatch 41910719:43
patchbothttps://review.openstack.org/#/c/419107/ - swift - Tighten the move-one-replica test19:43
claygno, the test change the break cleanup are unrelated?19:44
timburkethat. it's a general follow-up patch; i probably should have made that more clear19:44
gandersi change the opts on object-server.conf for keep_cache_size and keep_cache_private to true... is there any log or counter to see if this really helps out? I've already restart the object-server daemons but disks are still at 100%19:52
openstackgerritJanie Richling proposed openstack/swift: Symlink API documentation  https://review.openstack.org/41594319:53
*** joeljwright has joined #openstack-swift19:53
*** ChanServ sets mode: +v joeljwright19:53
jrichliok, sphinx builds with this now locally, so it should do the trick now. ^^19:53
*** ganders has quit IRC19:56
*** sgundur_ has quit IRC20:09
claygi guess ganders had to bolt :\20:12
claygwho do I gripe at these days about EC bugs with?  just acoles & kota?20:13
jrichliI am interested in learning more about EC, if that counts :-).  Seems like I remember sgundur saying the same20:14
claygyeah seems like folks love them some ec!20:15
claygi just sort of remember when we were fighting the ssync protocol early disconnect fragment metadata corruption bug someone pointed out how EC dark data has this weird property of generating un-reconstructable forever "durable" fragments that we never clean up20:17
clayg... then i see lp bug #165560820:17
openstackLaunchpad bug 1655608 in OpenStack Object Storage (swift) "reconstructor tries to reconstruct a deleted object from an orphan fragment" [Undecided,New] https://launchpad.net/bugs/165560820:17
claygso i guess we said it and never wrote it down :\20:18
claygmake it hard to keep track of what we're supposed to be working on!20:18
claygtdasilva: lol @ "just send the zero-byte etag" -> lp bug #151657920:20
openstackLaunchpad bug 1516579 in OpenStack Object Storage (swift) "PUTing a 0-byte object and supplying an Etag results in a 503 response" [High,Fix committed] https://launchpad.net/bugs/1516579 - Assigned to Samuel Merritt (torgomatic)20:20
claygat least it's fixed now ;)20:20
*** sgundur_ has joined #openstack-swift20:26
*** asettle has joined #openstack-swift20:29
*** asettle has quit IRC20:33
*** asettle has joined #openstack-swift20:33
openstackgerritMerged openstack/swift: For any part, only one replica can move in a rebalance  https://review.openstack.org/34647520:34
*** asettle has quit IRC20:38
mattoliverauMorning20:45
joeljwrightmorning20:46
*** bkeller` has joined #openstack-swift20:50
*** m_kazuhiro has joined #openstack-swift20:52
*** silor has quit IRC20:52
*** arch-nemesis has joined #openstack-swift20:54
claygman I am super pumped about that min_part_hours = 0 fix!?20:54
claygcc swifterdarrell torgomatic ^ look no more fighting with min_part_hours after full replication dispersion cycle!20:55
openstackgerritTim Burke proposed openstack/swift: Tighten the move-one-replica test  https://review.openstack.org/41910720:56
* clayg has a few clusters that are sorta small and a small gradual weight change can finish quickly :D20:58
cschwedewhoa, that's great that this patch merged!20:59
notmynameswift team meeting time in #openstack-meeting20:59
*** acoles_ is now known as acoles21:00
kota_morning21:01
*** jamielennox|away is now known as jamielennox21:01
openstackgerritJanie Richling proposed openstack/swift: Symlink implementation.  https://review.openstack.org/23216221:03
acolesclayg: I assumed trhat was going to be a duplicate bug report. did we not write one after/in Barcelona?21:06
cschwedenotmyname: thx for starting at the bottom in the swift meeting b/c of timezones - appreciated!21:06
acolesclayg: i guess not21:06
claygis it wednesday?21:07
claygdid I already miss the meeting?21:07
notmynameindeed it is21:07
mattoliverauits going now21:08
notmynamejust talking about you in there21:08
acolesonovy: pls give our congrats to Pavel :)21:14
onovyacoles: yep :)21:15
*** winggundamth has quit IRC21:19
jrichliI need the last patchset to patch 232162 to be removed.  Anyone know how to do that?21:19
patchbothttps://review.openstack.org/#/c/232162/ - swift - Symlink implementation.21:19
*** asettle has joined #openstack-swift21:21
timburkejrichli: just drop it back to 44? i think something like `git review -d 232162,44 && git review` should work21:22
timburkeit'll still be another patchset, but w/e21:23
jrichliok.  i just wondered if we could just blow it away altogether for a cleaner history, but thats ok21:23
acolesclayg: isn't the race...X sees no hashes.pkl so doesn't bother writing the invalidation, while Y was about to write hashes.pkl?21:26
claygacoles: +100 simple obvious LBYL race - needs to be restructored - never abandon the log - the log is rule!21:28
claygsimilarlly to patch 219165 - I want to do some reviews in the next few days - as always I'm particuarlly interested in patches that have been open for a long time and are ready to merge21:34
patchbothttps://review.openstack.org/#/c/219165/ - swift - EC Fragment Duplication - Foundational Global EC C...21:34
claygtdasilva: timburke: acoles: cschwede: tdasilva: jrichli ^ anything else come to mind?21:34
*** Jeffrey4l_ has joined #openstack-swift21:34
*** asettle has quit IRC21:34
*** Jeffrey4l has quit IRC21:35
tdasilvaclayg: the part power increase patch from cschwede would be great21:35
notmynamem_kazuhiro: ok, just give me your trello id and I'll add you21:36
tdasilvaclayg: i left some questions for you on some of the trello cards, if you have a chance, can you take a look?21:37
m_kazuhironotmyname: thank you. I'm just making my trello id.21:37
timburkeclayg: https://review.openstack.org/#/c/299225/21:37
patchbotpatch 299225 - swift - Treat invalid limit parameters as errors21:37
tdasilvaclayg, timburke: on the override-etag, i started looking and it seems like it would require a change to support adding params to that header? I was wondering if it could be done separately from the symlink patch? and if someone could help me?21:38
timburkeor https://review.openstack.org/#/c/390901/21:38
patchbotpatch 390901 - swift - Confirm receipt of SLO PUT with etag21:39
timburketdasilva: it would? i thought it just sent whatever the value was. i'll look into it a bit21:40
tdasilvatimburke: maybe i'm mistaken, but i was comparing to the content-type header and how it needs to parse the swift_bytes param21:40
tdasilva?21:41
m_kazuhironotmyname: I finished to making my id. My trello id is 'm_kazuhiro'.21:41
tdasilvatimburke: i might not be understanding well what needs to be done.21:41
notmynamem_kazuhiro: great. I added you21:41
m_kazuhironotmyname: thank you. I confirmed that I'm in openstack swift trello team.21:44
timburketdasilva: as i recall, it's only a limitation on content-type, as enforced at https://github.com/openstack/swift/blob/@{2017-01-11}/swift/proxy/controllers/obj.py#L78-L8521:46
timburkebah, maybe should've %-encoded that21:47
timburkehttps://github.com/openstack/swift/blob/@%7B2017-01-11%7D/swift/proxy/controllers/obj.py#L78-L8521:47
*** vint_bra has quit IRC21:52
claygonovy: there's not like some debuild magic I don't know about with the "package locking" - it's just like "python-pyeclib Requries liberasurecode == x.y.z" in it's control21:54
onovyit's just == x.y.z21:54
onovynothing more21:54
onovyso i will build two packages21:54
onovyliberasurecode 1.0.021:55
claygand then when you want to package a new liberasure code you check in updates to liberasurecode's deb source, and package that; then check in changes to pyeclib's deb source and package that ...21:55
onovyand python-pyeclib with depends on liberasurecode=1.0.021:55
onovyi will build this two packages at same time21:55
onovyfrom one source21:55
onovybecause you will have only one repo21:55
onovyit's simple :) i want to21:55
onovy1. offer liberasurecode lib for C21:56
onovy2. offer python wrapper for Python world21:56
onovyyou want:21:56
onovy1. have one repo21:56
onovy2. release both at same time21:56
onovyso i will have21:56
onovy1. one source package21:56
onovy2. two binary package21:56
timburkejoeljwright: that's why i was thinking etag, since the symlink target must be set on PUT -- shouldn't have the same issues that come up with tweaking content-type21:56
onovybut i don't want to have duplicity in liberasure and python wrapper binary package21:57
onovySO for me it's ideal to dynamic link python wrapper to liberasurecode C lib21:57
onovyand i will add deps which say: liberasurecode must be same version and python wrapper21:57
onovybecause someone will add 3. offer go wrapper for GoLang world21:58
claygonovy: why do you want liberasurecode c library - who wants that?  who uses that?  how can they!?  it's so volitle still...21:58
onovyand that go wrapper will use liberasurecode too21:58
mattoliverautimburke: we could use the deleted field, it's an int, and we are only using 0 and 1. So a link could be link a 2.. although it would then be good if the field was called something like status rather then deleted. But that would mean no extra storage and miminal changes to code21:58
timburkeonovy: ...and that will become even more important for you when we have go bindings, yeah?21:58
onovytimburke: yep21:58
onovyand another lang binding and another...21:58
onovyclayg: i don't think anybody is using it NOW21:58
notmynameclayg: IIRC others have been interested in using liberasurecode. ie any project that "just" uses C. IIRC, even ceph (c++) was looking at using it21:58
clayggood - let's never let them - it just sounds like more work for us - let the fork21:59
timburkemattoliverau: that wasn't all i was thinking of storing :-) may as well put the whole target in there21:59
notmynameclayg: or at least that was talked about21:59
onovyliberasurecode121:59
onovy  Reverse Depends: liberasurecode-dev (= 1.4.0-1)21:59
onovy  Reverse Depends: python-pyeclib (>= 1.4.0-2)21:59
onovy  Reverse Depends: python3-pyeclib (>= 1.4.0-2)21:59
claygReverse Depends - interesting21:59
mattoliverautimburke: oh right, like an ls -l shows where it's pointing to21:59
onovyso in your solution there will be duplicity between py2 and py3 wrapper21:59
onovyin my there will be almost no duplicty21:59
onovyclayg: no, it's not work for you22:00
onovyABI is volatile, Torvalds says that.22:00
onovy:)22:00
claygthe only that appears to get simpler if we just compile the binary bits into the python binding .so (instead of a dynamic handle to some shared library installed seperately)22:00
onovyso just break liberasurecode ABI, don't worry about it22:00
mattoliverautimburke: because you don't know the size of the link string, should you use some sysmeta or are you thinking of using etag field (seeing as it should always be a zero-byte file)22:00
claygis that we can bump our requirements in the gate anytime we want - or in dev - and developers don't have to think about `sudo make install`22:01
timburkeonovy: won't there still be the duplicity of *all the python files*? it's unavoidable for py vs. go, but our py2 & py3 code should be *the same code*22:01
onovyclayg: so if i install py2+py3+go wrapper i will get 3 copy of same code22:01
claygonovy: wfm!22:01
onovytimburke: yep, that's "how it works now for py2+py3" :]22:01
patchbotError: Spurious "]".  You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands.22:01
mattoliveraui.e if delete == 2, etag == link string.22:01
onovyclayg: i think ideal is to have statically linked liberasurecode for pip and dynamical for distros22:02
openstackgerritJanie Richling proposed openstack/swift: Symlink implementation.  https://review.openstack.org/23216222:02
timburkemattoliverau: ugh. i think i still prefer the idea of etag == <actual etag>;swift_symlink_target=a/c/o22:02
claygonovy: you just blew my mind22:02
onovy:)22:03
joeljwrighttimburke: I see why... that makes some sort of sense22:03
timburkeonovy: i can get behind that. not sure how to make it happen though :-( guess i need to learn more about python c extensions22:03
onovytimburke: i don't know too22:03
onovybut it should be possible22:03
claygonovy: also the asnwer might be more obvious if some interested party tried to write golang bindings for libec - I know golang has previoulsy had some opinons on static linking ....22:03
timburkeonovy: that's why i ended hopeful :-)22:04
mattoliverautimburke: etag of the symlink I guess? I see, that will be confusing for json/xml listing and existing clients, but I guess anyway you swing it, it'll be hard for em.22:04
timburkejoeljwright: mattoliverau: and if need be, we can have the container server pull it out (like we already do for swift_bytes) and stuff it in a separate key22:04
claygonovy: thanks again for your input on this22:04
onovyclayg: don't know how it's working inside golang sry22:04
mattoliverauahh22:04
*** sgundur_ has quit IRC22:04
onovyclayg: ok, let's summarize it?22:05
*** sgundur_ has joined #openstack-swift22:05
*** sams-gleb has quit IRC22:05
onovyyou want package for pip, without binary deps. install it anywhere, ...22:05
tdasilvatimburke: i need to run, but will try to catch up with you tomorrow22:05
onovyso liberasurecode should be embedded for this king of distributions22:05
*** sams-gleb has joined #openstack-swift22:06
onovy*kind22:06
onovyembedded=statically linked inside python_c binding22:06
onovythis is how it was22:07
onovyliberasurecode was embbeded at pypi22:07
clayghow it ... was?22:07
onovyin old version, if i remember correctly22:07
acolestimburke: (i'm playing catch up...) if we embed the symlink target in container listing, are we sure it will never, ever change with a POST?22:08
claygonovy: in old version it was *insane* - it was still dynamic AIUI - but like setup.py would randomly just start connecting to the internet and downloading things and running commands if the headers weren't around?22:08
onovyright22:09
kota_onovy: maybe not statically linking but exactly keep the liberasurecode tar ball inside in pyeclib repo.22:09
onovythat's black magic we don't want22:09
onovykota_: yep. but you don't want to break locally installed liberasurecode (from distros), so static link is better imho22:09
kota_onovy: yup, *in the future*22:10
*** sams-gleb has quit IRC22:10
onovyso let's build static linked python_c with liberasurecode when installed from pypi22:10
onovythat's fine22:10
onovybut for distros, use dynamic linking and offer liberasurecode for C devs22:11
onovyso let's do it same way as now for distros :)22:12
onovyjust imagine liberasurecode will be ~10MB library22:12
onovyi don't want to have it twice, one for py2 and one for py322:12
onovyand again for go, and again for PHP, and ...22:12
*** sgundur- has joined #openstack-swift22:13
kota_sounds reasonable to me22:14
timburkeacoles: we'll already be enforcing that it be a zero-byte object, so requiring a PUT to change targets shouldn't be onerous on clients -- there's no data to move either way. we already have the target recorded in *sysmeta*; if we start letting *that* change on POST, it seems like we'll have a whole host of other things breaking (or potentially breaking).22:14
timburkeseems like the only hangup would be our own resolve to not subsequently allow it to be stuffed into transient-sysmeta or something, which we should never do because we'll already have data on-disk in non-transient-sysmeta22:14
onovyif it's possible (simple)22:14
kota_yes, if it's possible22:14
onovyi can patch it in packing, that's possible too, but i don't prefer this solution22:15
onovybecause there is more distros, not only debian packages :]22:15
patchbotError: Spurious "]".  You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands.22:15
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873622:15
onovypatchbot: blah, ignore me pls!22:15
onovybtw: and stable/unstable ABI. Every upstream breaks ABI (really) often. Distros knows it, and have are using ABI bump for it22:16
onovyand we are...22:16
timburkeonovy: ugh. is it really so big? i really hope not...22:17
onovyideally upstream indicate this breaking ABI change, for example with major version bump. But every packager is checking this22:17
onovytimburke: "so big"? you mean often ABI bumps?22:17
timburkeno no :-) the 10MB. i understand that ABI bumps are a big deal for dynamically linked libraries22:18
onovytimburke: just __imagine__ :]22:18
patchbotError: Spurious "]".  You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands.22:18
onovy-rw-r--r--   1 onovy onovy  56K Dec 29 14:31 liberasurecode.so.1.4.022:19
onovy~ 112K all of them22:19
timburkeyeah; still not exactly trivial. but if we ever let this thing balloon to the MB range i'll be very mad :-)22:20
onovyit's not about size now, but about principle how distros is doing this22:20
onovyfor example we are removing embedded jquery and replacing it with deps22:21
* kota_ is away sorry, will take a look the log about packagin discussion for pyeclib/liberasurecode22:22
onovyto be honest, i would like to go to bed22:23
*** m_kazuhiro has quit IRC22:23
timburkedo it! i think we all have a better understanding of what should be done and why because of your helpful explanations :-)22:24
onovythanks :) let's continue later. gn22:25
notmynameonovy: thanks, as always, for helping out :-)22:25
*** sgundur_ has left #openstack-swift22:28
*** bkeller` has quit IRC22:32
*** geaaru has quit IRC22:34
acolestimburke: ah, target link is in sysmeta, of course. thank you , I will now sleep easier :)22:48
*** acoles is now known as acoles_22:49
*** catintheroof has quit IRC22:50
openstackgerritClay Gerrard proposed openstack/swift: Fix race in new partitions detecting new/invalid suffixes.  https://review.openstack.org/41869022:51
*** catintheroof has joined #openstack-swift22:51
*** chlong has quit IRC22:55
*** catintheroof has quit IRC22:55
*** joeljwright has quit IRC22:59
*** tqtran has quit IRC23:17
*** arch-nemesis has quit IRC23:22
*** tqtran has joined #openstack-swift23:29
*** klamath has quit IRC23:35
*** chsc has quit IRC23:35
*** vint_bra has joined #openstack-swift23:50
*** dpak has joined #openstack-swift23:56
*** kei_yama has joined #openstack-swift23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!