*** mmotiani_ has quit IRC | 00:01 | |
*** david-lyle has joined #openstack-swift | 00:09 | |
*** mmotiani_ has joined #openstack-swift | 00:15 | |
*** mmotiani_ has quit IRC | 00:17 | |
*** JimCheung has joined #openstack-swift | 00:20 | |
*** david-lyle has quit IRC | 00:20 | |
*** klamath has quit IRC | 00:21 | |
*** sams-gleb has joined #openstack-swift | 00:24 | |
*** sams-gleb has quit IRC | 00:28 | |
*** JimCheung has quit IRC | 00:29 | |
*** JimCheung has joined #openstack-swift | 00:38 | |
*** JimCheung has quit IRC | 00:46 | |
*** JimCheung has joined #openstack-swift | 00:47 | |
*** JimCheung has quit IRC | 00:47 | |
*** tonanhngo has quit IRC | 00:48 | |
*** _JZ_ has quit IRC | 00:51 | |
*** notmyname has quit IRC | 00:57 | |
*** tonanhngo has joined #openstack-swift | 00:58 | |
*** notmyname has joined #openstack-swift | 01:01 | |
*** ChanServ sets mode: +v notmyname | 01:01 | |
*** tonanhngo has quit IRC | 01:02 | |
*** jamielennox is now known as jamielennox|away | 01:07 | |
*** mmotiani_ has joined #openstack-swift | 01:07 | |
notmyname | mattoliverau: quick ansible question. the yaml files are all k/v pairs. so how can I designate a value to be a string specifically? | 01:10 |
---|---|---|
notmyname | mattoliverau: that is, I'm using the replace module, and I want the regexp given to be a literal string | 01:10 |
mattoliverau | the value can just be a string right, or am I miss understanding your question? | 01:11 |
clayg | jrichli: I'm not sure it can't be > - I think it's *normally* equall - but like... what about for revert jobs that don't have frag_indexes (tombstone only) doesn't they still have multiples? ec_duplication can also have a revert job with multiple primaries. I like >= | 01:11 |
notmyname | mattoliverau: the regexp line is a regular expression. but the line I want to modify starts with # and has $ in it. (mostly I want to uncomment some lines in a file) | 01:12 |
notmyname | mattoliverau: so I get a TypeError from ansible | 01:13 |
openstackgerrit | Tim Burke proposed openstack/liberasurecode master: Use preprocessor to build test suites https://review.openstack.org/431794 | 01:13 |
timburke | kota_: ^^^ let me know if shss actually passes test_decode_with_missing_parity and test_get_fragment_metadata -- i'd be perfectly happy to move that to use TEST_SUITE, too | 01:13 |
*** neonpastor has quit IRC | 01:19 | |
*** dmorita has quit IRC | 01:19 | |
*** dmorita has joined #openstack-swift | 01:20 | |
*** jamielennox|away is now known as jamielennox | 01:21 | |
notmyname | mattoliverau: I think I got it. adding single quotes makes it work | 01:23 |
mattoliverau | oh right ok | 01:23 |
*** tqtran has quit IRC | 01:23 | |
*** dmorita has quit IRC | 01:41 | |
*** dmorita has joined #openstack-swift | 01:42 | |
*** delattec has quit IRC | 01:44 | |
kota_ | good morning | 01:51 |
kota_ | timburke: with patch 431794 ? | 01:52 |
patchbot | https://review.openstack.org/#/c/431794/ - liberasurecode - Use preprocessor to build test suites | 01:52 |
* kota_ is at office a bit late due to that, i took enough rest. | 01:53 | |
openstackgerrit | Daniel Axtens proposed openstack/liberasurecode master: ISA-L: free matrix on exit https://review.openstack.org/431812 | 02:21 |
*** winggundamth has joined #openstack-swift | 02:23 | |
* dja = Daniel Axtens if anyone wants to talk about the change | 02:23 | |
jrichli | clayg: you may have misunderstood what I meant. The code loop changed. It used to be able to be >. But as it is now after the merge to master, that syncd_with will not be incremented more then len(job['sync_to']) times. | 03:06 |
openstackgerrit | Daniel Axtens proposed openstack/liberasurecode master: ISA-L: Only calculate gf tables on init, not every encode https://review.openstack.org/431850 | 03:09 |
jrichli | the loop used to be over dest_nodes, so the syncd_with could be incremented in the loop more than len(job['sync_to']) times | 03:09 |
jrichli | dest_nodes included other handoffs | 03:12 |
jrichli | ah, well with the old code, once it reached >= in the loop, it did break out. so it isn't that alone that made the difference. | 03:20 |
jrichli | it was just that before, there were more successful loops having the nodes from get_more_nodes to compensate for the down primary. | 03:21 |
jrichli | as it is written now, if not all the ssync calls are successful, then delete_reverted_objs will not be called. Is that the desired behavior? | 03:24 |
jrichli | in the past ... there was a buffer of the number of nodes returned from get_more_nodes. you could have that many failed ssync calls and still call delete_reverted_objs. | 03:25 |
jrichli | and the case you mentioned : the "revert jobs that don't have frag_indexes (tombstone only)" is the case that no longer causing that condition to be true. | 03:28 |
jrichli | so if we need to call for that case, then there are changes to make | 03:28 |
jrichli | the problem is for me, I don't really understand what the desired behavior is : what exactly are we looking for to tell us that we need to call delete_reverted_objs? | 03:31 |
*** links has joined #openstack-swift | 03:50 | |
*** mmotiani_ has quit IRC | 04:09 | |
*** SkyRocknRoll has joined #openstack-swift | 04:13 | |
*** psachin has joined #openstack-swift | 04:14 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements https://review.openstack.org/88736 | 04:21 |
*** dmorita has quit IRC | 04:58 | |
*** klrmn has quit IRC | 04:59 | |
*** cebreidian has quit IRC | 05:03 | |
*** klrmn has joined #openstack-swift | 05:04 | |
*** cebreidian has joined #openstack-swift | 05:05 | |
kota_ | jrichli, clayg: I'm not sure right now but I have been wondering if the https://github.com/openstack/swift/blob/master/swift/obj/reconstructor.py#L769-L772 could be sync (not revert) the .ts file from handoffs to primary? | 05:27 |
kota_ | s/could be sync/could sync/ | 05:28 |
kota_ | i may be wrong | 05:29 |
jrichli | kota_: interesting. that is a whole new area of the reconstructor code that I will need to grok. I think I will have to do that in the morning. let me know if you | 05:54 |
jrichli | have more discoveries | 05:55 |
*** dja has quit IRC | 05:55 | |
kota_ | jrichli: sure, I'm interested in the discussion always sorry, I had no time to deep dive. | 05:55 |
*** tqtran has joined #openstack-swift | 06:05 | |
*** tqtran has quit IRC | 06:10 | |
clayg | derpy derp | 06:11 |
clayg | jrichli: we should call delete_reverted_objs when we successfully sync'd to the primaries; we used to sync to other places like nutters (and even had probe test to prove how crazy we were apparently) | 06:15 |
clayg | jrichli: desired behavior if the primary is down is for the handoff to hold the parts until it can contact the primary | 06:15 |
clayg | jrichli: change the probetest | 06:16 |
*** sams-gleb has joined #openstack-swift | 06:32 | |
*** sams-gleb has quit IRC | 06:36 | |
*** klrmn has quit IRC | 06:48 | |
*** dmorita has joined #openstack-swift | 06:58 | |
openstackgerrit | Tim Burke proposed openstack/swift master: part_power followup https://review.openstack.org/432143 | 07:00 |
*** dmorita has quit IRC | 07:02 | |
*** rcernin has joined #openstack-swift | 07:03 | |
openstackgerrit | Janie Richling proposed openstack/swift master: Fix test_delete_propagate probe test https://review.openstack.org/432147 | 07:12 |
*** Jeffrey4l__ has joined #openstack-swift | 07:29 | |
*** pcaruana has joined #openstack-swift | 07:30 | |
*** Jeffrey4l_ has quit IRC | 07:30 | |
clayg | jrichli: nice!? | 07:32 |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Ignore cache files when comparing synced parts https://review.openstack.org/432156 | 07:35 |
clayg | tdasilva: jrichli: no one had fixed the hashes.invalid with rsync one yet right ^ | 07:35 |
*** foexle has joined #openstack-swift | 07:45 | |
openstackgerrit | Clay Gerrard proposed openstack/swift master: follow-up: probetests are a story https://review.openstack.org/432162 | 07:55 |
clayg | jrichli: ^ maybe squash? | 07:55 |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Fix test_delete_propagate probe test https://review.openstack.org/432147 | 07:59 |
*** sams-gleb has joined #openstack-swift | 08:03 | |
*** Jeffrey4l__ has quit IRC | 08:21 | |
*** Jeffrey4l__ has joined #openstack-swift | 08:22 | |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Deprecate broken handoffs_first in favor of handoffs_only https://review.openstack.org/425493 | 08:32 |
clayg | jrichli: I still didn't write that test like you told me too - so lazy | 08:32 |
*** foexle has quit IRC | 08:33 | |
*** rledisez has joined #openstack-swift | 08:37 | |
*** geaaru has joined #openstack-swift | 08:39 | |
*** jordanP has joined #openstack-swift | 08:48 | |
*** joeljwright has joined #openstack-swift | 08:48 | |
*** ChanServ sets mode: +v joeljwright | 08:48 | |
*** peterlisak has quit IRC | 09:01 | |
*** onovy has quit IRC | 09:01 | |
*** Shashikant86 has joined #openstack-swift | 09:09 | |
*** peterlisak has joined #openstack-swift | 09:14 | |
*** onovy has joined #openstack-swift | 09:16 | |
*** cbartz has joined #openstack-swift | 09:21 | |
*** Shashikant86 has quit IRC | 09:23 | |
*** tqtran has joined #openstack-swift | 10:08 | |
*** tqtran has quit IRC | 10:12 | |
*** openstackgerrit has quit IRC | 10:18 | |
*** dmorita has joined #openstack-swift | 10:19 | |
*** dmorita has quit IRC | 10:23 | |
*** winggundamth has quit IRC | 10:31 | |
*** Shashikant86 has joined #openstack-swift | 10:33 | |
*** Shashikant86 has quit IRC | 10:49 | |
mahatic | kota_: do you happen to be around | 10:54 |
kota_ | mahatic: hello | 10:54 |
mahatic | kota_: hi! | 10:54 |
kota_ | what's up? | 10:55 |
mahatic | kota_: quick question - here's my config for patch 219165 http://paste.openstack.org/show/598374/ | 10:56 |
patchbot | https://review.openstack.org/#/c/219165/ - swift - EC Fragment Duplication - Foundational Global EC C... | 10:56 |
kota_ | k | 10:56 |
mahatic | it throws an error "ERROR: Invalid Storage Policy Configuration in /etc/swift/swift.conf (Invalid option 'ec_duplication_factor' in storage-policy section, for index '2') | 10:56 |
patchbot | Error: No closing quotation | 10:56 |
mahatic | " | 10:56 |
patchbot | Error: No closing quotation | 10:56 |
*** sams-gleb has quit IRC | 10:56 | |
mahatic | kota_: did I miss any other config? | 10:57 |
*** sams-gleb has joined #openstack-swift | 10:57 | |
kota_ | mahatic: it looks correct | 10:57 |
mahatic | prior to your patch, regular object PUT on EC works | 10:57 |
kota_ | mahatic: do you run the swift my patch applied? | 10:58 |
mahatic | yeah, I'm on your patch and running that config | 10:58 |
kota_ | let me make sure the env | 10:59 |
kota_ | with "ec_duplication_factor = 1" works? | 10:59 |
kota_ | not commented out, specify clearly as 1 | 11:00 |
kota_ | i mean | 11:00 |
*** Jeffrey4l__ has quit IRC | 11:00 | |
*** Jeffrey4l__ has joined #openstack-swift | 11:01 | |
kota_ | the error looks like argument checks in the EC policy if we add the not supported keyword in the config, that error should occur | 11:01 |
*** sams-gleb has quit IRC | 11:01 | |
mahatic | right | 11:01 |
mahatic | duplication_factor 1 also throws the same error | 11:02 |
kota_ | hmm, in my env, i cannot repro that | 11:03 |
kota_ | the ec_duplication_factor was accepted in my env with the patch. | 11:04 |
kota_ | so i think your swift refers older package, maybe? | 11:05 |
mahatic | yeah I'm checking that | 11:05 |
mahatic | must be something like that | 11:05 |
mahatic | kota_: are you referring to any specific package? | 11:06 |
kota_ | mahatic: i may not get the mean correctly but maybe my answer is no | 11:07 |
mahatic | :) | 11:07 |
*** Shashikant86 has joined #openstack-swift | 11:07 | |
kota_ | mahatic: i have development package in my box and if i want to change it, re-install my dev code to the my python env. | 11:07 |
mahatic | kota_: ah okay | 11:08 |
kota_ | i don't tend to depend on specific package, frequently I changes my env with dev code. As well as that, my env is now the patch | 11:09 |
kota_ | now on | 11:09 |
mahatic | kota_: yeah sure. I'm also on your patch. But it's weird that some old pkg could have that effect | 11:12 |
kota_ | mahatic: python -c "import swift; print(swift.__path__)" | 11:12 |
kota_ | it shows the swift you refers | 11:12 |
kota_ | swift path | 11:12 |
mahatic | kota_: yeah, it refers to where swift is installed in my dev | 11:13 |
mahatic | in my case ['/home/mahati/swift/swift'] | 11:13 |
kota_ | is it not swift vagrant box? | 11:14 |
mahatic | kota_: oh no. I already had 8 devices setup via the plain saio. I'm reusing that | 11:15 |
kota_ | ok, it's saio not vagrant box | 11:16 |
kota_ | my vagrant box (and my dev env) shows ['/usr/local/lib/python2.7/dist-packages/swift'] | 11:17 |
mahatic | kota_: meh. I had rerun the setup | 11:27 |
mahatic | kota_: Other question I had was, should I update my ring as well? | 11:27 |
mahatic | kota_: nevermind. changing duplication_factor 2 works | 11:29 |
mahatic | kota_: thanks | 11:29 |
*** dmorita has joined #openstack-swift | 11:31 | |
mahatic | cool, I see expected duplicate fragments | 11:34 |
*** dmorita has quit IRC | 11:35 | |
*** xlucas has quit IRC | 11:44 | |
*** sams-gleb has joined #openstack-swift | 11:48 | |
*** sams-gle_ has joined #openstack-swift | 11:49 | |
*** tesseract has joined #openstack-swift | 11:50 | |
kota_ | mahatic: sounds good, sorry I was tied up to answer for a question from my co-worker in f2f | 11:50 |
mahatic | kota_: no problem, have a nice weekend! Isn't it late already? | 11:52 |
*** sams-gleb has quit IRC | 11:53 | |
kota_ | mahatic: yeah, I'm still at office and it seems I am running out of time to stay :/ | 11:55 |
*** bkopilov has quit IRC | 11:55 | |
*** bkopilov_ has quit IRC | 11:55 | |
kota_ | mahatic: if you have any question or find a bug, please feel free to report at the gerrit. | 11:55 |
*** caiobrentano has joined #openstack-swift | 11:55 | |
*** sams-gleb has joined #openstack-swift | 11:56 | |
*** sams-gl__ has joined #openstack-swift | 11:58 | |
*** sams-gle_ has quit IRC | 11:59 | |
mahatic | kota_: sure. thanks for the help. and go home! ;) | 12:00 |
kota_ | ;) | 12:00 |
*** sams-gleb has quit IRC | 12:02 | |
*** silor has joined #openstack-swift | 12:04 | |
*** cdelatte has joined #openstack-swift | 12:08 | |
*** bkopilov has joined #openstack-swift | 12:10 | |
*** bkopilov_ has joined #openstack-swift | 12:11 | |
*** silor1 has joined #openstack-swift | 12:16 | |
*** silor has quit IRC | 12:16 | |
*** silor1 is now known as silor | 12:16 | |
*** xlucas has joined #openstack-swift | 12:29 | |
*** dmorita has joined #openstack-swift | 12:43 | |
*** dmorita has quit IRC | 12:47 | |
*** Shashikant86 has quit IRC | 12:48 | |
*** Shashikant86 has joined #openstack-swift | 12:54 | |
*** Shashikant86 has quit IRC | 12:58 | |
*** caiobrentano has quit IRC | 13:16 | |
*** cebruns has quit IRC | 13:16 | |
*** caiobrentano has joined #openstack-swift | 13:16 | |
*** cebruns has joined #openstack-swift | 13:26 | |
*** links has quit IRC | 13:55 | |
*** dmorita has joined #openstack-swift | 13:55 | |
mahatic | kota_: I may not be able to get to the patch completely today. I maybe able to post a review by Monday though | 13:57 |
kota_ | mahatic: np | 13:57 |
mahatic | It might already have more reviews by then though | 13:57 |
kota_ | mahatic: and thanks for reviewing | 13:57 |
mahatic | kota_: sure np. great work! | 13:57 |
*** dmorita has quit IRC | 13:59 | |
kota_ | mahatic: have a nice weekend ;-) | 14:01 |
*** Shashikant86 has joined #openstack-swift | 14:02 | |
*** sanchitmalhotra has quit IRC | 14:10 | |
*** sanchitmalhotra has joined #openstack-swift | 14:10 | |
*** Shashikant86 has quit IRC | 14:14 | |
*** _JZ_ has joined #openstack-swift | 14:14 | |
*** klamath has joined #openstack-swift | 14:29 | |
*** Dw_Sn has joined #openstack-swift | 14:38 | |
Dw_Sn | Hello, I am trying to limite simultaneous upload and download , can that be done via swift proxy ? | 14:39 |
*** sams-gl__ has quit IRC | 14:41 | |
*** sams-gleb has joined #openstack-swift | 14:42 | |
*** _JZ_ has quit IRC | 14:42 | |
*** sams-gleb has quit IRC | 14:46 | |
*** sams-gleb has joined #openstack-swift | 14:59 | |
notmyname | Dw_Sn: no. you can ratelimit based on writes/second (API operations) and based on how big a container is. those are designed to help you protect the cluster from certain expensive operations. if you want eg ratelimiting based on data rates, probably best to do that in a load balancer | 15:19 |
*** dmorita has joined #openstack-swift | 15:23 | |
*** dmorita has quit IRC | 15:27 | |
*** dims_ has quit IRC | 15:28 | |
*** dims has joined #openstack-swift | 15:33 | |
*** chsc has joined #openstack-swift | 15:46 | |
*** chsc has joined #openstack-swift | 15:46 | |
*** dims has quit IRC | 15:55 | |
*** dims has joined #openstack-swift | 15:55 | |
*** dims is now known as Guest12406 | 15:56 | |
Dw_Sn | notmyname: thanks :) I think I will setup nginx infront of the swiftproxy :) | 16:01 |
*** klrmn has joined #openstack-swift | 16:05 | |
*** Guest12406 has quit IRC | 16:05 | |
*** glb has left #openstack-swift | 16:05 | |
*** Shashikant86 has joined #openstack-swift | 16:06 | |
*** rcernin has quit IRC | 16:06 | |
*** glb1 has left #openstack-swift | 16:07 | |
*** glb has joined #openstack-swift | 16:07 | |
*** Dw_Sn has quit IRC | 16:09 | |
*** openstackgerrit has joined #openstack-swift | 16:10 | |
openstackgerrit | Janie Richling proposed openstack/swift master: Fix test_delete_propagate probe test https://review.openstack.org/432147 | 16:10 |
jrichli | clayg: squashed and now going through your comments. thanks! as for test with hashes.invalid with rsync, I have not started. will check with tdasilva. | 16:13 |
tdasilva | jrichli: clayg posted a patch to fix that one, going through it now | 16:13 |
jrichli | oh, I missed that! will look now | 16:13 |
tdasilva | jrichli: https://review.openstack.org/#/c/432156 | 16:13 |
patchbot | patch 432156 - swift - Ignore cache files when comparing synced parts | 16:13 |
*** dims_ has joined #openstack-swift | 16:24 | |
*** amoralej has joined #openstack-swift | 16:30 | |
amoralej | hi swift, do you have any ETA for stable/ocata branch and a new release tag? | 16:32 |
*** bkopilov_ has quit IRC | 16:43 | |
*** bkopilov has quit IRC | 16:43 | |
*** tesseract has quit IRC | 16:45 | |
*** pcaruana has quit IRC | 16:53 | |
timburke | good morning | 17:01 |
*** Shashikant86 has quit IRC | 17:02 | |
notmyname | good morning | 17:06 |
notmyname | amoralej: yes. next week | 17:06 |
notmyname | amoralej: my understanding from the published release schedule is that the deadline is next thursday | 17:07 |
notmyname | so I'm shooting for on or before then | 17:07 |
amoralej | thanks notmyname | 17:08 |
amoralej | yes, final rcs and intermediary deadline is next week | 17:08 |
*** klrmn has quit IRC | 17:09 | |
*** stevemar has left #openstack-swift | 17:10 | |
*** psachin has quit IRC | 17:16 | |
*** _JZ_ has joined #openstack-swift | 17:25 | |
*** rledisez has quit IRC | 17:26 | |
openstackgerrit | Janie Richling proposed openstack/swift master: Ignore cache files when comparing synced parts https://review.openstack.org/432156 | 17:30 |
jrichli | just a rebase ^^ | 17:31 |
jrichli | I was getting some intermittent probetest failures on unrelated areas when testing that one. so i checked the git history and thought it may be good to rebase. | 17:31 |
jrichli | i am running tests again. i just wish probe tests didn't take so long to run altogether! | 17:32 |
jrichli | tdasilva: are you seeing any intermittent probe test failures or flakiness w that patch? (im going to lunch and will see replies later) | 17:38 |
*** JimCheung has joined #openstack-swift | 17:42 | |
*** dmorita has joined #openstack-swift | 17:47 | |
*** jordanP has quit IRC | 17:51 | |
*** cbartz has left #openstack-swift | 17:55 | |
*** tqtran has joined #openstack-swift | 18:03 | |
*** klrmn has joined #openstack-swift | 18:03 | |
clayg | heyoh! | 18:18 |
*** joeljwright has quit IRC | 18:21 | |
*** klrmn has quit IRC | 18:21 | |
clayg | jrichli: what's up with patch 429697 it says it closes lp bug #1662159 | 18:23 |
openstack | Launchpad bug 1662159 in OpenStack Object Storage (swift) "TCP leak between proxy and object-server on client disconnection" [Undecided,New] https://launchpad.net/bugs/1662159 | 18:23 |
patchbot | https://review.openstack.org/#/c/429697/ - swift - Wait for each putter to be done before disconnecti... | 18:23 |
clayg | but that bug is un-confirmed and undecided :'( | 18:23 |
*** tonanhngo has joined #openstack-swift | 18:24 | |
*** klrmn has joined #openstack-swift | 18:27 | |
*** geaaru has quit IRC | 18:36 | |
jrichli | jcaron1: I have tried reproducing the bug clayg just mentioned on my SAIO. I can manage to simulate slow uploads, and then I can see where connections take a very long time to close | 18:46 |
jrichli | but they do close *eventually*. | 18:47 |
jrichli | maybe they should be quicker to close ... I would need to look into that | 18:47 |
jrichli | that is, i make the uploads slow, but the client disconnnect fast | 18:48 |
jrichli | then no new connections are made, but the ones that were already established keep doing their thing | 18:48 |
*** dmorita has quit IRC | 18:50 | |
*** dmorita has joined #openstack-swift | 18:51 | |
tdasilva | jrichli: i have not seen any issues with patch 432156 | 18:52 |
patchbot | https://review.openstack.org/#/c/432156/ - swift - Ignore cache files when comparing synced parts | 18:52 |
jrichli | tdasilva: hmm. maybe that cluster is in a bad state for me now because of some testing. I'll keep looking. | 18:53 |
*** cdelatte has quit IRC | 19:09 | |
*** amandap has joined #openstack-swift | 19:13 | |
*** vint_bra has joined #openstack-swift | 19:19 | |
*** vint_bra has left #openstack-swift | 19:19 | |
*** vint_bra has joined #openstack-swift | 19:26 | |
*** vint_bra has left #openstack-swift | 19:26 | |
*** _JZ_ has quit IRC | 19:27 | |
clayg | sachin has been working on this patch 406012 for awhile - it's really got a number of things going for it! | 19:31 |
patchbot | https://review.openstack.org/#/c/406012/ - swift - Fix swift-get-nodes arg parsing for missing ring | 19:31 |
*** cdelatte has joined #openstack-swift | 19:32 | |
openstackgerrit | Thiago da Silva proposed openstack/swift master: Fix test comment and remove extra parameter https://review.openstack.org/432439 | 19:54 |
*** amoralej is now known as amoralej|off | 20:26 | |
*** amandap has quit IRC | 20:36 | |
clayg | tdasilva: is patch 432439 words correct - is that really the behiavor we want to test? | 20:37 |
patchbot | https://review.openstack.org/#/c/432439/ - swift - Fix test comment and remove extra parameter | 20:37 |
tdasilva | clayg: i went with what's written in lines 83-91 | 20:39 |
tdasilva | clayg: i might be missing something!?!? idk...i was trying to understand the whole test and noticed that those comments didn't seem to match with what's at the top... | 20:40 |
*** silor has quit IRC | 20:41 | |
*** JimCheung has quit IRC | 20:43 | |
clayg | tdasilva: ah, maybe move the lines closer to the actions like we do in newer probetests - that's pretty crazy tho | 20:43 |
clayg | tdasilva: yeah better to keep the comments close to the actions or stuff tends to rot | 20:44 |
tdasilva | clayg: but yeah, i agree that it is testing a weird behavior that I honestly didn't know about | 20:47 |
tdasilva | clayg: but in the end it does test that data gets replicated correctly :) | 20:47 |
*** JimCheung has joined #openstack-swift | 20:59 | |
*** JimCheung has quit IRC | 21:03 | |
*** JimCheung has joined #openstack-swift | 21:09 | |
*** caiobrentano has quit IRC | 21:11 | |
jrichli | i finally got past the intermittent probe test failures. i updated my apt repo and rebuilt tox env. | 21:13 |
*** dmorita has quit IRC | 21:33 | |
clayg | whoa!? apt got involved - you know it's bad | 21:37 |
tdasilva | hehe | 21:39 |
tdasilva | jrichli: i typically just `vagrant destroy -f` and `vagrant up` again | 21:40 |
clayg | anyone feeling "word-smithy" today? | 21:42 |
clayg | mahatic: called me out on patch 425493 that I should add words about handoffs_only in the example conf | 21:42 |
patchbot | https://review.openstack.org/#/c/425493/ - swift - Deprecate broken handoffs_first in favor of handof... | 21:42 |
jrichli | clayg: where is acoles when you need him ;-) he is a master of words | 21:42 |
clayg | ... which is true ... but I'm just not feeling it? I want to just be like "don't use this!? there is no way you're going to get it right. you're so screwed." | 21:42 |
clayg | jrichli: acoles is the master of *all* | 21:44 |
*** dmorita has joined #openstack-swift | 21:45 | |
*** dmorita has quit IRC | 21:46 | |
jrichli | so true! | 21:46 |
clayg | notmyname: hey can anyone edit priority reviews? Can I talk to you about a couple of thing that maybe we can squeeze in to make octocat *amazing* (assuming folks have time) | 21:46 |
notmyname | clayg: yes and yes | 21:46 |
clayg | notmyname: basically we have failing probetests on master - it's mostly my fault | 21:47 |
notmyname | I mean, yeah anyone can edit. I'd prefer that just anyone doesn't, but I'm generally fine with cores editing it (just as long as people know what's up). it's a communication tool, not a set of rules :-) | 21:47 |
notmyname | yeah, we shouldn't have failing probe tests in a release. do you feel terrible about it clayg? ;-) | 21:47 |
clayg | notmyname: plus side! jrichli and tdasilva are here to pick up my mess! | 21:47 |
notmyname | yes. jrichli and tdasilva are fantastic! | 21:48 |
clayg | notmyname: I feel *terrible*!!!! | 21:48 |
notmyname | clayg: well good | 21:48 |
notmyname | ;-) | 21:48 |
notmyname | but jrichli and tdasilva have a fix? | 21:48 |
clayg | so this one https://review.openstack.org/#/c/432147/ and https://review.openstack.org/#/c/432156/ | 21:48 |
patchbot | patch 432147 - swift - Fix test_delete_propagate probe test | 21:48 |
patchbot | patch 432156 - swift - Ignore cache files when comparing synced parts | 21:48 |
tdasilva | notmyname: can we propose a governance proposal to rename this release | 21:49 |
tdasilva | octocat is an awesome name | 21:49 |
notmyname | somehow I think github lawyers might object ;-) | 21:49 |
clayg | i mean it should be basically "confirm clayg sucks; checkout change; run probtest; +2 clayg is moron" | 21:49 |
notmyname | lol | 21:49 |
clayg | i'm working on that currently | 21:49 |
clayg | oh - my bad - once of those is +A'd | 21:50 |
jrichli | :-) | 21:50 |
clayg | *great* so we're back to waiting on me :'( | 21:50 |
jrichli | clayg: It sounds like you need a nice long break this weekend. I hope you have some fun coming up. | 21:51 |
notmyname | clayg: ok, I'll add https://review.openstack.org/#/c/432147/ to the priority reviews page | 21:52 |
patchbot | patch 432147 - swift - Fix test_delete_propagate probe test | 21:52 |
clayg | notmyname: you know what... i'm about to +2 - maybe you can review it and +A ;P | 21:52 |
notmyname | kk | 21:52 |
notmyname | clayg: what about https://review.openstack.org/#/c/425493/? needed any more or not? | 21:53 |
patchbot | patch 425493 - swift - Deprecate broken handoffs_first in favor of handof... | 21:53 |
clayg | notmyname: it's sitll on the priority list - I think everyohne is *trying* to get it landed - but we're running into my sucking again :'( | 21:53 |
notmyname | clayg: have you considered not sucking? | 21:54 |
clayg | IMHO if you try to rebalance EC at scale without a working handoffs_first/only mode you are like I was going to be *so* sad | 21:54 |
jrichli | oh geez | 21:54 |
clayg | but at least we merged the other ones | 21:54 |
* notmyname is lucky clayg sits juuust around the corner and can't throw anything directly at me | 21:55 | |
jrichli | clayg: you need to do this today https://www.youtube.com/watch?v=-DIETlxquzY | 21:55 |
* clayg is glad notmyname has known me long enough that constant digs on me is the only way to keep my ego in check | 21:55 | |
clayg | thanks jrichli that was helpful :D | 21:56 |
*** dmorita has joined #openstack-swift | 21:56 | |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Deprecate broken handoffs_first in favor of handoffs_only https://review.openstack.org/425493 | 22:11 |
clayg | ^ notmyname I'm *trying* | 22:11 |
notmyname | heh | 22:12 |
*** dmorita has quit IRC | 22:14 | |
*** dmorita has joined #openstack-swift | 22:15 | |
clayg | kota_: pyeclib will just return the frag! | 22:25 |
clayg | crap, we're still going to do the read/io regardless tho - we won't know that pyeclib is skipping the math | 22:26 |
notmyname | clayg: FWIW, probe tests didnt' imeediately pass, so may be something going on with my saio. investigating | 22:34 |
*** dmorita has quit IRC | 22:36 | |
jrichli | notmyname: there isn't a version right now where all tests pass at the same time. you'd have to rebase patch 432156 after patch 432147 is merged. | 22:37 |
patchbot | https://review.openstack.org/#/c/432156/ - swift - Ignore cache files when comparing synced parts | 22:37 |
patchbot | https://review.openstack.org/#/c/432147/ - swift - Fix test_delete_propagate probe test | 22:37 |
jrichli | what version are you testing with? | 22:38 |
notmyname | just path 432147 | 22:38 |
notmyname | just patch 432147 | 22:38 |
patchbot | https://review.openstack.org/#/c/432147/ - swift - Fix test_delete_propagate probe test | 22:38 |
notmyname | however, it's failing in new and interesting ways, so I'm investigating | 22:38 |
notmyname | Traceback (most recent call last): | 22:39 |
notmyname | File "/home/swift/swift/test/probe/test_reconstructor_revert.py", line 104, in test_revert_object | 22:39 |
notmyname | self.assertEqual(err.http_status, 507) | 22:39 |
notmyname | AssertionError: 404 != 507 | 22:39 |
jrichli | whoa. ok ... | 22:39 |
notmyname | likely some issue with config or something | 22:40 |
notmyname | yeah. I had mount_check = false in my obj server config | 22:42 |
notmyname | I don't remember why | 22:42 |
jrichli | whew! | 22:43 |
*** jtomasek has quit IRC | 22:43 | |
notmyname | ok, I've confirmed that master fails and the patch passes | 22:44 |
notmyname | so that's a good start :-) | 22:44 |
*** dmorita has joined #openstack-swift | 22:44 | |
jrichli | yay :-) | 22:46 |
openstackgerrit | Tim Burke proposed openstack/liberasurecode master: Make free_rs_cauchy_desc tolerate partially-initialized descriptors https://review.openstack.org/425471 | 22:53 |
timburke | now with a test! | 22:53 |
notmyname | jrichli: clayg: lgtm | 22:55 |
clayg | notmyname: :shipit: | 22:55 |
jrichli | \o/ | 22:55 |
notmyname | :shipitaftertheotherstufflandstoo: | 22:55 |
jrichli | heh | 22:56 |
timburke | now i'm imagining a patient squirrel in a fedora, just kinda loitering... i wonder if he's a spy... | 22:57 |
notmyname | isnt' that one of the other openstack project logos? | 22:58 |
*** jamielennox is now known as jamielennox|away | 22:58 | |
*** chsc has quit IRC | 22:59 | |
*** dmorita has quit IRC | 23:02 | |
*** catintheroof has quit IRC | 23:03 | |
*** catintheroof has joined #openstack-swift | 23:04 | |
*** dmorita has joined #openstack-swift | 23:05 | |
*** dmorita has quit IRC | 23:07 | |
*** dmorita_ has joined #openstack-swift | 23:07 | |
*** catintheroof has quit IRC | 23:08 | |
*** jtomasek has joined #openstack-swift | 23:12 | |
*** sams-gleb has quit IRC | 23:20 | |
*** dmorita_ has quit IRC | 23:26 | |
*** dmorita has joined #openstack-swift | 23:34 | |
*** jamielennox|away is now known as jamielennox | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!