*** rcernin has quit IRC | 00:12 | |
openstackgerrit | Tim Burke proposed openstack/swift master: proxy-server: errors talking to backend servers don't need tracebacks https://review.openstack.org/496965 | 00:12 |
---|---|---|
*** cshastri has joined #openstack-swift | 00:55 | |
*** itlinux has joined #openstack-swift | 00:57 | |
*** eckesicle has quit IRC | 01:01 | |
*** two_tired has joined #openstack-swift | 01:03 | |
*** klrmn has quit IRC | 01:07 | |
*** itlinux has quit IRC | 01:09 | |
*** cshastri has quit IRC | 01:12 | |
*** kiennt has joined #openstack-swift | 01:13 | |
*** cshastri has joined #openstack-swift | 01:13 | |
*** shuyingya has joined #openstack-swift | 01:19 | |
*** vint_bra has joined #openstack-swift | 01:37 | |
*** vint_bra has quit IRC | 01:39 | |
*** klrmn has joined #openstack-swift | 02:23 | |
*** silor has joined #openstack-swift | 03:10 | |
*** links has joined #openstack-swift | 03:18 | |
*** gkadam has joined #openstack-swift | 03:24 | |
*** itlinux has joined #openstack-swift | 03:42 | |
*** rmcall has quit IRC | 03:55 | |
*** rmcall has joined #openstack-swift | 03:57 | |
*** itlinux has quit IRC | 04:00 | |
*** itlinux has joined #openstack-swift | 04:02 | |
*** two_tired has quit IRC | 04:09 | |
*** mkrcmari__ has joined #openstack-swift | 04:22 | |
mahatic | notmyname: thanks for the info on meeting | 04:24 |
* notmyname wonders about that more people respond about *not* meeting than actually attend the meeting | 04:25 | |
notmyname | ;-) | 04:25 |
mahatic | notmyname: lol | 04:27 |
mahatic | well we don't get a special ping for our nicks when there's a meeting ;) | 04:27 |
notmyname | heh | 04:28 |
mahatic | we just show up | 04:28 |
notmyname | I should add that to patchbot or something | 04:28 |
mahatic | I think we're used to the timings by now. I have a reminder on my phone for the meeting though :) | 04:29 |
mahatic | kota_: happy birthday! | 04:30 |
*** gyee has quit IRC | 04:31 | |
*** mvk_ has joined #openstack-swift | 04:45 | |
*** mkrcmari__ has quit IRC | 04:49 | |
*** itlinux has quit IRC | 04:54 | |
zaitcev | I hate Oslo so much. Stupid crapware. | 04:54 |
zaitcev | Gnocchi uses it, unfortunately. As a result, one cannot rebuild gnocchi on a system that happens to have gnocchi installed already, because Oslo's config generator invokes stevedore, and that one ignores PYTHONPATH, loads installed gnocci instead of the one being built, blows up. | 04:55 |
zaitcev | Why did I agree to this | 04:56 |
mattoliverau | zaitcev: :( | 05:10 |
zaitcev | also, never IRC when you're about done and need to sleep | 05:10 |
*** rcernin has joined #openstack-swift | 05:11 | |
*** rcernin has quit IRC | 05:27 | |
*** silor has quit IRC | 05:28 | |
*** silor has joined #openstack-swift | 05:33 | |
*** kiennt has quit IRC | 05:34 | |
*** kiennt has joined #openstack-swift | 05:55 | |
*** kiennt has quit IRC | 06:09 | |
*** rcernin has joined #openstack-swift | 06:12 | |
*** mvk has joined #openstack-swift | 06:12 | |
*** mvk_ has quit IRC | 06:16 | |
*** ChubYann has quit IRC | 06:16 | |
*** pcaruana has joined #openstack-swift | 06:21 | |
*** skudlik has joined #openstack-swift | 06:36 | |
*** klrmn has quit IRC | 06:38 | |
*** joeljwright has quit IRC | 06:45 | |
*** hseipp has joined #openstack-swift | 06:46 | |
*** oshritf has joined #openstack-swift | 07:04 | |
*** hseipp has quit IRC | 07:04 | |
*** cschwede_ has joined #openstack-swift | 07:11 | |
*** tesseract has joined #openstack-swift | 07:20 | |
*** shuyingy_ has joined #openstack-swift | 07:39 | |
*** shuyingya has quit IRC | 07:39 | |
*** cbartz has joined #openstack-swift | 07:39 | |
*** gkadam_ has joined #openstack-swift | 07:40 | |
*** geaaru has joined #openstack-swift | 07:42 | |
*** gkadam has quit IRC | 07:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Imported Translations from Zanata https://review.openstack.org/496137 | 07:42 |
*** gkadam_ has quit IRC | 07:45 | |
*** tesseract-RH has joined #openstack-swift | 07:49 | |
*** tesseract-RH has quit IRC | 07:50 | |
*** tesseract-RH has joined #openstack-swift | 07:50 | |
*** tesseract has quit IRC | 07:52 | |
*** silor has quit IRC | 07:53 | |
*** tovin07_ has joined #openstack-swift | 07:59 | |
*** tesseract-RH has quit IRC | 08:01 | |
*** kiennt has joined #openstack-swift | 08:02 | |
*** tesseract-RH has joined #openstack-swift | 08:02 | |
*** hseipp has joined #openstack-swift | 08:02 | |
acoles | good morning | 08:03 |
acoles | kota_: happy birthday ! | 08:03 |
*** bkopilov has joined #openstack-swift | 08:22 | |
*** rmcall has quit IRC | 08:34 | |
*** psachin has joined #openstack-swift | 08:36 | |
*** joeljwright has joined #openstack-swift | 08:50 | |
*** ChanServ sets mode: +v joeljwright | 08:50 | |
*** joeljwright has quit IRC | 08:52 | |
*** joeljwright has joined #openstack-swift | 08:52 | |
*** ChanServ sets mode: +v joeljwright | 08:52 | |
*** mvk has quit IRC | 09:03 | |
*** cshastri has quit IRC | 09:06 | |
*** mvk has joined #openstack-swift | 09:07 | |
*** tesseract-RH has quit IRC | 09:18 | |
*** mvk has quit IRC | 09:20 | |
*** tesseract has joined #openstack-swift | 09:23 | |
*** psachin has quit IRC | 09:31 | |
*** kei_yama has quit IRC | 09:33 | |
*** tovin07_ has quit IRC | 10:10 | |
*** kiennt has quit IRC | 10:37 | |
*** eckesicle has joined #openstack-swift | 10:51 | |
*** mat128 has joined #openstack-swift | 11:39 | |
*** silor has joined #openstack-swift | 12:22 | |
*** shuyingy_ has quit IRC | 12:35 | |
*** mat128 has quit IRC | 12:55 | |
*** catintheroof has joined #openstack-swift | 13:02 | |
*** eckesicle has quit IRC | 13:12 | |
*** lucasxu has joined #openstack-swift | 13:15 | |
*** baojg has joined #openstack-swift | 13:20 | |
*** baojg has quit IRC | 13:40 | |
*** baojg has joined #openstack-swift | 13:42 | |
*** baojg has quit IRC | 13:43 | |
*** links has quit IRC | 13:46 | |
*** baojg has joined #openstack-swift | 13:48 | |
*** shuyingya has joined #openstack-swift | 13:53 | |
*** skudlik has quit IRC | 14:00 | |
*** shuyingya has left #openstack-swift | 14:02 | |
*** mat128 has joined #openstack-swift | 14:03 | |
*** mat128 has quit IRC | 14:05 | |
*** baojg has quit IRC | 14:14 | |
*** gyee has joined #openstack-swift | 14:17 | |
*** baojg has joined #openstack-swift | 14:21 | |
*** mat128 has joined #openstack-swift | 14:21 | |
*** baojg has quit IRC | 14:23 | |
*** baojg has joined #openstack-swift | 14:26 | |
openstackgerrit | Peter Lisák proposed openstack/swift master: Recon's get_diskusage and get_unmounted return all devs. https://review.openstack.org/348803 | 14:28 |
*** srbgupta has joined #openstack-swift | 14:36 | |
*** mat128 has quit IRC | 14:36 | |
*** jistr|trng is now known as jistr | 15:09 | |
*** cbartz has quit IRC | 15:17 | |
*** baojg has quit IRC | 15:19 | |
*** baojg has joined #openstack-swift | 15:24 | |
*** baojg has quit IRC | 15:36 | |
*** SkyRocknRoll has joined #openstack-swift | 15:36 | |
*** baojg has joined #openstack-swift | 15:39 | |
*** oshritf has quit IRC | 15:43 | |
*** mat128 has joined #openstack-swift | 15:43 | |
*** mat128 has quit IRC | 15:45 | |
*** vint_bra has joined #openstack-swift | 15:48 | |
*** mat128 has joined #openstack-swift | 15:48 | |
*** vint_bra has quit IRC | 15:52 | |
*** itlinux has joined #openstack-swift | 15:52 | |
*** rcernin has quit IRC | 15:54 | |
*** pcaruana has quit IRC | 15:57 | |
*** ianychoi has joined #openstack-swift | 16:00 | |
*** tesseract has quit IRC | 16:03 | |
*** itlinux has quit IRC | 16:03 | |
*** openstackgerrit has quit IRC | 16:04 | |
*** links has joined #openstack-swift | 16:06 | |
*** joeljwright has quit IRC | 16:10 | |
*** itlinux has joined #openstack-swift | 16:13 | |
*** oshritf has joined #openstack-swift | 16:17 | |
*** vint_bra has joined #openstack-swift | 16:20 | |
*** silor has quit IRC | 16:22 | |
*** hseipp has quit IRC | 16:26 | |
timburke | good morning | 16:29 |
*** oshritf has quit IRC | 16:30 | |
*** mvk has joined #openstack-swift | 16:34 | |
*** links has quit IRC | 16:38 | |
notmyname | good morning | 16:38 |
*** oshritf has joined #openstack-swift | 16:38 | |
*** chsc has joined #openstack-swift | 16:40 | |
*** chsc has joined #openstack-swift | 16:40 | |
acoles | timburke: notmyname o/ | 16:40 |
*** geaaru has quit IRC | 16:46 | |
*** psachin has joined #openstack-swift | 16:51 | |
*** vint_bra has quit IRC | 16:55 | |
*** oshritf has quit IRC | 16:56 | |
tdasilva | timburke: hi! just started playing with swift3 and I'm running into some "The request signature we calculated does not match the signature you provided" error, got any ideas? | 17:09 |
tdasilva | timburke: this is a swift3+keystone env | 17:09 |
timburke | tdasilva: v2 or v4 signatures? do you know? also, out of curiosity, what version of keystone? | 17:10 |
tdasilva | i do not know about v2 or v4, but keystone is pike | 17:10 |
tdasilva | I can see the error is returned by swift3 middleware and not s3token | 17:11 |
timburke | yay! it has https://github.com/openstack/keystone/commit/3ec1aa4 then. ocata is sad :-( | 17:11 |
timburke | tdasilva: got some logs for me to look at? | 17:12 |
timburke | my first guess ('cause it comes up a decent bit) is that we're working with v4 signatures and the region doesn't match | 17:13 |
tdasilva | timburke: http://paste.openstack.org/show/619341/ | 17:13 |
timburke | i stand corrected -- that string to sign is definitely v2 | 17:16 |
timburke | what's the keystone log look like? also, you might want to switch to using the version of s3token shipped with swift3 | 17:19 |
*** klrmn has joined #openstack-swift | 17:23 | |
*** rcernin has joined #openstack-swift | 17:27 | |
tdasilva | timburke: one sec | 17:28 |
timburke | also, what's the pipeline? did you *need* to disable auth_pipeline_check? i always felt like that was mostly for non-keystone, non-tempauth auth systems... | 17:29 |
tdasilva | pipeline = catch_errors healthcheck proxy-logging cache ratelimit bulk tempurl formpost authtoken keystone swift3 s3token staticweb copy container_quotas account_quotas slo dlo versioned_writes proxy-logging proxy-server | 17:31 |
tdasilva | in swift3 it's hardcoded to be something like keystoneauth | 17:32 |
tdasilva | so i just disabled auth_pipeline_check | 17:32 |
timburke | got it. i'm pretty sure we need something like ... authtoken swift3 s3token keystone ... though -- s3token just populates the env similar to authtoken with delay_auth_decision, and relies on keystoneauth to make final decisions (with the extra swift context of ACLs and the like) | 17:35 |
tdasilva | crap, i knew that, copy and paste error | 17:38 |
tdasilva | ok, so i made that change and will also change to use the s3token shipped with swift3 | 17:38 |
*** catinthe_ has joined #openstack-swift | 17:44 | |
*** catintheroof has quit IRC | 17:45 | |
tdasilva | timburke: http://paste.openstack.org/show/619345/ | 17:52 |
tdasilva | lol i think i delete line 160 by mistake: auth_pipeline_check=False is still there | 17:54 |
tdasilva | it's there on the config file, deleted on the paste by mistake | 17:54 |
notmyname | tdasilva: he wants you to know he's getting coffee | 17:55 |
tdasilva | notmyname: heh, thank you... | 17:56 |
timburke | :-( that log seems so anaemic... | 17:59 |
timburke | i'm so used to seeing things like "Calling S3Token middleware." "Connecting to Keystone sending this JSON: ..." "Keystone Reply: Status: 200, Output: ..." | 18:00 |
timburke | maybe i'm just too used to debug level from gates like http://logs.openstack.org/85/482485/3/check/gate-swift3-tox-keystone-ubuntu-xenial/d714017/tox/proxy.log.txt.gz ? | 18:01 |
timburke | oh! *there's* the problem! of course... | 18:01 |
timburke | > s3curl: StringToSign='GET\n\n\nThu, 24 Aug 2017 14:53:16 +0000\n/192.168.24.11/bucket' | 18:02 |
timburke | > Aug 24 14:53:14 localhost proxy-server: {... 'string_to_sign': 'GET\n\n\nThu, 24 Aug 2017 14:53:16 +0000\n/bucket', ... | 18:02 |
tdasilva | timburke: but is it possible that the request is not even getting to s3token? it seems like i'm getthing this: https://github.com/openstack/swift3/blob/master/swift3/request.py#L291 | 18:02 |
timburke | gotta convince s3curl that the ip address isn't part of the bucket name | 18:02 |
timburke | don't think so... again, that string to sign looks like you're using v2 signatures, and that error only comes up for v4 | 18:04 |
*** itlinux has quit IRC | 18:08 | |
clayg | timburke: not sure on patch 496535, I put it on the meeting agenda | 18:17 |
patchbot | https://review.openstack.org/#/c/496535/ - swift - Simplify testing for logging at error vs exception | 18:17 |
timburke | i did it through the log lines interface because we almost never use the raw log dict interface. as a result, we'd often end up with tracebacks for things where a traceback just isn't useful, as evidenced by the string of patches leading up to that one | 18:21 |
timburke | fwiw | 18:21 |
timburke | and of the places where we *do* test with the log_dict, i don't think *any* of them test the negative -- they only ever check that we *do* log a traceback | 18:24 |
timburke | that patch is *also* why i hesitated in adding tests with https://review.openstack.org/#/c/496965/ -- it seems like they'd surely conflict, and i didn't want to make that patch chain any longer than it already was | 18:26 |
patchbot | patch 496965 - swift - proxy-server: errors talking to backend servers do... | 18:26 |
timburke | though i guess since i tweaked the message format, maybe it isn't *so* bad... | 18:28 |
clayg | timburke: ^ considering trying to capture some of that reasoning/justification in gerrit for that patch - it'll probably be useful context later. | 18:37 |
*** cschwede_ has quit IRC | 18:47 | |
tdasilva | timburke: so the way it chooses v1 or v4 is just based on the headers sent with the request, right? | 18:52 |
tdasilva | sorry..v2 or v4 | 18:53 |
timburke | tdasilva: yup. v2 requests look like `Authorization: AWS <user>:<sig>` while v4 looks like `Authorization: AWS4-HMAC-SHA256 Credential=<user>/<date>/<region>/s3/aws4_request, SignedHeaders=<headers>, Signature=<sig>` | 18:57 |
*** rmcall has joined #openstack-swift | 18:58 | |
*** ChubYann has joined #openstack-swift | 19:06 | |
*** openstackgerrit has joined #openstack-swift | 19:09 | |
openstackgerrit | Tim Burke proposed openstack/swift master: proxy-server: errors talking to backend servers don't need tracebacks https://review.openstack.org/496965 | 19:09 |
tdasilva | timburke: what's interesting is that I tried testing with s3cmd, and just running `s3cmd ls` creates a v2 request, but `s3cmd ls s3://bucket` creates a v4 request | 19:13 |
timburke | curious... | 19:14 |
tdasilva | i've tried enabling debug logging in keystone, but i'm not really sure how to do it | 19:14 |
timburke | looks like it's coming out of this logic: https://github.com/s3tools/s3cmd/blob/master/S3/S3.py#L155-L163 | 19:16 |
tdasilva | yep | 19:18 |
*** SkyRocknRoll has quit IRC | 19:30 | |
timburke | both should work though -- are you running into trouble with one or the other? | 19:34 |
tdasilva | both | 19:37 |
tdasilva | but different errors | 19:37 |
tdasilva | with v4 i get InvalidAccessKeyId | 19:37 |
tdasilva | which is weird, because I can't see that even being used in the swift3 code source at all | 19:38 |
tdasilva | so i'm still trying to get my head around the code | 19:38 |
timburke | yeah, that InvalidAccessKeyId makes me wonder if it's hitting actual s3... | 19:43 |
timburke | in swift3 we really don't have a good way to check whether a user exists or not | 19:44 |
tdasilva | it was not, it was my config mistake, it is corrected now, but back to same previous error of SignatureDoesNotMatch | 19:52 |
tdasilva | so at least s3curl and s3cmd are matching??? fwiw | 19:52 |
timburke | what's the config look like? are the clients still claiming that the HTTP path in the string to sign should be "/192.168.24.11/bucket"? | 19:54 |
timburke | might work better to have an entry in /etc/hosts so you can use a hostname? | 19:55 |
*** psachin has quit IRC | 19:57 | |
*** psachin has joined #openstack-swift | 19:59 | |
tdasilva | timburke: so now with s3cmd I'm sure that the request is a v4 request...getting some logs for you... | 20:00 |
tdasilva | timburke: you might notice some extra debug statements in the log: http://paste.openstack.org/show/619360/ | 20:02 |
timburke | clayg: i can't decide whether to love or hate https://github.com/openstack/swift/blob/master/swift/common/utils.py#L1735 | 20:03 |
timburke | maybe you're right and i should carve out an exception for BadStatusLine there -- it seems like we should *never* use logger.error()? or we should just say error = exception in the class def | 20:03 |
timburke | and make sure that *all* of our normal testing infra includes an adapter? | 20:04 |
timburke | suck a giant yak! | 20:04 |
notmyname | timburke: once you shave the yak, you'll have plenty of hair to make the paintbrushes for recoloring the bikeshed | 20:08 |
timburke | tdasilva: why's the canonical request say "location=" for the query string when the actual request that's later sent is for "/bucket/?location" (no equals-sign)? i know i've gotten other reports about this... but it seems like a client bug | 20:08 |
timburke | heh. such* a giant yack. freudian slip | 20:09 |
*** mat128 has quit IRC | 20:11 | |
tdasilva | timburke: idk?? i'm pretty certain it's some config error on my part otherwise things would not be working on the gate, just not sure how to track it down yet: http://paste.openstack.org/show/619361/ | 20:12 |
timburke | clayg: like, i understand the convenience of having some centralized logging infra like that for whether or not to write a traceback, but why does it break from the stdlib like that? https://docs.python.org/2/library/logging.html#logging.Logger.exception reads *just* like Logger.error except for the "Exception info is always added to the logging message." | 20:12 |
clayg | timburke: since it's been there longer than you or I have been alive we don't have to have a love/hate feeling toward it - we can just accept it as "being" | 20:13 |
timburke | tdasilva: gate? which gate? maybe there's some difference in s3cmd versions? | 20:14 |
tdasilva | timburke: i meant to say i'm keystone+swift3 func test gate. so i don't think it's a problem with the software itself..more like how i'm configuring it...but yeah, could be s3cmd itself... | 20:16 |
tdasilva | timburke: i just grabbed the latest from s3cmd github... | 20:16 |
timburke | clayg: if we're going to accept it as "being" (rather than rip it out and follow stdlib conventions), then i'm thinking we should just alias error to exception | 20:17 |
timburke | and throw in a elif exc is not None before setting call = self._exception | 20:19 |
clayg | timburke: that doesn't sound so unreasonable to me... basically just further merge the two... main difference being you could call logger.error w/o having anything useful in sys.exc_info and maybe something weird... idk - you could try it - sounds like more yak | 20:29 |
*** itlinux has joined #openstack-swift | 20:30 | |
*** lucasxu has quit IRC | 20:31 | |
timburke | the yak is there regardless, and i can't unsee it. at least the tracebacks from https://review.openstack.org/#/c/496150/ got cleaned up. which only happened because we were using the root logger! | 20:31 |
patchbot | patch 496150 - swift - Socket errors don't warrant tracebacks when talkin... (MERGED) | 20:31 |
timburke | https://github.com/openstack/swift/blob/master/swift/common/utils.py#L1735 doesn't do us *any good* if we're just using logging.exception | 20:32 |
tdasilva | timburke: need to step out, thanks for the help, will continue later and let you know what i found | 20:33 |
*** psachin has quit IRC | 20:36 | |
*** zaitcev has quit IRC | 20:40 | |
*** zaitcev has joined #openstack-swift | 20:41 | |
*** ChanServ sets mode: +v zaitcev | 20:41 | |
openstackgerrit | Merged openstack/swift master: Use more specific asserts in test/unit/account tests https://review.openstack.org/342766 | 20:44 |
*** catinthe_ has quit IRC | 20:53 | |
*** catintheroof has joined #openstack-swift | 20:54 | |
*** catintheroof has quit IRC | 20:58 | |
*** itlinux has quit IRC | 21:03 | |
*** itlinux has joined #openstack-swift | 21:05 | |
*** rmcall has quit IRC | 21:07 | |
*** rcernin has quit IRC | 21:19 | |
*** itlinux has quit IRC | 21:24 | |
*** itlinux has joined #openstack-swift | 21:25 | |
*** srbgupta has quit IRC | 21:57 | |
*** catintheroof has joined #openstack-swift | 21:59 | |
*** itlinux has quit IRC | 23:00 | |
mattoliverau | morning | 23:04 |
*** chsc has quit IRC | 23:12 | |
*** kei_yama has joined #openstack-swift | 23:39 | |
*** mbirru has quit IRC | 23:39 | |
*** mbirru has joined #openstack-swift | 23:40 | |
*** catintheroof has quit IRC | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!