*** ^andrea^ has quit IRC | 00:26 | |
*** psachin has joined #openstack-swift | 00:54 | |
*** StevenK has quit IRC | 01:08 | |
*** StevenK has joined #openstack-swift | 01:12 | |
*** hoonetorg has quit IRC | 01:41 | |
*** cshastri has joined #openstack-swift | 01:42 | |
*** tovin07_ has joined #openstack-swift | 01:45 | |
-openstackstatus- NOTICE: The freenode network is currently the target of automated spam attacks, we have enabled temporary restrictions on targetted OpenStack channels which requires users to be logged on to NickServ. If you see spam in your channel, please report it in #openstack-infra. Thanks. | 01:48 | |
*** hoonetorg has joined #openstack-swift | 01:49 | |
kota_ | good morning | 01:56 |
---|---|---|
* kota_ got flu shot in this morning | 01:57 | |
*** m_kazuhiro has joined #openstack-swift | 02:01 | |
m_kazuhiro | good morning | 02:06 |
openstackgerrit | Cheng Li proposed openstack/swift master: change account_autocreate to default to true https://review.openstack.org/385946 | 02:34 |
mattoliverau | kota_, m_kazuhiro o/ | 02:41 |
m_kazuhiro | mattoliverau: o/ | 02:41 |
*** ChanServ sets mode: +r | 02:55 | |
*** gkadam has joined #openstack-swift | 03:37 | |
*** gkadam has quit IRC | 04:54 | |
kota_ | test call | 05:24 |
*** SkyRocknRoll has joined #openstack-swift | 06:17 | |
*** SkyRocknRoll has quit IRC | 06:28 | |
*** kei_yama has quit IRC | 06:30 | |
openstackgerrit | Andreas Jaeger proposed openstack/swift master: DNM: Testing Zuul v3 native tox jobs https://review.openstack.org/528582 | 06:38 |
*** tovin07_ has quit IRC | 06:44 | |
*** hoonetorg has quit IRC | 06:45 | |
*** rcernin has quit IRC | 06:46 | |
openstackgerrit | Andreas Jaeger proposed openstack/swift master: DNM: Testing Zuul v3 native tox jobs https://review.openstack.org/528582 | 06:52 |
*** hoonetorg has joined #openstack-swift | 07:01 | |
*** tovin07_ has joined #openstack-swift | 07:02 | |
openstackgerrit | Andreas Jaeger proposed openstack/swift master: DNM: Testing Zuul v3 native tox jobs https://review.openstack.org/528582 | 07:05 |
*** geaaru has quit IRC | 07:19 | |
*** m_kazuhiro has quit IRC | 07:47 | |
*** MeltedLux_ has quit IRC | 07:52 | |
openstackgerrit | Andreas Jaeger proposed openstack/swift master: DNM: Testing Zuul v3 native tox jobs https://review.openstack.org/528582 | 07:52 |
*** bkopilov has quit IRC | 07:55 | |
mattoliverau | acoles: ahem, seems the ashes are decided ;) better luck next year | 08:00 |
*** rcernin has joined #openstack-swift | 08:06 | |
*** silor has joined #openstack-swift | 08:15 | |
*** AJaeger has joined #openstack-swift | 08:27 | |
openstackgerrit | Andreas Jaeger proposed openstack/swift master: Native Zuul v3 tox jobs https://review.openstack.org/528582 | 08:28 |
AJaeger | swift team, I converted the legacy tox jobs to Zuul v3 and moved them in-tree. Please review the above and ask any questions you have. | 08:28 |
*** gkadam has joined #openstack-swift | 08:28 | |
AJaeger | notmyname: This still uses the XFS set up you did earlier. It's now much easier to do and fully under your control ;) | 08:29 |
AJaeger | notmyname: do we still need the py27/py35 jobs *without* XFS setup? Or should we remove them from project-config? | 08:32 |
*** cbartz has joined #openstack-swift | 08:53 | |
acoles | mattoliverau: :'( | 09:24 |
acoles | good morning | 09:24 |
*** jarbod_ has quit IRC | 09:57 | |
*** tovin07_ has quit IRC | 10:18 | |
*** d0ugal_ has quit IRC | 10:36 | |
*** cshastri has quit IRC | 10:46 | |
*** silor has quit IRC | 10:48 | |
*** rcernin has quit IRC | 10:58 | |
openstackgerrit | Alistair Coles proposed openstack/swift feature/deep: Fix broker merge_shard_ranges https://review.openstack.org/528422 | 11:02 |
*** d0ugal has joined #openstack-swift | 11:16 | |
openstackgerrit | Merged openstack/swift master: Move symlink versioning functional test https://review.openstack.org/528253 | 12:27 |
*** mvk has quit IRC | 12:31 | |
*** psachin has quit IRC | 12:56 | |
*** ChanServ sets mode: -r | 14:09 | |
*** saint_ has joined #openstack-swift | 14:23 | |
*** d0ugal has quit IRC | 14:56 | |
*** d0ugal has joined #openstack-swift | 15:08 | |
*** d0ugal has quit IRC | 15:11 | |
*** mingyu_ has joined #openstack-swift | 15:11 | |
*** d0ugal has joined #openstack-swift | 15:12 | |
*** thiago1 has quit IRC | 15:16 | |
*** hseipp has joined #openstack-swift | 15:46 | |
*** hseipp has quit IRC | 16:13 | |
*** saint_ has quit IRC | 16:30 | |
*** catintheroof has joined #openstack-swift | 16:38 | |
notmyname | good morning | 16:43 |
notmyname | AJaeger: ah, interesting. and thanks | 16:43 |
notmyname | (the zuul jobs) | 16:44 |
notmyname | AJaeger: for real testing, XFS should be required. however, the non-xfs jobs were left in because I wasn't able to get that requirement in devstack (well, was told it wouldn't happen if I tried) | 16:45 |
notmyname | so the existing jobs needed to still work | 16:45 |
*** catintheroof has quit IRC | 16:45 | |
clarkb | notmyname: devstack has created an xfs filesystem for swift as long as I can remember | 16:46 |
notmyname | clarkb: nah, it's xfs as the TMPDIR location | 16:46 |
notmyname | not the data location | 16:46 |
notmyname | (or more generally, a TMPDIR location that supports more than 4k of xattrs) | 16:46 |
*** armaan has joined #openstack-swift | 16:47 | |
notmyname | and I got pushback from tempest, actually, not "devstack". ie something along the lines of "adding a specific filesystem requirement in this way is something that is unreasonable to add as a requirement to tests that tempest runs" | 16:48 |
clarkb | I see so something different than the xfs that is there | 16:48 |
notmyname | but TBH, it doesn't matter too much for me. I went with the direction that would (1) let me get what I needed done and (2) caused fewest needless arguments with others | 16:48 |
notmyname | FWIW, the commit message for the related patch in swift (the one that caused the test changes) has some more details https://review.openstack.org/#/c/336323/ | 16:51 |
patchbot | patch 336323 - swift - Add checksum to object extended attributes (MERGED) | 16:51 |
*** creiht has joined #openstack-swift | 17:03 | |
*** gyee has joined #openstack-swift | 17:04 | |
creiht | Greetings swiftlings! | 17:04 |
notmyname | hello creiht | 17:04 |
notmyname | what's up? | 17:04 |
creiht | We noticed some small issues with the additions of the symlinks functests | 17:05 |
creiht | Not all of them have the logic to be skipped if not enabled | 17:05 |
*** SkyRocknRoll has joined #openstack-swift | 17:06 | |
notmyname | ah, sounds like a good catch | 17:07 |
creiht | and raising skipTest in the setupmodule can be a little problematic when running nosetests | 17:08 |
creiht | what is the preferred paste server for you guys? | 17:08 |
notmyname | there's not one. the openstack pastebin (paste.openstack.org) if you don't have one you prefer | 17:09 |
notmyname | I'm bringing up my dev vm | 17:09 |
creiht | Here's the tests we had to manually skip: http://paste.openstack.org/show/629229/ | 17:11 |
creiht | And here's a traceback we were getting when running nosetest: http://paste.openstack.org/show/629230/ | 17:12 |
notmyname | hmm... functests passed on my saio vm | 17:15 |
*** mvk has joined #openstack-swift | 17:16 | |
notmyname | but I got the same SkipTest error when runnign it directly with nosetests | 17:17 |
notmyname | creiht: it's a bad import | 17:19 |
creiht | ahh | 17:20 |
notmyname | unittest vs unittest2 | 17:22 |
notmyname | nose recognizes unittest.Skiptest | 17:22 |
notmyname | testr recognizes unittest2.SkipTest | 17:22 |
notmyname | (because of course) | 17:23 |
notmyname | so running ./.functests works (uses testr) | 17:23 |
notmyname | running nose directly doesn't | 17:23 |
notmyname | looks like there'sa couple of other places like that too | 17:23 |
*** catintheroof has joined #openstack-swift | 17:23 | |
notmyname | I'll have a patch in a moment | 17:23 |
creiht | No worries, we got things working here | 17:24 |
*** armaan has quit IRC | 17:24 | |
creiht | just wanted to let you guys now | 17:24 |
creiht | know | 17:24 |
*** armaan has joined #openstack-swift | 17:24 | |
*** cshastri has joined #openstack-swift | 17:25 | |
notmyname | meaning you already have a patch you could share? | 17:28 |
*** catintheroof has quit IRC | 17:30 | |
creiht | no, we just told our tests to skip those tests :) | 17:30 |
creiht | and we just found the nosetest thing accidentally when trying to figure out what was wrong | 17:31 |
*** cshastri has quit IRC | 17:32 | |
*** cbartz has quit IRC | 17:33 | |
openstackgerrit | John Dickinson proposed openstack/swift master: fix SkipTest imports in functests so they can be run directly by nose https://review.openstack.org/528769 | 17:33 |
clayg | rledisez: thanks for the detailed report on lp bug #1738804 | 17:34 |
openstack | Launchpad bug 1738804 in OpenStack Object Storage (swift) "Socket leak on proxy->obj when HTTPRequestedRangeNotSatisfiable with erasure code" [Undecided,New] https://launchpad.net/bugs/1738804 | 17:34 |
rledisez | clayg: np, i just pasted a dirty fix, but i don't know where to look for writing a real fix | 17:36 |
*** mvk has quit IRC | 17:37 | |
*** HCLTech-SSW has joined #openstack-swift | 17:38 | |
*** gkadam has quit IRC | 17:38 | |
HCLTech-SSW | Hi Clay | 17:38 |
* creiht waves at everyone, and hopes everyone has a Merry Christmas | 17:40 | |
*** creiht has quit IRC | 17:40 | |
*** MeltedLux has joined #openstack-swift | 17:48 | |
*** HCLTech-SSW has quit IRC | 17:49 | |
*** JimCheung has joined #openstack-swift | 17:53 | |
*** geaaru has joined #openstack-swift | 18:03 | |
*** mvk has joined #openstack-swift | 18:25 | |
*** catintheroof has joined #openstack-swift | 18:36 | |
*** catintheroof has quit IRC | 18:36 | |
*** catintheroof has joined #openstack-swift | 18:36 | |
*** catintheroof has quit IRC | 18:36 | |
AJaeger | notmyname: I'm talking about py27 and py35 tox jobs - do we need them both with XFS as TMPDIR and without? | 18:37 |
clayg | i don't think anyone really wants the "without XFS TMPDIR" jobs - but at somepoint we also decided trying to mock out the xattr support when the default tmpdir filesystem doesn't support it wasn't working anymore | 18:43 |
clayg | I think at the time notmyname asked if we can just "fix" the "normal" python unittest environments to have a xattr supporting TMPDIR but the easiest path forward at the time was to create a second job? | 18:44 |
notmyname | AJaeger: yeah, that's what I was trying to get at. we only *need* the with XFS jobs in order to qualify swift for delivery. but keeping the non-xfs ones around make it easier on other projects | 18:44 |
timburke | ...something something PTI something... | 18:46 |
notmyname | AJaeger: so the simple answer is "yes, we need them both" | 18:46 |
notmyname | (although technically we don't have any py3 jobs, at least that do anything...) | 18:46 |
timburke | notmyname: hey! there are *some* modules that get py3 coverage now! https://github.com/openstack/swift/blob/master/tox.ini#L31-L35 :P | 18:47 |
notmyname | I have *some* parts of a million dollars in my bank account right now! | 18:48 |
timburke | and if i ever beat the ring builder tests into submission so we could land https://review.openstack.org/#/c/401397/ you could actually do your ring manipulations in py3! | 18:49 |
patchbot | patch 401397 - swift - py3: port common/ring/ and common/utils.py | 18:49 |
*** mingyu_ has quit IRC | 18:55 | |
*** mingyu has joined #openstack-swift | 18:56 | |
clayg | torgomatic: do you have the cors patch handy? | 18:56 |
*** catintheroof has joined #openstack-swift | 18:56 | |
timburke | clayg: https://review.openstack.org/#/c/528106/ | 18:57 |
patchbot | patch 528106 - swift - Move CORS to middleware. | 18:57 |
clayg | timburke: thanks! starred now! | 18:58 |
*** itlinux has joined #openstack-swift | 18:58 | |
clayg | torgomatic: ok, now I remember where we were at... 1) there's no functional tests for container CORS that I could find 2) the auto-insert placement isn't deterministic if you're not using either tempauth or keystoneauth | 19:00 |
*** mingyu has quit IRC | 19:00 | |
*** mingyu has joined #openstack-swift | 19:06 | |
*** mingyu has quit IRC | 19:07 | |
*** mingyu has joined #openstack-swift | 19:07 | |
*** mingyu has quit IRC | 19:12 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Stop logging tracebacks when the replicator runs out of handoffs https://review.openstack.org/528792 | 19:12 |
AJaeger | notmyname: The PTI does not imply that you need to run py27 two times - once with XFS, once without. | 19:14 |
AJaeger | notmyname, timburke : Same for py35. Let's define one variant and run that one | 19:14 |
notmyname | AJaeger: I'm totally fine with only having the definitions that require xfs. I was led to believe that adding an XFS TMPDIR as a hard requirement to anything that is running swift tests was not something that could be done. also, changing the definition for "py27" tests would add that for every project regardless of if they run swift tests, because the job definition is (was?) global | 19:16 |
notmyname | AJaeger: for swift, we require the XFS change. I am 100% happy with the current situation with two job definitions. I do *not* want to try to convince every openstack project to change test environment definitions (one, it's not needed for them and two, it's hard to convince that many people of anything) | 19:18 |
notmyname | if zuul 3 has changed something, that's great (eg per-project definitions of py* jobs) | 19:20 |
AJaeger | notmyname: then we can merge my change - and we then remove the openstack-tox-py27 /py35 jobs from your project. | 19:21 |
AJaeger | notmyname: yes, zuul v3 has this changed, have a look at my proposed change https://review.openstack.org/528582 | 19:22 |
patchbot | patch 528582 - swift - Native Zuul v3 tox jobs | 19:22 |
notmyname | AJaeger: ok, thanks. I'll look at it. my only concern, from the words you just said, are any perceived differences with swift not doing the "right" thing wrt testing. you know, the whole "swift is different" meme that won't die | 19:25 |
AJaeger | notmyname: https://governance.openstack.org/tc/reference/pti/python.html#specific-commands has | 19:28 |
AJaeger | "Some basic prerequisites for test running (system packages, database configuration, custom filesystem types) are acceptable" - so, this is fine. | 19:28 |
notmyname | right, but the xfs change requires a global different definition of `tox -epy27` | 19:29 |
AJaeger | Looking at my change, the only thing special is the passing of TMPDIR in so that it points to a custom filesystem type | 19:29 |
notmyname | or did that change with zuulv3? | 19:29 |
AJaeger | notmyname: we inherit from the global one and the only change I do is adding TMPDIR. The rest is the same... | 19:29 |
AJaeger | fungi: any comments on https://review.openstack.org/528582 and whether we need openstack-tox-py27 and swift-tox-py27? I argue we don't and this fullfills the PTI. | 19:30 |
patchbot | patch 528582 - swift - Native Zuul v3 tox jobs | 19:30 |
notmyname | my understanding is that every python project must run tests when they are invoked exactly with `tox -epy27` | 19:31 |
AJaeger | notmyname: see my quoted test from PTI - you can ask for some set up. | 19:33 |
fungi | AJaeger: i explicitly amended the pti after discussing the xfs case with notmyname: https://review.openstack.org/397502 | 19:34 |
patchbot | patch 397502 - governance - Acknowledge nominal prerequisites for tests (MERGED) | 19:34 |
notmyname | AJaeger: just looked at your patch. looks fairly simple (I like that!). I don't quite understand all of it yet (mostly how it fits together). but thanks | 19:34 |
fungi | a little over a year ago now | 19:34 |
fungi | that additional sentence was basically initiated by this use case | 19:35 |
notmyname | yeah, so with that governance change and the in-project definition, it seems like we can both fulfill the PTI and simplify the jobs by removing the non-xfs-tmpdir jobs | 19:35 |
notmyname | yay! | 19:36 |
torgomatic | clayg: I have no answer for the functests, but I made the middleware work before auth so now placement doesn't care about your auth system | 19:37 |
AJaeger | fungi, thanks | 19:43 |
AJaeger | notmyname: if you don't understand it: Note that it's self testing, you see the jobs running fine on it ;) If you have questions about it, just ask and I'll try to explain and give pointer | 19:44 |
notmyname | AJaeger: thanks. yeah, I'll look over the yaml schema. it's just me wrapping my head around how the parts fit together | 19:46 |
AJaeger | notmyname: I'll stay a bit in the channel in case of questions - but since I'm Europe based, I won't answer forever but can then read scrollback... | 19:48 |
notmyname | AJaeger: no worries. TBH it's close to lunch time for me, and I've got a bunch of other stuff going on too. I'm not doing it right now, so don't wait around for me. if I have questions, I'll handle them async in gerrit | 19:48 |
clayg | torgomatic: perfecto! | 19:49 |
AJaeger | notmyname: enjoy lunch... | 19:50 |
clayg | timburke: i hate it when 'this needs a number %d' % '0' blows up with a TypeError :'( | 19:52 |
timburke | clayg: whomp whomp. i'll respin it, and actually add a test to cover the branch | 19:53 |
clayg | test_update (test.unit.obj.test_replicator.TestObjectReplicator) hits it | 19:53 |
clayg | i think it just has everything mocked as unmounted so ... eventually it runs out! | 19:54 |
timburke | oh, gdi -- i haven't cleaned up my vsaio to default to an xfs tmp! | 19:54 |
clayg | timburke: sorry about that - pull the latest goodies! | 19:55 |
clayg | ... and vagrant provision | 19:55 |
timburke | those skips should have given me a clue... | 19:55 |
*** SkyRocknRoll has quit IRC | 20:07 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Stop logging tracebacks when the replicator runs out of handoffs https://review.openstack.org/528792 | 20:08 |
*** armaan has quit IRC | 20:21 | |
*** armaan has joined #openstack-swift | 20:22 | |
*** d0ugal has quit IRC | 20:36 | |
*** d0ugal has joined #openstack-swift | 20:37 | |
*** ChanServ has quit IRC | 20:52 | |
*** linkmark has joined #openstack-swift | 20:59 | |
*** ChanServ has joined #openstack-swift | 21:01 | |
*** barjavel.freenode.net sets mode: +o ChanServ | 21:01 | |
timburke | tdasilva: what was the status of the experimental centos7 jobs? i was worried about the failures on https://review.openstack.org/#/c/528582/ -- but checking against another recent patch suggests they're broken anyway? | 21:01 |
patchbot | patch 528582 - swift - Native Zuul v3 tox jobs | 21:01 |
tdasilva | timburke: yeah, I think they worked at some point, but I'm not 100% what's broken | 21:02 |
tdasilva | timburke: gime a few and i'm going to try to dig a little bit | 21:02 |
timburke | something about the repos -- no erasurecode available if i remember right | 21:03 |
*** ChanServ sets mode: +v tdasilva | 21:03 | |
AJaeger | timburke: they are broken since bindep.txt has liberasurecode-devel which does not exist on CentOS7 - only on Fedora and openSUSE. | 21:03 |
AJaeger | So, I suggest to test on either of those instead - or drop it completely | 21:04 |
timburke | what's weird is that it *had* worked on centos, once -- https://review.openstack.org/#/c/438758/ | 21:04 |
patchbot | patch 438758 - swift - fix bindep file to enable func test in centos (MERGED) | 21:04 |
timburke | (that or we lied about what platform it was in the job name) | 21:05 |
tdasilva | right, i thought at some point the rdo repo was being installed on the centos nodes | 21:05 |
tdasilva | centos-release-openstack-* | 21:05 |
tdasilva | AJaeger: ^^^ | 21:08 |
AJaeger | tdasilva: not anymore, we removed that one some time ago... | 21:08 |
timburke | either way, it seems like moving the job definitions in-repo must be a step in the right direction -- then we can iterate on trying to fix up centos (or fedora, or suse, or *whatever*) without a bunch of churn in -infra repos that shouldn't really care | 21:08 |
*** mingyu has joined #openstack-swift | 21:08 | |
AJaeger | tdasilva: there was an email on the mailing list about that | 21:08 |
tdasilva | AJaeger: i trust you :) i probably missed the email | 21:09 |
AJaeger | http://lists.openstack.org/pipermail/openstack-dev/2017-November/124613.html | 21:10 |
tdasilva | timburke: yeah, i'm fine with removing it for now and maybe we can later add it ourselves. I think one of the goals was to test swift EC with the libec that is packaged in a rhel based platform | 21:11 |
AJaeger | tdasilva: shouldn't be a problem to update the job to add rdo repos in this case again , best ask ianw on #openstack-infra | 21:11 |
AJaeger | the jobs are experimental, I suggest to migrate my change over as is - and then you can decide in followup what to do... | 21:12 |
timburke | tdasilva: i wasn't really suggesting we remove them -- just looking for how best to interpret the results :-) | 21:13 |
*** mingyu has quit IRC | 21:13 | |
tdasilva | AJaeger: .zuul.yaml is the swift-tox-func job missing the TMPDIR tox_environment setting? | 21:13 |
tdasilva | AJaeger: ah, nevermind: parent: swift-tox-base | 21:14 |
AJaeger | tdasilva: yes, that's the trick ;) | 21:17 |
*** catintheroof has quit IRC | 21:20 | |
*** hseipp has joined #openstack-swift | 21:24 | |
*** JimCheung has quit IRC | 21:24 | |
*** saint_ has joined #openstack-swift | 21:25 | |
*** JimCheung has joined #openstack-swift | 21:25 | |
*** JimCheung has quit IRC | 21:29 | |
*** JimCheung has joined #openstack-swift | 21:29 | |
*** openstackgerrit has quit IRC | 21:33 | |
*** JimCheung has quit IRC | 21:36 | |
*** JimCheung has joined #openstack-swift | 21:37 | |
*** JimCheung has quit IRC | 21:49 | |
*** hseipp has quit IRC | 21:52 | |
mattoliverau | morning | 22:05 |
*** JimCheung has joined #openstack-swift | 22:16 | |
torgomatic | morning | 22:18 |
*** JimCheung has quit IRC | 22:28 | |
*** JimCheung has joined #openstack-swift | 22:30 | |
*** JimCheung has quit IRC | 22:37 | |
*** rcernin has joined #openstack-swift | 22:37 | |
*** JimCheung has joined #openstack-swift | 22:39 | |
*** saint_ has quit IRC | 22:40 | |
*** JimCheung has quit IRC | 22:43 | |
*** JimCheung has joined #openstack-swift | 22:45 | |
*** JimCheung has quit IRC | 22:52 | |
*** catinthe_ has joined #openstack-swift | 23:08 | |
*** catinthe_ has quit IRC | 23:13 | |
notmyname | bit rot visualized https://www.youtube.com/watch?v=m4dZ4x_f4CM | 23:22 |
*** zacksh has quit IRC | 23:23 | |
*** zacksh has joined #openstack-swift | 23:23 | |
*** tonyb has quit IRC | 23:26 | |
timburke | mattoliverau (or anyone else with opinions): any thoughts on logging at warning vs error for p 528792? | 23:32 |
patchbot | https://review.openstack.org/#/c/528792/ - swift - Stop logging tracebacks when the replicator runs o... | 23:32 |
*** tonyb has joined #openstack-swift | 23:36 | |
*** openstackgerrit has joined #openstack-swift | 23:50 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Stop logging tracebacks when the replicator runs out of handoffs https://review.openstack.org/528792 | 23:50 |
*** d0ugal has quit IRC | 23:51 | |
*** mingyu has joined #openstack-swift | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!