Tuesday, 2018-01-09

mattoliveraulol00:00
*** itlinux has joined #openstack-swift00:19
*** vint_bra1 has quit IRC00:30
*** vint_bra has joined #openstack-swift00:32
timburkehttp://logs.openstack.org/27/531527/2/check/swift-tox-py27/fb13f40/job-output.txt.gz#_2018-01-08_22_59_52_213463 hmmm....00:37
timburkeCongratulations! .... Job timed out!00:37
mattoliveraui guess that means another recheck?00:43
timburketorgomatic's on it already00:44
torgomaticpush the button, Frank00:44
*** tovin07_ has joined #openstack-swift00:52
*** vint_bra has quit IRC01:37
kota_good morning01:38
* kota_ is scrolling back the logs that are tons of lines...01:40
openstackgerritMatthew Oliver proposed openstack/swift master: Show devices marked as deleted on empty rings  https://review.openstack.org/53083901:42
mattoliverauSigh.. damn pep801:42
mattoliverautimburke: clayg ^^01:42
mattoliveraukota_: morning01:42
kota_mattoliverau: hi01:42
*** awkwardpenguin has quit IRC01:43
*** two_tired2 has joined #openstack-swift01:47
mattoliverauclayg: as an aside, I know your a vim man like myself. I've been using https://github.com/frutiger/git-vimdiff quite a bit and find it really useful. gives you 'git vimdiff' which I use 'git vimdiff HEAD~' alot when review patches. It gives each file diff on a different tab, so I can jump back and forth and hack as required. I'm even lazy and..  https://github.com/matthewoliver/junk/blob/master/install_git_vimdiff.sh01:47
mattoliveraumaybe you don't like tabs, or are happy with the normal git diff (using vimdiff) but I'm I like to jump around the patchset.01:48
mattoliveraus/i'm//01:48
*** zhongjun has joined #openstack-swift01:52
openstackgerritMatthew Oliver proposed openstack/swift feature/deep: Use includes query param to request the SR that includes an object  https://review.openstack.org/53166101:57
openstackgerrityanwei proposed openstack/swift master: Merge repeat code for rebalance There are three similar code segments in rebalance process as follows´╝Ü  https://review.openstack.org/53110902:06
openstackgerritMatthew Oliver proposed openstack/swift feature/deep: Use _root.db and _shard.db on sharded containers  https://review.openstack.org/53135002:14
openstackgerritSamuel Merritt proposed openstack/swift master: proxy: make the right number of container updates  https://review.openstack.org/53152702:21
*** armaan has quit IRC02:33
*** awkwardpenguin has joined #openstack-swift02:43
kota_ok, reached at the end of new logs.02:45
kota_i loo02:45
kota_oops02:45
kota_it looks i should go to patch 53152702:45
patchbothttps://review.openstack.org/#/c/531527/ - swift - proxy: make the right number of container updates02:45
kota_i don't have clear memory on the reason for the number of container updates but i like the smaller number if possible.02:47
kota_IIRC, on those days, the number of commit ack was different too. maybe 2? so i couldn't choose less number of container_updates to prevent the container update lost.02:48
*** awkwardpenguin has quit IRC02:49
*** bkopilov has quit IRC03:04
openstackgerritlei zhang proposed openstack/swift master: Fix the incorrect git.openstack.org source URL  https://review.openstack.org/53198903:05
*** hoonetorg has quit IRC03:12
*** hoonetorg has joined #openstack-swift03:25
*** two_tired2 has quit IRC03:34
*** kei_yama has quit IRC03:37
*** gyee has quit IRC03:48
*** m_kazuhiro has joined #openstack-swift04:00
m_kazuhirogood morning04:01
*** kei_yama has joined #openstack-swift04:02
mattoliveraum_kazuhiro: morning04:15
m_kazuhiromattoliverau: morning!04:18
kota_m_kazuhiro: o/04:19
m_kazuhirokota_: o/04:19
openstackgerritMerged openstack/swift master: Support existing builders with None _last_part_moves  https://review.openstack.org/53190504:22
m_kazuhiromattoliverau: I added answer comments to your questions about legacy problem of general task queue on gerrit page. I want to get your opinion for them. https://review.openstack.org/#/c/517389/04:22
patchbotpatch 517389 - swift - WIP: Update object expirer to use general task que...04:22
*** bkopilov has joined #openstack-swift04:23
mattoliveraum_kazuhiro: oh yeah, I'll go take a look.04:23
m_kazuhiromattoliverau: Thank you! And if you have time, please check internal client update patch for general task queue. clayg added +2 for this. https://review.openstack.org/#/c/530006/04:25
patchbotpatch 530006 - swift - Allow InternalClient to container/object listing w...04:25
*** m_kazuhiro_ has joined #openstack-swift04:30
*** m_kazuhiro has quit IRC04:32
*** m_kazuhiro_ has quit IRC04:32
*** m_kazuhiro has joined #openstack-swift04:33
*** awkwardpenguin has joined #openstack-swift04:46
*** awkwardpenguin has quit IRC04:51
*** psachin has joined #openstack-swift05:04
*** links has joined #openstack-swift05:07
*** Renich_ has quit IRC05:22
*** hoonetorg has quit IRC05:55
*** hoonetorg has joined #openstack-swift05:59
*** links has quit IRC06:35
*** rcernin has quit IRC06:38
*** awkwardpenguin has joined #openstack-swift06:42
*** gkadam has quit IRC06:43
*** links has joined #openstack-swift06:51
*** hoonetorg has quit IRC06:56
*** pcaruana has joined #openstack-swift06:56
*** links has quit IRC07:03
*** armaan has joined #openstack-swift07:10
*** hoonetorg has joined #openstack-swift07:12
*** links has joined #openstack-swift07:14
*** awkwardpenguin has quit IRC07:18
*** links has quit IRC07:27
*** m_kazuhiro has quit IRC07:32
*** hoonetorg has quit IRC07:32
*** hseipp has joined #openstack-swift07:41
*** m_kazuhiro has joined #openstack-swift07:42
*** links has joined #openstack-swift07:45
*** notmyname has quit IRC07:49
*** PagliaccisCloud has quit IRC07:49
*** d0ugal has joined #openstack-swift07:52
*** notmyname has joined #openstack-swift07:52
*** ChanServ sets mode: +v notmyname07:52
*** PagliaccisCloud has joined #openstack-swift07:52
*** itlinux has quit IRC07:58
*** AJaeger has joined #openstack-swift07:58
AJaegerswift3 cores, could you review https://review.openstack.org/#/c/530099/ to update your Zuul jobs, please?07:58
patchbotpatch 530099 - swift3 - Import legacy tox jobs07:59
*** neonpastor has quit IRC08:00
*** hoonetorg has joined #openstack-swift08:01
*** neonpastor has joined #openstack-swift08:02
*** gkadam has joined #openstack-swift08:13
*** tesseract has joined #openstack-swift08:20
*** psachin has quit IRC08:30
*** tovin07_ has quit IRC08:38
*** tovin07_ has joined #openstack-swift08:38
*** psachin has joined #openstack-swift08:40
*** geaaru has joined #openstack-swift08:48
*** cbartz has joined #openstack-swift08:55
acolesgood morning08:58
acolesmattoliverau: timburke clayg : nice work on ringbuilder fixes08:59
*** awkwardpenguin has joined #openstack-swift09:20
*** flwang1 has quit IRC09:22
*** flwang has joined #openstack-swift09:24
*** nakagawamsa has joined #openstack-swift09:25
*** nakagawamsa has quit IRC09:25
*** awkwardpenguin has quit IRC09:25
*** hoonetorg has quit IRC09:32
openstackgerritKota Tsuyuzaki proposed openstack/swift feature/s3api: Avoid global LOGGER instance  https://review.openstack.org/52926809:34
*** jistr|off|mtg is now known as jistr09:36
kota_good morning acoles09:39
acoleskota_: o/09:40
kota_acoles: and a happy new year09:40
acolesthank you. and you too!09:40
kota_acoles: sorry i was missing your message before the last vacation09:40
kota_(and found after the vacation :( )09:40
acolesoh well, better late than never :)09:40
kota_AJaeger: done on patch 530099. thanks for the good work.09:42
patchbothttps://review.openstack.org/#/c/530099/ - swift3 - Import legacy tox jobs09:42
kota_timburke: i suppose you may prefer to patch 529268 rather than the old patch set. however since the work to write the patch takes over the year, i may put some mistakes in the patch so it's nice if you could take time to check the diff.09:45
patchbothttps://review.openstack.org/#/c/529268/ - swift (feature/s3api) - Avoid global LOGGER instance09:45
AJaegerthanks, kota_ !09:45
*** armaan has quit IRC09:46
*** armaan has joined #openstack-swift09:47
*** hoonetorg has joined #openstack-swift09:49
*** armaan has quit IRC10:07
*** armaan has joined #openstack-swift10:07
*** d0ugal has quit IRC10:19
*** mvk has joined #openstack-swift10:20
*** d0ugal has joined #openstack-swift10:21
*** tovin07_ has quit IRC10:43
*** m_kazuhiro has quit IRC10:44
*** hoonetorg has quit IRC10:46
*** hoonetorg has joined #openstack-swift10:47
*** hseipp has quit IRC10:54
*** hseipp has joined #openstack-swift10:59
*** hoonetorg has quit IRC11:04
*** vint_bra has joined #openstack-swift11:17
*** kei_yama has quit IRC11:20
*** awkwardpenguin has joined #openstack-swift11:22
*** awkwardpenguin has quit IRC11:26
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Turn down swiftclient and requests probe test logging level earlier  https://review.openstack.org/53216411:27
*** vint_bra has quit IRC11:29
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Turn down swiftclient and requests probe test logging level earlier  https://review.openstack.org/53216411:29
*** vint_bra has joined #openstack-swift11:32
*** bkopilov has quit IRC11:36
*** mvk has quit IRC11:45
acolesare the zuul checks smart enough to not run the dsvm jobs when the a patch only changes a unit test? e.g. p 53181511:52
patchbothttps://review.openstack.org/#/c/531815/ - swift - Fix intermittent check_delete_headers failure11:52
acolestimburke: ^^ you know *everything* ;)11:53
openstackgerritMerged openstack/swift master: Allow InternalClient to container/object listing with prefix  https://review.openstack.org/53000611:59
*** hoonetorg has joined #openstack-swift12:34
*** mvk has joined #openstack-swift12:47
*** zhurong_ has joined #openstack-swift12:56
*** hoonetorg has quit IRC13:03
*** zhurong_ has quit IRC13:07
*** bkopilov has joined #openstack-swift13:17
*** awkwardpenguin has joined #openstack-swift13:23
*** awkwardpenguin has quit IRC13:28
*** Dw_Sn has joined #openstack-swift13:34
Dw_SnHello, I have an issue with one of my ring, it s -55.55 balance and now the rest of my luns are getting full and this one is free, can I run rebalance ? or check if there is a rebalance process running already ?13:35
*** AJaeger has left #openstack-swift13:36
*** hseipp has quit IRC14:03
*** saint_ has joined #openstack-swift14:16
*** psachin has quit IRC14:28
*** awkwardpenguin has joined #openstack-swift14:30
*** awkwardpenguin has quit IRC14:35
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Add state and state_timestamp to ShardRange  https://review.openstack.org/53148815:12
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Set shard range state during sharding  https://review.openstack.org/53148915:12
*** saint_ has quit IRC15:14
*** hoonetorg has joined #openstack-swift15:16
openstackgerritAlistair Coles proposed openstack/swift master: Use _update_x_timestamp method in object controller DELETE method  https://review.openstack.org/53144715:23
acoleszaitcev: timburke: ^^ sorry to ask for your votes again but I liked timburke's suggestions15:26
zaitcevoffset is something like 0.123_456, right?15:28
acoleszaitcev: correct15:28
zaitcevIs that even legal for clients to supply15:28
zaitcevwhy are they messing with our representation15:29
zaitcevis this for container-sync or something15:29
*** ChanServ sets mode: +v jrichli15:30
zaitcevI mean, it someone at proxy is trying to tell object server to delete at 0.123_456, it ought to be rejected with a 400.15:30
acolesin general clients can't supply x-timestamp, the gatekeeper prevents it. container sync is an exception. but internal client might get given an offset timestamp15:31
zaitcevActually.... this is a test for proxy, not object server.15:31
acolese.g. the reconciler uses offsets with internal client requests https://github.com/openstack/swift/blob/85d6cd30be965d3df2dca22d363aafd12146f869/swift/container/reconciler.py#L397-L43115:31
zaitcevMakes sense, thanks15:32
*** links has quit IRC15:36
*** hoonetorg has quit IRC15:41
*** hoonetorg has joined #openstack-swift15:54
*** ^andrea^ has quit IRC16:17
*** itlinux has joined #openstack-swift16:19
*** awkwardpenguin has joined #openstack-swift16:32
*** awkwardpenguin has quit IRC16:37
openstackgerritMerged openstack/swift master: Fix intermittent check_delete_headers failure  https://review.openstack.org/53181516:38
*** geaaru has quit IRC16:48
*** hseipp has joined #openstack-swift16:50
*** itlinux has quit IRC16:56
*** gyee has joined #openstack-swift17:01
*** mvk has quit IRC17:06
*** awkwardpenguin has joined #openstack-swift17:18
*** itlinux has joined #openstack-swift17:18
notmynamegood morning17:19
*** cbartz has quit IRC17:22
*** hseipp has quit IRC17:27
*** Dw_Sn has quit IRC17:29
*** JimCheung has joined #openstack-swift17:39
timburkeacoles: on the dsvm jobs -- yep :-) i did that in https://github.com/openstack-infra/project-config/commit/633b4c69317:45
acolestimburke: nice17:47
timburkeSO much faster17:47
acolesyup17:47
*** awkwardpenguin has quit IRC17:48
*** gkadam has quit IRC17:49
*** tesseract has quit IRC17:57
*** hseipp has joined #openstack-swift18:19
*** hseipp has quit IRC18:29
*** itlinux has quit IRC18:38
*** itlinux has joined #openstack-swift18:42
*** itlinux has quit IRC18:46
*** itlinux has joined #openstack-swift18:49
*** itlinux has quit IRC18:52
*** itlinux has joined #openstack-swift18:54
*** itlinux has quit IRC18:55
*** gkadam has joined #openstack-swift18:57
*** JimCheung has quit IRC18:59
*** JimCheung has joined #openstack-swift19:01
notmynamereminder, we should cut a release soon, so https://wiki.openstack.org/wiki/Swift/PriorityReviews is being updated with appropriate patches19:02
notmynamenote that the queens cycle is ending soon (next month), so this may be a final release in queens, or we may have a smaller fast-follow release closer to the queens freeze date (feb 19)19:02
clayginteresting...19:18
openstackgerritClay Gerrard proposed openstack/swift master: Further extract a builder method to a util function  https://review.openstack.org/53229119:18
*** itlinux has joined #openstack-swift19:18
notmynameclayg: I find your "interesting..." comment interesting19:22
claygi just hadn't realized we were so close to OS release - your point about the timelines is realistic I think - and it's a reminder that time moves fast19:22
notmynameah. I thought your refactor was the interesting one :-)19:23
notmynameand I was trying to work out why19:23
notmynameyeah, the queens release kinda snuck up on me too19:23
claygno, that's just trying to help up some newish contributor that's been poking around at stuff19:24
notmynameinteresting...19:24
notmyname;-)19:24
*** itlinux has quit IRC19:24
claygfollowing up on something they already have loaded in their brain seems like a good way to introduce them to different ideas about clarity and maintainability and collaboration...19:24
claygit was orthogonal to my reaction to the release - and significantly LESS interesting in my mind ;)19:25
*** hoonetorg has quit IRC19:25
*** gkadam has quit IRC19:32
*** itlinux has joined #openstack-swift19:36
*** itlinux has quit IRC19:41
claygtimburke: looks like you pointed torgomatic at some issues with the pipeline insertion on patch 528106 - but didn't -119:57
patchbothttps://review.openstack.org/#/c/528106/ - swift - Move CORS to middleware.19:57
timburkeshit, i still have three pending drafts! i better finish that review!19:58
timburkei got side-tracked by wanting to write a CORS-functest harness, but i'm having a hard time imagining it being worth the (rather large) amount of work that requires19:59
claygtimburke: did you look at the existing functional tests for CORS?  I feel like the existing functests are mostly focused on objects... but the unittests seem to do some assertions on container requests and strict mode about a few things...20:00
claygah...20:01
claygis that mainly because or CORS support is so flakey/underused?20:01
timburkeclayg: certainly seems to be -- but then, you saw my rant last week around http://eavesdrop.openstack.org/irclogs/%23openstack-swift/%23openstack-swift.2018-01-05.log.html#t2018-01-05T21:58:03 :P20:03
claygyeah :D20:04
timburkeyou can't even auth against tempauth... now i'm wondering if SLO/DLO work... it's a mess20:04
timburkeany time a middleware swallows a proxy-server response (or never even *calls* the proxy!) and instead makes up something from whole cloth, we've almost certainly broken CORS20:06
timburkegiven that we *haven't* had people screaming at us about it... it's probably underused to the point that we'll just continue to neglect it? torgomatic's patch is a good step toward *not*-neglect, but i'm increasingly feeling like the best way to make sure CORS works is a func test harness that simulates how a browser handles CORS20:11
*** mvk has joined #openstack-swift20:11
timburkeand it turns out that's *also* really messy, and a lot of work, and you'd still be left wondering "did we *accurately* simulate a browser's behavior?"20:12
timburkemaybe something like https://github.com/synacor/python-cors would be helpful?20:15
*** hoonetorg has joined #openstack-swift20:21
*** armaan has quit IRC20:22
*** armaan has joined #openstack-swift20:23
*** armaan has quit IRC20:44
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Set shard range state during sharding  https://review.openstack.org/53148920:44
openstackgerritAlistair Coles proposed openstack/swift feature/deep: WIP NEEDS TEST Fix container listing while in sharding state  https://review.openstack.org/53230820:45
notmynametimburke: https://docs.openstack.org/swift/latest/cors.html#test-cors-page20:58
notmynamethat's the one I was thinking of. not sure how helpful it is for what you're doing20:59
timburkenotmyname: thanks -- reasonably interesting, but not so far off from what i'm already playing with. still manual :-( i might see what i can do to build out some sort of "automated" in-browser test suite21:06
notmynameit has the advantage of already being in our source repo :-)21:06
*** pcaruana has quit IRC21:38
*** threestrands has joined #openstack-swift21:44
*** threestrands has quit IRC21:44
*** threestrands has joined #openstack-swift21:44
torgomaticwe should just give up on CORS entirely22:02
torgomaticthe point of CORS is so the browser can provide or not provide data to the running JS application, but it's data that the browser has access to already22:02
torgomaticnow, thanks to the miracle of speculative execution and cache-timing attacks, the JS application has access to the data anyway, so we don't need CORS at all! :p22:03
*** rcernin has joined #openstack-swift22:06
openstackgerritMerged openstack/swift feature/deep: Turn down swiftclient and requests probe test logging level earlier  https://review.openstack.org/53216422:14
notmynametorgomatic: lol22:14
openstackgerritSamuel Merritt proposed openstack/swift master: Limit object-expirer queue updates on object DELETE  https://review.openstack.org/53234222:23
claygtorgomatic: ^ this is pretty shitty22:26
claygtorgomatic: i missed that when you were talking about it earlier22:26
torgomaticclayg: the code, the situation, or both? :p22:26
clayglol, well I don't immediately *love* X-Backend-Update-Expiring-Object-Queue: <true|false>22:27
claygwhy not just don't send the expirer update headers?  Or maybe better question - why isn't pop_queue *eventually* going to be everything we need?22:27
torgomaticclayg: it's already not sending expirer update headers22:28
torgomaticthis is on object DELETE, so the object server is the only guy who knows if the object is expiring or not22:28
claygI'm pretty sure the reconciler relies on it's own idempotency to eventually clean up a missed queue update22:28
torgomaticand he's got no rings, so he just drops an async_pending and calls it a day22:28
claygoh sorry - i'm starting to catch on22:29
mattoliveraumorning22:29
torgomaticyeah, the expirer will clean his own queue if you let him go; the early delete is an optimization so if you prematurely delete a bunch of expiring objects, the queue shrinks back down22:29
torgomaticmorning!22:29
claygmeh... only if you haven't since changed your container divisor - or it wasn't in a container before we started doing the divisor_container - hash % 100 thing22:30
timburkeand the upgrade path to making proxy-server send down expirer update headers and object-server rely solely on that involves losing expirer-queue updates22:30
claygtimburke: you mean have the proxy pre-calculate expirer update headers just in case22:31
torgomaticI'm not opposed to updating the expirer queue on object DELETE, but maybe let's not do it so much is all I'm saying22:31
timburkeya, like we already do for container updates22:32
torgomaticif you miss an update, things still work correctly, so let's not destroy the container servers in order to optimize them22:32
torgomaticyou can't compute expirer update headers on DELETE; you don't know the object's X-Delete-At, so you can't figure out which shard to look up in the ring22:33
claygthis applies equally to PUT overwrite?22:33
*** awkwardpenguin has joined #openstack-swift22:33
torgomaticcould be; I haven't looked22:33
timburkeah, good point. i was thinking about the PUT/POST path22:34
torgomaticclayg: ...yep, applies to PUT overwrite too, so I should probably get that code path22:34
timburkeyup. only it get *even more fun* since we need to delete the old entry then add the new one22:34
torgomaticat least we get update headers for the new one, so it's not always going to async_pending22:35
claygdoes the *expirer* itself somehow supress the generation of the async pendings tho?  this is *any* DELETE or just DELETEs from the client?22:35
torgomaticclayg: currently, no, the expirer doesn't suppress anything, so the expirer issues a bunch of DELETE requests (creating async_pendings), then directly deletes the container rows, then the object updater eats the async_pendings and directly deletes the container rows a lot22:36
torgomaticI'm working on fixing that thing next now that I've got a way of suppressing the generation of those async_pendings22:36
torgomaticalthough I should probably fix up PUT-overwrite first22:42
mattoliverauwhile thinking about the expirer, which is good. We should also think about how far away is the general task queue which will also change how the expirer will operate. And can we glean something from what your working on now that we can put into the general queue design and expirer reimplementation?22:44
torgomaticmattoliverau: maybe? The general queue thing is about what the queue looks like; the stuff I'm doing is about how many enqueue/dequeue operations occur22:44
*** itlinux has joined #openstack-swift22:47
mattoliverausure. I understand :) just want to make sure whatever brillant enqueue/dequeue optimisations you come up with making it known so anything using the new queue can take advantage (or copy) ;) Just saying keep on going but don't forget Kazuhiro is playing with reworking the expirer as well, and not sure how much of the changes he's making would conflict with what your playing with (patch 517389)22:54
mattoliveraumaybe none, but want just wanted to put it in the back of everyones mind :)22:56
torgomatic:)22:57
mattoliverauAlso, I've woken up to an email saying work'll send me to the PTG! now need to go deal with find the best 30+ hour flights.23:02
*** awkwardpenguin has quit IRC23:04
*** awkwardpenguin has joined #openstack-swift23:04
torgomatichooray! I mean, not for the 30-hour flight part, but for the rest23:07
*** awkwardpenguin has quit IRC23:10
timburkemattoliverau: yay!23:26
timburkespeaking of... i should go book tickets/travel/hotel...23:26
torgomatictimburke: you've got to call the hotel on the phone. They have a website, but it won't take the room-block code, and if you email them then they email you back asking for a credit-card number (in cleartext email!), so...23:28
notmynamemattoliverau: yay23:31
*** kei_yama has joined #openstack-swift23:37
*** vint_bra has joined #openstack-swift23:49
openstackgerritTim Burke proposed openstack/swift master: Add pipeline modification test for previously-recommended pipelines  https://review.openstack.org/53236023:56
timburketorgomatic: maybe handy? ^^^23:56
timburkei kinda wanna just get it out of the git history dynamically... but the expectations are going to have to be specified out-of-band...23:58
*** vint_bra has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!