Thursday, 2018-04-26

*** ukaynar has joined #openstack-swift00:11
*** brimestone has quit IRC00:13
*** openstackgerrit has joined #openstack-swift00:36
openstackgerritClay Gerrard proposed openstack/swift feature/deep: make sharding 100x faster  https://review.openstack.org/56437400:36
*** ukaynar has quit IRC00:46
*** vint_bra has joined #openstack-swift00:58
openstackgerritMerged openstack/swift master: Make reconstructor go faster with --override-devices  https://review.openstack.org/55595101:00
*** vint_bra has quit IRC01:23
kota_oh, sounds awesome. sharding is being faster 100x!?01:31
DHEit's just a checkbox. now we make it the default.01:33
DHE:)01:33
notmynamelol @ patch 56437401:39
patchbothttps://review.openstack.org/#/c/564374/ - swift (feature/deep) - make sharding 100x faster01:39
notmynametimburke: can we get that pushed to the qa cluster asap?01:41
*** wangyx has joined #openstack-swift01:52
*** kei_yama has quit IRC01:53
openstackgerritNguyen Hai proposed openstack/python-swiftclient master: Change python-swiftclient webpage to openstackdocstheme  https://review.openstack.org/55343301:53
openstackgerritNguyen Hai proposed openstack/python-swiftclient master: Change python-swiftclient webpage to openstackdocstheme  https://review.openstack.org/55343301:53
*** kei_yama has joined #openstack-swift01:57
*** AndyWojo_ has joined #openstack-swift02:08
*** viks_ has joined #openstack-swift02:08
*** early` has joined #openstack-swift02:09
*** ndk- has joined #openstack-swift02:12
*** AndyWojo has quit IRC02:12
*** early has quit IRC02:12
*** viks has quit IRC02:12
*** blair has quit IRC02:12
*** d0ugal has quit IRC02:12
*** ndk_ has quit IRC02:12
*** AndyWojo_ is now known as AndyWojo02:12
*** viks_ is now known as viks02:12
*** blair has joined #openstack-swift02:13
*** d0ugal has joined #openstack-swift02:13
*** Renich has quit IRC02:16
*** gkadam has joined #openstack-swift02:26
*** psachin has joined #openstack-swift02:49
*** armaan has quit IRC03:16
*** armaan has joined #openstack-swift03:17
*** dr_gogeta86 has quit IRC03:28
*** dr_gogeta86 has joined #openstack-swift03:30
*** dr_gogeta86 has quit IRC03:30
*** dr_gogeta86 has joined #openstack-swift03:30
*** kei_yama has quit IRC03:36
*** kei_yama has joined #openstack-swift03:40
*** bkopilov has quit IRC03:45
openstackgerritMerged openstack/swift feature/deep: make sharding 100x faster  https://review.openstack.org/56437403:54
timburkeclayg: one thought on ^^^ -- do we need the db version check to switch between 'deleted' and '+deleted'?04:20
*** armaan has quit IRC04:22
*** armaan has joined #openstack-swift04:23
*** gkadam has quit IRC04:45
*** ccamacho has quit IRC04:48
*** links has joined #openstack-swift04:53
*** gkadam has joined #openstack-swift05:29
*** bkopilov has joined #openstack-swift05:29
*** d0ugal has quit IRC05:46
*** geaaru has quit IRC05:48
*** armaan has quit IRC06:12
*** armaan has joined #openstack-swift06:13
*** armaan has quit IRC06:13
*** d0ugal has joined #openstack-swift06:13
*** armaan has joined #openstack-swift06:13
*** kei_yama has quit IRC06:31
*** kei_yama has joined #openstack-swift06:44
*** cbartz has joined #openstack-swift06:46
*** tesseract has joined #openstack-swift06:58
*** tesseract has quit IRC07:00
*** tesseract has joined #openstack-swift07:02
*** ccamacho has joined #openstack-swift07:03
*** ntt has quit IRC07:13
*** ntt has joined #openstack-swift07:20
*** silor has joined #openstack-swift07:22
*** guest has joined #openstack-swift07:26
guest{"error": {"message": "The request you have made requires authentication.", "code": 401, "title": "Unauthorized"}}07:26
*** pcaruana has joined #openstack-swift07:31
*** rcernin has quit IRC07:32
guest.{"error": {"message": "The request you have made requires authentication.", "code": 401, "title": "Unauthorized"}}07:33
acolesgood morning07:40
*** geaaru has joined #openstack-swift07:41
acolesaha, while I sleep,  clayg fixes everything07:42
*** threestrands_ has quit IRC07:52
*** gkadam has quit IRC07:56
*** ccamacho has quit IRC08:08
*** ccamacho has joined #openstack-swift08:11
*** gkadam has joined #openstack-swift08:20
*** cbartz has quit IRC08:30
*** Renich has joined #openstack-swift08:50
*** jmccarthy has joined #openstack-swift08:52
*** jmccarthy has left #openstack-swift08:53
*** cbartz has joined #openstack-swift08:57
*** hoonetorg has quit IRC08:58
*** guest has quit IRC09:08
openstackgerritTovin Seven proposed openstack/swift master: OSprofiler in OpenStack Swift  https://review.openstack.org/46831609:12
*** hoonetorg has joined #openstack-swift09:15
*** Renich has quit IRC09:39
*** Fr33m1nd has joined #openstack-swift09:41
*** mtreinish has quit IRC09:41
*** mtreinish has joined #openstack-swift09:47
*** silor1 has joined #openstack-swift09:56
*** silor has quit IRC09:58
*** silor1 is now known as silor09:58
*** cbartz has quit IRC09:59
*** armaan has quit IRC10:03
*** ccamacho has quit IRC10:07
*** cbartz has joined #openstack-swift10:07
openstackgerritMerged openstack/swift feature/deep: Refactor finding sharding and shrinking candidates  https://review.openstack.org/56427710:08
*** ccamacho has joined #openstack-swift10:08
*** ccamacho has quit IRC10:08
*** ccamacho has joined #openstack-swift10:08
*** cbartz has quit IRC10:18
*** Renich has joined #openstack-swift10:20
*** silor has quit IRC10:24
*** Fr33m1nd has quit IRC10:28
*** cbartz has joined #openstack-swift10:28
*** cbartz has quit IRC10:44
*** threestrands_ has joined #openstack-swift11:01
*** Fr33m1nd has joined #openstack-swift11:03
*** Fr33m1nd has quit IRC11:04
*** armaan has joined #openstack-swift11:12
*** vint_bra has joined #openstack-swift11:35
*** wangyx has quit IRC11:36
*** bkopilov has quit IRC11:38
*** armaan has quit IRC11:45
*** StevenK has quit IRC11:55
*** wangyx has joined #openstack-swift11:55
*** StevenK has joined #openstack-swift11:56
*** vint_bra has quit IRC12:01
*** hseipp has joined #openstack-swift12:06
*** Fr33m1nd has joined #openstack-swift12:13
*** Fr33m1nd has quit IRC12:18
*** kei_yama has quit IRC12:34
*** psachin has quit IRC12:38
*** vint_bra has joined #openstack-swift12:42
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Stop internal client txn_id bleeding into sharder logs  https://review.openstack.org/56448812:47
*** threestrands_ has quit IRC12:58
*** bkopilov has joined #openstack-swift13:23
*** brimestone has joined #openstack-swift13:27
*** mvk has quit IRC13:29
*** brimestone has quit IRC13:33
*** vint_bra has quit IRC13:40
*** ediardo has quit IRC13:44
*** mvk has joined #openstack-swift13:58
*** armaan has joined #openstack-swift14:24
*** bkopilov has quit IRC14:32
*** bkopilov has joined #openstack-swift14:35
*** pcaruana has quit IRC14:42
*** armaan has quit IRC14:58
*** silor has joined #openstack-swift14:59
*** early` has quit IRC15:03
*** jistr|mtgs is now known as jistr15:04
*** links has quit IRC15:06
-openstackstatus- NOTICE: We've successfully troubleshooted the issue that prevented paste.openstack.org from loading and it's now back online, thank you for your patience.15:06
*** wangyx has quit IRC15:09
*** early has joined #openstack-swift15:15
*** silor has quit IRC15:21
notmynamegood morning15:26
notmynamerledisez: et al: the sharding speed is going a lot faster in the cluster with the big DB, now that patch 564374 landed15:26
patchbothttps://review.openstack.org/#/c/564374/ - swift (feature/deep) - make sharding 100x faster (MERGED)15:26
rlediseznotmyname: nice, that's the best "2-lines patch" ever!15:27
notmyname:-)15:28
DHEas a layperson who does know SQL, what values besides 0 and 1 can 'deleted' take anyway such that this would help so much?15:31
DHE(or is it an index thing?)15:31
*** zaitcev_ has joined #openstack-swift15:33
*** ChanServ sets mode: +v zaitcev_15:33
*** zaitcev has quit IRC15:37
*** gyee has joined #openstack-swift15:40
timburkegood morning15:43
timburkeacoles: isn't that just always the case? ;-)15:43
acolestimburke: yep, so typical15:44
acoles:)15:44
timburkeDHE: it's an index thing. deleted will only ever be 0 or 1, but since it wasn't in the query, sqlite didn't know to use the index15:44
*** gkadam has quit IRC15:53
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Reclaim deleted shard range rows after 2 * reclaim_age  https://review.openstack.org/56454015:55
*** silor has joined #openstack-swift16:02
*** d0ugal has quit IRC16:03
*** d0ugal has joined #openstack-swift16:04
notmynamecschwede: mattoliverau: thanks for the s3api reviews so far16:17
*** geaaru has quit IRC16:27
*** brimestone has joined #openstack-swift16:27
*** silor has quit IRC16:45
*** germs has joined #openstack-swift16:50
*** germs has quit IRC16:50
*** germs has joined #openstack-swift16:50
DHEtimburke: interesting... not what I expected...16:53
*** ediardo has joined #openstack-swift16:55
timburkethe trouble is that sqlite doesn't know what kinds of values deleted might have -- as far as it's concerned, that could take any of 4 billion values, so it assumes the index wouldn't be useful16:55
*** silor has joined #openstack-swift16:56
*** ChanServ changes topic to "https://bugs.not.mn/project/Swift | Logs: http://eavesdrop.openstack.org/irclogs/%23openstack-swift/ | Meetings: https://wiki.openstack.org/wiki/Meetings/Swift | Review Dashboard: http://not.mn/reviews.html"16:56
DHEdepends on the index type. I'm used to mysql/pgsql which use btree indexes which are useful for searches on only 'a' when the index was built on (a,b)16:56
timburke(really, it assumes it could take *any value* -- as i recall, it trusts the developer rather than impose a strict adherence to the schema)16:56
DHEbut for a hash index, yeah I can see that16:56
timburkesqlite also uses btrees, as i recall. since it's a (deleted, name) index, you need to be searching off deleted as well as name to get the benefit16:57
DHEah, the commit message says "(name, deleted) index" so that's what confused me16:59
notmynameacoles: clayg: timburke: tdasilva: would next tuesday work for a video chat about feature/deep? how about 9am pacific/1600utc ?16:59
*** hseipp has quit IRC17:00
acolesnotmyname: ok for me17:00
timburkeah, yeah. didn't notice the error in the message -- too happy that it fixed the problem!17:01
clayg9-9:30 is when I walk my kids to school. I’ll could try to drop them off early and join late. So mostly wfm.17:01
notmynameI keep forgetting how late your kids start17:02
timburkei can probably make that work. assuming no baby yet17:02
claygDHE: i probably could have been more clear in the commit. Thanks for asking for clarity.17:04
*** germs has quit IRC17:13
*** germs has joined #openstack-swift17:13
*** germs has quit IRC17:13
*** germs has joined #openstack-swift17:13
notmynameacoles: when I make feature/deep-review, I'll need to give it a commit sha on master from which to branch. is there any reason to not use HEAD of master?17:24
*** germs has quit IRC17:24
timburkeoh yeah... i should do another merge of master to feature/deep... i think there are some conflicts in utils...17:25
*** germs has joined #openstack-swift17:25
*** germs has quit IRC17:25
*** germs has joined #openstack-swift17:25
acolesnotmyname: not that I am aware of. My plan was to merge from master into feature/deep once s3api lands, then propose patches to feature/deep-review. Make sense?17:25
notmynameyep. makes sense17:26
acolesor...I'll wait for timburke to do the first part :)17:26
*** germs has quit IRC17:26
*** germs has joined #openstack-swift17:26
*** germs has quit IRC17:26
*** germs has joined #openstack-swift17:26
notmynameI'll wait on creating deep-review until s3api lands (or at least give it another 24 hours or so). it *shouldn't* take too long for that to be created17:27
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Remove unused code for passing shard ranges via the pending file  https://review.openstack.org/56457017:41
*** germs has quit IRC17:46
*** germs has joined #openstack-swift17:47
*** germs has quit IRC17:47
*** germs has joined #openstack-swift17:47
*** geaaru has joined #openstack-swift17:51
*** mvk has quit IRC17:55
*** brimestoned has joined #openstack-swift17:57
*** brimestone has quit IRC17:59
*** tesseract has quit IRC18:24
*** mvk has joined #openstack-swift18:31
*** hseipp has joined #openstack-swift19:09
*** brimestoned has quit IRC19:17
*** brimestoned has joined #openstack-swift19:18
*** armaan has joined #openstack-swift19:19
*** armaan has quit IRC19:22
*** ediardo has quit IRC19:23
*** ukaynar has joined #openstack-swift19:37
openstackgerritTim Burke proposed openstack/swift feature/deep: Skip commits when recording progress for logs/recon  https://review.openstack.org/56427119:45
openstackgerritTim Burke proposed openstack/swift feature/deep: Catch more exceptions when recording progress  https://review.openstack.org/56460519:45
*** silor has quit IRC19:50
*** geaaru_ has joined #openstack-swift19:58
*** hseipp has quit IRC19:59
*** ukaynar has quit IRC19:59
*** geaaru has quit IRC20:00
*** ukaynar has joined #openstack-swift20:00
openstackgerritTim Burke proposed openstack/swift feature/deep: Clean up logs a bit  https://review.openstack.org/56461320:01
*** geaaru__ has joined #openstack-swift20:04
*** NM has joined #openstack-swift20:04
*** geaaru_ has quit IRC20:06
claygi was able to duplicate the failures on patch 564488 - so I'm going to look at those20:07
patchbothttps://review.openstack.org/#/c/564488/ - swift (feature/deep) - Stop internal client txn_id bleeding into sharder ...20:07
timburkeoh yeah, that reminds me of https://review.openstack.org/#/c/507706/ -- i'd originally done that with the sharder in mind20:08
patchbotpatch 507706 - swift - Clear logger txn_id after making requests20:08
*** geaaru_ has joined #openstack-swift20:09
*** geaaru__ has quit IRC20:12
*** geaaru__ has joined #openstack-swift20:16
*** geaaru_ has quit IRC20:18
openstackgerritClay Gerrard proposed openstack/swift feature/deep: Stop internal client txn_id bleeding into sharder logs  https://review.openstack.org/56448820:18
claygtorgomatic: what do you think about making internal_client.make_request *always* do a spawn().wait() so that the request happens in a different thread_id and the loggers thread_locals txn_id never pick up the reference to subrequest's info and cram it on to subsequent log messages?20:21
claygtorgomatic: i ask in the context of patch 56448820:29
patchbothttps://review.openstack.org/#/c/564488/ - swift (feature/deep) - Stop internal client txn_id bleeding into sharder ...20:29
acolestimburke: we both had same thought... my drive by here https://review.openstack.org/#/c/564540/1/swift/container/sharder.py@1133 vs https://review.openstack.org/#/c/564613/120:34
patchbotpatch 564540 - swift (feature/deep) - Reclaim deleted shard range rows after 2 * reclaim...20:34
patchbotpatch 564613 - swift (feature/deep) - Clean up logs a bit20:34
openstackgerritAlistair Coles proposed openstack/swift feature/deep: Reclaim deleted shard range rows after 2 * reclaim_age  https://review.openstack.org/56454020:36
timburkei think i'd like internal_client better if it took on the log_name of whoever created it :-/20:37
timburkeacoles: nice! yeah -- either's fine by me :-)20:37
acolestimburke: you won20:38
acolespulled it out of my patch, +A on yours20:38
*** geaaru__ has quit IRC21:02
openstackgerritTim Burke proposed openstack/swift feature/deep: Commit from pending file less often  https://review.openstack.org/56463021:27
timburkeacoles: ^^^ might make https://review.openstack.org/#/c/564271/ mostly unnecessary? *shrug*21:28
patchbotpatch 564271 - swift (feature/deep) - Skip commits when recording progress for logs/recon21:28
timburkethere's still that call to _make_stats_info though...21:29
*** NM has quit IRC21:48
*** NM has joined #openstack-swift21:58
timburkeso how icky would it be to scribble down some reference to the parent container's sharding context (in incoming sync points, maybe?) when cleaving to a (sub-)shard once we're ready to replicate? then if replication fails, when we come 'round to cleave it again... we skip straight to replication if it matches our cleave context at that time22:06
timburkeacoles: clayg: mattoliverau: ^^^22:07
*** rcernin has joined #openstack-swift22:23
mattoliveraumorning22:37
mattoliverautimburke: I think I need a coffee before I can think that through :)22:38
*** NM has quit IRC22:41
*** kei_yama has joined #openstack-swift23:20
*** ukaynar has quit IRC23:25
openstackgerritSamuel Merritt proposed openstack/swift master: Refactor replicators' statistics  https://review.openstack.org/56464623:29
*** brimestoned has quit IRC23:35
openstackgerritMerged openstack/swift feature/deep: Remove unused code for passing shard ranges via the pending file  https://review.openstack.org/56457023:44
*** brimestone has joined #openstack-swift23:44
*** gyee has quit IRC23:54
openstackgerritTim Burke proposed openstack/swift feature/deep: Parameterize SQL args  https://review.openstack.org/56465123:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!