| *** klamath has quit IRC | 00:42 | |
| *** gyee has quit IRC | 01:00 | |
| *** armaan_ has joined #openstack-swift | 01:02 | |
| *** armaan has quit IRC | 01:04 | |
| *** amandap has joined #openstack-swift | 02:18 | |
| kota_ | acoles: no worries. I'll continue other parts in sharder, I might find some answers by my-self during the process. | 02:24 |
|---|---|---|
| kota_ | ok, i found the acoles' answer for _find_ranges, let me check/play within my local. | 02:31 |
| *** Jeffrey4l has quit IRC | 03:48 | |
| *** Jeffrey4l has joined #openstack-swift | 03:55 | |
| *** germs has quit IRC | 03:59 | |
| *** germs_ has joined #openstack-swift | 03:59 | |
| *** rcernin has quit IRC | 04:03 | |
| *** rcernin has joined #openstack-swift | 04:03 | |
| *** germs_ has quit IRC | 04:04 | |
| *** gyan_ has joined #openstack-swift | 04:12 | |
| *** rickflare2 has joined #openstack-swift | 04:19 | |
| *** early has quit IRC | 05:04 | |
| *** early has joined #openstack-swift | 05:15 | |
| *** cshastri has joined #openstack-swift | 06:01 | |
| *** psachin has joined #openstack-swift | 06:01 | |
| *** cbartz has joined #openstack-swift | 06:10 | |
| *** ccamacho has quit IRC | 06:22 | |
| *** cbartz has quit IRC | 06:25 | |
| openstackgerrit | yfzhao proposed openstack/swift master: Replace deprecated "auth_uri" by "www_authenticate_uri" https://review.openstack.org/569341 | 06:34 |
| *** ccamacho has joined #openstack-swift | 06:40 | |
| *** bkopilov has quit IRC | 06:50 | |
| *** rcernin has quit IRC | 07:01 | |
| *** cbartz has joined #openstack-swift | 07:05 | |
| *** bkopilov has joined #openstack-swift | 07:07 | |
| *** tesseract has joined #openstack-swift | 07:14 | |
| *** threestrands has quit IRC | 07:17 | |
| *** geaaru has joined #openstack-swift | 07:27 | |
| *** armaan_ has quit IRC | 07:29 | |
| *** armaan has joined #openstack-swift | 07:29 | |
| acoles | good morning | 07:57 |
| *** mikecmpbll has joined #openstack-swift | 08:06 | |
| *** silor has joined #openstack-swift | 08:11 | |
| *** gkadam has joined #openstack-swift | 08:18 | |
| *** vinsh has quit IRC | 08:19 | |
| *** mvk has quit IRC | 08:23 | |
| *** silor has quit IRC | 08:24 | |
| *** silor has joined #openstack-swift | 08:24 | |
| kota_ | good morning acoles | 08:42 |
| acoles | kota_: o/ | 08:42 |
| kota_ | i found Tim answered some of my questions, so I'm going to understand around manage_shard_ranges | 08:42 |
| acoles | ok | 08:43 |
| acoles | I'll fix the doc/config file issue today | 08:43 |
| kota_ | then, probably https://review.openstack.org/#/c/565748/9/swift/cli/manage_shard_ranges.py@96 is a minor bug? | 08:44 |
| patchbot | patch 565748 - swift (feature/deep-review) - Add sharder daemon, manage_shard_ranges tool and p... | 08:44 |
| kota_ | I just was writing a comment there. | 08:44 |
| kota_ | limit=5 as hard coded. | 08:44 |
| acoles | not sure. if limit is -1 at line 84 then find_shard_ranges at line 85 should return all shard ranges so line 96 wouldn't be reached. But I agree its not clear. And I think you pointed out before that maybe limit is always 5, if the func is vener called with status_file=None. | 08:47 |
| acoles | s/vener/never/ | 08:47 |
| acoles | kota_: please leave a comment at line 96 so we can look at improving | 08:48 |
| kota_ | acoles: yup | 08:49 |
| *** cbartz has quit IRC | 08:54 | |
| kota_ | pushed | 08:55 |
| acoles | kota_: thanks | 08:55 |
| *** cbartz has joined #openstack-swift | 09:08 | |
| *** SkyRocknRoll has joined #openstack-swift | 09:09 | |
| *** mikecmpb_ has joined #openstack-swift | 09:22 | |
| *** mikecmpbll has quit IRC | 09:23 | |
| *** silor1 has joined #openstack-swift | 09:59 | |
| *** silor has quit IRC | 10:01 | |
| *** silor1 is now known as silor | 10:01 | |
| *** armaan has quit IRC | 10:24 | |
| *** armaan has joined #openstack-swift | 10:24 | |
| *** mikecmpb_ has quit IRC | 10:28 | |
| *** mikecmpbll has joined #openstack-swift | 10:31 | |
| *** mikecmpb_ has joined #openstack-swift | 11:01 | |
| *** mikecmpbll has quit IRC | 11:02 | |
| *** vinsh has joined #openstack-swift | 11:37 | |
| *** amandap has quit IRC | 11:47 | |
| *** armaan has quit IRC | 12:10 | |
| *** armaan has joined #openstack-swift | 12:10 | |
| *** NM has joined #openstack-swift | 12:14 | |
| *** NM has quit IRC | 12:19 | |
| *** psachin has quit IRC | 12:23 | |
| *** kei_yama has quit IRC | 12:49 | |
| *** armaan has quit IRC | 12:52 | |
| *** armaan has joined #openstack-swift | 12:53 | |
| *** vinsh_ has joined #openstack-swift | 12:54 | |
| *** vinsh_ has quit IRC | 12:54 | |
| *** vinsh has quit IRC | 12:54 | |
| *** vinsh has joined #openstack-swift | 12:55 | |
| openstackgerrit | Mark McArdle proposed openstack/swift master: IP Range restrictions in temp urls https://review.openstack.org/569404 | 12:56 |
| *** NM has joined #openstack-swift | 13:08 | |
| *** cshastri has quit IRC | 13:14 | |
| *** silor has quit IRC | 14:17 | |
| *** hoonetorg has quit IRC | 14:28 | |
| *** germs has joined #openstack-swift | 14:33 | |
| *** cbartz has quit IRC | 14:40 | |
| *** hoonetorg has joined #openstack-swift | 14:45 | |
| *** gyan_ has quit IRC | 14:47 | |
| *** gyan_ has joined #openstack-swift | 14:53 | |
| openstackgerrit | Mark McArdle proposed openstack/swift master: IP Range restrictions in temp urls https://review.openstack.org/569404 | 14:53 |
| *** gyan_ has quit IRC | 15:14 | |
| *** armaan has quit IRC | 15:15 | |
| *** germs has quit IRC | 15:15 | |
| *** armaan has joined #openstack-swift | 15:15 | |
| *** germs has joined #openstack-swift | 15:16 | |
| *** germs has quit IRC | 15:16 | |
| *** germs has joined #openstack-swift | 15:16 | |
| *** gkadam_ has joined #openstack-swift | 15:21 | |
| *** gkadam has quit IRC | 15:24 | |
| *** tesseract has quit IRC | 15:46 | |
| *** mikecmpb_ has quit IRC | 16:05 | |
| *** gkadam_ has quit IRC | 16:44 | |
| *** silor has joined #openstack-swift | 16:56 | |
| *** silor has quit IRC | 17:01 | |
| *** geaaru has quit IRC | 17:06 | |
| notmyname | tdasilva: mattoliverau: kota_: and everyone else... here's the plan. acoles will be proposing a patch set that addresses outstanding comments and reviews. then we will merge it today. I will hold off on an upstream 2.18.0 tag for now. likely will tag it in a week or week and a half from now | 17:28 |
| notmyname | IT'S HAPPENING! | 17:29 |
| *** armaan has quit IRC | 17:30 | |
| *** armaan has joined #openstack-swift | 17:57 | |
| acoles | timburke: torgomatic kota_ clayg I just checked that I pushed all my gerrit review comments. apologies if there are any of your review comments I have not responded to, there may be some I thought could be handled as follow ups. new patchsets coming soon, running tests locally. | 18:01 |
| clayg | whoot! | 18:01 |
| *** NM has quit IRC | 18:05 | |
| *** NM has joined #openstack-swift | 18:08 | |
| *** armaan has quit IRC | 18:24 | |
| *** SkyRocknRoll has quit IRC | 18:29 | |
| *** geaaru has joined #openstack-swift | 18:32 | |
| *** silor has joined #openstack-swift | 18:40 | |
| *** NM has quit IRC | 18:52 | |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Add support for sharding in ContainerBroker https://review.openstack.org/565744 | 19:08 |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Add shard range support to container server https://review.openstack.org/565745 | 19:08 |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Enable proxy to build listings from shards https://review.openstack.org/565746 | 19:08 |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Redirect object updates to shard containers https://review.openstack.org/565747 | 19:08 |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Add sharder daemon, manage_shard_ranges tool and probe tests https://review.openstack.org/565748 | 19:08 |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: Add container sharding documentation https://review.openstack.org/565749 | 19:08 |
| acoles | latest patchsets ^^ | 19:09 |
| notmyname | acoles: thanks! | 19:11 |
| notmyname | I'm eating lunch. I'll start the patch landing as soon as I'm done | 19:12 |
| *** NM has joined #openstack-swift | 19:30 | |
| clayg | notmyname: GO FOR IT! | 19:35 |
| clayg | timburke: you ready!? | 19:35 |
| timburke | i'm'a run probe tests one more time... | 19:36 |
| notmyname | done with lunch. I'll start the process now | 19:40 |
| notmyname | timburke: I'll be waiting for your probe test results | 19:40 |
| *** silor has quit IRC | 19:42 | |
| notmyname | timburke: I'll uncork the chain as soon as you share positive probe test results | 19:45 |
| *** NM has quit IRC | 20:03 | |
| timburke | fwiw, manila-tempest-minimal-dsvm-cephfs-native-centos-7 seems to hit the same sort of gate failure as our probe tests | 20:05 |
| timburke | can someone else try running test_misplaced_object_movement ? i'm getting a consistent fail... | 20:07 |
| timburke | (even though logs *say* the sharder did what it was supposed to?) | 20:07 |
| *** NM has joined #openstack-swift | 20:08 | |
| *** NM has quit IRC | 20:11 | |
| *** NM has joined #openstack-swift | 20:13 | |
| *** NM has quit IRC | 20:15 | |
| notmyname | clayg: torgomatic: is that something you can run for timburke? I tried, but my dev environment seems "not healthy" right now | 20:23 |
| torgomatic | notmyname: I can give it a shot; just let me take a minute to pack up my current changes | 20:24 |
| notmyname | thanks | 20:24 |
| *** NM has joined #openstack-swift | 20:24 | |
| timburke | note that you'll need to pick up the option rename in your configs or the tests will skip | 20:31 |
| torgomatic | timburke: which option is this? | 20:35 |
| torgomatic | timburke: never mind, found it | 20:37 |
| torgomatic | test passes on my machine in ~44 seconds | 20:37 |
| acoles | timburke: where did it fail? probe tests were ok for me | 20:40 |
| timburke | will post more info... hold on... | 20:41 |
| acoles | just passed again | 20:44 |
| notmyname | timburke: ? | 20:56 |
| timburke | posted details. there was also an error i'd hit testing utf8 listings? | 21:01 |
| timburke | idk, maybe my env is hosed... but it makes me suspicious... | 21:02 |
| notmyname | where did you post details? | 21:02 |
| timburke | on the patch that added probe tests | 21:03 |
| notmyname | https://review.openstack.org/#/c/565748/ | 21:04 |
| patchbot | patch 565748 - swift (feature/deep-review) - Add sharder daemon, manage_shard_ranges tool and p... | 21:04 |
| timburke | ...and that error turns out *isn't* sporadic -- i thought it was because my first few runs were with -x and only caught the fail | 21:05 |
| timburke | (or rather, stopped upon catching the fail) | 21:06 |
| torgomatic | timburke: do you have the most recent eventlet? that'll poison your stuff | 21:06 |
| timburke | that'll do it :-/ | 21:06 |
| *** NM has quit IRC | 21:08 | |
| acoles | timburke: what shard_container_threshold do you have? | 21:08 |
| timburke | 0.22.1 fixed the error | 21:09 |
| acoles | both? | 21:09 |
| timburke | checking the fail now | 21:10 |
| timburke | though i'd be surprised if that was because of eventlet | 21:10 |
| timburke | yep; still fails | 21:10 |
| timburke | threshold's at 50 | 21:11 |
| acoles | that's same as I use | 21:12 |
| *** NM has joined #openstack-swift | 21:12 | |
| timburke | ...makes me wish our gate check worked... | 21:14 |
| timburke | i guess it's probably fine? WOOPM, right? | 21:14 |
| timburke | :P | 21:14 |
| acoles | timburke: did you post the failure somewhere? | 21:15 |
| timburke | https://review.openstack.org/#/c/565748/11/test/probe/test_sharder.py@1810 -- bah, forgot the actual failure message! "Lists differ: ['alpha'] != []" | 21:18 |
| patchbot | patch 565748 - swift (feature/deep-review) - Add sharder daemon, manage_shard_ranges tool and p... | 21:18 |
| timburke | logs say it moved, but it doesn't show up :-/ | 21:19 |
| acoles | so the assertion at line 302 fails? | 21:21 |
| timburke | ha! showed up in the wrong policy! i've got ec by default and as policy 0 -- and we force a replicated policy! | 21:25 |
| notmyname | ah ha! I ran into that one time. | 21:26 |
| notmyname | probe tests have to have replica policy as the first policy | 21:26 |
| timburke | why? this seems to have exposed a legit bug -- we apparently don't set storage policy properly | 21:27 |
| timburke | hell, what i'd *really* like is to have a test setup with *no policy:0 at all* -- everything *should* work | 21:27 |
| notmyname | we don't set it properly in the test? or in the sharding patch chain? | 21:27 |
| acoles | timburke: can you confirm that the test container is not policy index 0, but the shard does have 'alpha' object with policy index 0? | 21:31 |
| timburke | yep, that's the state. i guess it maybe comes down to the merge_object function in the probe test not being policy-aware? | 21:32 |
| acoles | timburke: exactly my suspicion. horrible but so far necessary hack. | 21:33 |
| acoles | I am just reproducing | 21:33 |
| acoles | oops, that could be misinterpreted :P | 21:34 |
| timburke | wouldn't be too hard to fix, either -- include 'policy_index': shard_broker.sorage_policy_index or somesuch | 21:34 |
| timburke | i think i'm content that it's a test problem, not a sharder problem | 21:34 |
| notmyname | timburke: then I think that means it's time to uncork the chain | 21:37 |
| timburke | DO EEET!! | 21:37 |
| timburke | i gotta bounce | 21:37 |
| notmyname | done | 21:37 |
| notmyname | now it's all the the hands of zuul | 21:37 |
| notmyname | when this chain lands, I'll propose and approve the merge to master itself | 21:38 |
| acoles | timburke: reproduced AssertionError: Lists differ: ['alpha'] != [] | 21:38 |
| *** ukaynar_ has joined #openstack-swift | 21:40 | |
| acoles | fixed | 21:40 |
| notmyname | acoles: can we add that fix on master? | 21:43 |
| acoles | yes, it's a test gremlin, simple fix. I'll push a patch now just to get it off my laptop the cherry-pick to master on Monday | 21:45 |
| *** mikecmpbll has joined #openstack-swift | 21:46 | |
| openstackgerrit | Alistair Coles proposed openstack/swift feature/deep-review: DO NOT MERGE Use correct policy index when faking misplaced objects https://review.openstack.org/569527 | 21:48 |
| acoles | notmyname: ^^ | 21:49 |
| acoles | I'm going back to my glass of wine. good night. | 21:51 |
| *** armaan has joined #openstack-swift | 22:03 | |
| *** ukaynar_ has quit IRC | 22:09 | |
| *** NM has quit IRC | 22:12 | |
| *** armaan has quit IRC | 22:17 | |
| openstackgerrit | Samuel Merritt proposed openstack/swift master: Add support for PROXY protocol v1 (only) https://review.openstack.org/373563 | 22:31 |
| *** Rhvs has quit IRC | 22:35 | |
| *** Rhvs has joined #openstack-swift | 22:41 | |
| *** d0ugal_ has joined #openstack-swift | 23:12 | |
| *** d0ugal has quit IRC | 23:13 | |
| *** mikecmpbll has quit IRC | 23:38 | |
| *** mikecmpbll has joined #openstack-swift | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!