openstackgerrit | Merged openstack/swift master: Use sets instead of dicts when we only care about the keys https://review.openstack.org/569861 | 00:05 |
---|---|---|
*** gyee has quit IRC | 00:17 | |
*** mikecmpbll has quit IRC | 00:25 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Prevent IndexError on bad fragment index https://review.openstack.org/569897 | 00:35 |
*** itlinux has joined #openstack-swift | 00:41 | |
*** itlinux has quit IRC | 00:45 | |
notmyname | just finished my presentation slides for the "state of the project" talk. there's a lot going on in swift, a lot going on around swift, and a lot to keep us very busy for a long time. it's all pretty exciting | 01:08 |
*** amandap has joined #openstack-swift | 01:12 | |
*** psachin has joined #openstack-swift | 01:50 | |
*** zhongjun_ has joined #openstack-swift | 01:53 | |
*** armaan has quit IRC | 02:06 | |
*** armaan has joined #openstack-swift | 02:07 | |
openstackgerrit | Merged openstack/swift master: Fix probe tests in the gate https://review.openstack.org/569882 | 02:22 |
*** itlinux has joined #openstack-swift | 03:08 | |
*** itlinux has quit IRC | 03:12 | |
mattoliverau | notmyname: I saw romain and m_kazuhiro here too | 03:16 |
*** cshastri has joined #openstack-swift | 03:28 | |
hugokuo | morning ! | 03:33 |
hugokuo | Since the deep container is under developing. I wonder if there's an existing tool for benchmarking SqliteDB for container DB so far? | 03:34 |
hugokuo | It seems like the sqlite DB can only handle lower than 200 concurrent update with 10secs lock timeout. | 03:35 |
hugokuo | While the DB is located on SSD. | 03:35 |
*** _alastor_ has quit IRC | 03:55 | |
*** threestrands has quit IRC | 04:02 | |
*** links has joined #openstack-swift | 04:06 | |
*** l4yerffej has quit IRC | 04:17 | |
*** pcaruana has joined #openstack-swift | 04:44 | |
*** spsurya has joined #openstack-swift | 04:45 | |
*** amandap_ has joined #openstack-swift | 04:49 | |
*** amandap has quit IRC | 04:52 | |
*** pcaruana has quit IRC | 05:03 | |
*** amandap_ has quit IRC | 05:05 | |
*** ccamacho has quit IRC | 05:07 | |
*** amandap has joined #openstack-swift | 05:23 | |
*** amandap has joined #openstack-swift | 05:23 | |
*** cshastri has quit IRC | 05:38 | |
*** ccamacho has joined #openstack-swift | 05:51 | |
*** links has quit IRC | 06:08 | |
*** cshastri has joined #openstack-swift | 06:17 | |
*** links has joined #openstack-swift | 06:25 | |
*** cshastri has quit IRC | 06:28 | |
*** cshastri has joined #openstack-swift | 06:31 | |
*** armaan has quit IRC | 06:42 | |
*** armaan has joined #openstack-swift | 06:43 | |
*** pcaruana has joined #openstack-swift | 06:46 | |
*** lifeless has quit IRC | 06:47 | |
*** neonpastor has quit IRC | 07:00 | |
*** ccamacho has quit IRC | 07:00 | |
*** ccamacho has joined #openstack-swift | 07:00 | |
*** neonpastor has joined #openstack-swift | 07:01 | |
*** rcernin has quit IRC | 07:03 | |
*** armaan has quit IRC | 07:04 | |
*** mikecmpbll has joined #openstack-swift | 07:05 | |
*** armaan has joined #openstack-swift | 07:13 | |
*** lifeless has joined #openstack-swift | 07:15 | |
*** armaan has quit IRC | 07:15 | |
*** tesseract has joined #openstack-swift | 07:22 | |
*** hseipp has joined #openstack-swift | 07:31 | |
*** mikecmpb_ has joined #openstack-swift | 07:56 | |
*** links has quit IRC | 07:58 | |
*** mikecmpbll has quit IRC | 07:58 | |
*** geaaru has joined #openstack-swift | 08:00 | |
*** cbartz has joined #openstack-swift | 08:04 | |
*** threestrands has joined #openstack-swift | 08:11 | |
*** links has joined #openstack-swift | 08:11 | |
*** hugokuo has quit IRC | 08:17 | |
*** hugokuo has joined #openstack-swift | 08:20 | |
*** threestrands has quit IRC | 08:46 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Improve building listings from shards https://review.openstack.org/569796 | 08:52 |
openstackgerrit | Alistair Coles proposed openstack/swift master: Check for unexpected shard ranges when building sharded listings https://review.openstack.org/569942 | 08:52 |
*** NM has joined #openstack-swift | 09:03 | |
*** armaan has joined #openstack-swift | 09:24 | |
*** NM1 has joined #openstack-swift | 09:35 | |
*** armaan has quit IRC | 09:35 | |
*** NM has quit IRC | 09:37 | |
*** armaan has joined #openstack-swift | 09:39 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Reclaim expired cleaving context metadata https://review.openstack.org/569832 | 10:20 |
*** mikecmpb_ has quit IRC | 10:21 | |
*** mikecmpbll has joined #openstack-swift | 10:22 | |
*** silor has joined #openstack-swift | 10:27 | |
*** amandap has quit IRC | 10:38 | |
*** NM1 has quit IRC | 10:40 | |
*** NM has joined #openstack-swift | 10:40 | |
*** NM has quit IRC | 10:44 | |
*** pcaruana has quit IRC | 10:53 | |
*** pcaruana has joined #openstack-swift | 11:09 | |
*** SkyRocknRoll has joined #openstack-swift | 11:09 | |
*** SkyRocknRoll has joined #openstack-swift | 11:09 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Reclaim expired cleaving context metadata https://review.openstack.org/569832 | 11:14 |
*** SkyRocknRoll_ has joined #openstack-swift | 11:14 | |
*** SkyRocknRoll has quit IRC | 11:16 | |
*** SkyRocknRoll has joined #openstack-swift | 11:17 | |
*** SkyRocknRoll_ has quit IRC | 11:20 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Simplify ContainerBroker._get_shard_range_rows() https://review.openstack.org/569962 | 11:21 |
*** spsurya has quit IRC | 11:41 | |
*** armaan has quit IRC | 11:41 | |
*** armaan has joined #openstack-swift | 11:44 | |
*** armaan has quit IRC | 11:48 | |
*** armaan has joined #openstack-swift | 11:49 | |
*** armaan has quit IRC | 11:49 | |
*** armaan has joined #openstack-swift | 11:50 | |
*** armaan has quit IRC | 11:51 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Test rsync error log truncation https://review.openstack.org/569968 | 11:59 |
*** silor has quit IRC | 12:03 | |
*** vinsh has quit IRC | 12:04 | |
*** vinsh has joined #openstack-swift | 12:04 | |
*** vinsh has quit IRC | 12:04 | |
*** vinsh has joined #openstack-swift | 12:05 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Avoid premature shrinking in sharder probe test https://review.openstack.org/569973 | 12:35 |
*** mvenesio has joined #openstack-swift | 12:43 | |
*** pcaruana has quit IRC | 12:54 | |
*** cshastri has quit IRC | 12:58 | |
openstackgerrit | Merged openstack/swift master: Remove exclude_states from get_shard_ranges https://review.openstack.org/569840 | 13:04 |
*** pcaruana has joined #openstack-swift | 13:13 | |
*** zigo_ is now known as zigo | 13:22 | |
*** NM has joined #openstack-swift | 13:27 | |
*** NM has quit IRC | 13:33 | |
*** psachin has quit IRC | 13:37 | |
*** ccamacho has quit IRC | 14:19 | |
*** ccamacho has joined #openstack-swift | 14:31 | |
*** ccamacho has quit IRC | 14:31 | |
*** ccamacho has joined #openstack-swift | 14:32 | |
*** cshastri has joined #openstack-swift | 14:34 | |
*** spsurya has joined #openstack-swift | 14:43 | |
*** pcaruana has quit IRC | 14:58 | |
*** armaan has joined #openstack-swift | 15:05 | |
*** cshastri has quit IRC | 15:09 | |
*** links has quit IRC | 15:37 | |
*** gyee has joined #openstack-swift | 15:38 | |
*** cshastri has joined #openstack-swift | 15:39 | |
*** cbartz has quit IRC | 16:05 | |
*** tesseract has quit IRC | 16:17 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Add unit tests for replicator sync_shard_ranges https://review.openstack.org/570005 | 16:18 |
*** ccamacho has quit IRC | 16:23 | |
openstackgerrit | Merged openstack/swift master: s3api: simplify BaseAclHandler.request_with https://review.openstack.org/565872 | 16:28 |
*** armaan has quit IRC | 16:34 | |
*** armaan has joined #openstack-swift | 16:35 | |
*** geaaru has quit IRC | 16:37 | |
*** armaan has quit IRC | 16:38 | |
*** armaan_ has joined #openstack-swift | 16:38 | |
*** mikecmpbll has quit IRC | 16:39 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Prevent IndexError on bad fragment index https://review.openstack.org/569897 | 16:46 |
openstackgerrit | Alistair Coles proposed openstack/swift master: Add unit tests for replicator sync_shard_ranges https://review.openstack.org/570005 | 16:57 |
openstackgerrit | Tim Burke proposed openstack/swift master: Bump up timeout for swift-probetests-centos-7 https://review.openstack.org/570011 | 16:58 |
clayg | timburke: ^ great commit message on that one! | 17:03 |
acoles | this patch https://review.openstack.org/#/c/565748/ is still showing as open and polluting the dashboards even though it is merged? | 17:05 |
patchbot | patch 565748 - swift (feature/deep-review) - Add sharder daemon, manage_shard_ranges tool and p... (MERGED) | 17:05 |
clayg | what is MHNIASP !? google and urban dictionary don't know - so I don't feel bad not knowing either. | 17:06 |
acoles | must have needed it at some point | 17:06 |
acoles | (I made it up) | 17:07 |
clayg | I like it! | 17:07 |
acoles | clayg: YCMTUT | 17:07 |
clayg | we should definitely have a short hand for MHNIASP - that's basically all code I've written and the only real excuse for half of it! | 17:07 |
acoles | (you can make things up too!) | 17:08 |
openstackgerrit | Tim Burke proposed openstack/swift master: Clean up direct_client's gen_headers https://review.openstack.org/569884 | 17:18 |
timburke | acoles: on the unmerged-yet-clearly-merged patch, i think we may need -infra's help... | 17:21 |
*** hseipp has quit IRC | 17:25 | |
*** armaan_ has quit IRC | 17:25 | |
*** armaan has joined #openstack-swift | 17:26 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Get rid of tpool_reraise https://review.openstack.org/518783 | 17:31 |
*** armaan has quit IRC | 17:35 | |
*** armaan has joined #openstack-swift | 17:35 | |
*** ccamacho has joined #openstack-swift | 17:53 | |
kota_ | good morning Vancouver Day 2 | 17:55 |
*** links has joined #openstack-swift | 17:59 | |
openstackgerrit | Merged openstack/swift master: Truncate error logs to prevent log handler runs out of the buffer. https://review.openstack.org/561142 | 18:06 |
*** armaan has quit IRC | 18:07 | |
*** armaan has joined #openstack-swift | 18:08 | |
*** SkyRocknRoll has quit IRC | 18:29 | |
*** cshastri has quit IRC | 18:35 | |
*** germs has joined #openstack-swift | 18:36 | |
mahatic | notmyname: sure, looking forward to meet you. Met kota_ mattoliverau and joe arnold. Not sure cschwede is around | 18:50 |
mahatic | congrats everyone on sharding merge! | 18:51 |
*** hseipp has joined #openstack-swift | 18:57 | |
*** links has quit IRC | 19:01 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift master: Fix versioned writes error with url-encoded object name https://review.openstack.org/555245 | 19:07 |
openstackgerrit | Tim Burke proposed openstack/swift master: Get rid of tpool_reraise https://review.openstack.org/518783 | 19:08 |
kota_ | timburke: push an update for the versioned_wirte fix and response for your comments. | 19:08 |
*** Anticime1 is now known as Anticimex | 19:09 | |
timburke | thanks kota_! i'll try to look at it again later today, maybe tomorrow | 19:10 |
*** hseipp has quit IRC | 19:10 | |
*** hseipp has joined #openstack-swift | 19:10 | |
kota_ | yeah, i think you have good eyes but I don't remember so much for the patch written at one month ago so feel free to talk around to get it understand together. | 19:12 |
openstackgerrit | Tim Burke proposed openstack/swift master: Make the decision between primary/handoff sets more obvious https://review.openstack.org/567940 | 19:13 |
*** hseipp has quit IRC | 19:15 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift master: WIP: Add ceph-s3 test non-voting job https://review.openstack.org/564700 | 19:16 |
*** mikecmpbll has joined #openstack-swift | 19:24 | |
openstackgerrit | Merged openstack/swift master: Simplify ContainerBroker._get_shard_range_rows() https://review.openstack.org/569962 | 19:31 |
*** mvenesio has quit IRC | 19:39 | |
*** mvenesio has joined #openstack-swift | 19:39 | |
*** mvenesio has quit IRC | 19:44 | |
*** amandap has joined #openstack-swift | 19:52 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Clean up logging interpolation https://review.openstack.org/570034 | 19:54 |
openstackgerrit | Merged openstack/swift master: Avoid premature shrinking in sharder probe test https://review.openstack.org/569973 | 19:54 |
openstackgerrit | Merged openstack/swift master: Test rsync error log truncation https://review.openstack.org/569968 | 19:54 |
openstackgerrit | Tim Burke proposed openstack/swift master: Move handling of missing table outside of do_query https://review.openstack.org/570036 | 20:00 |
openstackgerrit | Merged openstack/swift master: Bump up timeout for swift-probetests-centos-7 https://review.openstack.org/570011 | 20:09 |
*** d0ugal_ has joined #openstack-swift | 20:19 | |
*** d0ugal has quit IRC | 20:21 | |
*** mikecmpbll has quit IRC | 20:31 | |
*** mikecmpbll has joined #openstack-swift | 20:32 | |
*** germs has quit IRC | 20:34 | |
*** bigdogstl has joined #openstack-swift | 20:41 | |
rledisez | mahatic: i saw cschwede in a hallway ;) | 20:42 |
*** mvenesio has joined #openstack-swift | 20:45 | |
*** bigdogstl has quit IRC | 20:46 | |
*** germs has joined #openstack-swift | 20:47 | |
kota_ | rledisez: nice! | 20:49 |
openstackgerrit | Tim Burke proposed openstack/swift master: Let make_db_file_path accept epoch=None https://review.openstack.org/570054 | 20:50 |
*** germs has quit IRC | 20:51 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Stop overriding _in_sync in container replicator https://review.openstack.org/570055 | 21:02 |
timburke | torgomatic: what do you mean about https://review.openstack.org/#/c/556192/ ? requirements.txt bumped both requests and six past what's provided by trusty... and even xenial (well, for requests)! | 21:10 |
patchbot | patch 556192 - python-swiftclient - add lower-constraints job | 21:10 |
torgomatic | timburke: the lower constraints didn't, though... I thought that was the one that mattered | 21:11 |
torgomatic | or have I misunderstood how that stuff works? | 21:11 |
timburke | eh? i see requests==2.14.2, six==1.10.0 in lower-constraints.txt for that patch | 21:12 |
timburke | trusty ships requests 2.2.1, six 1.5.2 | 21:12 |
torgomatic | bah, apparently I can't read :( | 21:12 |
torgomatic | timburke: shall I -2 it, or is it not worth the hassle? | 21:13 |
timburke | i started messing around with backing out most of the delta from patchset 8 in https://review.openstack.org/#/c/568914/ but it looks like our --insecure option actually *does* require a newer requests... | 21:14 |
patchbot | patch 568914 - python-swiftclient - Back out some version bumps | 21:14 |
timburke | idk man, idk... | 21:14 |
torgomatic | yeah, me neither | 21:15 |
timburke | fwiw, i notice that a few days ago: "dependencies are the worst. when i did https://github.com/openstack/python-swiftclient/commit/ff505d7 i made a liar of our impressively-low requests>=1.1 requirement, 'cause the exception came in with https://github.com/requests/requests/commit/811ee4e (so, requests 2.4.0)" | 21:15 |
timburke | but i haven't gotten around to doing anything with that info | 21:15 |
torgomatic | Maybe just let it go and see if anything catches fire. We can revert it later if need be, I imagine. | 21:16 |
timburke | what i *do* know is that the failure output looks like shit: http://logs.openstack.org/14/568914/4/check/openstack-tox-lower-constraints/bca39dc/job-output.txt.gz#_2018-05-16_18_34_43_901554 | 21:16 |
torgomatic | it reminds me of C++ template errors, only with more console colors | 21:17 |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Add a helper context for optional connection args https://review.openstack.org/570058 | 21:17 |
*** germs has joined #openstack-swift | 21:40 | |
*** germs has quit IRC | 21:40 | |
*** germs has joined #openstack-swift | 21:40 | |
*** germs has quit IRC | 21:45 | |
*** germs has joined #openstack-swift | 21:46 | |
*** germs has quit IRC | 21:54 | |
*** germs has joined #openstack-swift | 21:57 | |
*** germs has quit IRC | 22:01 | |
openstackgerrit | Tim Burke proposed openstack/swift master: WIP: Get rid of _transform_record in ContainerBroker https://review.openstack.org/570063 | 22:03 |
openstackgerrit | Clay Gerrard proposed openstack/swift master: Use maybe_get more https://review.openstack.org/570068 | 22:04 |
*** d0ugal_ has quit IRC | 22:06 | |
*** mikecmpbll has quit IRC | 22:07 | |
clayg | timburke: ok, this time I even checked for a Related-Change-Id... I'm not seeing the *why* part of patch 570063 | 22:07 |
patchbot | https://review.openstack.org/#/c/570063/ - swift - WIP: Get rid of _transform_record in ContainerBroker | 22:07 |
*** d0ugal_ has joined #openstack-swift | 22:07 | |
clayg | I can't evaluate if it's good/bad to change the contract w/o a use-case - I mean... I would say "there's no reason for this; this is needless code churn; needless code churn is bad" - but I know you too well. You have some sneaky plan... what is it!? | 22:08 |
timburke | 'cause it bugs me that we smear the responsibility of transforming a row from the database to something consumable by a client across three separate little helper functions, one of which you kind-of-sometimes get for free-ish | 22:09 |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Add live status report to object replicator https://review.openstack.org/565868 | 22:09 |
timburke | even *better* would be if i could get update_data_record and _record_to_dict unified to some degree | 22:10 |
timburke | but i haven't thought that far ahead | 22:10 |
timburke | even better than *that* though would be to *actually use row_factory* instead of reinventing it | 22:11 |
*** amandap has quit IRC | 22:12 | |
clayg | ok, acctually the only one of those I think I understood and immediately associated with value was the last one - and only because it sounded like less code - thinking about "less code" immediately triggers dopamine for me. | 22:14 |
timburke | clayg: well hell, it's already a net -16 -- merge it! | 22:15 |
timburke | :P | 22:16 |
*** rcernin has joined #openstack-swift | 22:21 | |
*** germs has joined #openstack-swift | 22:25 | |
openstackgerrit | Merged openstack/python-swiftclient master: add lower-constraints job https://review.openstack.org/556192 | 22:30 |
*** germs has quit IRC | 22:32 | |
zaitcev | I'm working on adding py3 to sharding | 22:34 |
zaitcev | Man | 22:34 |
zaitcev | Looks like attempts were made, but it requires a serious concentration to track what is string and what is bytes, so regardless everything is mixed up. | 22:35 |
openstackgerrit | Tim Burke proposed openstack/python-swiftclient master: Back out some version bumps https://review.openstack.org/568914 | 22:35 |
timburke | zaitcev: that seems to *always* be the case when trying to write py2/py3 code. it sucks. | 22:36 |
zaitcev | ValueError: upper (b'') must be greater than or equal to lower (b"b'obj89'") | 22:37 |
*** germs has joined #openstack-swift | 22:38 | |
*** germs has quit IRC | 22:38 | |
*** germs has joined #openstack-swift | 22:38 | |
*** threestrands has joined #openstack-swift | 22:39 | |
timburke | ugh. so, should ShardRange bounds always be bytes, always be unicode, or always be native str? | 22:40 |
timburke | it seems like probably native str? but i'm not sure | 22:40 |
zaitcev | I chose bytes, primarily because it permits stuffing them from sqlite without any conversions. | 22:40 |
zaitcev | But keep in mind that they also have special type that adds comparisons, the MIN and MAX | 22:41 |
timburke | but surely py3 lets you use native strings with sqlite, yeah? | 22:41 |
zaitcev | Dunno, maybe the table needs to have some different types | 22:41 |
zaitcev | er, columns in the table | 22:42 |
timburke | regardless, https://github.com/openstack/swift/blob/master/swift/common/utils.py#L4601 (for example) should probably be `if value in (None, b'', u''):` | 22:42 |
timburke | heh. column types in sqlite are really more of a "recommendation"... | 22:42 |
*** germs has quit IRC | 22:42 | |
timburke | oh, interesting... https://docs.python.org/2/library/sqlite3.html#sqlite3.Connection.text_factory | 22:46 |
openstackgerrit | Merged openstack/swift master: Clean up logging interpolation https://review.openstack.org/570034 | 22:50 |
*** timur has joined #openstack-swift | 22:59 | |
timur | I noticed that the X-Timestamp header for objects does not include the offset (i.e. the metadata update date) and while the Last-Modified date does include it, it does not offer sub-second resolution and may return a date in the "future" (because it calls math.ceil(float(file_x_ts))). Would Swift be open to including an additional header, like X-Timestamp, that includes the sub-second resolution of | 23:03 |
timur | the created time + metadata offset? | 23:03 |
*** kei_yama has joined #openstack-swift | 23:14 | |
openstackgerrit | Merged openstack/swift master: Improve building listings from shards https://review.openstack.org/569796 | 23:22 |
*** amandap has joined #openstack-swift | 23:43 | |
*** germs has joined #openstack-swift | 23:46 | |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Use X-Timestamp when checking object expiration https://review.openstack.org/532595 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!