| UnfairFunction | mattoliverau: sure thing. I am still learning how to phrase those | 00:00 |
|---|---|---|
| mattoliverau | UnfairFunction: no probs :) https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure is the best resource we have on that. Really yours just needed a blank line to break out the bug metadata down the bottom, tho I reworded a little so it kinda has a title and a comment (tho that last part is really a nit). | 00:02 |
| openstackgerrit | Matthew Oliver proposed openstack/swift master: Add Alpine Linux suuprt to bindep https://review.openstack.org/580511 | 00:03 |
| mattoliverau | UnfairFunction: thanks for finding and issue, and then going about fixing it. Nice work! | 00:03 |
| UnfairFunction | mattoliverau: thank you for the feedback. truth is I had that space on the initial commit, but then 'git review' pasted the change-id above the closes-bug. I removed the line to prevent that... | 00:24 |
| mattoliverau | fair enough :) So long as all the metadata is in the last paragraph I don't think it matters the metadata order.. though maybe I'm wrong about that :P Or at least once there is a Change-Id it wont add another as that's how gerrit will track the patch. | 00:27 |
| UnfairFunction | i'll leave it as is next thime, then, and see if anyone corrects me :) | 00:34 |
| mattoliverau | UnfairFunction: next time, thats what I like to here ;) | 00:34 |
| mattoliverau | *hear | 00:35 |
| UnfairFunction | so, for context: this is all an attempt to install Swift on Alpine linux. there is a bug already opened to pyeclib for not parsing the output of find_library the right way for Alpine (along with a a bug to alpine to add the lib version to the reported name...) | 00:37 |
| UnfairFunction | and another bug for xattr, for not compiling on Alpine (musl instead of glibc) | 00:37 |
| UnfairFunction | but ye - i'm here to stay (not sure if that's a good thing for the project...) | 00:38 |
| mattoliverau | cool, I haven't used alpine linux, looking insteresting though :) one day when theres time I've love to have a play with it :) | 00:41 |
| mattoliverau | it's getting enough time in the day is always the problem :P | 00:42 |
| kota_ | morning | 01:04 |
| openstackgerrit | zhongshengping proposed openstack/python-swiftclient master: remove AUTHORS file from git https://review.openstack.org/580531 | 01:06 |
| openstackgerrit | zhongshengping proposed openstack/python-swiftclient master: remove ChangeLog from git https://review.openstack.org/580532 | 01:07 |
| *** ianychoi_ is now known as ianychoi | 01:16 | |
| openstackgerrit | Merged openstack/swift master: swift-ring-builder shows hint about composite builder file https://review.openstack.org/475727 | 01:19 |
| openstackgerrit | Nguyen Hai proposed openstack/swift master: Update doc building instructions in Development Guidelines https://review.openstack.org/579486 | 01:30 |
| mattoliverau | kota_: morning | 01:30 |
| kota_ | o/ | 01:30 |
| *** gyee has quit IRC | 01:45 | |
| openstackgerrit | zhongshengping proposed openstack/swift master: remove AUTHORS file from git https://review.openstack.org/580539 | 02:02 |
| openstackgerrit | zhongshengping proposed openstack/swift master: remove ChangeLog from git https://review.openstack.org/580540 | 02:02 |
| *** psachin` has joined #openstack-swift | 02:40 | |
| UnfairFunction | i'm sure y'all be delighted to know to I created a PR to Alpine linux to add liberasurecode to thier repos | 02:46 |
| UnfairFunction | mattoliverau: how do you generate those Zuul requests ("hello Zuul, i' | 02:54 |
| mattoliverau | UnfairFunction: \o/ | 02:54 |
| UnfairFunction | d like you do reexamine...") | 02:55 |
| mattoliverau | oh that just gets sent to everyone when there is a new patchset pushed to a review. | 02:55 |
| UnfairFunction | ok | 02:55 |
| mattoliverau | *sent to everyone who is a reviewer on the patch | 02:55 |
| UnfairFunction | cause I change the commit message (suuprt -> support) and did not get that email | 02:56 |
| UnfairFunction | changed it directly in gerrit | 02:56 |
| UnfairFunction | is there a better way to make such changes? | 02:57 |
| mattoliverau | sometimes gerrit's definition on what should trigger is a little odd. obviously it thought a simple spelling error in the commit message wasn't enough :) | 02:57 |
| UnfairFunction | i see | 02:57 |
| UnfairFunction | ok then | 02:57 |
| UnfairFunction | as long as it doesn't crumble the entire commit... | 02:58 |
| mattoliverau | changing it in gerrit is the same thing and if you pulled the patch, changed, git commit --amend and then git reviewed again. | 02:58 |
| mattoliverau | nah is should be fine, it also shouldn't have effected any of the reviews | 02:58 |
| UnfairFunction | i don't know how strict you are on proper splleing | 02:59 |
| UnfairFunction | :) | 02:59 |
| mattoliverau | if you need to tell zuul to rerun the gate tests you can leave a review with only the work, recheck | 03:00 |
| mattoliverau | it'll trigger it to rerun the tests. | 03:00 |
| mattoliverau | but you only do that if you look at the logs and it definitely a test infrastructor error and nothing to do with your patch | 03:01 |
| mattoliverau | Well I'm Australian, so I don't know if my normal spelling can be considered correct anyway :P | 03:01 |
| UnfairFunction | wait, you lost me with the "tell zuul to rerun" | 03:02 |
| UnfairFunction | why would I need that, and how to i leave a review as such? | 03:02 |
| mattoliverau | usually we try and get it right. Once the patch lands, the commit message will be the main source of info on each patch in the repo. So getting the commit message to explain what the patch does in general is good. | 03:02 |
| mattoliverau | lol, hold on let me find some links. But in essence, when you push to gerrit, there is another system called zuul which watches the gerrit event stream and will go trigger a bunch of gating tests on the patch. | 03:03 |
| UnfairFunction | yup, good so far | 03:04 |
| mattoliverau | when done, zuul will add a review to the patch with the results. You can watch your patch in zuul by looking at status.openstack.org/zuul | 03:05 |
| mattoliverau | zuul does a heap of tests, spinning up dev cloud envs to test different things. If something does do wrong, you can add a comment (review) to a patch in review with the single work 'recheck' and zuul will see it and trigger a recheck of the patch through the tests. | 03:06 |
| UnfairFunction | humm | 03:07 |
| UnfairFunction | let me try | 03:07 |
| UnfairFunction | is there another way than just replying to your last review? | 03:09 |
| UnfairFunction | Code Review - Error | 03:10 |
| UnfairFunction | cannot post review on edit | 03:10 |
| openstackgerrit | Merged openstack/swift master: Add Alpine Linux suuprt to bindep https://review.openstack.org/580511 | 03:10 |
| mattoliverau | ^ there you go, and opps, yup I did typo the first line opps | 03:11 |
| mattoliverau | UnfairFunction: oh, you probably haven't published the change yet | 03:11 |
| mattoliverau | in gerrit if your editing something, you sit save, and then have to press publish, your still in edit mode. | 03:12 |
| mattoliverau | but you should cancel the edit, because the patch has already landed | 03:12 |
| mattoliverau | UnfairFunction: We're working on a contributor guide to better explain everything. https://docs.openstack.org/contributors/code-and-documentation/index.html The openstack infra manual also has a bunch of great info https://docs.openstack.org/infra/manual/developers.html | 03:13 |
| mattoliverau | the contributor guide is https://docs.openstack.org/contributors/ but assumed your a dev ;) | 03:14 |
| UnfairFunction | now you assume i'm not? | 03:15 |
| UnfairFunction | is dev a title or an ad-hoc dfescription | 03:15 |
| UnfairFunction | ?>' | 03:15 |
| mattoliverau | UnfairFunction: lol, good point. really just giving fodder for the americans and especially one of our british cores to make fun of me when they're around next ;) | 03:26 |
| mattoliverau | UnfairFunction: really everyone is a dev, if your an op, doing doc, you are a dev, so no not a title, but someone interested in pushing a change. | 03:27 |
| mattoliverau | the fact that you've pushed a fix means your a dev, ie you had to figure out all the hoops you needed to get a patch up in gerrit ;) | 03:28 |
| openstackgerrit | Pete Zaitcev proposed openstack/swift master: WIP PUT+POST: test proxy object controller PUT path https://review.openstack.org/579229 | 03:42 |
| *** kei_yama has quit IRC | 03:49 | |
| mattoliverau | UnfairFunction: oh I thought you were saying you never said you weren't australian when I was making fun of my bad spelling I can blame on being Aussie. But it was the dev / not dev. sorry. I only sent you the dev link first because your a dev, and the full contributor link because it's the "correct" link to give, rather then the inner one. I'm a part of the First Contact Sig and have been working on the contributor | 03:58 |
| mattoliverau | guide, so thought I'd better give the main link. | 03:58 |
| *** kei_yama has joined #openstack-swift | 04:02 | |
| *** cbartz has joined #openstack-swift | 04:30 | |
| *** silor has joined #openstack-swift | 05:00 | |
| *** cshastri has joined #openstack-swift | 05:02 | |
| openstackgerrit | HCLTech-SSW proposed openstack/swift master: Add ability to undelete an account. https://review.openstack.org/507808 | 05:14 |
| *** armaan has joined #openstack-swift | 05:35 | |
| *** armaan has quit IRC | 05:40 | |
| *** armaan has joined #openstack-swift | 05:41 | |
| *** zaitcev has quit IRC | 05:46 | |
| *** armaan has quit IRC | 05:47 | |
| *** armaan has joined #openstack-swift | 05:47 | |
| UnfairFunction | mattoliverau: don't worry about it. i'm just kidding | 05:54 |
| *** silor has quit IRC | 06:10 | |
| *** geaaru has joined #openstack-swift | 06:49 | |
| openstackgerrit | Nguyen Hai proposed openstack/swift master: add lower-constraints job https://review.openstack.org/556255 | 06:56 |
| *** ccamacho has quit IRC | 07:08 | |
| *** ccamacho has joined #openstack-swift | 07:08 | |
| *** hseipp has joined #openstack-swift | 07:09 | |
| *** rcernin has quit IRC | 07:29 | |
| openstackgerrit | Nguyen Hai proposed openstack/swift master: Update doc building instructions in Development Guidelines https://review.openstack.org/579486 | 07:40 |
| openstackgerrit | Nguyen Hai proposed openstack/swift master: Update doc building instructions in Development Guidelines https://review.openstack.org/579486 | 07:40 |
| *** gkadam has joined #openstack-swift | 07:52 | |
| acoles | good morning | 07:57 |
| acoles | mattoliverau: thanks for you replicator recon paste | 08:05 |
| mattoliverau | acoles: no worries, I didn't actually test it or run it. just merged to two concepts while watching a cloud build for work :) | 08:25 |
| mattoliverau | acoles: is today your last day? | 08:26 |
| acoles | mattoliverau: NP I'll work on it some more today | 08:26 |
| acoles | mattoliverau: kind of - I may take some time off next week for a break | 08:27 |
| acoles | but may keep an eye out for anything that needs progressing | 08:27 |
| mattoliverau | :( for almost :) for I get to see more of you next week | 08:28 |
| *** cshastri has quit IRC | 08:30 | |
| *** armaan has quit IRC | 08:49 | |
| *** armaan has joined #openstack-swift | 08:50 | |
| *** cshastri has joined #openstack-swift | 08:52 | |
| *** armaan has quit IRC | 08:58 | |
| *** armaan has joined #openstack-swift | 08:59 | |
| *** armaan has quit IRC | 09:04 | |
| *** gkadam_ has joined #openstack-swift | 10:33 | |
| *** gkadam has quit IRC | 10:37 | |
| openstackgerrit | Merged openstack/swift master: Update doc building instructions in Development Guidelines https://review.openstack.org/579486 | 10:52 |
| *** mikecmpbll has quit IRC | 11:17 | |
| *** armaan has joined #openstack-swift | 11:19 | |
| *** hseipp has quit IRC | 11:37 | |
| *** armaan has quit IRC | 11:47 | |
| *** armaan has joined #openstack-swift | 11:47 | |
| *** armaan has quit IRC | 11:51 | |
| *** armaan has joined #openstack-swift | 12:07 | |
| openstackgerrit | Nguyen Hai proposed openstack/swift master: add lower-constraints job https://review.openstack.org/556255 | 12:59 |
| *** cshastri has quit IRC | 13:10 | |
| *** armaan has quit IRC | 13:18 | |
| *** armaan has joined #openstack-swift | 13:19 | |
| *** armaan has quit IRC | 13:23 | |
| *** cshastri has joined #openstack-swift | 13:24 | |
| *** armaan has joined #openstack-swift | 13:26 | |
| *** kei_yama has quit IRC | 13:26 | |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Make primary only and handoff only workers dump separate recon stats https://review.openstack.org/580215 | 13:34 |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Make obj replicator config error messages more informative https://review.openstack.org/580216 | 13:34 |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Use duration of all workers for aggregate object_replication_time https://review.openstack.org/580658 | 13:34 |
| *** armaan has quit IRC | 13:36 | |
| *** armaan has joined #openstack-swift | 13:37 | |
| *** armaan has quit IRC | 13:40 | |
| *** armaan has joined #openstack-swift | 13:40 | |
| *** psachin` has quit IRC | 13:42 | |
| acoles | mattoliverau: ^^ maybe I got carried away with the code re-use :/ | 13:44 |
| *** armaan has quit IRC | 13:45 | |
| acoles | clayg: I've kept replicator recon fixes in separate patches for now for clarity. The tip of the chain ends up with the replicator doing aggregation like the reconstructor i.e. replication_time is from first start to last finish | 13:46 |
| *** cbartz has left #openstack-swift | 13:57 | |
| *** cshastri has quit IRC | 14:09 | |
| *** zaitcev has joined #openstack-swift | 14:57 | |
| *** ChanServ sets mode: +v zaitcev | 14:57 | |
| *** seongsoocho has joined #openstack-swift | 15:13 | |
| *** openstackgerrit has quit IRC | 15:19 | |
| *** geaaru has quit IRC | 15:28 | |
| notmyname | good morning | 15:29 |
| *** mikecmpbll has joined #openstack-swift | 15:54 | |
| UnfairFunction | good morning, notmyname | 15:56 |
| notmyname | UnfairFunction: looks like your alpine dependencies landed. I'll work on getting patch 577467 rebased on top of it today | 15:57 |
| patchbot | https://review.openstack.org/#/c/577467/ - swift - added docker test target tools | 15:57 |
| UnfairFunction | cool | 15:58 |
| UnfairFunction | did you see the bug for pyeclib? | 15:58 |
| notmyname | no | 15:59 |
| UnfairFunction | apparently, Alpine Python find_librarty (contrary to others), does not return the version as part of the lib name | 16:00 |
| UnfairFunction | everyone else: liberasurecode.so.1 | 16:00 |
| UnfairFunction | alline: liberasurecode.so | 16:00 |
| UnfairFunction | causes the the install to fail | 16:00 |
| notmyname | can you link the bug? | 16:01 |
| UnfairFunction | of course | 16:04 |
| UnfairFunction | https://bugs.launchpad.net/pyeclib/+bug/1780320 | 16:04 |
| openstack | Launchpad bug 1780320 in PyECLib "If find_library('erasurecode') in setup.py does not return a library version, try to append it " [Undecided,New] | 16:04 |
| *** gkadam_ has quit IRC | 16:05 | |
| UnfairFunction | i already opened a bug to alpine, but i'm not sure if they'll see it as a bug or a feature, and if bug - how long it will take to issue a fix | 16:07 |
| UnfairFunction | the question is - is there any harm in checking for the version and appending if it's not there, if it will break something down the road (e.g., if i append .1 but the system has only .2 installed) | 16:08 |
| notmyname | honestly, I have no idea | 16:09 |
| notmyname | UnfairFunction: you got all the dependencies installed in alpine via bindep? | 16:14 |
| UnfairFunction | yes | 16:15 |
| UnfairFunction | that works | 16:15 |
| notmyname | I'm getting `unable to execute 'gcc': No such file or directory` but I don't know if that's because I'm calling bindep incorrectly or what | 16:15 |
| UnfairFunction | what is gcc missing? | 16:16 |
| UnfairFunction | are you running bindep or pip -r first? | 16:16 |
| notmyname | I'm runnign the alpine playbook in https://review.openstack.org/#/c/577467/ | 16:19 |
| patchbot | patch 577467 - swift - added docker test target tools | 16:19 |
| notmyname | I rebased that on top of master, uncommented the base-alpine stanza in docker-compose.yaml, and ran `docker-compose build base-alpine` | 16:20 |
| notmyname | which gets https://gist.github.com/notmyname/3ab26376ef99c43efad60ca3d6c7bb38 (slightly cleaned up) | 16:21 |
| notmyname | which is failing on the pip install part | 16:22 |
| notmyname | the bindep install reported success | 16:22 |
| UnfairFunction | interesting | 16:31 |
| UnfairFunction | just tried it on my setup and greenlet installed with no issue | 16:32 |
| UnfairFunction | can you add the output of bindep on alpine? | 16:32 |
| *** openstackgerrit has joined #openstack-swift | 16:33 | |
| openstackgerrit | John Dickinson proposed openstack/swift master: added docker test target tools https://review.openstack.org/577467 | 16:33 |
| notmyname | UnfairFunction: you can get that via `git review -d 577467` | 16:34 |
| UnfairFunction | I more interested in bindep itself - if it is my patched version for alpine | 16:37 |
| UnfairFunction | https://review.openstack.org/#/c/579056/ | 16:37 |
| patchbot | patch 579056 - openstack-infra/bindep - Add support for Alpine Linux | 16:37 |
| notmyname | oh! right | 16:38 |
| notmyname | that's probably it | 16:38 |
| notmyname | which would mean it's not actually running bindep on alpine yet | 16:38 |
| UnfairFunction | not until someone merges this patch... | 16:38 |
| notmyname | (I think this means technically the updates in swift to add alpine packages in bindep.txt probably shouldn't have landed yet. but I don't think it causes any harm) | 16:39 |
| notmyname | I need to go do a couple of other time-sensitive things right now, instead of working on this thing at the moment | 16:40 |
| UnfairFunction | the swift patch is meaningless without the binde patch | 16:43 |
| UnfairFunction | it does not harm any other platform, but it does make you think you can run bindep on Alpine, where bindep itself does not know yet what alpine is | 16:44 |
| notmyname | right. that's what I mean. we should have waited to land the change in swift until after the patch landed in bindep | 16:45 |
| UnfairFunction | sorry... | 16:47 |
| notmyname | nah, it's fine | 16:47 |
| notmyname | I suppose if it takes a long time to get the bindep stuff landed and we also see some maintenance burden for having the extra stuff in bindep.txt, then we may need to roll it back out. however, I don't expect either of those to happen | 16:48 |
| *** mikecmpbll has quit IRC | 16:56 | |
| timburke | good morning | 17:00 |
| UnfairFunction | good morning | 17:04 |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Use duration of all workers for aggregate object_replication_time https://review.openstack.org/580658 | 17:16 |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Make obj replicator config error messages more informative https://review.openstack.org/580216 | 17:16 |
| *** itlinux has joined #openstack-swift | 17:28 | |
| *** itlinux has quit IRC | 17:56 | |
| *** itlinux has joined #openstack-swift | 17:56 | |
| *** itlinux has quit IRC | 17:57 | |
| *** ccamacho has quit IRC | 18:17 | |
| *** cargonza_ has joined #openstack-swift | 18:41 | |
| *** mikecmpbll has joined #openstack-swift | 18:55 | |
| *** mikecmpbll has quit IRC | 19:27 | |
| notmyname | tdasilva: timburke: zaitcev: for py3 compat, may be good to pay attention to https://review.openstack.org/#/c/575933/ | 19:30 |
| patchbot | patch 575933 - governance - write up the python3-first goal | 19:30 |
| *** gyee has joined #openstack-swift | 19:32 | |
| *** cargonza_ has quit IRC | 19:39 | |
| *** cargonza_ has joined #openstack-swift | 19:39 | |
| *** UnfairFunction has quit IRC | 19:52 | |
| *** UnfairFunction has joined #openstack-swift | 19:52 | |
| openstackgerrit | Ehud Kaldor proposed openstack/pyeclib master: This change allows systems that report library without version https://review.openstack.org/580753 | 20:29 |
| openstackgerrit | Ehud Kaldor proposed openstack/pyeclib master: Adds support for systems that report library without version https://review.openstack.org/580754 | 20:29 |
| *** UnfairFunction has quit IRC | 20:49 | |
| zaitcev | notmyname: thanks a lot, that was amusing. | 21:18 |
| zaitcev | "The built-in ``unicode`` no longer exists under python 3, so using it causes pylint to report an undefined name. Use ``six.text_type`` instead." | 21:19 |
| zaitcev | it might be the easiest issue that arises during the transition to py3 | 21:19 |
| zaitcev | who cares about such trivial details | 21:19 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Include SLO ETag in container updates https://review.openstack.org/337960 | 22:37 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Include '-' in multipart ETags https://review.openstack.org/575860 | 22:37 |
| timburke | notmyname: clayg: kota_: ^^^ | 22:37 |
| notmyname | timburke: thanks! | 22:38 |
| clayg | Whoa. | 22:39 |
| openstackgerrit | Tim Burke proposed openstack/swift master: Include '-' in multipart ETags https://review.openstack.org/575860 | 22:59 |
| *** cshastri has joined #openstack-swift | 23:28 | |
| *** rcernin has joined #openstack-swift | 23:36 | |
| mattoliverau | Oh oops I didn't realise there was a seperate bindep patch in another repo. My bad, we could've added a cross repo depends on. | 23:38 |
| notmyname | mattoliverau: no worries. like I said, it's unlikely to cause any issues for the moment, and we expect it to work soon, and if it did cause issues we can roll it back | 23:41 |
| mattoliverau | Damn jhesketh has already +2ed the infra bindep patch. Now I cant poke him for the second one :p | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!