timburke | it's a little discouraging when you're trying to figure out why we're masking errno=0 "errors" and you find https://github.com/openstack/swift/blame/e630e7c/swift/common/utils.py#L160 ... | 00:14 |
---|---|---|
timburke | maybe that's because of the latent bug i noticed when dealing with posix_fallocate? | 00:14 |
*** rcernin has joined #openstack-swift | 00:31 | |
*** early` has quit IRC | 03:05 | |
*** early has joined #openstack-swift | 03:18 | |
*** e0ne has joined #openstack-swift | 04:10 | |
*** e0ne_ has joined #openstack-swift | 04:13 | |
*** e0ne has quit IRC | 04:16 | |
*** e0ne_ has quit IRC | 05:30 | |
*** e0ne has joined #openstack-swift | 05:39 | |
alecuyer | timburke: I looked at this on the plane, I think you're right. It would also mean 2ca379d40f06d892fdf6e3430ccd8a78726e5626 would not work as intended | 06:08 |
alecuyer | I think we would to do something like, if ret not in (ENOSYS, … , EINVAL): raise .. for posix_fallocate. and for fallocate, remove 0 and EINVAL from the ignored error list | 06:09 |
alecuyer | (haven't checked the relevant error codes yet for posix_fallocate beyond EINVAL) | 06:09 |
alecuyer | oops the posix_fallocate would be ret not int (0, <errors we want to ignore>). Will look again after getting some sleep :) | 06:11 |
*** e0ne has quit IRC | 06:46 | |
*** rcernin has quit IRC | 08:17 | |
*** fatema__ has joined #openstack-swift | 09:50 | |
*** fatema__ has quit IRC | 10:21 | |
*** silor has joined #openstack-swift | 10:37 | |
*** silor has quit IRC | 12:17 | |
*** two_tired2 has joined #openstack-swift | 14:06 | |
*** e0ne has joined #openstack-swift | 15:33 | |
*** e0ne has quit IRC | 15:35 | |
*** SkyRocknRoll has joined #openstack-swift | 16:42 | |
*** SkyRocknRoll has quit IRC | 17:25 | |
*** pcaruana has joined #openstack-swift | 18:48 | |
*** pcaruana has quit IRC | 19:07 | |
*** emccormickva has joined #openstack-swift | 19:22 | |
*** emccormickva has quit IRC | 19:22 | |
*** jistr has quit IRC | 20:47 | |
*** jistr has joined #openstack-swift | 20:53 | |
*** two_tired2 has quit IRC | 21:39 | |
*** rcernin has joined #openstack-swift | 22:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!