Wednesday, 2018-11-28

*** hoonetorg has quit IRC00:09
*** hoonetorg has joined #openstack-swift00:22
notmynamemattoliverau: we're all so talkative today :-)00:34
mattoliverauI know, I'm struggling to keep up with the discussions :P00:35
mattoliverauI assume it's just that time of year. Y'all busy eating left overs and getting ready for Christmas :P00:35
mattoliveraume, I'm trying to beat crowbar (and chef) into better support ipv6 for work, so I can make progress from what SUSE wants me to do, so I can "hopefully" spend my arvo playing with Swift ;)00:38
notmyname:-)00:39
mattoliverauipv6 isn't chef issues, just me learning chef and ruby :P00:39
*** two_tired has joined #openstack-swift01:35
*** vintbra has quit IRC01:37
*** SkyRocknRoll has joined #openstack-swift01:44
zaitcevgeh02:32
zaitcevI started working on py3 container server and it turned out that its tests rely on object server working02:32
zaitcevI expected it to be a mirror image of account server, but it's not the case02:32
*** psachin has joined #openstack-swift02:41
*** SkyRocknRoll has quit IRC02:44
*** SkyRocknRoll has joined #openstack-swift02:46
*** mahatic has quit IRC02:59
openstackgerritArzhna Lee proposed openstack/swift master: Fix a potential bug  https://review.openstack.org/62044002:59
notmynameclayg: mattoliverau: kota_: https://review.openstack.org/#/c/620440/ is an interesting patch/bug. for people running other diskfile implementations* this could be a pretty big deal. but I wonder how we could test it04:00
patchbotpatch 620440 - swift - Fix a potential bug - 1 patch set04:00
notmyname* turns out, this may be more common that we realize (my own gut reaction based on stuff I heard at the summit)04:01
mattoliverauI tracked the method call with None, it does indeed hit the BaseDiskFile __init__ setting the partition to None and Account to the partition number. However, everytime we seem to call the method we luckily pass in a diskfile patch, so it doesn't end up generating the wrong path. We could add a test that does use that code. Because the from_hash_path is only called from get_diskfile_from_audit_location04:24
mattoliverau*path04:25
mattoliverausorry datadir04:25
mattoliverauphew, let's try again, we pass in a datadir path, so we never build a bad one.04:25
mattoliverauwhich is why we've never seen an issue.. to date.04:26
mattoliverauBuilding some tests around "from_hash_dir" ie, creating a test_from_hash_dir test means we could confirm the issue, I.e get a diskfile object generated from the passed in params, and becasue oble to read it.04:29
mattoliverauinfact, from_hash_dir always expects a hash_dir_path to override. So unless that is sent in as None it can't be triggered.04:40
mattoliveraucool, so made a test, and of course from_hash_dir never sends in an account, container or object, so you _must_ pass in the hash_dir_path (diskfiles _datadir) so the account and paritiion they are incorrect _can't_ cause a problem as we never need to generate the path.04:50
mattoliverauSo it's definitely a bug, but will only effect a diskfile implementation that would use either the account and/or partition in addition to what is passed in as _datadir. Which is possible, but without actaully writing a simple diskfile implementation (ie slightly alter as the replicated one) that acts opon this, I can't think of a way to test it.04:55
*** mahatic has joined #openstack-swift05:00
*** ChanServ sets mode: +v mahatic05:00
*** pcaruana has joined #openstack-swift05:09
*** two_tired has quit IRC05:31
*** e0ne has joined #openstack-swift05:37
*** tdasilva has quit IRC05:39
*** e0ne has quit IRC05:42
*** e0ne has joined #openstack-swift05:44
*** e0ne has quit IRC05:45
*** SkyRocknRoll has quit IRC05:46
*** gyee has quit IRC06:20
*** psachin has quit IRC06:47
*** rcernin has quit IRC06:57
*** gkadam has joined #openstack-swift07:00
*** m_kazuhiro has joined #openstack-swift07:12
* kota_ is in a busy week 07:19
kota_for the conference of my company07:20
kota_notmyname: ack, I'll dig it more (probably it's in the next week) I don't have any idea the *None* in the middle of the argument order.07:21
kota_mattoliverau: sorry, I might be absent from the meeting tomorrow morning in our timezone due to the conference.07:21
*** e0ne has joined #openstack-swift07:54
mattoliveraukota_: nps08:03
*** hseipp has joined #openstack-swift08:03
mattoliverautimburke, clayg, rledisez, m_kazuhiro, tdasilva, zaitcev: if let me know if y'all can make it, otherwise we  can give it a miss.08:04
m_kazuhiroI'm sorry, I'm busy in this week too.08:18
rledisezmattoliverau: i'll be at the meeting if it is held08:33
openstackgerritKazuhiro MIYAHARA proposed openstack/swift master: Enable to configure object-expirer in object-server.conf  https://review.openstack.org/60195008:36
openstackgerritKazuhiro MIYAHARA proposed openstack/swift master: Add object-expirer new mode to execute tasks from general task queue  https://review.openstack.org/51738908:36
*** e0ne has quit IRC08:37
*** m_kazuhiro has quit IRC08:40
*** mikecmpbll has joined #openstack-swift09:07
*** e0ne has joined #openstack-swift10:14
*** jistr is now known as jistr|mtg10:34
*** vintbra has joined #openstack-swift11:51
*** e0ne has quit IRC12:09
*** takamatsu has quit IRC12:37
*** takamatsu has joined #openstack-swift12:43
*** e0ne has joined #openstack-swift13:05
*** jistr|mtg is now known as jistr13:21
*** takamatsu has quit IRC13:29
*** takamatsu has joined #openstack-swift13:30
*** takamatsu has quit IRC13:44
*** takamatsu has joined #openstack-swift13:48
*** vintbra has quit IRC13:54
*** vintbra has joined #openstack-swift14:52
*** two_tired has joined #openstack-swift14:55
*** two_tired has quit IRC15:30
*** gkadam has quit IRC15:35
*** gyee has joined #openstack-swift16:27
*** hseipp has quit IRC16:50
*** SkyRocknRoll has joined #openstack-swift16:51
*** SkyRocknRoll has quit IRC16:56
*** e0ne has quit IRC17:02
*** tdasilva has joined #openstack-swift17:03
*** ChanServ sets mode: +v tdasilva17:03
*** pcaruana has quit IRC17:03
tdasilvamattoliverau: i'll be at the meeting too17:06
*** SkyRocknRoll has joined #openstack-swift17:31
*** mikecmpbll has quit IRC17:41
timburkegood morning18:22
*** vintbra has quit IRC18:26
*** SkyRocknRoll has quit IRC18:29
*** SkyRocknRoll has joined #openstack-swift18:29
*** vintbra has joined #openstack-swift18:40
*** e0ne has joined #openstack-swift19:07
*** e0ne has quit IRC19:15
*** e0ne has joined #openstack-swift19:17
*** e0ne has quit IRC19:18
*** e0ne has joined #openstack-swift20:19
*** e0ne has quit IRC20:20
*** openstackgerrit has quit IRC20:36
*** e0ne has joined #openstack-swift20:40
*** e0ne has quit IRC20:49
mattoliveraumorning20:58
mattoliverauSwift meeting in 2 minutes, phew I made it :P20:59
mattoliverauSwift team meeting in #openstack-meeting21:00
mattoliverauclayg: zaitcev you guys coming to the meeting?21:03
claygmattoliverau: yay thanksgiving - have you ever been to one?  it's a good time/feast.  Do you folks in oz have a fall holiday?  Or maybe harvest time is a different part of the year entirely...21:11
mattoliverauclayg: no never been to one :( and it's Spring here for us.21:15
mattoliverauwould love to experience one tho21:15
mattoliverautho because Xmas is in our summer, our major school holidays (summer holidays) happen soon, so is a busy time of year.21:21
*** e0ne has joined #openstack-swift21:21
*** e0ne has quit IRC21:21
*** e0ne has joined #openstack-swift21:26
*** klamath has quit IRC21:26
*** klamath has joined #openstack-swift21:26
rledisezalecuyer: please explain the issue related to finally not being called, so that the same mistake cannot be made somewhere else in Swift21:27
*** e0ne has quit IRC21:27
*** SkyRocknRoll has quit IRC21:31
mattoliveraucool, thanks for coming, coffee time!21:32
claygmattoliverau: great meeting, thanks!21:35
*** vintbra has quit IRC21:38
*** rcernin has joined #openstack-swift21:50
*** mikecmpbll has joined #openstack-swift22:01
*** rcernin has quit IRC22:03
*** rcernin has joined #openstack-swift22:12
*** vintbra has joined #openstack-swift22:33
*** vintbra has quit IRC22:37

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!