*** hoonetorg has quit IRC | 00:09 | |
*** hoonetorg has joined #openstack-swift | 00:22 | |
notmyname | mattoliverau: we're all so talkative today :-) | 00:34 |
---|---|---|
mattoliverau | I know, I'm struggling to keep up with the discussions :P | 00:35 |
mattoliverau | I assume it's just that time of year. Y'all busy eating left overs and getting ready for Christmas :P | 00:35 |
mattoliverau | me, I'm trying to beat crowbar (and chef) into better support ipv6 for work, so I can make progress from what SUSE wants me to do, so I can "hopefully" spend my arvo playing with Swift ;) | 00:38 |
notmyname | :-) | 00:39 |
mattoliverau | ipv6 isn't chef issues, just me learning chef and ruby :P | 00:39 |
*** two_tired has joined #openstack-swift | 01:35 | |
*** vintbra has quit IRC | 01:37 | |
*** SkyRocknRoll has joined #openstack-swift | 01:44 | |
zaitcev | geh | 02:32 |
zaitcev | I started working on py3 container server and it turned out that its tests rely on object server working | 02:32 |
zaitcev | I expected it to be a mirror image of account server, but it's not the case | 02:32 |
*** psachin has joined #openstack-swift | 02:41 | |
*** SkyRocknRoll has quit IRC | 02:44 | |
*** SkyRocknRoll has joined #openstack-swift | 02:46 | |
*** mahatic has quit IRC | 02:59 | |
openstackgerrit | Arzhna Lee proposed openstack/swift master: Fix a potential bug https://review.openstack.org/620440 | 02:59 |
notmyname | clayg: mattoliverau: kota_: https://review.openstack.org/#/c/620440/ is an interesting patch/bug. for people running other diskfile implementations* this could be a pretty big deal. but I wonder how we could test it | 04:00 |
patchbot | patch 620440 - swift - Fix a potential bug - 1 patch set | 04:00 |
notmyname | * turns out, this may be more common that we realize (my own gut reaction based on stuff I heard at the summit) | 04:01 |
mattoliverau | I tracked the method call with None, it does indeed hit the BaseDiskFile __init__ setting the partition to None and Account to the partition number. However, everytime we seem to call the method we luckily pass in a diskfile patch, so it doesn't end up generating the wrong path. We could add a test that does use that code. Because the from_hash_path is only called from get_diskfile_from_audit_location | 04:24 |
mattoliverau | *path | 04:25 |
mattoliverau | sorry datadir | 04:25 |
mattoliverau | phew, let's try again, we pass in a datadir path, so we never build a bad one. | 04:25 |
mattoliverau | which is why we've never seen an issue.. to date. | 04:26 |
mattoliverau | Building some tests around "from_hash_dir" ie, creating a test_from_hash_dir test means we could confirm the issue, I.e get a diskfile object generated from the passed in params, and becasue oble to read it. | 04:29 |
mattoliverau | infact, from_hash_dir always expects a hash_dir_path to override. So unless that is sent in as None it can't be triggered. | 04:40 |
mattoliverau | cool, so made a test, and of course from_hash_dir never sends in an account, container or object, so you _must_ pass in the hash_dir_path (diskfiles _datadir) so the account and paritiion they are incorrect _can't_ cause a problem as we never need to generate the path. | 04:50 |
mattoliverau | So it's definitely a bug, but will only effect a diskfile implementation that would use either the account and/or partition in addition to what is passed in as _datadir. Which is possible, but without actaully writing a simple diskfile implementation (ie slightly alter as the replicated one) that acts opon this, I can't think of a way to test it. | 04:55 |
*** mahatic has joined #openstack-swift | 05:00 | |
*** ChanServ sets mode: +v mahatic | 05:00 | |
*** pcaruana has joined #openstack-swift | 05:09 | |
*** two_tired has quit IRC | 05:31 | |
*** e0ne has joined #openstack-swift | 05:37 | |
*** tdasilva has quit IRC | 05:39 | |
*** e0ne has quit IRC | 05:42 | |
*** e0ne has joined #openstack-swift | 05:44 | |
*** e0ne has quit IRC | 05:45 | |
*** SkyRocknRoll has quit IRC | 05:46 | |
*** gyee has quit IRC | 06:20 | |
*** psachin has quit IRC | 06:47 | |
*** rcernin has quit IRC | 06:57 | |
*** gkadam has joined #openstack-swift | 07:00 | |
*** m_kazuhiro has joined #openstack-swift | 07:12 | |
* kota_ is in a busy week | 07:19 | |
kota_ | for the conference of my company | 07:20 |
kota_ | notmyname: ack, I'll dig it more (probably it's in the next week) I don't have any idea the *None* in the middle of the argument order. | 07:21 |
kota_ | mattoliverau: sorry, I might be absent from the meeting tomorrow morning in our timezone due to the conference. | 07:21 |
*** e0ne has joined #openstack-swift | 07:54 | |
mattoliverau | kota_: nps | 08:03 |
*** hseipp has joined #openstack-swift | 08:03 | |
mattoliverau | timburke, clayg, rledisez, m_kazuhiro, tdasilva, zaitcev: if let me know if y'all can make it, otherwise we can give it a miss. | 08:04 |
m_kazuhiro | I'm sorry, I'm busy in this week too. | 08:18 |
rledisez | mattoliverau: i'll be at the meeting if it is held | 08:33 |
openstackgerrit | Kazuhiro MIYAHARA proposed openstack/swift master: Enable to configure object-expirer in object-server.conf https://review.openstack.org/601950 | 08:36 |
openstackgerrit | Kazuhiro MIYAHARA proposed openstack/swift master: Add object-expirer new mode to execute tasks from general task queue https://review.openstack.org/517389 | 08:36 |
*** e0ne has quit IRC | 08:37 | |
*** m_kazuhiro has quit IRC | 08:40 | |
*** mikecmpbll has joined #openstack-swift | 09:07 | |
*** e0ne has joined #openstack-swift | 10:14 | |
*** jistr is now known as jistr|mtg | 10:34 | |
*** vintbra has joined #openstack-swift | 11:51 | |
*** e0ne has quit IRC | 12:09 | |
*** takamatsu has quit IRC | 12:37 | |
*** takamatsu has joined #openstack-swift | 12:43 | |
*** e0ne has joined #openstack-swift | 13:05 | |
*** jistr|mtg is now known as jistr | 13:21 | |
*** takamatsu has quit IRC | 13:29 | |
*** takamatsu has joined #openstack-swift | 13:30 | |
*** takamatsu has quit IRC | 13:44 | |
*** takamatsu has joined #openstack-swift | 13:48 | |
*** vintbra has quit IRC | 13:54 | |
*** vintbra has joined #openstack-swift | 14:52 | |
*** two_tired has joined #openstack-swift | 14:55 | |
*** two_tired has quit IRC | 15:30 | |
*** gkadam has quit IRC | 15:35 | |
*** gyee has joined #openstack-swift | 16:27 | |
*** hseipp has quit IRC | 16:50 | |
*** SkyRocknRoll has joined #openstack-swift | 16:51 | |
*** SkyRocknRoll has quit IRC | 16:56 | |
*** e0ne has quit IRC | 17:02 | |
*** tdasilva has joined #openstack-swift | 17:03 | |
*** ChanServ sets mode: +v tdasilva | 17:03 | |
*** pcaruana has quit IRC | 17:03 | |
tdasilva | mattoliverau: i'll be at the meeting too | 17:06 |
*** SkyRocknRoll has joined #openstack-swift | 17:31 | |
*** mikecmpbll has quit IRC | 17:41 | |
timburke | good morning | 18:22 |
*** vintbra has quit IRC | 18:26 | |
*** SkyRocknRoll has quit IRC | 18:29 | |
*** SkyRocknRoll has joined #openstack-swift | 18:29 | |
*** vintbra has joined #openstack-swift | 18:40 | |
*** e0ne has joined #openstack-swift | 19:07 | |
*** e0ne has quit IRC | 19:15 | |
*** e0ne has joined #openstack-swift | 19:17 | |
*** e0ne has quit IRC | 19:18 | |
*** e0ne has joined #openstack-swift | 20:19 | |
*** e0ne has quit IRC | 20:20 | |
*** openstackgerrit has quit IRC | 20:36 | |
*** e0ne has joined #openstack-swift | 20:40 | |
*** e0ne has quit IRC | 20:49 | |
mattoliverau | morning | 20:58 |
mattoliverau | Swift meeting in 2 minutes, phew I made it :P | 20:59 |
mattoliverau | Swift team meeting in #openstack-meeting | 21:00 |
mattoliverau | clayg: zaitcev you guys coming to the meeting? | 21:03 |
clayg | mattoliverau: yay thanksgiving - have you ever been to one? it's a good time/feast. Do you folks in oz have a fall holiday? Or maybe harvest time is a different part of the year entirely... | 21:11 |
mattoliverau | clayg: no never been to one :( and it's Spring here for us. | 21:15 |
mattoliverau | would love to experience one tho | 21:15 |
mattoliverau | tho because Xmas is in our summer, our major school holidays (summer holidays) happen soon, so is a busy time of year. | 21:21 |
*** e0ne has joined #openstack-swift | 21:21 | |
*** e0ne has quit IRC | 21:21 | |
*** e0ne has joined #openstack-swift | 21:26 | |
*** klamath has quit IRC | 21:26 | |
*** klamath has joined #openstack-swift | 21:26 | |
rledisez | alecuyer: please explain the issue related to finally not being called, so that the same mistake cannot be made somewhere else in Swift | 21:27 |
*** e0ne has quit IRC | 21:27 | |
*** SkyRocknRoll has quit IRC | 21:31 | |
mattoliverau | cool, thanks for coming, coffee time! | 21:32 |
clayg | mattoliverau: great meeting, thanks! | 21:35 |
*** vintbra has quit IRC | 21:38 | |
*** rcernin has joined #openstack-swift | 21:50 | |
*** mikecmpbll has joined #openstack-swift | 22:01 | |
*** rcernin has quit IRC | 22:03 | |
*** rcernin has joined #openstack-swift | 22:12 | |
*** vintbra has joined #openstack-swift | 22:33 | |
*** vintbra has quit IRC | 22:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!