| *** mikecmpbll has quit IRC | 00:07 | |
| mattoliverau | notmyname: so we had a quick discussion about this weeks ago. But what shall we do with p 620440. The way the code is now is clearly wrong. As we pass the partition in as the account. But turns out we don't use those values because we overload with _datadir. So doesn't cause us issues. | 00:19 |
|---|---|---|
| patchbot | https://review.openstack.org/#/c/620440/ - swift - Fix a potential bug - 1 patch set | 00:19 |
| mattoliverau | Without creating a fictional diskfile class that needs the _datadir, partition and account we cant really test this. | 00:20 |
| timburke | could we have mem_diskfile do ... something ... with it? | 00:21 |
| mattoliverau | But I'm of the opinion, clearly what we have now is an error not a bug. We're just lucky we don't use all the parameters we pass in. So I think it should land without a test. | 00:21 |
| mattoliverau | oh yeah, I guess that's an option. | 00:21 |
| notmyname | mattoliverau: kinda reminds me of the patch for sharding. the code was just wrong, so testing it initially seemed to be something silly like "make sure we know how to call a function" | 00:22 |
| mattoliverau | but we don't write tests for any typo's or copy and paste errors we've made.. we just fix em | 00:22 |
| notmyname | right | 00:22 |
| notmyname | in a lot of ways, this is "just " a typo. but if we can test it by making a stub mem diskfile or something, just to ensure the interface contract is valid, that seems ok | 00:22 |
| notmyname | so I'm ok with landing it as-is. but a test that checks the interface contract seems reasonable too | 00:23 |
| mattoliverau | I'm about to go to lunch with csmart. I think some more afterwards. I can be convinced to create a test using stub mem diskfile, but I'm also lazy :P | 00:24 |
| csmart | 👍👌 | 00:25 |
| *** itlinux has quit IRC | 01:02 | |
| *** gyee has quit IRC | 02:00 | |
| *** rcernin has quit IRC | 02:31 | |
| *** psachin has joined #openstack-swift | 02:43 | |
| *** rcernin has joined #openstack-swift | 02:55 | |
| *** rcernin has quit IRC | 04:05 | |
| *** rcernin has joined #openstack-swift | 04:12 | |
| openstackgerrit | Merged openstack/swift master: Add a comment about the module list for py3 in tox.ini https://review.openstack.org/626077 | 05:03 |
| zaitcev | Good heavens, what a struggle that was :-) | 05:10 |
| mattoliverau | lol | 05:19 |
| *** mgagne has quit IRC | 06:33 | |
| *** mgagne has joined #openstack-swift | 06:40 | |
| *** ccamacho has quit IRC | 06:47 | |
| *** rcernin has quit IRC | 06:56 | |
| *** pcaruana has joined #openstack-swift | 07:25 | |
| *** hseipp has joined #openstack-swift | 07:42 | |
| *** hseipp has quit IRC | 07:47 | |
| *** gkadam has joined #openstack-swift | 07:49 | |
| *** ccamacho has joined #openstack-swift | 08:03 | |
| *** ccamacho has quit IRC | 08:13 | |
| *** ccamacho has joined #openstack-swift | 08:13 | |
| *** ccamacho has quit IRC | 08:49 | |
| *** mikecmpbll has joined #openstack-swift | 09:09 | |
| *** ccamacho has joined #openstack-swift | 09:13 | |
| *** hseipp has joined #openstack-swift | 09:47 | |
| *** e0ne has joined #openstack-swift | 09:53 | |
| *** e0ne has quit IRC | 10:29 | |
| *** e0ne has joined #openstack-swift | 10:30 | |
| *** mikecmpb_ has joined #openstack-swift | 10:33 | |
| *** mikecmpbll has quit IRC | 10:34 | |
| *** mpasserini has joined #openstack-swift | 11:16 | |
| mpasserini | Hi, we upgraded our main OpenStack to Queens, but Swift is still at Pike, we see this error in the logs when trying to access Swift: | 11:17 |
| mpasserini | proxy-server: Identity response: {"error": {"message": "(http://172.16.12.21:5000/v2.0/tokens): The resource could not be found.", "code": 404, "title": "Not Found"}} | 11:17 |
| mpasserini | I guess we need to force Swift to use v3 tokens? | 11:17 |
| *** mikecmpb_ has quit IRC | 11:17 | |
| mpasserini | what's the right config for that, I tried adding auth_uri = http://172.16.12.21:5000/v3 but it didn't help | 11:18 |
| *** mikecmpbll has joined #openstack-swift | 11:18 | |
| *** mvkr has quit IRC | 11:28 | |
| *** mpasserini has quit IRC | 11:31 | |
| *** mvkr has joined #openstack-swift | 11:54 | |
| *** ccamacho has quit IRC | 12:14 | |
| *** mpasserini has joined #openstack-swift | 12:22 | |
| mpasserini | (sorry I lost connection, did I get some reply in the meanwhile?) | 12:22 |
| mpasserini | solved, nevermind | 12:51 |
| *** ccamacho has joined #openstack-swift | 12:58 | |
| *** ccamacho has quit IRC | 12:58 | |
| *** ccamacho has joined #openstack-swift | 12:58 | |
| *** ccamacho has quit IRC | 13:06 | |
| *** ccamacho has joined #openstack-swift | 13:12 | |
| *** e0ne has quit IRC | 13:19 | |
| *** gkadam has quit IRC | 13:25 | |
| *** psachin has quit IRC | 13:27 | |
| *** e0ne has joined #openstack-swift | 13:33 | |
| *** mvkr has quit IRC | 14:10 | |
| *** mvkr has joined #openstack-swift | 14:10 | |
| *** e0ne has quit IRC | 14:11 | |
| *** e0ne_ has joined #openstack-swift | 14:11 | |
| *** mpasserini has quit IRC | 14:13 | |
| *** baojg has quit IRC | 14:15 | |
| *** baojg has joined #openstack-swift | 14:16 | |
| *** hseipp has quit IRC | 16:23 | |
| *** ccamacho has quit IRC | 16:24 | |
| *** mvkr has quit IRC | 16:29 | |
| *** gyee has joined #openstack-swift | 16:36 | |
| *** e0ne_ has quit IRC | 16:59 | |
| *** ccamacho has joined #openstack-swift | 17:09 | |
| *** SkyRocknRoll has joined #openstack-swift | 17:25 | |
| *** mikecmpbll has quit IRC | 17:37 | |
| *** mvkr has joined #openstack-swift | 17:39 | |
| *** SkyRocknRoll has quit IRC | 18:16 | |
| *** mikecmpbll has joined #openstack-swift | 18:19 | |
| *** ianychoi has quit IRC | 18:22 | |
| *** guimaluf has joined #openstack-swift | 18:27 | |
| *** e0ne has joined #openstack-swift | 18:49 | |
| *** e0ne_ has joined #openstack-swift | 19:25 | |
| *** e0ne has quit IRC | 19:25 | |
| openstackgerrit | Thiago da Silva proposed openstack/swift master: WIP: add rolling upgrade tests https://review.openstack.org/626663 | 19:44 |
| *** pcaruana has quit IRC | 19:57 | |
| openstackgerrit | Thiago da Silva proposed openstack/swift master: WIP: add rolling upgrade tests https://review.openstack.org/626663 | 20:46 |
| notmyname | tdasilva: cool. looks like the main benefit there is testing against data that has persisted across an upgrade? | 20:52 |
| openstackgerrit | Andreas Jaeger proposed openstack/python-swiftclient master: Use template for lower-constraints https://review.openstack.org/626742 | 20:52 |
| tdasilva | notmyname: yes, that's the idea. right now it's just the framework, but we could add more tests that exercise, slos, dlos, versioning, etc... | 20:53 |
| notmyname | yeah testing those "special" types of objects would be really good | 20:53 |
| tdasilva | notmyname: was also thinking about modifying the rolling nodes a bit to have 2 object server nodes and 1 account/container as opposed to the current 1 object, 1 account, 1 container. | 20:54 |
| tdasilva | notmyname: that way we could just upgrade one of the object servers | 20:55 |
| tdasilva | i'm thinking of cases like losf for example | 20:56 |
| notmyname | yeah. sounds like a great (additive?) change | 20:57 |
| *** e0ne_ has quit IRC | 21:21 | |
| *** itlinux has joined #openstack-swift | 22:04 | |
| openstackgerrit | Thiago da Silva proposed openstack/swift master: Add rolling upgrade tests https://review.openstack.org/626663 | 22:19 |
| mattoliverau | tdasilva: great idea | 22:20 |
| mattoliverau | morning | 22:20 |
| tdasilva | just realized our experiemental tests were not running against those defined versions due to a typo that ansible never got to tell us about because it just used a default value instead :/ | 22:22 |
| tdasilva | mattoliverau: thanks | 22:22 |
| tdasilva | https://review.openstack.org/#/c/626663/3/tools/playbooks/multinode_setup/make_rings.yaml@24 | 22:23 |
| patchbot | patch 626663 - swift - Add rolling upgrade tests - 3 patch sets | 22:23 |
| *** rcernin has joined #openstack-swift | 22:50 | |
| *** itlinux has quit IRC | 23:11 | |
| openstackgerrit | Thiago da Silva proposed openstack/swift master: Add rolling upgrade tests https://review.openstack.org/626663 | 23:24 |
| openstackgerrit | Merged openstack/python-swiftclient master: Use template for lower-constraints https://review.openstack.org/626742 | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!