*** early` has joined #openstack-swift | 01:08 | |
*** early has quit IRC | 01:08 | |
*** baojg has joined #openstack-swift | 01:43 | |
*** threestrands has joined #openstack-swift | 02:23 | |
*** tonyb has quit IRC | 03:05 | |
kota_ | clayg: what are you trying to is for p 667933? Basically, the algorithms is what timburke described above. the acl handler will translate the PUT with acl to PUT/POST to save the existing acls. | 03:35 |
---|---|---|
patchbot | https://review.opendev.org/#/c/667933/ - swift - clarify s3api ACL test HEADs - 1 patch set | 03:35 |
*** tonyb has joined #openstack-swift | 03:36 | |
kota_ | and https://github.com/openstack/swift/blob/master/swift/common/middleware/s3api/s3request.py#L1554 is to avoid unnecessary request which will be into same result. so if you find other status (i.e. the case that we cannot skip the extra request), probably we should fix the if condition. | 03:37 |
kota_ | hmm... it looks to be related p 580333 that looks I was looking so i should circle back to the patch what we exactly are changing... | 03:39 |
patchbot | https://review.opendev.org/#/c/580333/ - swift - Use get_container_info to check existence before c... - 3 patch sets | 03:39 |
*** psachin has joined #openstack-swift | 03:40 | |
timburke | kota_, for a bit of context, we've got a customer who was doing some benchmarking/stress-testing using the S3 api and started seeing some strange behavior (like BucketNotFound errors during object PUT) once the container servers got overloaded | 03:54 |
timburke | this kicked out https://review.opendev.org/#/c/667411/ and https://review.opendev.org/#/c/667235/ as correctness issues -- better to 503 than say that a container that clearly *does exist* doesn't | 03:55 |
patchbot | patch 667411 - swift - Return 503 when primary containers can't respond (MERGED) - 2 patch sets | 03:55 |
patchbot | patch 667235 - swift - Don't handle object without container (MERGED) - 1 patch set | 03:55 |
timburke | and it renewed interest in https://review.opendev.org/#/c/580333/ whose symptom (large numbers of LockTimeouts) we also saw | 03:57 |
patchbot | patch 580333 - swift - Use get_container_info to check existence before c... - 3 patch sets | 03:57 |
timburke | ...and even when it *did* succeed, it'd cause needless memcache churn | 03:58 |
timburke | even with all that, we're worried that the container's still overloaded because of all the HEADs we have to do as part of s3api ... but there isn't really a good way to avoid some of those -- we *have* to get something down the pipeline to let auth translate access_key_id to account | 04:00 |
timburke | ...which led to me playing around with https://review.opendev.org/#/c/668064/ | 04:01 |
patchbot | patch 668064 - swift - WIP: Give operators the option of serving containe... - 2 patch sets | 04:01 |
kota_ | timburke: i see, I'll take a look the history but exactly we could have something wrong with overloaded container, especially non-atomic operation (e.g. acls) | 04:06 |
*** pcaruana has joined #openstack-swift | 04:36 | |
openstackgerrit | Tim Burke proposed openstack/python-swiftclient master: Clean up warnings from newer flake8 https://review.opendev.org/667478 | 04:44 |
openstackgerrit | Tim Burke proposed openstack/python-swiftclient master: Fix SLO re-upload https://review.opendev.org/651666 | 04:45 |
openstackgerrit | Merged openstack/python-swiftclient master: Isolate docs requirements https://review.opendev.org/667477 | 05:39 |
*** gkadam has joined #openstack-swift | 05:50 | |
*** gkadam has quit IRC | 06:17 | |
*** threestrands has quit IRC | 06:34 | |
*** gkadam has joined #openstack-swift | 06:44 | |
*** csmart has quit IRC | 06:52 | |
*** ccamacho has joined #openstack-swift | 06:53 | |
*** csmart has joined #openstack-swift | 07:03 | |
*** rcernin has quit IRC | 07:16 | |
*** tesseract has joined #openstack-swift | 07:17 | |
openstackgerrit | Matthew Oliver proposed openstack/swift master: Auto-sharding: Initial steps https://review.opendev.org/667030 | 07:17 |
openstackgerrit | Matthew Oliver proposed openstack/swift master: sharding: first attempt at _elect_leader https://review.opendev.org/667579 | 07:17 |
*** tesseract has quit IRC | 07:30 | |
*** rdejoux has joined #openstack-swift | 07:32 | |
*** tesseract has joined #openstack-swift | 07:32 | |
openstackgerrit | Merged openstack/python-swiftclient master: Fix SLO re-upload https://review.opendev.org/651666 | 08:04 |
*** mikecmpbll has joined #openstack-swift | 08:05 | |
*** psachin has quit IRC | 08:08 | |
openstackgerrit | Merged openstack/python-swiftclient master: Clean up warnings from newer flake8 https://review.opendev.org/667478 | 08:13 |
*** psachin has joined #openstack-swift | 08:25 | |
openstackgerrit | zhufl proposed openstack/swift master: Fix invalid assert states https://review.opendev.org/668117 | 09:00 |
*** psachin has quit IRC | 09:16 | |
kota_ | timburke, clayg: After I looked at the changes timburke suggested, I'm realizing the status code map would not follow the recent swift status code changes (perhaps, it has not followed for corner cases ever though) | 09:21 |
kota_ | https://github.com/openstack/swift/blob/master/swift/common/middleware/s3api/s3request.py#L1254-L1256 | 09:21 |
kota_ | ok, let me remember the logic. probably the controllers takes a S3Request (or S3ACLRequest) object instead of swob.Request so the acl handler gets something as clayg said, https://github.com/openstack/swift/blob/master/swift/common/middleware/s3api/acl_handlers.py#L205-L222 | 09:36 |
kota_ | and exactly as the FIXME said, potentially the secondary POST request happens anyway even the first PUT failed with 5xx or 4xx | 09:38 |
kota_ | oh... but the error resp should be raised instead of just a return | 09:41 |
kota_ | Though, InternalError would be returned but the handler will *raise* error status if swift returns unknown status code. | 09:44 |
kota_ | so I assume when overload happens in the swift cluster, then the PUT container (first request) failed with 503, the second request won't happen... | 09:45 |
kota_ | OIC, maybe I reached out what timburke said. | 09:47 |
kota_ | I might be missing what's going on clayg's but p 668064 looks to mitigate the number of HEAD requests for GET account operation to check the last modified? | 09:49 |
patchbot | https://review.opendev.org/#/c/668064/ - swift - WIP: Give operators the option of serving containe... - 2 patch sets | 09:49 |
kota_ | if my understanding would be correct, I think the challenge was what I tried a few years ago, https://www.slideshare.net/tsuyuzaki/liberty-design-summit | 09:51 |
kota_ | anyway, thanks for sharing that context, I may catch (or follow) up more on that so I'll continue to look at the patches and ircs in the next week. | 09:55 |
*** ccamacho has quit IRC | 10:30 | |
*** ccamacho has joined #openstack-swift | 10:31 | |
*** ccamacho has quit IRC | 11:11 | |
*** mvkr has quit IRC | 12:29 | |
*** tdasilva has joined #openstack-swift | 12:35 | |
*** ChanServ sets mode: +v tdasilva | 12:35 | |
*** pcaruana has quit IRC | 12:40 | |
*** pcaruana has joined #openstack-swift | 12:41 | |
*** baojg has quit IRC | 12:51 | |
*** gkadam_ has joined #openstack-swift | 13:21 | |
*** gkadam has quit IRC | 13:22 | |
*** baojg has joined #openstack-swift | 13:36 | |
*** BjoernT has joined #openstack-swift | 13:42 | |
*** gkadam_ has quit IRC | 14:21 | |
*** baojg has quit IRC | 15:19 | |
*** baojg has joined #openstack-swift | 15:19 | |
*** zaitcev_ has joined #openstack-swift | 15:20 | |
*** ChanServ sets mode: +v zaitcev_ | 15:20 | |
*** jistr is now known as jistr|off | 15:20 | |
*** zaitcev has quit IRC | 15:23 | |
*** baojg has quit IRC | 15:29 | |
*** jistr|off is now known as jistr | 15:42 | |
*** zaitcev__ has joined #openstack-swift | 16:19 | |
*** ChanServ sets mode: +v zaitcev__ | 16:19 | |
*** zaitcev_ has quit IRC | 16:23 | |
*** BjoernT has quit IRC | 16:46 | |
*** zaitcev__ has quit IRC | 16:53 | |
*** zaitcev__ has joined #openstack-swift | 17:04 | |
*** ChanServ sets mode: +v zaitcev__ | 17:04 | |
*** e0ne has joined #openstack-swift | 17:26 | |
*** zaitcev__ is now known as zaitcev | 17:26 | |
*** mikecmpbll has quit IRC | 17:34 | |
*** rdejoux has quit IRC | 17:47 | |
*** mvkr has joined #openstack-swift | 17:52 | |
*** e0ne has quit IRC | 18:12 | |
*** e0ne has joined #openstack-swift | 18:13 | |
*** tesseract has quit IRC | 18:13 | |
*** e0ne has quit IRC | 18:16 | |
*** e0ne has joined #openstack-swift | 18:26 | |
*** e0ne has quit IRC | 18:28 | |
*** zaitcev has quit IRC | 18:28 | |
*** zaitcev has joined #openstack-swift | 18:39 | |
*** ChanServ sets mode: +v zaitcev | 18:39 | |
*** tdasilva has quit IRC | 19:06 | |
*** BjoernT has joined #openstack-swift | 19:59 | |
*** BjoernT has quit IRC | 20:04 | |
zaitcev | What does Jinja2 do in our lower-constraints.txt? | 20:06 |
*** BjoernT has joined #openstack-swift | 20:08 | |
*** zaitcev has quit IRC | 20:11 | |
timburke | that's an excellent question :-/ i'm guessing it's a transitive dep of some sort, but i don't remember who brought it in | 20:21 |
*** zaitcev has joined #openstack-swift | 20:24 | |
*** ChanServ sets mode: +v zaitcev | 20:24 | |
*** mvkr has quit IRC | 20:40 | |
*** mvkr has joined #openstack-swift | 20:53 | |
*** mvkr has quit IRC | 21:07 | |
*** pcaruana has quit IRC | 21:16 | |
*** mvkr has joined #openstack-swift | 21:21 | |
timburke | zaitcev, looks like sphinx pulls it in. so it probably doesn't strictly need to be in lower-constraints.txt; we don't have a lower-constraints docs build or anything | 22:04 |
zaitcev | ok | 22:05 |
zaitcev | I tried to run my test cluster on py3 and immediatelly object server threw up | 22:05 |
zaitcev | I thought you were running func tests. | 22:05 |
zaitcev | Not that I'm disappointed or anything, at last something that I can fix. | 22:05 |
timburke | oh good! that means you can review https://review.opendev.org/#/c/665494/ :P | 22:06 |
patchbot | patch 665494 - swift - Move call to global_conf_callback after loadapp() - 4 patch sets | 22:06 |
zaitcev | so that's what it was huh | 22:06 |
timburke | still weirds me out a bit that we're getting different paste behavior based on python version... makes me wonder a bit if there's some new interpolation thing that's happening that's gonna break some existing configs... | 22:07 |
timburke | iirc, pick up that patch and https://review.opendev.org/#/c/662546/ and you can get func tests passing with tempauth | 22:09 |
patchbot | patch 662546 - swift - py3: Be able to read and write non-ASCII headers - 4 patch sets | 22:09 |
timburke | add https://review.opendev.org/#/c/653548/ and they'll pass for keystone too | 22:10 |
patchbot | patch 653548 - swift - py3: add swift-dsvm-functional-py3 job - 14 patch sets | 22:10 |
timburke | which we verify in https://review.opendev.org/#/c/666942/ | 22:10 |
patchbot | patch 666942 - swift - Run all func tests under py2 against services runn... - 1 patch set | 22:10 |
*** zaitcev has quit IRC | 23:39 | |
*** zaitcev has joined #openstack-swift | 23:40 | |
*** ChanServ sets mode: +v zaitcev | 23:40 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!