| opendevreview | Tim Burke proposed openstack/swift master: Plumb allow_modify_pipeline through run_wsgi/run_server https://review.opendev.org/c/openstack/swift/+/804544 | 00:09 |
|---|---|---|
| opendevreview | Tim Burke proposed openstack/swift master: DNM: Add MultiprocessInternalClient https://review.opendev.org/c/openstack/swift/+/803536 | 00:09 |
| opendevreview | Matthew Oliver proposed openstack/swift master: statsd: Make statsd prefix support account interpolation https://review.opendev.org/c/openstack/swift/+/804948 | 06:24 |
| mattoliver | ^ thanks kinda just an experiment. Next need to test it out to see if it actaully works as I expect :P | 06:25 |
| godog | hello folks, I ran into an issue on Swift 2.26 where transfer-encoding: chunked is sent on 204, I've opened #1939888 for it and was wondering what you think ? thank you ! | 08:38 |
| clayg | godog: i just did a HEAD on my account in my dev environment running master - and did not see a transfer-encoding header in the 204 response 🤔 | 18:06 |
| clayg | i'm booting up 2.26 now | 18:06 |
| clayg | hrm.. same | 18:06 |
| clayg | our pipelines look pretty similar | 18:08 |
| clayg | godog: take a closer look at the layers between your client and the eventlet wsgi app that's running the proxy - try to talk directly to it from on a proxy node and see the response is any different (GL!) | 18:15 |
| opendevreview | Clay Gerrard proposed openstack/swift master: ring: store actual ring replica count to better deserialize https://review.opendev.org/c/openstack/swift/+/803665 | 19:55 |
| timburke_ | almost meeting time! | 20:55 |
| *** timburke_ is now known as timburke | 21:00 | |
| timburke | #startmeeting swift | 21:00 |
| opendevmeet | Meeting started Wed Aug 18 21:00:22 2021 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
| opendevmeet | The meeting name has been set to 'swift' | 21:00 |
| timburke | who's here for the swift meeting? | 21:00 |
| kota | o/ | 21:00 |
| mattoliver | o/ | 21:01 |
| acoles | o/ | 21:03 |
| timburke | i forgot to update the agenda, sorry -- but mostly i think we just want to follow-up on the patches from last week | 21:04 |
| timburke | #topic container sharding and storage policy reconcililiation | 21:04 |
| timburke | so we merged the first patch in the chain: https://review.opendev.org/c/openstack/swift/+/803423 | 21:04 |
| timburke | how's the patch to propagate the correct policy to the shards looking? still need review? | 21:05 |
| timburke | https://review.opendev.org/c/openstack/swift/+/800748 | 21:05 |
| mattoliver | Yeah, I've rebased it. just needs some review time | 21:07 |
| mattoliver | unless that happened while I slept :) | 21:07 |
| timburke | i know the first patch also spun off a handful of other patches, most of which either got squashed in or already mereged | 21:10 |
| timburke | i think the one exception is https://review.opendev.org/c/openstack/swift/+/804696 -- acoles, is that mostly a belt & bracers sort of a patch? | 21:10 |
| acoles | mostly belt and braces, seemed like future us could be surprised to deal with an object listing body in a response with a record type of shard. | 21:13 |
| timburke | 👍 | 21:14 |
| mattoliver | I'll check it out and review it today | 21:14 |
| acoles | I was a little worried about that catching us out given the recursive nature of shard listings | 21:14 |
| timburke | yeah, seems totally reasonable | 21:15 |
| acoles | but so far I'm not aware of any bug as such | 21:15 |
| timburke | #topic internal client bottlenecks | 21:15 |
| acoles | I guess if any middleware ever started to pay attention to the record type then there could be issues | 21:15 |
| timburke | i finally got around to doing some benchmarking with my MultiprocessInternalClient | 21:16 |
| timburke | the context, again, was that i had a single-process, greenthreaded data mover that would get CPU bound. on a little test cluster, switching InternalClient for MultiprocessInternalClient got me a 4-5x speedup! | 21:17 |
| mattoliver | nice! | 21:18 |
| timburke | i even managed to do it without any swift changes, though it'll be a lot cleaner once we've got https://review.opendev.org/c/openstack/swift/+/804544 to add some allow_modify_pipeline plumbing through run_wsgi and run_server | 21:18 |
| acoles | sounds promising! | 21:19 |
| timburke | thanks for the reviews on that clayg! definitely helped me clean things up a bit and minimize the likelihood that anyone accidentally runs like that for a client-facing proxy | 21:19 |
| clayg | @timburke thanks for flailing along with me | 21:20 |
| timburke | the main process is still CPU-bound, so next up, i'm going to try fanning out that guy as well | 21:22 |
| timburke | that's all i've got | 21:22 |
| timburke | #topic open discussion | 21:22 |
| timburke | what else should we bring up this week? | 21:22 |
| mattoliver | I'm making prgress on my request tracing POC. Now mostly has opentracing support, I hope to have that working soon. | 21:24 |
| timburke | nice! | 21:24 |
| mattoliver | I've also played with adding statsd account interpolation support https://review.opendev.org/c/openstack/swift/+/804948 | 21:24 |
| mattoliver | Which will allow someone to add accounts to statsd prefixs when it makes sense. In case larger clusters wants to track account usage/datapoints more. | 21:25 |
| mattoliver | wrote code and tests yest.. hopefully test it today. | 21:26 |
| mattoliver | Oh and I saw clayg has pushed and commented on the ring derserialization stuff. So thanks! I'll look at that today too! | 21:27 |
| mattoliver | #link https://review.opendev.org/c/openstack/swift/+/803665 | 21:29 |
| timburke | the version number bump is definitely something on my mind, since i still want to allow for wider dev_ids in https://review.opendev.org/c/openstack/swift/+/761794 ;-) | 21:31 |
| timburke | (and it runs into similar upgrade problems) | 21:31 |
| mattoliver | oh yeah | 21:31 |
| clayg | @mattoliver do you have any reason to believe someone would want to have that many metric files? we already have trouble aggregating cluster stats across our number of servers | 21:31 |
| clayg | @timburke awesome!!! ring format v2 here we come! | 21:32 |
| timburke | hopefully while still being able to write out v1 rings for a while ;-) | 21:32 |
| mattoliver | @clay | 21:33 |
| mattoliver | @clay good question... but something that someone like john is interested in.. but now sure it's exactly what we want yet.. wanted to see how it came out. | 21:33 |
| mattoliver | *not sure | 21:34 |
| mattoliver | (sorry seems I can't type this early) :P | 21:34 |
| timburke | surely we can find a way to shard metrics across multiple collectors -- there's definitely an interest in being able to see at a glance which tenant is responsible for a sudden uptick in traffic, for example | 21:35 |
| mattoliver | But currently if you don't add an {account} nothing changes to what we have today. | 21:35 |
| timburke | seems about like our usual policy: give ops enough rope to hang themselves :P | 21:36 |
| mattoliver | lol, that's what I do.. I'm software engineer/hangman :P | 21:36 |
| mattoliver | I'll mark it as WIP in any case becasue no doubt it needs more discussion and testing :) | 21:37 |
| timburke | all right, seems like we're about done | 21:39 |
| timburke | thank you all for coming, and thank you for working on swift! | 21:39 |
| clayg | it's possible the way the statsd exporter does metric collection (or how prometheus stores it) makes this exactly what they need/want - but I don't think i'd want that if i was dumping into graphite | 21:39 |
| timburke | don't forget to put topics on the PTG etherpad | 21:39 |
| timburke | #link https://etherpad.opendev.org/p/swift-ptg-yoga | 21:39 |
| timburke | #endmeeting | 21:39 |
| opendevmeet | Meeting ended Wed Aug 18 21:39:55 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:39 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2021/swift.2021-08-18-21.00.html | 21:39 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2021/swift.2021-08-18-21.00.txt | 21:39 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2021/swift.2021-08-18-21.00.log.html | 21:39 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!