opendevreview | Alistair Coles proposed openstack/swift master: Modify log_name in internal clients' pipeline configs https://review.opendev.org/c/openstack/swift/+/820539 | 15:41 |
---|---|---|
clayg | timburke: FWIW i saw that you were pulling the track method off the class when you were done with it using del - but the justification I imagined was to keep the attributes the same between fake and real | 19:41 |
clayg | timburke: you could prefix the the function name with an underscore or even just leave it - I think pete and al just thought the del was un-usual (which maybe it is; you don't see that often) | 19:42 |
timburke | i know i've seen it on occasion in some other code, though i forget where now. i think it was somebody wanting to have a singleton, and the surest, clearest way is to define the class, instantiate the object, then delete the class | 20:56 |
opendevreview | Tim Burke proposed openstack/swift master: tests: Improve FakeMemcache call tracking https://review.opendev.org/c/openstack/swift/+/823725 | 21:09 |
opendevreview | Tim Burke proposed openstack/swift master: proxy: Add a chance to skip memcache when looking for shard ranges https://review.opendev.org/c/openstack/swift/+/736802 | 21:09 |
opendevreview | Tim Burke proposed openstack/swift master: Get rid of pipeline_property https://review.opendev.org/c/openstack/swift/+/821920 | 21:09 |
opendevreview | Tim Burke proposed openstack/swift master: proxy: Add a chance to skip memcache for get_*_info calls https://review.opendev.org/c/openstack/swift/+/821921 | 21:09 |
clayg | timburke: 🙄 | 21:35 |
timburke | you want an eye-roll, check out https://github.com/eventlet/eventlet/pull/743 :P | 21:47 |
clayg | 🤮 | 21:51 |
opendevreview | Clay Gerrard proposed openstack/swift master: DNM: add a probetest for MPU expiration https://review.opendev.org/c/openstack/swift/+/822192 | 22:06 |
opendevreview | Clay Gerrard proposed openstack/swift master: WIP: use async pending to expire MPU https://review.opendev.org/c/openstack/swift/+/822377 | 22:06 |
opendevreview | Clay Gerrard proposed openstack/swift master: Expire the entire s3api MPU https://review.opendev.org/c/openstack/swift/+/800701 | 22:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!