opendevreview | Tim Burke proposed openstack/swift master: systemd: Send STOPPING/RELOADING notifications https://review.opendev.org/c/openstack/swift/+/837633 | 01:00 |
---|---|---|
opendevreview | Tim Burke proposed openstack/swift master: Add swift-notifications abstract socket https://review.opendev.org/c/openstack/swift/+/837641 | 01:00 |
opendevreview | Matthew Oliver proposed openstack/swift master: WIP: Adding some statisical variance to shard/shrink candidates https://review.opendev.org/c/openstack/swift/+/837669 | 07:09 |
mattoliver | ^ that is nothing important, just playing with stats in an attempt to add some stats to shard ranges. Wanted to get it off my computer | 07:10 |
opendevreview | Thibault Person proposed openstack/swift master: Add support of Sigv4-streaming https://review.opendev.org/c/openstack/swift/+/836755 | 10:17 |
opendevreview | Alistair Coles proposed openstack/swift master: RateLimiter: add option to burst on start-up https://review.opendev.org/c/openstack/swift/+/835122 | 11:49 |
opendevreview | Alistair Coles proposed openstack/swift master: Add backend rate limiting middleware https://review.opendev.org/c/openstack/swift/+/836046 | 11:49 |
opendevreview | Thibault Person proposed openstack/swift master: Add support of Sigv4-streaming https://review.opendev.org/c/openstack/swift/+/836755 | 12:50 |
opendevreview | Alistair Coles proposed openstack/swift master: Add backend rate limiting middleware https://review.opendev.org/c/openstack/swift/+/836046 | 13:23 |
timburke__ | fyi, on the current gate breakage: http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028160.html | 15:38 |
opendevreview | Alistair Coles proposed openstack/swift master: s3api: add API support for optional bucket inventory https://review.opendev.org/c/openstack/swift/+/835938 | 17:34 |
opendevreview | Clay Gerrard proposed openstack/swift master: Don't monkey patch logging on import https://review.opendev.org/c/openstack/swift/+/457110 | 19:24 |
acoles | are we meeting today? | 20:02 |
opendevreview | Tim Burke proposed openstack/swift master: sharding: Skip shards that can't include any new subdir entries https://review.opendev.org/c/openstack/swift/+/837397 | 20:34 |
opendevreview | Tim Burke proposed openstack/swift master: Add --test-config option to WSGI servers https://review.opendev.org/c/openstack/swift/+/833124 | 20:43 |
opendevreview | Tim Burke proposed openstack/swift master: Add a swift-reload command https://review.opendev.org/c/openstack/swift/+/833174 | 20:43 |
opendevreview | Tim Burke proposed openstack/swift master: systemd: Send STOPPING/RELOADING notifications https://review.opendev.org/c/openstack/swift/+/837633 | 20:43 |
opendevreview | Tim Burke proposed openstack/swift master: Add abstract sockets for process notifications https://review.opendev.org/c/openstack/swift/+/837641 | 20:43 |
timburke__ | acoles, we are, but in ~10min. i think the last meeting was before your DST kicked in | 20:50 |
*** timburke__ is now known as timburke | 20:55 | |
timburke | #startmeeting swift | 21:00 |
opendevmeet | Meeting started Wed Apr 13 21:00:03 2022 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
opendevmeet | The meeting name has been set to 'swift' | 21:00 |
timburke | who's here for the swift meeting? | 21:00 |
kota | hi | 21:00 |
acoles | o/ | 21:02 |
timburke | you're back! i thought you'd left for the night ;-) | 21:02 |
timburke | i know clayg has a sick kid at home, and it's towards the end of his day anyway, so he might not come | 21:03 |
timburke | dunno about mattoliver | 21:03 |
timburke | but we can go ahead and start | 21:03 |
timburke | as usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift | 21:04 |
timburke | first up | 21:04 |
timburke | #topic ptg recap | 21:04 |
timburke | thanks to everybody for coming last week! it was great seeing everyone again | 21:04 |
mattoliver | Oh o/ | 21:04 |
mattoliver | (Forgot this is earlier after day light savings ended) | 21:05 |
timburke | i feel like we had a lot of good discussions about what we're working on, including things like ring v2, sharding, and tsync | 21:05 |
acoles | ptg is always good | 21:05 |
kota | +1 | 21:06 |
timburke | the previous ptg, we came away with a bunch of action items -- hopefully the fact that we only bothered to write down three this time means we'll be more likely to do them ;-) | 21:06 |
timburke | the action items this time were: | 21:07 |
timburke | investigate the current state of the art for erasure coding | 21:07 |
timburke | get the test/s3api suite running in the gate | 21:07 |
timburke | and figure out how to tag releases in docker hub as part of the release process | 21:08 |
timburke | who would like to champion any of these? | 21:08 |
mattoliver | I can play with the docker one as I watched tdasilva do the last docker stuff at a in person ptg. | 21:09 |
mattoliver | Not that that means it's help :p | 21:10 |
timburke | 👍 let me know if/when you'd like me to put a release together to test zuul pipeline machinery | 21:10 |
timburke | i can take on the test/s3api suite; i've done similar things before for the CORS tests | 21:11 |
timburke | on the last -- *shrug* we can revisit it later | 21:12 |
timburke | next up | 21:12 |
timburke | #topic liberasure code release | 21:12 |
timburke | i tagged 1.6.3 a few days ago! | 21:13 |
kota | nice | 21:13 |
timburke | it includes the library name suffixing that pyeclib will require to be able to build useful wheels | 21:13 |
timburke | so i guess my next question is, do we want to review and merge https://review.opendev.org/c/openstack/pyeclib/+/817498 ahead of a pyeclib 1.6.1 release? | 21:14 |
timburke | i already started compiling release notes at https://review.opendev.org/c/openstack/pyeclib/+/833471 fwiw | 21:15 |
timburke | eh, i think i'll aim to release sooner rather than later. can always do another ;-) | 21:17 |
mattoliver | Well if you've added the other things needed to build wheels we could add it too to make it easier to build. But either way. | 21:17 |
timburke | well, i went ahead and broke out the stable python abi changes from the rest of the wheel-building stuff, and merged the stable abi patch. i think anyone *could* make useful wheels now, so the patch is only really about having the tooling for it in-tree | 21:19 |
timburke | #topic improving sharded listing performance | 21:20 |
timburke | so we got a complaint about listing performance for one of our larger containers | 21:21 |
timburke | it was a prefix/delimiter query that covered a fairly wide part of the namespace, so the one client request needed to contact several hundred backend shards | 21:22 |
timburke | part of the problem was that a lot of objects had been deleted, so ~100 or so shards were actually *empty* | 21:23 |
timburke | once we did some manual shrinking, the situation improved a bit, but we're still talking to hundreds of shards to get a listing with <50 subdir entries | 21:24 |
timburke | (which means there's a whole bunch of shards that have *no* new information *at all*) | 21:25 |
mattoliver | So a bunch we're answering the same question | 21:25 |
timburke | i took a stab at fixing that in https://review.opendev.org/c/openstack/swift/+/837397 - Skip shards that can't include any new subdir entries | 21:25 |
mattoliver | It's a good optimisation, even if it took me longer to grok then I'd like. | 21:26 |
mattoliver | But that's due to subdir and pseudo folder and how that works. | 21:27 |
timburke | it's probably still under-tested, but if you get a chance, please take a look! there are definitely some subtle fence-post-error sorts of things to consider | 21:27 |
timburke | i should also think about whether it's got any implications for https://review.opendev.org/c/openstack/swift/+/829605 🤔 | 21:28 |
timburke | next up | 21:29 |
timburke | #topic ring v2 | 21:29 |
mattoliver | I'll play with it today. | 21:29 |
timburke | mattoliver, thanks! | 21:29 |
timburke | i haven't forgotten about it! though i never did get around to pushing up that fresh patchset last week :-( | 21:30 |
timburke | just wanted to let people know that it's still on my radar | 21:30 |
timburke | #topic backend ratelimiting | 21:30 |
mattoliver | Feel free to squash any of my follow up in, ie the serialize/deserialize v2 stuff. | 21:31 |
timburke | 👍 | 21:31 |
timburke | it seems like we've seen a decent bit of activity on ratelimiting; how's it going acoles? | 21:31 |
acoles | we discussed this at the ptg and questioned why it would be built in to the storage server rather than a middleware, so I changed my patch to be a middleware | 21:33 |
acoles | https://review.opendev.org/c/openstack/swift/+/836046 | 21:33 |
mattoliver | Nice | 21:33 |
acoles | we also discussed what an appropriate response code would be | 21:33 |
acoles | 503 could be confusing, but was assumed to be handled by all existing 'clients' | 21:34 |
mattoliver | What did you end up doing, has 529 been born? | 21:34 |
acoles | however, I noticed some unfortunate proxy log errors when i played with this in an object erver | 21:34 |
acoles | so, we may need to make some proxy changes whatever response code we choose, so 529 might be ok - still wondering what to do about that | 21:35 |
mattoliver | Kk | 21:36 |
acoles | BTW the error I saw logged in proxy was "Apr 13 11:37:02 saio proxy-server: ERROR 503 Expect: 100-continue From Object Server 127.0.0.4:6040/sdb4 (txn: txe9b36cc23552497697801-006256b5de) (client_ip: 127.0.0.1)" | 21:36 |
timburke | that makes some sense -- i bet we get similar log lines on 507 | 21:37 |
acoles | no, 507 is handled separately | 21:37 |
timburke | ah, yeah -- https://github.com/openstack/swift/blob/master/swift/proxy/controllers/obj.py#L481-L492 | 21:38 |
acoles | something like "'ERROR Insufficient Storage'" | 21:38 |
timburke | all right, that's all i've got | 21:38 |
timburke | #topic open discussion | 21:39 |
acoles | so I wonder if we ought to have "ERROR ratelimited" ??? | 21:39 |
timburke | i like that | 21:39 |
timburke | what else should we talk about this week? | 21:39 |
timburke | i started playing around with systemd notify sockets more yesterday | 21:41 |
timburke | including sending STOPPING and RELOADING messages in https://review.opendev.org/c/openstack/swift/+/837633 | 21:41 |
acoles | sorry, I need to drop -👋 | 21:42 |
timburke | and mostly reimplementing the thing in https://review.opendev.org/c/openstack/swift/+/837641 so the swift-reload guy doesn't have to poll child processes | 21:42 |
timburke | g'night, acoles | 21:42 |
mattoliver | It's Easter long weekend here, so not too much will happen this next week as Friday and Monday are off. But hopefully I'll get a chance to go over the patches I have that we discussed at PTG and will follow up on them. Will add them to the agenda if there is anything to talk about. | 21:42 |
mattoliver | Nice work Tim. | 21:42 |
timburke | all right then | 21:43 |
timburke | thank you all for coming, and thank you for working on swift! | 21:43 |
timburke | #endmeeting | 21:43 |
opendevmeet | Meeting ended Wed Apr 13 21:43:57 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:43 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.html | 21:43 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.txt | 21:43 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.log.html | 21:43 |
opendevreview | Tim Burke proposed openstack/swift master: s3api: Use constant-time string comparisons in check_signature https://review.opendev.org/c/openstack/swift/+/837773 | 22:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!