Wednesday, 2022-04-13

opendevreviewTim Burke proposed openstack/swift master: systemd: Send STOPPING/RELOADING notifications  https://review.opendev.org/c/openstack/swift/+/83763301:00
opendevreviewTim Burke proposed openstack/swift master: Add swift-notifications abstract socket  https://review.opendev.org/c/openstack/swift/+/83764101:00
opendevreviewMatthew Oliver proposed openstack/swift master: WIP: Adding some statisical variance to shard/shrink candidates  https://review.opendev.org/c/openstack/swift/+/83766907:09
mattoliver^ that is nothing important, just playing with stats in an attempt to add some stats to shard ranges. Wanted to get it off my computer07:10
opendevreviewThibault Person proposed openstack/swift master: Add support of Sigv4-streaming  https://review.opendev.org/c/openstack/swift/+/83675510:17
opendevreviewAlistair Coles proposed openstack/swift master: RateLimiter: add option to burst on start-up  https://review.opendev.org/c/openstack/swift/+/83512211:49
opendevreviewAlistair Coles proposed openstack/swift master: Add backend rate limiting middleware  https://review.opendev.org/c/openstack/swift/+/83604611:49
opendevreviewThibault Person proposed openstack/swift master: Add support of Sigv4-streaming  https://review.opendev.org/c/openstack/swift/+/83675512:50
opendevreviewAlistair Coles proposed openstack/swift master: Add backend rate limiting middleware  https://review.opendev.org/c/openstack/swift/+/83604613:23
timburke__fyi, on the current gate breakage: http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028160.html15:38
opendevreviewAlistair Coles proposed openstack/swift master: s3api: add API support for optional bucket inventory  https://review.opendev.org/c/openstack/swift/+/83593817:34
opendevreviewClay Gerrard proposed openstack/swift master: Don't monkey patch logging on import  https://review.opendev.org/c/openstack/swift/+/45711019:24
acolesare we meeting today?20:02
opendevreviewTim Burke proposed openstack/swift master: sharding: Skip shards that can't include any new subdir entries  https://review.opendev.org/c/openstack/swift/+/83739720:34
opendevreviewTim Burke proposed openstack/swift master: Add --test-config option to WSGI servers  https://review.opendev.org/c/openstack/swift/+/83312420:43
opendevreviewTim Burke proposed openstack/swift master: Add a swift-reload command  https://review.opendev.org/c/openstack/swift/+/83317420:43
opendevreviewTim Burke proposed openstack/swift master: systemd: Send STOPPING/RELOADING notifications  https://review.opendev.org/c/openstack/swift/+/83763320:43
opendevreviewTim Burke proposed openstack/swift master: Add abstract sockets for process notifications  https://review.opendev.org/c/openstack/swift/+/83764120:43
timburke__acoles, we are, but in ~10min. i think the last meeting was before your DST kicked in20:50
*** timburke__ is now known as timburke20:55
timburke#startmeeting swift21:00
opendevmeetMeeting started Wed Apr 13 21:00:03 2022 UTC and is due to finish in 60 minutes.  The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot.21:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.21:00
opendevmeetThe meeting name has been set to 'swift'21:00
timburkewho's here for the swift meeting?21:00
kotahi21:00
acoleso/21:02
timburkeyou're back! i thought you'd left for the night ;-)21:02
timburkei know clayg has a sick kid at home, and it's towards the end of his day anyway, so he might not come21:03
timburkedunno about mattoliver21:03
timburkebut we can go ahead and start21:03
timburkeas usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift21:04
timburkefirst up21:04
timburke#topic ptg recap21:04
timburkethanks to everybody for coming last week! it was great seeing everyone again21:04
mattoliverOh o/21:04
mattoliver(Forgot this is earlier after day light savings ended) 21:05
timburkei feel like we had a lot of good discussions about what we're working on, including things like ring v2, sharding, and tsync21:05
acolesptg is always good21:05
kota+121:06
timburkethe previous ptg, we came away with a bunch of action items -- hopefully the fact that we only bothered to write down three this time means we'll be more likely to do them ;-)21:06
timburkethe action items this time were:21:07
timburkeinvestigate the current state of the art for erasure coding21:07
timburkeget the test/s3api suite running in the gate21:07
timburkeand figure out how to tag releases in docker hub as part of the release process21:08
timburkewho would like to champion any of these?21:08
mattoliverI can play with the docker one as I watched tdasilva do the last docker stuff at a in person ptg. 21:09
mattoliverNot that that means it's help :p 21:10
timburke👍 let me know if/when you'd like me to put a release together to test zuul pipeline machinery21:10
timburkei can take on the test/s3api suite; i've done similar things before for the CORS tests21:11
timburkeon the last -- *shrug* we can revisit it later21:12
timburkenext up21:12
timburke#topic liberasure code release21:12
timburkei tagged 1.6.3 a few days ago!21:13
kotanice21:13
timburkeit includes the library name suffixing that pyeclib will require to be able to build useful wheels21:13
timburkeso i guess my next question is, do we want to review and merge https://review.opendev.org/c/openstack/pyeclib/+/817498 ahead of a pyeclib 1.6.1 release?21:14
timburkei already started compiling release notes at https://review.opendev.org/c/openstack/pyeclib/+/833471 fwiw21:15
timburkeeh, i think i'll aim to release sooner rather than later. can always do another ;-)21:17
mattoliverWell if you've added the other things needed to build wheels we could add it too to make it easier to build. But either way. 21:17
timburkewell, i went ahead and broke out the stable python abi changes from the rest of the wheel-building stuff, and merged the stable abi patch. i think anyone *could* make useful wheels now, so the patch is only really about having the tooling for it in-tree21:19
timburke#topic improving sharded listing performance21:20
timburkeso we got a complaint about listing performance for one of our larger containers21:21
timburkeit was a prefix/delimiter query that covered a fairly wide part of the namespace, so the one client request needed to contact several hundred backend shards21:22
timburkepart of the problem was that a lot of objects had been deleted, so ~100 or so shards were actually *empty*21:23
timburkeonce we did some manual shrinking, the situation improved a bit, but we're still talking to hundreds of shards to get a listing with <50 subdir entries21:24
timburke(which means there's a whole bunch of shards that have *no* new information *at all*)21:25
mattoliverSo a bunch we're answering the same question21:25
timburkei took a stab at fixing that in https://review.opendev.org/c/openstack/swift/+/837397 - Skip shards that can't include any new subdir entries21:25
mattoliverIt's a good optimisation, even if it took me longer to grok then I'd like. 21:26
mattoliverBut that's due to subdir and pseudo folder and how that works. 21:27
timburkeit's probably still under-tested, but if you get a chance, please take a look! there are definitely some subtle fence-post-error sorts of things to consider21:27
timburkei should also think about whether it's got any implications for https://review.opendev.org/c/openstack/swift/+/829605 🤔21:28
timburkenext up21:29
timburke#topic ring v221:29
mattoliverI'll play with it today. 21:29
timburkemattoliver, thanks!21:29
timburkei haven't forgotten about it! though i never did get around to pushing up that fresh patchset last week :-(21:30
timburkejust wanted to let people know that it's still on my radar21:30
timburke#topic backend ratelimiting21:30
mattoliverFeel free to squash any of my follow up in, ie the serialize/deserialize v2 stuff. 21:31
timburke👍21:31
timburkeit seems like we've seen a decent bit of activity on ratelimiting; how's it going acoles?21:31
acoleswe discussed this at the ptg and questioned why it would be built in to the storage server rather than a middleware, so I changed my patch to be a middleware21:33
acoleshttps://review.opendev.org/c/openstack/swift/+/83604621:33
mattoliverNice21:33
acoleswe also discussed what an appropriate response code would be21:33
acoles503 could be confusing, but was assumed to be handled by all existing 'clients'21:34
mattoliverWhat did you end up doing, has 529 been born? 21:34
acoleshowever, I noticed some unfortunate proxy log errors when i played with this in an object erver21:34
acolesso, we may need to make some proxy changes whatever response code we choose, so 529 might be ok - still wondering what to do about that21:35
mattoliverKk21:36
acolesBTW the error I saw logged in proxy was "Apr 13 11:37:02 saio proxy-server: ERROR 503 Expect: 100-continue From Object Server 127.0.0.4:6040/sdb4 (txn: txe9b36cc23552497697801-006256b5de) (client_ip: 127.0.0.1)"21:36
timburkethat makes some sense -- i bet we get similar log lines on 50721:37
acolesno, 507 is handled separately21:37
timburkeah, yeah -- https://github.com/openstack/swift/blob/master/swift/proxy/controllers/obj.py#L481-L49221:38
acolessomething like "'ERROR Insufficient Storage'"21:38
timburkeall right, that's all i've got21:38
timburke#topic open discussion21:39
acolesso I wonder if we ought to have "ERROR ratelimited" ???21:39
timburkei like that21:39
timburkewhat else should we talk about this week?21:39
timburkei started playing around with systemd notify sockets more yesterday21:41
timburkeincluding sending STOPPING and RELOADING messages in https://review.opendev.org/c/openstack/swift/+/83763321:41
acolessorry, I need to drop -👋21:42
timburkeand mostly reimplementing the thing in https://review.opendev.org/c/openstack/swift/+/837641 so the swift-reload guy doesn't have to poll child processes21:42
timburkeg'night, acoles21:42
mattoliverIt's Easter long weekend here, so not too much will happen this next week as Friday and Monday are off. But hopefully I'll get a chance to go over the patches I have that we discussed at PTG and will follow up on them. Will add them to the agenda if there is anything to talk about. 21:42
mattoliverNice work Tim. 21:42
timburkeall right then21:43
timburkethank you all for coming, and thank you for working on swift!21:43
timburke#endmeeting21:43
opendevmeetMeeting ended Wed Apr 13 21:43:57 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)21:43
opendevmeetMinutes:        https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.html21:43
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.txt21:43
opendevmeetLog:            https://meetings.opendev.org/meetings/swift/2022/swift.2022-04-13-21.00.log.html21:43
opendevreviewTim Burke proposed openstack/swift master: s3api: Use constant-time string comparisons in check_signature  https://review.opendev.org/c/openstack/swift/+/83777322:42

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!