opendevreview | Matthew Oliver proposed openstack/swift master: sharding: shard deleted containers that have shards with objects https://review.opendev.org/c/openstack/swift/+/844553 | 07:15 |
---|---|---|
opendevreview | Tim Burke proposed openstack/python-swiftclient master: tempurl: Support sha256 and sha512 signatures https://review.opendev.org/c/openstack/python-swiftclient/+/845157 | 16:33 |
opendevreview | Tim Burke proposed openstack/python-swiftclient master: Add more validation for ip_range args https://review.opendev.org/c/openstack/python-swiftclient/+/581906 | 18:06 |
opendevreview | Tim Burke proposed openstack/python-swiftclient master: Be a little more careful about read() return values https://review.opendev.org/c/openstack/python-swiftclient/+/834754 | 20:27 |
opendevreview | Tim Burke proposed openstack/python-swiftclient master: service: Allow SwiftUploadObject sources to be bytes https://review.opendev.org/c/openstack/python-swiftclient/+/834753 | 20:29 |
timburke_ | #startmeeting swift | 21:00 |
opendevmeet | Meeting started Wed Jun 8 21:00:38 2022 UTC and is due to finish in 60 minutes. The chair is timburke_. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
opendevmeet | The meeting name has been set to 'swift' | 21:00 |
timburke_ | who's here for the swift meeting? | 21:00 |
kota | hi | 21:00 |
timburke_ | as usual, the agenda's at | 21:02 |
timburke_ | #link https://wiki.openstack.org/wiki/Meetings/Swift | 21:02 |
acoles | I'm here for a while | 21:02 |
timburke_ | first up | 21:02 |
timburke_ | #topic tempurl sha1 deprecation | 21:03 |
timburke_ | so i realized we probably should have added client support before we went and removed sha1 from the server defaults | 21:03 |
timburke_ | and i proposed https://review.opendev.org/c/openstack/python-swiftclient/+/845157 to remedy that | 21:04 |
timburke_ | in general, i think clayg wasn't real happy with how https://review.opendev.org/c/openstack/swift/+/525771 shook out | 21:06 |
timburke_ | but it's not clear to me what lessons there are to be learned as we try to do something similar for formpost | 21:06 |
acoles | client support first would have helped i guess | 21:07 |
timburke_ | maybe we could also emit some stats about what algorithms are in use, so ops can feel confident that their users have transitioned? | 21:07 |
acoles | yeah, I'm not sure - were we logging warnings if sha1 was still configured after deprecation? | 21:08 |
timburke_ | or that the feature isn't being used | 21:08 |
acoles | but logging stats about clients would be cool | 21:08 |
timburke_ | i think clay's issue was with the deprecation and the removal from defaults coming in one patch -- but i feel like our default configs shouldn't emit deprecation warnings as a matter of principle | 21:10 |
kota | i see | 21:11 |
acoles | I guess we could first introduce the facility to explicitly opt in for the legacy support, and warn if client uses legacy but its not explicitly configured, then in a later release flip to *requiring* explicit opt in. That would be a softer bump. | 21:11 |
timburke_ | would there be value in me writing that up for tempurl? we haven't had a tagged release since the deprecation/removal-from-defaults landed | 21:12 |
timburke_ | if we *do* do that, how long should we wait before requiring the explicit opt-in? | 21:13 |
acoles | IDK, it feels like a lot of work in lieu of ops not reading upgrade impacts | 21:14 |
kota | ;/ | 21:14 |
timburke_ | meanwhile, i'm pretty sure sha1 was a bad idea (or at least, not a great idea) even when swift was first released :-( | 21:15 |
acoles | hmm | 21:15 |
timburke_ | it's an appeal to authority, but: https://www.schneier.com/essays/archives/2004/08/cryptanalysis_of_md5.html | 21:16 |
timburke_ | as of 2004, "It’s time for us all to migrate away from SHA-1." | 21:16 |
acoles | being contrarian, we could just add the ability to opt *out* of sha1 (if we don't already have that) and leave it to ops to do the right thing??? | 21:17 |
zaitcev | I'm not militant about client first. I think it's sufficient if curl can be used. | 21:18 |
zaitcev | The shift in the defaults thanks to TripleO people being lazy is something that bothers me. | 21:18 |
timburke_ | right -- you'd brought that up in the review, too. i'm not clear on when we *would* feel safe removing it from defaults, though | 21:19 |
timburke_ | idk -- i'll hash it out with clay some more, too. it *does* make me glad that we broke up the formpost changes into a few different patches | 21:21 |
timburke_ | speaking of | 21:21 |
timburke_ | #topic formpost digest algos | 21:21 |
timburke_ | i think i'm happy with https://review.opendev.org/c/openstack/swift/+/838434 now | 21:22 |
timburke_ | the formats of signatures match tempurl, and i cleaned up the tests a little | 21:22 |
timburke_ | i think both mattoliver and i have touched it a lot -- anyone else have some review bandwidth for it? | 21:24 |
timburke_ | otherwise, maybe we'll just get the two of us on board and call it good enough ;-) | 21:25 |
acoles | sorry, I'm not going to be able to help with that for a while | 21:25 |
timburke_ | all right, we'll sort it out -- that first patch in particular is purely additive, so i'm not too worried | 21:27 |
timburke_ | #topic backend ratelimiting | 21:28 |
timburke_ | to my knowledge, we still haven't gotten to doing any load testing with it yet. i still want to see how it actually behaves before merging | 21:29 |
acoles | +1 | 21:29 |
acoles | I've been doing some thinking about how the proxy error limiting is going to react to the 529 responses and I still feel we should be cautious. | 21:30 |
timburke_ | and https://review.opendev.org/c/openstack/swift/+/839088 is the follow-up to have 529 not count for error-limiting | 21:31 |
acoles | It's all about the timescales - error limiting takes a node out for one minute which may be longer than needed after a burst of heavy load on a hotspot device | 21:31 |
acoles | on the other hand, if the hotspot node is in a terrible state, one minute recovery time may be incidental | 21:32 |
acoles | sorry, on that note I need to drop, and I will miss the next couple of meetings (vacation) | 21:34 |
timburke_ | the assumption is that it'll be a more noticeable effect on smaller clusters, yeah? as the number of proxies grows, the chance that a client will get routed to a proxy that's currently error-limiting the hotspot should go down? | 21:34 |
acoles | ^^ yes | 21:34 |
timburke_ | all right -- have a good holiday, acoles! | 21:34 |
acoles | :wave | 21:34 |
acoles | 👋 | 21:34 |
kota | enjoy acoles | 21:34 |
acoles | thank you | 21:35 |
timburke_ | maybe i'll get some load testing done in my saio or home lab while you're out :-D | 21:35 |
timburke_ | #topic s3api test suite | 21:35 |
timburke_ | nothing new to report here; i think it should be ready | 21:36 |
zaitcev | cool | 21:37 |
timburke_ | since it's just adding more tests that already pass, i'm inclined to self-approve if i don't hear anything by, say, next week | 21:37 |
timburke_ | that's all i've got | 21:38 |
timburke_ | #topic open discussion | 21:38 |
timburke_ | anything else we should bring up this week? | 21:38 |
timburke_ | all right, i'm calling it | 21:40 |
zaitcev | Next PTG is in person, I heard. | 21:40 |
timburke_ | thank you all for coming, and thank you for working on swift! | 21:40 |
timburke_ | oh, yes! | 21:40 |
kota | oh really | 21:40 |
timburke_ | in Columbus, OH | 21:40 |
timburke_ | #link https://openinfra.dev/ptg | 21:40 |
timburke_ | Oct 17-20 | 21:41 |
timburke_ | all right, one more time :-) | 21:42 |
timburke_ | thank you all for coming, and thank you for working on swift! | 21:42 |
timburke_ | #endmeeting | 21:42 |
opendevmeet | Meeting ended Wed Jun 8 21:42:13 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:42 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-08-21.00.html | 21:42 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-08-21.00.txt | 21:42 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-08-21.00.log.html | 21:42 |
opendevreview | Tim Burke proposed openstack/swift master: ring: Introduce a v2 ring format https://review.opendev.org/c/openstack/swift/+/834261 | 23:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!