opendevreview | Tim Burke proposed openstack/swift master: tempurl: Deprecate sha1 more softly https://review.opendev.org/c/openstack/swift/+/845862 | 00:23 |
---|---|---|
opendevreview | Matthew Oliver proposed openstack/swift master: Refactor memcache config and MemcacheRing loading https://review.opendev.org/c/openstack/swift/+/820648 | 05:10 |
opendevreview | Matthew Oliver proposed openstack/swift master: Refactored errorlimited out of proxy + global cache https://review.opendev.org/c/openstack/swift/+/820313 | 05:10 |
opendevreview | Matthew Oliver proposed openstack/swift master: Add global error_limiting to object-updater https://review.opendev.org/c/openstack/swift/+/820486 | 05:10 |
opendevreview | Merged openstack/swift master: Clear logger txn_id after making requests https://review.opendev.org/c/openstack/swift/+/507706 | 19:24 |
mattoliver | Morning | 21:03 |
*** timburke_ is now known as timburke | 21:03 | |
timburke | oh right | 21:03 |
timburke | #startmeeting swift | 21:03 |
opendevmeet | Meeting started Wed Jun 15 21:03:34 2022 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:03 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:03 |
opendevmeet | The meeting name has been set to 'swift' | 21:03 |
timburke | who's here for the swift meeting? | 21:03 |
mattoliver | o/ | 21:06 |
kota | hi, i'm late | 21:06 |
mattoliver | acoles is on vacation | 21:06 |
timburke | heh -- i was just about to propose cancelling for lack of interest/new topics ;-) | 21:06 |
timburke | main thing i wanted to bring up was around the sha1 deprecation stuff | 21:07 |
timburke | #topic sha1 deprecation | 21:07 |
mattoliver | Well a short one is OK too :) | 21:07 |
timburke | i'd appreciate some reviews on https://review.opendev.org/c/openstack/python-swiftclient/+/845157 to add support for sha256/sha512 tempurls to the client | 21:07 |
kota | +1 | 21:07 |
timburke | mattoliver, i pushed up some revisions to https://review.opendev.org/c/openstack/swift/+/838434 to add sha256/sha512 support server-side for formpost -- if it looks good to you, let's go ahead and merge it | 21:09 |
timburke | and i took acoles's idea to make the tempurl deprecation a little softer and wrote up https://review.opendev.org/c/openstack/swift/+/845862 | 21:09 |
timburke | basically, the idea is to keep sha1 support by default for now, but warn about it when clients use it | 21:10 |
mattoliver | kk, thanks, I'll loop back to it todat | 21:10 |
mattoliver | *today | 21:11 |
timburke | thanks! | 21:11 |
mattoliver | I did take a quick look the other day and was a great refactor and change, so thanks! | 21:11 |
timburke | to make the tempurl warnings not *so* overwhelming, just log the first time a client uses it per-worker | 21:11 |
timburke | though that could still get to be a lot, depending on how often you reload your proxies | 21:12 |
mattoliver | sure, but better, and if people don't want the noise, stop using sha1 :) | 21:12 |
kota | true | 21:13 |
timburke | you can disable the warning on client usage by explicitly configuring sha1 -- but it'll go back to warning you during process start-up instead | 21:13 |
timburke | i'm still torn about whether it's a good path forward -- we (nvidia) have already had our firedrill about it, so it doesn't buy us anything -- and it puts the eventual dropping of sha1 support that much further off | 21:15 |
timburke | but if we want to slow down the deprecation, now's the time to do it -- and i'd like to tag a release sometime in the next month or so, so... what do we think? should i pursue it further and write up some tests around it? | 21:17 |
mattoliver | at least it is a path, and lack of support in the client probably means its a good idea | 21:17 |
timburke | true -- which reminds me that i ought to go review https://review.opendev.org/c/openstack/python-swiftclient/+/833954 to move formpost to the client ;-) | 21:18 |
timburke | all right, i'll get some tests together | 21:21 |
mattoliver | oh yeah, I should confirm I have base64 support there | 21:21 |
timburke | we could probably rebase it off the tempurl patch and share some code | 21:22 |
timburke | i figured i'd probably do that as part of my review ;-) | 21:23 |
mattoliver | true. whoever gets to it first ;) | 21:23 |
timburke | all right | 21:25 |
timburke | #topic backend ratelimiting | 21:25 |
timburke | mattoliver, did i see you reworked some patches around this? | 21:25 |
mattoliver | Well it was refactoring the error_limiting code, mostly rebasing it. | 21:26 |
mattoliver | seperating the error_limiting into a class where we can configure the count and period was something that has come up again, I think related | 21:27 |
mattoliver | and I already had a patch for that. | 21:28 |
timburke | nice | 21:28 |
timburke | all right -- i think that's all i've got | 21:29 |
timburke | #topic open discussion | 21:29 |
timburke | anything else we ought to bring up this week? | 21:30 |
mattoliver | nope | 21:30 |
timburke | all right -- i'll let you guys get breakfast then ;-) | 21:30 |
timburke | thank you for coming, and thank you for working on swift! | 21:31 |
timburke | #endmeeting | 21:31 |
opendevmeet | Meeting ended Wed Jun 15 21:31:04 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:31 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-15-21.03.html | 21:31 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-15-21.03.txt | 21:31 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-06-15-21.03.log.html | 21:31 |
mattoliver | thanks timburke | 21:31 |
mattoliver | good to see ya kota have a good breakfast :) | 21:31 |
kota | thx, mattoliver! | 21:31 |
clayg | sry, forgot | 21:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!