opendevreview | Matthew Oliver proposed openstack/swift master: sharding: don't replace own_shard_range without an epoch https://review.opendev.org/c/openstack/swift/+/809969 | 05:30 |
---|---|---|
opendevreview | Thomas Goirand proposed openstack/swift master: drive-full-checker https://review.opendev.org/c/openstack/swift/+/907523 | 07:20 |
opendevreview | Thomas Goirand proposed openstack/swift master: drive-full-checker https://review.opendev.org/c/openstack/swift/+/907523 | 07:55 |
zigo | Hi. I'd like to add some tests for the above patch, so I tried creating a temp directory with a xfs loopback file that I'd like to mount, though without root, no way ... | 09:34 |
zigo | Any clue how I can do this? | 09:34 |
zigo | In the context of swift tests, there's already mounted stuff in /srv/node, or what? | 09:35 |
opendevreview | Merged openstack/swift master: tests: Fix float expectations for py312 https://review.opendev.org/c/openstack/swift/+/904601 | 10:16 |
opendevreview | Alistair Coles proposed openstack/swift master: proxy-server: de-duplicate _get_next_response_part method https://review.opendev.org/c/openstack/swift/+/890919 | 12:25 |
opendevreview | Anish Kachinthaya proposed openstack/swift master: added parsing container level grace period through config and container level grace period in expirer, as well as tests https://review.opendev.org/c/openstack/swift/+/907762 | 16:57 |
timburke | zigo, not all unit tests require xfs -- basically, that should only be necessary for the ones that want to write real diskfiles with (sometimes large) xattrs. i'd recommend writing the unit test you want (likely mocking out shutil.disk_usage) and only really going down the xfs-tempdir rabbit hole if it seems like you need to | 17:34 |
timburke | if you *do*, it seems like there might be a way forward with guestmount/libguestfs-xfs? but i've never tried it | 17:34 |
clarkb | I thought the tests we ran did create and mount an xfs filesystem prior to droppign root | 17:40 |
clarkb | ya tools/test-setup.sh should be run by the jobs and in theory is something you can run locally too | 17:42 |
timburke | clarkb, in the gate, yeah -- my read was that zigo wanted to get an xfs tempdir locally so he could run tests, but maybe i'm off base about that | 17:43 |
opendevreview | Clay Gerrard proposed openstack/swift master: test for bad config https://review.opendev.org/c/openstack/swift/+/908206 | 22:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!