| opendevreview | Matthew Oliver proposed openstack/python-swiftclient master: Add formpost subcommand to generate signature https://review.opendev.org/c/openstack/python-swiftclient/+/833954 | 02:51 |
|---|---|---|
| opendevreview | Tim Burke proposed openstack/swift master: stats: Allow emission of labeled metrics https://review.opendev.org/c/openstack/swift/+/896968 | 05:16 |
| opendevreview | Tim Burke proposed openstack/swift master: Move proxy-logging to labeled metrics https://review.opendev.org/c/openstack/swift/+/896969 | 05:16 |
| opendevreview | Matthew Oliver proposed openstack/swift master: SIGUSR2 signals print process info on wsgi servers https://review.opendev.org/c/openstack/swift/+/909637 | 05:23 |
| opendevreview | Matthew Oliver proposed openstack/swift master: SIGUSR2 signals print process info on wsgi servers https://review.opendev.org/c/openstack/swift/+/909637 | 05:29 |
| opendevreview | Thomas Goirand proposed openstack/swift master: drive-full-checker https://review.opendev.org/c/openstack/swift/+/907523 | 10:45 |
| opendevreview | Thomas Goirand proposed openstack/swift master: drive-full-checker https://review.opendev.org/c/openstack/swift/+/907523 | 11:44 |
| opendevreview | Alistair Coles proposed openstack/swift master: diskfile: add test_open_meta_file_unlinked https://review.opendev.org/c/openstack/swift/+/909674 | 14:39 |
| zigo | Is there a problem with the CI's release notes thingy? | 16:06 |
| zigo | https://a2c2b9c0506b0b396571-e07636147bed59ede28bbdb888fbf884.ssl.cf1.rackcdn.com/907523/30/check/build-openstack-releasenotes/11422a7/job-output.txt | 16:06 |
| timburke | zigo, strange -- i know the stable/yoga branch was recently renamed to unmaintained/yoga; seems likely to be fallout from that? https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/V7H6M5ANYOMFWSZ5BJSWAXVNQCUXI6D7/ | 16:16 |
| opendevreview | Clay Gerrard proposed openstack/swift master: test: all primary error limit is error https://review.opendev.org/c/openstack/swift/+/909691 | 16:17 |
| timburke | zigo, for the time being, i'd be content to drop the release note -- i usually put together a patch with all notes for a release anyway | 16:32 |
| opendevreview | Clay Gerrard proposed openstack/swift master: test: all primary error limit is error https://review.opendev.org/c/openstack/swift/+/909691 | 16:32 |
| zigo | timburke: If I remove the release notes, it wont trigger the job?!? | 16:33 |
| zigo | That'd be surprising. | 16:35 |
| timburke | zigo, it only runs if a subset of files gets touched: https://opendev.org/zuul/zuul-jobs/src/commit/f2208ed3c350cbe2ea87a8be932cb36d23f8544b/zuul.d/python-jobs.yaml#L594-L599 | 17:08 |
| timburke | which seems reasonable; nothing should have changed with regard to the built notes (short of some change in reno itself) | 17:09 |
| opendevreview | Tim Burke proposed openstack/python-swiftclient master: lint: Up-rev hacking https://review.opendev.org/c/openstack/python-swiftclient/+/909498 | 17:14 |
| timburke | zigo, actually -- i realized that i missed https://review.opendev.org/c/openstack/swift/+/908433 -- once that merges, the releasenotes job should pass | 18:29 |
| patch-bot | patch 908433 - swift - reno: Update master for unmaintained/yoga - 1 patch set | 18:29 |
| opendevreview | Merged openstack/swift master: Add ClosingIterator class; be more explicit about closes https://review.opendev.org/c/openstack/swift/+/904652 | 18:35 |
| opendevreview | Merged openstack/swift master: reno: Update master for unmaintained/yoga https://review.opendev.org/c/openstack/swift/+/908433 | 18:45 |
| opendevreview | Merged openstack/python-swiftclient master: reno: Update master for unmaintained/yoga https://review.opendev.org/c/openstack/python-swiftclient/+/908431 | 18:45 |
| opendevreview | Tim Burke proposed openstack/python-swiftclient master: CI: constrain deps for tests https://review.opendev.org/c/openstack/python-swiftclient/+/909789 | 18:58 |
| opendevreview | ASHWIN A NAIR proposed openstack/swift master: s3api: return 400 if partNumber and Range sent https://review.opendev.org/c/openstack/swift/+/906906 | 19:15 |
| opendevreview | Merged openstack/swift master: test: all primary error limit is error https://review.opendev.org/c/openstack/swift/+/909691 | 19:52 |
| opendevreview | ASHWIN A NAIR proposed openstack/python-swiftclient master: Support part-num in python swiftClient https://review.opendev.org/c/openstack/python-swiftclient/+/902020 | 20:07 |
| timburke | #startmeeting swift | 21:05 |
| opendevmeet | Meeting started Wed Feb 21 21:05:45 2024 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:05 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:05 |
| opendevmeet | The meeting name has been set to 'swift' | 21:05 |
| timburke | sorry, got distracted working on a patch :-) | 21:05 |
| mattoliver | how dare you :P | 21:06 |
| mattoliver | o/ | 21:06 |
| timburke | #topic releases | 21:06 |
| timburke | it's that time again! i really need to get some new releases proposed soon | 21:07 |
| timburke | i think the deadline for client's technically next week, but iirc they like it if i do it a little earlier | 21:07 |
| timburke | if you've got any more patches to get in this cycle, now's a good time to get them on people's radars! | 21:08 |
| mattoliver | ahh yeah kk. Well we have some python swiftclient patches to land so that's timely ;) | 21:08 |
| mattoliver | This one p 833954 | 21:09 |
| patch-bot | https://review.opendev.org/c/openstack/python-swiftclient/+/833954 - python-swiftclient - Add formpost subcommand to generate signature - 7 patch sets | 21:09 |
| mattoliver | and the up-rev patch so I can run pep on py3.12 | 21:09 |
| mattoliver | p 909498 | 21:10 |
| patch-bot | https://review.opendev.org/c/openstack/python-swiftclient/+/909498 - python-swiftclient - lint: Up-rev hacking - 2 patch sets | 21:10 |
| mattoliver | Thanks for lookin at the last one today timburke | 21:10 |
| timburke | yeah, i was about to thank you for that one -- i think it can definitely get in, and it was handy that it kicked the tires on the build-openstack-releasenotes job | 21:10 |
| timburke | p 848926 might be nice, too -- and we'll see where p 903770 is | 21:11 |
| patch-bot | https://review.opendev.org/c/openstack/python-swiftclient/+/848926 - python-swiftclient - shell: Print friendly account byte quotas - 3 patch sets | 21:11 |
| patch-bot | https://review.opendev.org/c/openstack/python-swiftclient/+/903770 - python-swiftclient - Add transaction id to errors - 5 patch sets | 21:11 |
| timburke | p 909789 might be good, too, though i'd need to investigate the entrypoints issue some more first | 21:12 |
| patch-bot | https://review.opendev.org/c/openstack/python-swiftclient/+/909789 - python-swiftclient - CI: constrain deps for tests - 1 patch set | 21:12 |
| timburke | speaking of cycles turning over, it's also election time, so there's another thing i should be doing but haven't 🙃 | 21:13 |
| mattoliver | lol, timburke for PTL! | 21:14 |
| clayg | timburke: PTL for life! don't quit on us like notmyname 😡 | 21:14 |
| mattoliver | rofl | 21:14 |
| timburke | you two just don't want to find yourselves needing to do it instead ;-) | 21:14 |
| clayg | 💯 | 21:14 |
| mattoliver | that and your great at it!! | 21:15 |
| timburke | a swift release will need to happen fairly soon, too -- so if there's anything you feel strongly about, add it to the priority reviews wiki (which i'll update after the meeting to at least pick up those swiftclient patches) | 21:16 |
| timburke | #link https://wiki.openstack.org/wiki/Swift/PriorityReviews | 21:16 |
| mattoliver | kk | 21:16 |
| timburke | (oh hey -- that still has p 809969 on it! we actually merged something we said we cared about!) | 21:17 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/809969 - swift - sharding: don't replace own_shard_range without an... (MERGED) - 16 patch sets | 21:17 |
| acoles | wait, you mean we accidentally worked on a priority ;-) | 21:17 |
| mattoliver | \o/ the system works.. when we get acoles to fix it :P | 21:17 |
| timburke | ok, i'm glad i'm not the only one feeling punchy this week :-) | 21:18 |
| clayg | 🤣 | 21:18 |
| indianwhocodes | o/ | 21:18 |
| indianwhocodes | https://review.opendev.org/c/openstack/python-swiftclient/+/902020 is on my radar although i don't think it will be ready for the release until i managed to get it all the related part-num patches by next week! | 21:19 |
| patch-bot | patch 902020 - python-swiftclient - Support part-num in python swiftClient - 4 patch sets | 21:19 |
| timburke | aside from that, i don't think i've really got anything new to bring up -- and since we've got so many, how about i just open up the floor for people to bring up more patches for the priority reviews page ;-) | 21:19 |
| timburke | #topic patchfest | 21:20 |
| mattoliver | lol | 21:20 |
| indianwhocodes | we have https://review.opendev.org/c/openstack/swift/+/906906 that could use another pass | 21:20 |
| patch-bot | patch 906906 - swift - s3api: return 400 if partNumber and Range sent - 5 patch sets | 21:20 |
| opendevreview | Alistair Coles proposed openstack/swift master: WIP s3api: add more MPU cross-compat tests https://review.opendev.org/c/openstack/swift/+/907751 | 21:20 |
| mattoliver | oh yeah, I was going to take a look at the partnum chain.. will now that indianwhocodes is back! | 21:21 |
| timburke | acoles, you reminded me that i never posted my attempt at resolving some of those! i should figure out where i put that... | 21:22 |
| mattoliver | timburke: I think we should add your static web tempurl prefix patch. I've +2ed it ;) | 21:22 |
| indianwhocodes | I am still going through the chain, the one that has some unresolved comments that i need to address is this one ref : https://review.opendev.org/c/openstack/swift/+/894580 | 21:22 |
| patch-bot | patch 894580 - swift - s3api: Support GET/HEAD request with ?partNumber - 96 patch sets | 21:22 |
| timburke | p 810754 | 21:22 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/810754 - swift - staticweb: Work with prefix-based tempurls - 14 patch sets | 21:22 |
| mattoliver | thanks, I was looking for it | 21:22 |
| jianjian | looking at this one from acoles, https://review.opendev.org/c/openstack/swift/+/890919 | 21:23 |
| patch-bot | patch 890919 - swift - proxy-server: de-duplicate _get_next_response_part... - 22 patch sets | 21:23 |
| mattoliver | I whipped up a "what about something like this" patch based on our SRE wanting to be able to get the error_limited nodes. Tracing will grab that for them too.. but who knows how long that'll take to land. p 909637 | 21:23 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/909637 - swift - SIGUSR2 signals print process info on wsgi servers - 2 patch sets | 21:23 |
| jianjian | seems I need rebase it first | 21:23 |
| mattoliver | That idea comes from a feature of dd. Which if you send a USR1 or USR2 (I forget which) it'll print the status. That's how you used to have to do it before more modern dd. | 21:24 |
| mattoliver | We could also extend it to dump the dict and get the running work pids settings. | 21:25 |
| indianwhocodes | I want to rebase fix this one before the release next week.p 890919 | 21:25 |
| timburke | p 890919 | 21:25 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/890919 - swift - proxy-server: de-duplicate _get_next_response_part... - 22 patch sets | 21:26 |
| mattoliver | Not married to it.. but was kinda interesting I thought. Tim mentioned maybe a domain socket api.. that could work too :) | 21:26 |
| acoles | jianjian: indianwhocodes : why does this need rebasing https://review.opendev.org/c/openstack/swift/+/890919 ? | 21:26 |
| patch-bot | patch 890919 - swift - proxy-server: de-duplicate _get_next_response_part... - 22 patch sets | 21:26 |
| timburke | oh yeah yeah, jianjian mentioned that one, too :-) | 21:26 |
| indianwhocodes | it has a merge conflict, but it could use reviews too. | 21:27 |
| timburke | i like rebasing -- i could do that instead of writing a nomination email ;-) | 21:27 |
| mattoliver | lol | 21:27 |
| acoles | I don't see any merge conflict | 21:27 |
| indianwhocodes | Am I the only one seeting it, lol ? | 21:28 |
| timburke | :-/ gerrit sees it... | 21:28 |
| acoles | but yes I'd love reviews | 21:28 |
| jianjian | I am seeing it too. | 21:28 |
| indianwhocodes | https://usercontent.irccloud-cdn.com/file/HQqRdTNy/Screenshot%202024-02-21%20at%201.28.21%E2%80%AFPM.png | 21:28 |
| jianjian | doing rebase, conflicts in test/unit/proxy/controllers/test_base.py | 21:28 |
| acoles | ugh yeah, caching :/ | 21:29 |
| jianjian | ++<<<<<<< HEAD | 21:29 |
| jianjian | + factory = CaptureIteratorFactory(handler._iter_parts_from_response) | 21:29 |
| jianjian | + with mock.patch.object(handler, '_find_source', mock_find_source): | 21:29 |
| jianjian | + with mock.patch.object( | 21:29 |
| jianjian | + handler, '_iter_parts_from_response', factory): | 21:29 |
| jianjian | + resp = handler.get_working_response(req) | 21:29 |
| jianjian | + resp.app_iter.close() | 21:29 |
| jianjian | + # verify that iter exited | 21:29 |
| jianjian | + self.assertEqual({1: ['next', '__del__']}, factory.captured_calls) | 21:29 |
| jianjian | ++======= | 21:29 |
| jianjian | + with mock.patch.object(handler, '_find_source', | 21:29 |
| jianjian | + mock_find_source): | 21:29 |
| jianjian | + resp = handler.get_working_response() | 21:29 |
| jianjian | + resp.app_iter.close() | 21:29 |
| jianjian | ++>>>>>>> c06296250 (proxy-server: de-duplicate _get_next_response_part method) | 21:29 |
| indianwhocodes | it is not a biggie | 21:29 |
| indianwhocodes | i believe its just one file | 21:29 |
| acoles | hah, that'll teach me to merge something! I'll get it sorted | 21:29 |
| mattoliver | oh hey I had draft comments on that.. that probably means I started reviewing it at some point.. will do that again.. and maybe reply this time : P | 21:30 |
| indianwhocodes | https://review.opendev.org/q/has:draft | 21:31 |
| opendevreview | Tim Burke proposed openstack/swift master: proxy-server: de-duplicate _get_next_response_part method https://review.opendev.org/c/openstack/swift/+/890919 | 21:31 |
| indianwhocodes | tim taught me that ^ | 21:31 |
| mattoliver | yeah, or I can just be surprised by past me on occasion :P | 21:31 |
| mattoliver | thanks | 21:31 |
| timburke | 😳 mine goes on for more than one page... | 21:31 |
| indianwhocodes | 😭 | 21:32 |
| mattoliver | oh mine too | 21:32 |
| mattoliver | bugger | 21:32 |
| mattoliver | but some are 6 years old.. better hit review on those :P | 21:32 |
| mattoliver | woah oldest is 9 years old.. bad Matt! | 21:33 |
| clayg | i have a lot of draft comments on patches that are *merged* 🤷♂️ | 21:33 |
| jianjian | Tim fixed merge conflict, nice! | 21:33 |
| mattoliver | yeah me too | 21:33 |
| jianjian | I had one too :-) | 21:33 |
| mattoliver | maybe something like: https://review.opendev.org/q/has:draft+status:open but my gerrit-fu isn't as good as tims | 21:34 |
| timburke | seemed pretty good to me :-) | 21:36 |
| indianwhocodes | p 836755 | 21:37 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/836755 - swift - Add support of Sigv4-streaming - 9 patch sets | 21:37 |
| mattoliver | turns out status:open covers merge conflict etc, so yeah seems to work. | 21:37 |
| indianwhocodes | Tim, I know you took over and its messy code | 21:37 |
| mattoliver | Oh yeah I looked. So are we taking it over then? | 21:37 |
| timburke | yeah, i'm still playing with that -- indianwhocodes, if you get a chance, maybe try warp against p 908953 | 21:38 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/908953 - swift - Get basic write support for mountpoint-s3 - 2 patch sets | 21:38 |
| indianwhocodes | noted. | 21:38 |
| opendevreview | Alistair Coles proposed openstack/swift master: proxy: don't use recoverable_node_timeout with x-newest https://review.opendev.org/c/openstack/swift/+/908287 | 21:39 |
| mattoliver | Seeing as we have other swift users submitting cool tools like p 907523 is it something we should try and review and get in too? | 21:39 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/907523 - swift - drive-full-checker - 30 patch sets | 21:39 |
| mattoliver | maybe I'll poke our SRE for them to take a look too. although our controller probably does similar things | 21:40 |
| timburke | my plan for aws-chunked (currently) looks like p 909049, then "add support for additional checksum", then squash together the two patches for aws-chunked | 21:40 |
| patch-bot | https://review.opendev.org/c/openstack/swift/+/909049 - swift - s3api: Improve checksum-mismatch detection - 1 patch set | 21:40 |
| mattoliver | kk | 21:40 |
| timburke | but i owe patchsets for all that work (when i said i got distracted, that was what i was working on :-) | 21:40 |
| mattoliver | well that's a good distraction and your definitely forgiven :) | 21:41 |
| indianwhocodes | and you got labeled metrics as well, phew | 21:41 |
| timburke | i'd very much like to get the fullness checker in for this release -- it's a useful tool that people shouldn't need to reinvent everywhere | 21:42 |
| mattoliver | +1 | 21:45 |
| indianwhocodes | dum question but do you think we might need a doc in there ? | 21:45 |
| acoles | I need to drop, bye y'all :wave | 21:45 |
| timburke | we could always use more docs ;-) | 21:45 |
| timburke | acoles, o/ | 21:45 |
| acoles | 👋 | 21:46 |
| jianjian | bye | 21:46 |
| timburke | indianwhocodes, whether we should hold off on merging until there are docs kinda depends on the patch -- i generally err toward getting code out there, even if its under-documented, and if i feel like docs are *so* important that we *do* need them, take a stab at writing them myself | 21:47 |
| mattoliver | ok big questoin.. if we're going to have a new swift release soon... should we make it the last one with py2 ;) | 21:49 |
| mattoliver | maybe too big as question for 10mins left of meeting | 21:49 |
| timburke | mattoliver, i'd love to! just as soon as i no longer have py2 code wanting to import it ;-) | 21:49 |
| mattoliver | I know.. just hoping we're getting close enough | 21:49 |
| timburke | we've already *technically* dropped support for py2 for a while -- those poor fools still relying on py2 CI are on their own ;-) | 21:50 |
| mattoliver | and maybe light a fire under ourselves | 21:50 |
| timburke | all right, i think we've got most of the patches out -- i think i'll call it (and get on with updating the priority reviews) | 21:54 |
| indianwhocodes | I had a minor suggestion for the channel head maybe we can interchange positions for priority reviews with logs, since i feel that takes precedence ? | 21:54 |
| timburke | good idea! i'll see whether i can update the topic... | 21:55 |
| timburke | thank you all for coming, and thank you for working on swift! | 21:56 |
| timburke | #endmeeting | 21:56 |
| opendevmeet | Meeting ended Wed Feb 21 21:56:07 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:56 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2024/swift.2024-02-21-21.05.html | 21:56 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2024/swift.2024-02-21-21.05.txt | 21:56 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2024/swift.2024-02-21-21.05.log.html | 21:56 |
| indianwhocodes | thanks! | 21:56 |
| timburke | https://wiki.openstack.org/wiki/Swift/PriorityReviews updated! | 22:02 |
| timburke | indianwhocodes, doesn't look like i can change it: "#openstack-swift :You're not channel operator" and attempting to op: "You do not have access to the OP command on channel #openstack-swift" | 22:13 |
| timburke | i could probably get someone else to change it, or give me permissions to op... but i'm not sure it's worth the effort | 22:15 |
| clarkb | timburke: https://opendev.org/openstack/project-config/src/branch/master/accessbot/channels.yaml#L264 you'd edit this file entry to add you to a new ops listing for this channel (there are examples in the file) | 22:44 |
| opendevreview | Thomas Goirand proposed openstack/swift master: drive-full-checker https://review.opendev.org/c/openstack/swift/+/907523 | 22:47 |
| opendevreview | Tim Burke proposed openstack/swift master: s3api: Refactor how we handle expected errors https://review.opendev.org/c/openstack/swift/+/751555 | 23:02 |
| opendevreview | Anish Kachinthaya proposed openstack/swift master: add enable open expired in proxy config https://review.opendev.org/c/openstack/swift/+/907774 | 23:27 |
| opendevreview | Tim Burke proposed openstack/swift master: s3api: Improve checksum-mismatch detection https://review.opendev.org/c/openstack/swift/+/909049 | 23:33 |
| opendevreview | Tim Burke proposed openstack/swift master: utils: Add crc32c function https://review.opendev.org/c/openstack/swift/+/909800 | 23:33 |
| opendevreview | Tim Burke proposed openstack/swift master: s3api: Add support for additional checksums https://review.opendev.org/c/openstack/swift/+/909801 | 23:33 |
| opendevreview | Tim Burke proposed openstack/swift master: WIP: s3api: Additional checksums for MPUs https://review.opendev.org/c/openstack/swift/+/909802 | 23:33 |
| timburke | still pretty rough/ugly, but that's ^^^ what i'm thinking of putting in front of the aws-chunked stuff... | 23:34 |
| timburke | i still need to see what they do to listings on for-realsy S3, but i think the approach is mostly solid -- needing to touch the encrypter was a little unfortunate, though, and i still need to get some slo changes so it can validate segment checksums... and there's a whole host of error cases to investigate | 23:36 |
| opendevreview | Anish Kachinthaya proposed openstack/swift master: add enable open expired in proxy config https://review.opendev.org/c/openstack/swift/+/907774 | 23:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
