boosungkim[m] | Ah, I did come across the stacklevel after doing a bit of research, and it seems like that will make the tests pass. Would importing the new library in the file be okay? | 00:49 |
---|---|---|
boosungkim[m] | Wasn't sure what the procedure is to import libraries in existing files | 01:05 |
opendevreview | Yan Xiao proposed openstack/swift master: Object-server: add http exception handling for object request timing stats https://review.opendev.org/c/openstack/swift/+/949348 | 13:58 |
opendevreview | Ivan Anfimov proposed openstack/swift master: Remove unused MANIFEST.in https://review.opendev.org/c/openstack/swift/+/949368 | 14:53 |
opendevreview | Ivan Anfimov proposed openstack/swift master: Remove unused MANIFEST.in https://review.opendev.org/c/openstack/swift/+/949368 | 14:54 |
timburke | boosungkim[m], yeah, import as needed! adding an import isn't a problem (as long as it doesn't create a problematic import loop) -- adding a new *dependency* should be done with care and thought, though. but since warnings comes from stdlib, it's already available! | 16:26 |
opendevreview | Jianjian Huo proposed openstack/swift master: common: add memcached based cooperative token mechanism. https://review.opendev.org/c/openstack/swift/+/890174 | 16:30 |
opendevreview | Jianjian Huo proposed openstack/swift master: proxy: use cooperative tokens to coalesce updating shard range requests into backend https://review.opendev.org/c/openstack/swift/+/908969 | 16:30 |
opendevreview | Jianjian Huo proposed openstack/swift master: proxy: use cooperative tokens to coalesce updating shard range requests into backend https://review.opendev.org/c/openstack/swift/+/908969 | 16:37 |
opendevreview | Merged openstack/swift master: Remove unused MANIFEST.in https://review.opendev.org/c/openstack/swift/+/949368 | 17:52 |
opendevreview | Merged openstack/swift master: Implement heartbeat response for COPY request https://review.opendev.org/c/openstack/swift/+/940762 | 17:52 |
opendevreview | Jianjian Huo proposed openstack/swift master: common: add memcached based cooperative token mechanism. https://review.opendev.org/c/openstack/swift/+/890174 | 19:17 |
opendevreview | Jianjian Huo proposed openstack/swift master: proxy: use cooperative tokens to coalesce updating shard range requests into backend https://review.opendev.org/c/openstack/swift/+/908969 | 19:23 |
boosungkim[m] | timburke: Alright, good to know! I'll push the patch soon with that solution then. Thank you! | 20:49 |
opendevreview | Jianjian Huo proposed openstack/swift master: common: add memcached based cooperative token mechanism. https://review.opendev.org/c/openstack/swift/+/890174 | 23:30 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!