opendevreview | Tim Burke proposed openstack/swift master: ringv2: Use dataclasses https://review.opendev.org/c/openstack/swift/+/951049 | 00:57 |
---|---|---|
opendevreview | Tim Burke proposed openstack/swift master: ringv2: Use dataclasses https://review.opendev.org/c/openstack/swift/+/951049 | 03:25 |
timburke_ | mattoliver, see what you think of ^^^ -- i might squash it in | 03:27 |
opendevreview | Alistair Coles proposed openstack/swift feature/mpu: WIP object_versioning: make is_enabled tri-state https://review.opendev.org/c/openstack/swift/+/951108 | 09:50 |
opendevreview | Shreeya Deshpande proposed openstack/swift master: proxy-logging: Add real-time transfer bytes counters https://review.opendev.org/c/openstack/swift/+/930918 | 15:21 |
DHE | well, I can confirm ZFS works... xattrs and all. | 16:39 |
opendevreview | Merged openstack/swift master: Add config option for whether to skip s3_acl-requiring tests https://review.opendev.org/c/openstack/swift/+/949716 | 18:05 |
opendevreview | Merged openstack/swift master: CI: run S3 cross-compat tests as part of DSVM jobs https://review.opendev.org/c/openstack/swift/+/942133 | 18:05 |
*** timburke_ is now known as timburke | 20:59 | |
timburke | #startmeeting swift | 21:00 |
opendevmeet | Meeting started Wed May 28 21:00:11 2025 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
opendevmeet | The meeting name has been set to 'swift' | 21:00 |
timburke | who's here for the swift meeting? | 21:00 |
mattoliver | o/ | 21:00 |
timburke | i don't have too many topics, mostly just follow-up from a couple weeks ago | 21:02 |
timburke | as usual, the agenda's at | 21:02 |
timburke | #link https://wiki.openstack.org/wiki/Meetings/Swift | 21:02 |
timburke | first up | 21:02 |
timburke | #topic aws-chunked and additional checksums | 21:03 |
jianjian | o/ | 21:03 |
timburke | we still need to review & merge checksum validation | 21:03 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/944073 | 21:03 |
timburke | but it's been going well since we carried it in prod | 21:04 |
timburke | we've even seen clients trying to use crc64nvme, so i'm glad we had that follow-on ready to go | 21:04 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/946141 | 21:04 |
jianjian | -88 +2061, wow, quite a large patch | 21:04 |
acoles | o/ | 21:05 |
mattoliver | oh nice, if people use it let's look at getting that landed too! | 21:05 |
timburke | decent majority of it should be in test coverage, though, so that's good | 21:05 |
acoles | are we still waiting for a py version bump to land the checksum validation? something to do with up-reving boto3 for tests?? | 21:05 |
timburke | nope -- i decided to just split the test expectations based on version of boto3 available | 21:06 |
acoles | ok | 21:06 |
acoles | I'll try to revisit that review then | 21:06 |
timburke | fwiw, i think that was only needed in test_different_checksum_requested | 21:07 |
timburke | there's also a follow-up for s3token to ensure that aws-chunked works even when the secret key didn't come out of cache | 21:08 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/949671 | 21:08 |
timburke | ...which would be nice to have before our next upstream release (not that i'm in a rush for that, but good to mention early) | 21:09 |
timburke | next up | 21:10 |
timburke | #topic swiftclient release | 21:10 |
timburke | we had one! 4.8.0 is out and available | 21:10 |
timburke | it also dropped support for py36, so we're (slowly) getting closer to openstack's support matrix ;-) | 21:12 |
mattoliver | \o/ | 21:12 |
jianjian | great! | 21:12 |
timburke | sorry we didn't get more landed (i know there was some hope of getting retries for bytes literals merged) | 21:13 |
timburke | #link https://review.opendev.org/c/openstack/python-swiftclient/+/918701 | 21:13 |
timburke | but there's always more releases we can make! | 21:13 |
jianjian | 🙂 will wait for next release then | 21:13 |
timburke | next up | 21:14 |
timburke | #topic conditional PUTs for s3api | 21:14 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/949680 | 21:14 |
timburke | it merged! thanks for your help, jianjian! | 21:14 |
jianjian | \o/ | 21:15 |
timburke | we've got it out in prod, and our preliminary testing shows it working as we'd hoped | 21:15 |
mattoliver | nice work timburke and jianjian | 21:16 |
timburke | (in particular, we had a user interested in lancedb using swift's s3api as a backend, and jianjian's manual testing showed it working -- still waiting to here back from our users) | 21:16 |
timburke | #link https://github.com/lancedb/ | 21:16 |
jianjian | yep, also the s3api support of if-none-match: * works well with aws cli and boto3 SDK as well | 21:17 |
timburke | all right, last topic from me | 21:18 |
timburke | #topic MANIFEST.in removal | 21:18 |
timburke | i merged a change a bit ago because it seemed like this really wasn't necessary anymore | 21:18 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/949368 | 21:18 |
timburke | i built wheels before and after the patch, and everything seemed right | 21:19 |
timburke | but the next time we went to build RPMs for our internal release, they were missing the xml schema files used by s3api! | 21:20 |
mattoliver | yeah, it seems this is still the way to tell setuptools to include extra files | 21:20 |
timburke | as a result, s3api requests that included xml bodies would all fail (multi-deleted, mpu-completions, probably others) | 21:20 |
timburke | i proposed a revert for it | 21:21 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/950615 | 21:21 |
timburke | but i still haven't pinned down where things went wrong -- my assumption is that our build process's old versions of pbr and setuptools were to blame | 21:22 |
mattoliver | I've managed to fix it downstream in our rpm build but specificalyy including them. But that might not help others. So unless there is another way to specify extra files in setuptools we might need to put that back | 21:23 |
timburke | and now that we can actually declare minimum versions of those in pyproject.toml, i think i might prefer to just make sure those minimums are right and keep the MANIFEST.in out | 21:23 |
opendevreview | Yan Xiao proposed openstack/swift master: Object-server: change labeled timing metrics sample rate for debugging requests https://review.opendev.org/c/openstack/swift/+/951042 | 21:23 |
timburke | mattoliver, did you explicitly add the files in our spec file, or did you try updating pbr/setuptools? i think clayg tried the latter approach, but ran into other issues because of our old python(/OS?) :-/ | 21:24 |
mattoliver | oh good thinking. Maybe need to play with pbr and setuptools versions then an find the culprit if its just a version then. | 21:24 |
mattoliver | I just added the files, I mean the spec already explicitly grabs the man files etc | 21:25 |
timburke | yeah, i figured i ought to start with trying to build with our lower-bounds, as they're pretty reasonable: https://github.com/openstack/swift/blob/master/pyproject.toml#L2 | 21:27 |
timburke | released in '22 and '23 | 21:27 |
clayg | yeah, our .spec for setuptools ~41 expected some bootstrap.py script that doesn't exist ~64 | 21:27 |
timburke | so i'll plan to try that out in the next day or two and post results in a comment on the revert | 21:28 |
mattoliver | kk sounds like a plan | 21:28 |
mattoliver | clayg: oh great. So setuptools spec needs a bunch of updating then. | 21:29 |
timburke | but i wanted to make sure to bring it up in case cschwede_ or anyone else bumps into a similar issue. if it's more than just us, i'm a lot more inclined to merge the revert | 21:29 |
mattoliver | maybe it's already done in the 3.10 branch | 21:29 |
timburke | i think it might be | 21:30 |
timburke | all right, that's all i've got | 21:30 |
timburke | #topic open discussion | 21:30 |
timburke | anything else we ought to talk about this week? | 21:30 |
acoles | just an fyi, I''m ramping back up on feature/mpu work | 21:30 |
mattoliver | nice | 21:31 |
acoles | picking up where I left off, and pursuing a new approach to reliably detecting obsolete MPUs for orphan cleanup | 21:31 |
mattoliver | I've been a bit distracted with some downstream work, but I looked at the dataclass ringv2 patch tho. Nice we can start using more modern python concepts (even if its from 3.7) :P | 21:32 |
mattoliver | I want to finally push up a rebase of the tracing chain.. otherwise it'll get harder and harder as time goes on. Hopefullly get back to this sooner rather then later. | 21:33 |
mattoliver | mostly got it ready, just need to test it in vsaio to make sure everything is working | 21:34 |
timburke | oh yeah, i should take a look at https://github.com/NVIDIA/vagrant-swift-all-in-one/pull/134 ... | 21:36 |
mattoliver | woah 2022... really should land this one day, maybe this year will be there year :P | 21:38 |
mattoliver | that vsaio probably needs a rebase too | 21:38 |
mattoliver | anyway, that's all I've got | 21:38 |
mattoliver | oh I did remember the meeting last week too, which was nice :P | 21:39 |
timburke | 🎉 | 21:39 |
timburke | thanks again for leading that meeting slot | 21:40 |
timburke | all right, i think i'll call it early then | 21:41 |
timburke | thank you all for coming, and thank you for working on swift! | 21:41 |
timburke | #endmeeting | 21:42 |
opendevmeet | Meeting ended Wed May 28 21:42:02 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:42 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2025/swift.2025-05-28-21.00.html | 21:42 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2025/swift.2025-05-28-21.00.txt | 21:42 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2025/swift.2025-05-28-21.00.log.html | 21:42 |
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org is temporarily unreachable due to an ongoing issue in the hosting provider where it resides | 22:08 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!