Callum027 | timburke__: Regarding 898783, was the only reason why it wasn't merged essentially due to the lack of necessity for it, or was there some technical reason why it couldn't be merged at the time? | 00:38 |
---|---|---|
opendevreview | Matthew Oliver proposed openstack/swift master: ring: Add a rebalance history in the ring https://review.opendev.org/c/openstack/swift/+/834621 | 07:11 |
opendevreview | Matthew Oliver proposed openstack/swift master: ringbuilder cli: add set_history_count command https://review.opendev.org/c/openstack/swift/+/955452 | 07:11 |
opendevreview | Merged openstack/swift master: Drop support for old pickled rings https://review.opendev.org/c/openstack/swift/+/953497 | 09:23 |
opendevreview | Vitaly Bordyug proposed openstack/swift master: proxy-logging: create new field for s3_access_key_id https://review.opendev.org/c/openstack/swift/+/955225 | 14:12 |
opendevreview | Vitaly Bordyug proposed openstack/swift master: proxy-logging: create new field for s3_access_key_id https://review.opendev.org/c/openstack/swift/+/955225 | 14:56 |
*** timburke__ is now known as timburke | 17:02 | |
timburke | Callum027, i think we just got distracted from https://review.opendev.org/c/openstack/swift/+/898783 -- i'd done that without knowing about the demonstrable harm in https://bugs.launchpad.net/swift/+bug/2117241 | 17:06 |
opendevreview | Vitaly Bordyug proposed openstack/swift master: proxy-logging: create new field for s3_access_key_id https://review.opendev.org/c/openstack/swift/+/955225 | 18:16 |
opendevreview | Tim Burke proposed openstack/swift master: ring: Introduce a v2 ring format https://review.opendev.org/c/openstack/swift/+/834261 | 18:37 |
opendevreview | Tim Burke proposed openstack/swift master: object: Return storage policy in headers https://review.opendev.org/c/openstack/swift/+/898783 | 18:40 |
opendevreview | Tim Burke proposed openstack/swift master: proxy: Move object storage policy to expected header https://review.opendev.org/c/openstack/swift/+/898784 | 18:49 |
Callum027 | timburke: Thanks, I see that you've updated both 898783 and 898784, would these need to be deployed together? Also, do they also handle setting {policy_index} for container-level requests as well (doesn't look like it looking at the code)? I don't need it for *my* use case but I was trying to cover that with my patch as well | 20:50 |
timburke | Callum027, yeah, i think we'd need both patches to address the logging trouble you identified, since there's nothing in proxy-logging to go looking at X-Backend-Object-Storage-Policy-Index (though that's maybe the direction clayg wanted to go in https://review.opendev.org/c/openstack/swift/+/901194 ?) | 22:08 |
timburke | i'll see if i can get some interest from clayg (or maybe mattoliver? he's always good for a nerd-snipe ;-) to review | 22:08 |
timburke | we probably still want some changes in staticweb for the generated listing pages; while the container server should always be sending back the x-backend-storage-policy-index header, it's not getting transferred there | 22:10 |
timburke | i should get some tests on that second patch, though... | 22:10 |
opendevreview | Merged openstack/swift stable/2024.1: CI: make sure old swift is truly gone for rolling-upgrade jobs https://review.opendev.org/c/openstack/swift/+/954849 | 22:39 |
Callum027 | timeburke: Sounds good, if you'd like me to change my patch to provide the missing pieces for staticweb I can do that | 22:42 |
opendevreview | Merged openstack/swift stable/2024.1: [stable-only] Fix rolling-upgrade jobs https://review.opendev.org/c/openstack/swift/+/954830 | 22:45 |
opendevreview | Jianjian Huo proposed openstack/swift master: Object: log breakdown timings for slow DELETE requests. https://review.opendev.org/c/openstack/swift/+/951219 | 23:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!