| *** tetsuro has joined #openstack-tc | 00:10 | |
| *** cloudnull has quit IRC | 02:13 | |
| *** cloudnull has joined #openstack-tc | 02:13 | |
| *** cloudnull6 has joined #openstack-tc | 02:34 | |
| *** cloudnull has quit IRC | 02:35 | |
| *** cloudnull6 is now known as cloudnull | 02:35 | |
| *** ricolin_ has joined #openstack-tc | 03:00 | |
| openstackgerrit | zhangboye proposed openstack/governance master: migrate testing to ubuntu focal https://review.opendev.org/740851 | 03:03 |
|---|---|---|
| *** tetsuro has quit IRC | 03:04 | |
| *** iurygregory has quit IRC | 03:54 | |
| *** TheJulia has quit IRC | 03:54 | |
| *** TheJulia has joined #openstack-tc | 03:55 | |
| *** tetsuro has joined #openstack-tc | 04:22 | |
| *** tetsuro_ has joined #openstack-tc | 04:26 | |
| *** tetsuro has quit IRC | 04:27 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-tc | 04:33 | |
| *** tetsuro_ has quit IRC | 04:41 | |
| *** tetsuro has joined #openstack-tc | 04:46 | |
| *** tetsuro has quit IRC | 04:58 | |
| *** dklyle has quit IRC | 06:39 | |
| *** iurygregory_ has joined #openstack-tc | 07:10 | |
| *** iurygregory_ is now known as iurygregory | 07:31 | |
| *** ralonsoh has joined #openstack-tc | 07:31 | |
| *** tosky has joined #openstack-tc | 07:37 | |
| *** e0ne has joined #openstack-tc | 08:01 | |
| ttx | tc-members, mnaser: reminder that we have a community newsletter going out this week, so if you have any OpenStack news to suggest, please add to https://etherpad.opendev.org/p/newsletter-openstack-news | 08:44 |
| openstackgerrit | Luigi Toscano proposed openstack/project-team-guide master: Import the Zuul v3 porting guide https://review.opendev.org/740727 | 08:46 |
| *** camelCaser has quit IRC | 09:15 | |
| *** camelCaser has joined #openstack-tc | 09:17 | |
| *** frickler is now known as frickler_pto | 09:44 | |
| *** frickler_pto is now known as frickler | 09:47 | |
| *** tkajinam has quit IRC | 10:12 | |
| *** ShadowJonathan has quit IRC | 10:22 | |
| *** gouthamr has quit IRC | 10:22 | |
| *** ShadowJonathan has joined #openstack-tc | 10:22 | |
| *** gouthamr has joined #openstack-tc | 10:23 | |
| *** Jeffrey4l has quit IRC | 10:23 | |
| *** Jeffrey4l has joined #openstack-tc | 10:24 | |
| openstackgerrit | Luigi Toscano proposed openstack/project-team-guide master: Import the Zuul v3 porting guide https://review.opendev.org/740727 | 11:26 |
| *** iurygregory has quit IRC | 11:46 | |
| *** iurygregory has joined #openstack-tc | 12:00 | |
| *** ijolliffe has joined #openstack-tc | 12:25 | |
| *** Luzi has joined #openstack-tc | 12:55 | |
| *** Luzi has quit IRC | 13:29 | |
| *** Luzi has joined #openstack-tc | 13:45 | |
| *** ralonsoh has quit IRC | 13:49 | |
| *** frickler is now known as frickler_pto | 13:50 | |
| *** ralonsoh has joined #openstack-tc | 14:00 | |
| knikolla | o/ | 14:04 |
| jungleboyj | o/ | 14:04 |
| njohnston | o/ | 14:08 |
| *** Luzi has quit IRC | 14:18 | |
| gmann | o/ | 14:21 |
| gmann | ttx: addedabout tc-uc merge and new uc charter | 14:24 |
| gmann | *added tc-uc merge and new uc charter | 14:24 |
| gmann | not sure if we mentioned that in last newsletter if so, then we can skip. other than that nothing else i can remember to add than existing items | 14:25 |
| *** dklyle has joined #openstack-tc | 14:34 | |
| *** johnthetubaguy has quit IRC | 14:50 | |
| ShadowJonathan | gmann: i'm currently all set-up to start working on the drafts, do you think it's alright if i submit them under branches 'draft/{nebula,dew,aurora}', and under rst files 'doc/source/ideas/{nebula,dew,aurora}.rst'? | 14:51 |
| *** johnthetubaguy has joined #openstack-tc | 14:52 | |
| gmann | ShadowJonathan: i was thinking all three as separate rst file as they are three different ideas? | 14:52 |
| gmann | or you mean separate rst only? | 14:52 |
| ShadowJonathan | yeah, that's my plan, but that i submit all 3 induvidually under a 'draft/` branch, and as a single file each (for now) in 'doc/source/ideas/' | 14:53 |
| ShadowJonathan | individually* | 14:53 |
| smcginnis | ShadowJonathan: Under Gerrit, that would be three different topics. | 14:53 |
| smcginnis | Better to have them separately in a local branch so none of them are dependent on the other patch landing. | 14:54 |
| ShadowJonathan | that'd be perfect, as i would want to discuss them as separate ideas | 14:54 |
| ShadowJonathan | no, i'm going to submit them as induvidual branches, no worries about that | 14:54 |
| gmann | ShadowJonathan: yeah, under this is fine 'doc/source/ideas/' we will merge it once it is complete i mean no draft dir etc required | 14:55 |
| ShadowJonathan | if git-review just submits the latest commits under the currently-selected branch since a `master` commit, then it'll be alright | 14:55 |
| ShadowJonathan | yeah, that's what i realised as well, no draft dir needed if the branch will already be tagged as that | 14:56 |
| smcginnis | Yep, so as long as you don't stack you commits on top of each other, they are submitted as separate independent reviews. | 14:56 |
| ShadowJonathan | yup | 14:56 |
| smcginnis | So it can all be in one branch, even master, as long as you "git reset --hard HEAD~1" between each one. The local branching is just a convenient way for them to be submitted under different topics. | 14:56 |
| ShadowJonathan | that's basically stepping back one commit, right? | 14:57 |
| ShadowJonathan | why not `git reset --hard master`? much more reliable and doesnt depend on relative commits | 14:58 |
| mnaser | two ways of saying the same thing :) | 14:59 |
| mnaser | except smcginnis way doesn't depend on having a specific remote | 15:00 |
| ShadowJonathan | yeah, but i'm not gonna delete local commits, i'll be placing them in seperate branches, so i'll still keep track of them | 15:00 |
| mnaser | you would need to add origin/master or gerrit/master depending on what you remote is | 15:00 |
| ShadowJonathan | iirc `git reset --hard` just removes them | 15:00 |
| ShadowJonathan | seperate local* branches | 15:00 |
| ShadowJonathan | "Resets the index and working tree. Any changes to tracked files in the working tree since <commit> are discarded." | 15:02 |
| ShadowJonathan | it removes local files, which is something i especially wouldn't want, as commits are actually inscribed (and hopefully the only thing that git-review looks at), and local workspace can be as cluttered as you want, but it'd only be cumbersome if it merges upon checkout | 15:02 |
| mnaser | right, you'd run that after committing and running git review | 15:03 |
| mnaser | the commit still exists locally | 15:03 |
| fungi | git-review will want to perform a test rebase to make sure the change isn't in merge conflict with the target branch, so it'll tell you to stash uncommitted changes first | 15:03 |
| ShadowJonathan | i'd need local files like `venv/` and `.idea/` and soforth because they're not specified in the .gitignore file, so those will be 'seen' by git | 15:04 |
| ShadowJonathan | hmmmm | 15:04 |
| ShadowJonathan | fungi: thanks for telling me that, i'll stash some stuff then | 15:04 |
| fungi | i believe it will be fine if there are untracked files though | 15:04 |
| fungi | just a problem if you have a diff to any tracked files which hasn't been committed | 15:04 |
| *** cloudnull6 has joined #openstack-tc | 15:44 | |
| *** cloudnull has quit IRC | 15:46 | |
| *** cloudnull6 is now known as cloudnull | 15:46 | |
| ShadowJonathan | oof, this is going to be a relatively opinionated piece | 16:05 |
| fungi | opinions are good | 16:05 |
| ShadowJonathan | I'm currently writing the Dew draft, I didn't realise how much of it was biased views instead of some more logical proposals to observations | 16:06 |
| ShadowJonathan | Aurora is probably going to be somewhat the same, they both have a need to "tell a story" first before making a case | 16:09 |
| mnaser | ShadowJonathan: sending a review doesn't necessarily mean it's baked and read, it could very much be an rfc | 16:20 |
| ShadowJonathan | i know, i'm just commenting on the fact how differently this draft is turning out for me right now | 16:21 |
| *** e0ne has quit IRC | 16:38 | |
| openstackgerrit | Jonathan de Jong proposed openstack/ideas master: First (rough) draft for Dew project [RFC] https://review.opendev.org/741005 | 16:51 |
| ShadowJonathan | there we go | 16:51 |
| ShadowJonathan | wait, master? | 16:51 |
| *** njohnston is now known as njohnston|lunch | 16:58 | |
| ShadowJonathan | eh, i think this is already a foot in the door, i'll be finishing the other two before making sending an RFC to the mailing list | 16:59 |
| openstackgerrit | Jonathan de Jong proposed openstack/ideas master: First (rough) draft for Dew project [RFC] https://review.opendev.org/741008 | 17:05 |
| *** ijolliffe has quit IRC | 17:06 | |
| knikolla | that created two reviews, please abandon one of them. | 17:07 |
| ShadowJonathan | just did that with the first | 17:07 |
| ShadowJonathan | i didn't know how to add an additional commit, and i thought the wiki said to squash both commits into a completely new one, but apparently i don't understand how to do such a thing properly, sorry about that | 17:08 |
| fungi | if you want to revise an existing review, commit --amend to the original. gerrit keeps the history of the prior revisions for you | 17:09 |
| fungi | not sure what wiki you're talking about, but the general workflow is documented in the opendev manual: https://docs.opendev.org/opendev/infra-manual/latest/gettingstarted.html#updating-a-change | 17:10 |
| ShadowJonathan | yeah i looked over there, but i wasn't reading it correctly | 17:10 |
| fungi | under the hood, gerrit looks at the change-id footer in each commit message to determine whether it's a revision of a change it already has or a new change | 17:11 |
| ShadowJonathan | ah | 17:11 |
| fungi | if there's already a change for that target project and branch with the same change-id then it creates a new revision of that change. if there is no prior occurrence of that change-id for the target project and branch, gerrit creates an entirely new change | 17:11 |
| fungi | a git commit-hook runs when you originally commit to generate a random change-id if none is not already present, and appends it when you save the commit message | 17:12 |
| ShadowJonathan | alright, thanks about that | 17:15 |
| ShadowJonathan | sorry* about that | 17:16 |
| fungi | no worries. how gerrit works can take a bit of getting used to, unless you happen to be a linux kernel developer (gerrit is basically an attempt at automating the lkml patch review workflow) | 17:17 |
| ShadowJonathan | Yeah, I'm more used to the GitHub flow of contribution (fork-commit-PR-(discuss-commit)-squash-merge), so this might take a moment or two to get used to | 17:39 |
| *** ralonsoh has quit IRC | 17:57 | |
| *** ricolin_ has quit IRC | 18:41 | |
| *** njohnston|lunch is now known as njohnston | 18:41 | |
| *** slaweq has joined #openstack-tc | 18:54 | |
| *** slaweq has quit IRC | 18:56 | |
| openstackgerrit | Jonathan de Jong proposed openstack/ideas master: First (rough) draft for Dew project [RFC] https://review.opendev.org/741008 | 19:37 |
| ShadowJonathan | heck yeah, got the amend option working correctly | 19:38 |
| ShadowJonathan | fungi: thanks for telling me about it being identified by `Change-Id`, as `git commit --amend` did not seem to pick up my additional changes, so i just reset and recommitted with the right files, but with the same change-id header | 19:39 |
| fungi | yeah, it would either be `git commit -a --amend` or `git commit --amend some/file another/file that/third/file` | 19:42 |
| ShadowJonathan | yeah, i didn't do either of those (as i didn't know that), and doing `-a` would've just added my whole venv directory, heh | 19:43 |
| fungi | -a says commit all changes for tracked files but if you only want certain file changes added you would list them independently | 19:43 |
| fungi | or you can git add them first | 19:43 |
| ShadowJonathan | wait, only tracked ones? | 19:43 |
| fungi | yeah, git never commits untracked files | 19:44 |
| ShadowJonathan | i meant adding them, as `-a` to me seems like "git add -a", which just adds every file | 19:45 |
| smcginnis | ShadowJonathan: if you use tox, that will create any venv's under the .tox directory that is included in .gitignore. | 19:48 |
| ShadowJonathan | those are venvs that're used by the tox tool, and generally should/could be wiped upon every test for a completely untouched environment | 19:49 |
| fungi | ShadowJonathan: similar use of -a, `git add -a` says track all untracked files and stage any changes for commit while `git commit -a` says to commit any changes for tracked files whether or not they were staged for commit | 19:49 |
| fungi | you can also git add a tracked file and any of its changes will be staged for commit | 19:50 |
| ShadowJonathan | ah | 19:50 |
| ShadowJonathan | that makes more sense, yeah | 19:50 |
| ShadowJonathan | thanks | 19:50 |
| *** e0ne has joined #openstack-tc | 20:57 | |
| *** markvoelker has joined #openstack-tc | 21:23 | |
| *** markvoelker has quit IRC | 21:27 | |
| openstackgerrit | Jonathan de Jong proposed openstack/ideas master: [RFC] Rough draft for Nebula/Constellation project https://review.opendev.org/741057 | 21:30 |
| ShadowJonathan | i think that's probably enough for me today, i'll most likely submit Aurora tomorrow, take one last look, and then send an email to the openstack-discuss mailing list | 21:33 |
| *** e0ne has quit IRC | 21:37 | |
| *** e0ne has joined #openstack-tc | 21:38 | |
| ShadowJonathan | https://review.opendev.org/Documentation/intro-user.html#drafts | 21:39 |
| ShadowJonathan | welp, didn't know about this, better use that to stage stuff next time | 21:39 |
| fungi | ShadowJonathan: don't try. we have acls in place to disable draft changes, they were never actually useful for our workflow, and the implementation of them in gerrit was severely flawed anyway. later versions of gerrit (we're in the midst of prepping for a long overdue upgrade) got rid of the draft option entirely for similar reasons | 21:45 |
| fungi | if you want to signal that a change is not yet ready for reviewing, you can just set a workflow -1 vote on it | 21:45 |
| fungi | that will mark it as a work in progress | 21:45 |
| ShadowJonathan | Ah, I simply marked all of my changes thus far as "RFC", will that get the right intention across as a changeset that's more about discussing the content than actually working towards applying it? | 21:46 |
| ShadowJonathan | I have 0 intention to have my drafts fly into the repo (and site) as they are now, I know they're flawed and probably biased, so I want to discuss them | 21:47 |
| ShadowJonathan | fungi: *bump* | 21:50 |
| gmann | ShadowJonathan: usually we use [WIP] in title commit msg to mark work-in-progress from cmt msg or -1 workflow is easy to block change to get it merge. but getting review feedback on those can be done by pushing it on ML or irc even in WIP stage | 21:50 |
| ShadowJonathan | I'll be doing that after having pushed the third project, so I can focus on receiving feedback, and not composing them in the meantime, but yeah, thanks for telling me that | 21:51 |
| *** e0ne has quit IRC | 22:21 | |
| *** jamesmcarthur has joined #openstack-tc | 22:32 | |
| *** tosky has quit IRC | 22:50 | |
| *** tkajinam has joined #openstack-tc | 22:58 | |
| *** e0ne has joined #openstack-tc | 23:11 | |
| *** e0ne has quit IRC | 23:13 | |
| *** jamesmcarthur has quit IRC | 23:36 | |
| *** jamesmcarthur has joined #openstack-tc | 23:48 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!