| gmann | knikolla: I think this is ready to merge, release patch is waiting for this to remove the release steps for Winstacker https://review.opendev.org/c/openstack/governance/+/886880 | 17:31 |
|---|---|---|
| dansmith | gmann: remind me, do I just have to recheck this after the dependent patch merges or is there a shortcut? https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/887111 | 17:55 |
| gmann | dansmith: recheck, i do not think there is another way. | 17:56 |
| dansmith | ack | 18:02 |
| fungi | if they shared a dependent queue in zuul then pre-approving the later change would cause it to get enqueued with the dependency | 18:06 |
| fungi | but otherwise zuul assumes the dependency will need to merge before testing the dependent change will work | 18:07 |
| dansmith | I understand that, I was hoping for a quicker way to kick it straight to gate | 18:12 |
| knikolla | gmann: thanks, kicked it through. | 18:22 |
| gmann | knikolla: thanks | 18:30 |
| opendevreview | Merged openstack/governance master: Retire Winstackers project https://review.opendev.org/c/openstack/governance/+/886880 | 18:32 |
| fungi | if it already has a verified +1, a new approval vote (workflow +1) should enqueue directly into the gate. this can either be a new reviewer adding a workflow +1 or the provider of a prior workflow +1 removing and adding theirs again | 18:32 |
| fungi | note that the need for an existing verified +1 before enqueuing into the gate pipeline is a specific rule for the "openstack" tenant, most (all?) other tenants in our zuul deployment allow a workflow +1 to automatically enqueue into the gate regardless of what existing verified votes may or may not exist on the change (cancelling any running check pipeline builds in progress too since | 18:34 |
| fungi | they'll cease to be relevant) | 18:34 |
| fungi | this is a choice the tc can revisit if they determine it's no longer relevant to the project | 18:36 |
| dansmith | yeah it doesn't have a V+1 because it has a V-2 because it tried to gate and failed, that's why I was hoping there was a way to go straight to gate instead of another check | 18:46 |
| dansmith | and yeah, I know the check required rule is "openstack heritage" | 18:47 |
| gmann | yeah, I am not in what condition this condition is valid. because if change is +W and depends-on is not merged then zuul put V-2. The only situation when it can have V+1 is do not +W until depends-on is not merged | 18:48 |
| gmann | *am not sure | 18:48 |
| gmann | and usually we put +W on the series expecting deps merge in order otherwise we need to ask core members again to +W after depends-on is merged. | 18:50 |
| dansmith | in case it's not clear, I'm not complaining, I was just asking if there was a shortcut for this unshared pipeline thing :) | 19:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!