| *** bauzas_ is now known as bauzas | 06:58 | |
| *** bauzas_ is now known as bauzas | 08:09 | |
| opendevreview | Francesco Di Nucci proposed openstack/openstack-manuals master: Review "Tool support for image creation" https://review.opendev.org/c/openstack/openstack-manuals/+/923650 | 08:18 |
|---|---|---|
| opendevreview | Merged openstack/openstack-manuals master: docs: review manual image creation https://review.opendev.org/c/openstack/openstack-manuals/+/923947 | 12:37 |
| frickler | tc-members: does anybody happen to know if Kristi Nikolla has left OpenStack? they're still listed as release liaison for keystone, but I don't see a review or comment from them over the last months | 15:45 |
| gtema | I sadly haven't heard anything from him since Vancouver summit | 15:45 |
| *** bauzas_ is now known as bauzas | 18:09 | |
| spotz[m] | I saw him at FOSDEM, I won't be at Devconf US which I know he sometimes attends | 18:49 |
| spotz[m] | knikolla: You about? | 18:50 |
| spotz[m] | One way to check:) | 18:50 |
| knikolla | spotz: that was last year's FOSDEM | 18:52 |
| knikolla | o/ | 18:52 |
| spotz[m] | hehe time just flies!!!! And frickler I found him for you:) | 18:53 |
| knikolla | Taking a bit of a break from OpenStack for the rest of this year at least | 18:53 |
| knikolla | I did notify the keystone PTL that I was resigning from keystone-core, but I guess the liaison page hasn't been updated. | 18:54 |
| frickler | ah, that's matrix's bad habit of not keeping users online even if they are online once again :-/ | 18:57 |
| gouthamr | o/ frickler: i got a response on the setuptools pinning concern for skyline_console | 19:26 |
| gouthamr | https://review.opendev.org/c/openstack/skyline-console/+/924130 | 19:26 |
| gouthamr | (https://review.opendev.org/c/openstack/skyline-console/+/924130/comments/79531001_6ef6e566) | 19:26 |
| gouthamr | it looks to be for CI alone as the comment states, https://opendev.org/openstack/skyline-console/src/branch/master/playbooks/python-tarball/run.yaml#L21-L28 | 19:27 |
| clarkb | gouthamr: the problem with it is if you don't use their makefile then you apparnetly can't build the package properly? | 19:29 |
| clarkb | Generally I try to encourage projects to think about what happens if someone git clones the repo on their laptop or in a VM and does relatively standard things against the project. We should do our best to ensure things owrk | 19:30 |
| gouthamr | clarkb: hmm, they do reference the make file for source installs: https://docs.openstack.org/skyline-console/latest/install/source-install-ubuntu.html#install-and-configure-components | 19:30 |
| clarkb | right but 98% of the python world isn't going to expect that they will just run the buil dtool or setup.py or pip intsall ./ | 19:31 |
| gouthamr | atleast for OpenStack services, no :D | 19:33 |
| JayF | ++ | 19:33 |
| JayF | I would take this as a mild sign that we've done a bad job of integrating them into openstack culture and style | 19:33 |
| JayF | (and keeping them as emerging would likely just be an extension of this failure rather than a stick to cause improvement) | 19:33 |
| gouthamr | they're no longer emerging :) | 19:34 |
| clarkb | fwiw it looks like the issue is they don't want a skyline_console package they want a skyline-console package. The reason for that _ instead of - is that _ is considered canonical by python packaging and newer setuptools is converting to the canonical version. I'm not 100% certain of this fungi can confirm but if so it is also just better to use the canonical version I think | 19:34 |
| gouthamr | yes; so fix the installation scripts (and workaround the issue for stable branches) perhaps | 19:35 |
| clarkb | anyway pinning setuptools is generally a user unfriendly thing to do. The major exception to that is if you use pyproject.toml to specify build versions ensuring that when people build your mpackage using standard tools they get the version you want | 19:35 |
| JayF | tbh it's the kind of behavior that causes downstream packagers a bunch of pain | 19:36 |
| JayF | which we do backflips to avoid them feeling with other things like requirements project | 19:36 |
| gouthamr | ty clarkb JayF; i'm commenting on the change with a link to this conversation.. | 19:39 |
| JayF | Am I remembering right that at some point we did a oslo-BLAH -> oslo_BLAH transition for similar reasons? | 19:39 |
| gouthamr | oslo<dot>blah | 19:40 |
| JayF | or am I just remembering decade-ago-jay being flustered at the repo having - and the package having _ | 19:40 |
| JayF | yeah, that's right | 19:40 |
| clarkb | JayF: I think there were multiple iterations of that due to subprojects going away or being a bad idea | 19:40 |
| clarkb | and then there was the canonicalization problem | 19:40 |
| clarkb | gouthamr: might also be worth mentioning that python setup.py commands (not the script itself) are deprecated | 19:42 |
| clarkb | you are expected to use a tool like build or pip to execute the script as appropriate | 19:42 |
| gouthamr | they're using pip? | 19:43 |
| * gouthamr looks again | 19:43 | |
| clarkb | gouthamr: https://review.opendev.org/c/openstack/skyline-console/+/924130/1/Makefile is using python setup.py dsist and bdist_wheel | 19:43 |
| gouthamr | AH | 19:43 |
| gouthamr | yes | 19:43 |
| clarkb | I don't think that is urgent but will at some point in time need to change if I understand pypa's intentions there | 19:44 |
| gouthamr | ack; linked them to https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ | 19:45 |
| gouthamr | thanks clarkb! | 19:45 |
| fungi | right, they ought to be using something like https://pypi.org/p/build instead | 19:55 |
| fungi | and yes, canonicalization of python package names is a thing, but you don't have to do everything in canonical form if you don't want, you just need to compensate for the fact that they'll appear in canonical form when you query with certain tools | 19:59 |
| fungi | that is, python distribution packages | 19:59 |
| fungi | you can't have "-" in the name (nor namespace) of a python import package | 19:59 |
| fungi | but that's never worked, and for obvious reasons | 19:59 |
| *** bauzas_ is now known as bauzas | 20:04 | |
| opendevreview | Jeremy Stanley proposed openstack/election master: Add affiliation lookup functionality https://review.opendev.org/c/openstack/election/+/876738 | 23:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!