| *** vhari_ is now known as vhari | 15:01 | |
| tkajinam | I don't remember the actual action items after retirement of tag framework. Should we remove only mention to the framework or should we also drop the badges from README ? | 17:27 |
|---|---|---|
| tkajinam | I see badges were removed from some repos but are still kept in the others | 17:28 |
| tkajinam | tc-members ^^^ wondering if anyone remember this | 17:32 |
| gmaan | tkajinam: tag things needs to be removed but badges are valid and they point to the correct links so we do not need to remove them | 17:50 |
| gmaan | example these two badges are good to have and they point to correct links https://camo.githubusercontent.com/a4f107d91a1669abb299499d334ab62ba559b8d1e95ad28c702b61cd5a81b38d/68747470733a2f2f676f7665726e616e63652e6f70656e737461636b2e6f72672f74632f6261646765732f626c617a61722e737667 | 17:51 |
| gmaan | example here https://review.opendev.org/c/openstack/blazar/+/961046 | 17:52 |
| sean-k-mooney | i acutlly dont see the poin tof removing tag or badges | 20:22 |
| sean-k-mooney | even if the tags framework is not maintianed naymore having them did not cost us anything and removing them just created review load for little gain | 20:23 |
| sean-k-mooney | i appoved the ones i reviewd but to me this was a waste of effort that could have been spent elsewehre | 20:23 |
| sean-k-mooney | in nova the svg was removed as well by the way https://github.com/openstack/nova/commit/65409f9483411ed94e1cf87dd30373650c2b67d8 | 20:25 |
| sean-k-mooney | watcher still has them btu its not a prity to remvoe them ever form my persepctive https://github.com/openstack/watcher/blob/master/README.rst?plain=1#L5 | 20:27 |
| sean-k-mooney | i wont say no to a patch btu its a whishlist bug at the most | 20:29 |
| fungi | i expect if you're going to the trouble of making a change to remove the reference to the tags process in a random project then removing the corresponding badges in the same change makes sense, but yeah it doesn't seem like either should be a high priority | 20:30 |
| sean-k-mooney | i guess this is a low hanging fruit bug for a new be alhtough im not sure they woudl get much value out of htat | 20:32 |
| sean-k-mooney | the main reason i knwo of in the past to condier remvoing the badge | 20:32 |
| sean-k-mooney | was for some downstream package they didnt like having urls to external source like the badge in the docs they packaged | 20:32 |
| sean-k-mooney | but i think the sphix directive take care of that somehow | 20:33 |
| sean-k-mooney | i could be wrong but i think when you buidl the pdf docs for example the .. image:: https://governance.openstack.org/tc/badges/blazar.svg | 20:33 |
| sean-k-mooney | the image embeded into pdf | 20:34 |
| sean-k-mooney | we dont use those for tacking | 20:34 |
| sean-k-mooney | but that was they issue given for having badges in readmes that was rasied in the past | 20:34 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
