| tkajinam | I really hate people started using legacy gerrit api likely due to their local ai toolings. it makes me hard to check whether all my comments are addressed (and how)... | 01:22 |
|---|---|---|
| tkajinam | makes it * | 01:22 |
| gouthamr | what does this mean, tkajinam? | 02:13 |
| tkajinam | https://review.opendev.org/c/openstack/oslo.messaging/+/1008831 | 02:14 |
| tkajinam | this is where I find that annoying thing (I'm not blaming it on that single person but have seen the same in multiple repos recently | 02:14 |
| tkajinam | "I got my ai to fix my code according to your comment and let it posted that single ugly comment, so please review the comment to check whether your comments are all addressed" | 02:15 |
| gouthamr | ah, ugly indeed | 02:15 |
| tkajinam | I'm not dong work for their AI :-) | 02:15 |
| tkajinam | even if the comment is better formatted I still find that legacy comment annoying because it doesn't allow me to easily understand how that comment can be related to individual suggestions | 02:16 |
| tkajinam | I know some people like that due to toolings (again I'm not complaining it on that) but I find that "abuse" by ai tools a bit concerning | 02:17 |
| gouthamr | yeah, fair. It shouldn't be a horrible lift for them/their LLM.. but, also by extension, if their agent is just being sloppy, pushing sloppy code - we have no reason to entertain them like we would do any genuine contributor | 02:17 |
| tkajinam | yeah | 02:19 |
| tkajinam | it might be constructive to discuss whether we can expose api to let them do "reply to a comment" with infra team or even gerrit community | 02:19 |
| tkajinam | but I could not stop posting the complaining somewhere visible :-P | 02:20 |
| gouthamr | i think that's totally possible? i see many mentions of "in_reply_to" in this: https://review.opendev.org/Documentation/rest-api-changes.html | 02:21 |
| tkajinam | ah ok | 02:22 |
| tkajinam | I said that because I remember fungi was talking about some limitation about his tools but it may be related to his local tool rather than capability in server side. | 02:23 |
| tkajinam | or some recent upgrade in gerrit, I guess | 02:24 |
| gouthamr | ++ ack, didn’t notice when it got added | 02:44 |
| opendevreview | Merged openstack/governance master: Retire openstack/molteniron https://review.opendev.org/c/openstack/governance/+/1008521 | 07:31 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: OSSN-0109: EC2-derived tokens retain full privileges https://review.opendev.org/c/openstack/security-doc/+/1002392 | 12:19 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: OSSN-0112: EC2-derived tokens retain full privileges https://review.opendev.org/c/openstack/security-doc/+/1002392 | 12:20 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 13:06 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 13:06 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 13:09 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 13:10 |
| fungi | tkajinam: i use gertty (a console-based gerrit client) a lot, and yes its support for the newer gerrit comment threading metadata is recent and experimental/incomplete | 14:03 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0113: project-scoped admin remains cloud-wide https://review.opendev.org/c/openstack/security-doc/+/1007719 | 15:23 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 15:48 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: Add OSSN-0111: Keystone MFA enforcement gaps and replay weaknesses https://review.opendev.org/c/openstack/security-doc/+/1006742 | 15:51 |
| opendevreview | Grzegorz Grasza proposed openstack/security-doc master: OSSN-0112: EC2-derived tokens retain full privileges https://review.opendev.org/c/openstack/security-doc/+/1002392 | 15:53 |
| mnasiadka | fungi: gertty has some initial threading support? Cool - it was the legacy comments stuff that stopped me from using it | 17:33 |
| fungi | mnasiadka: yes, there's a proposed change which i've been testing with for a while | 17:33 |
| tkajinam | oh, that's nice | 17:57 |
| mnasiadka | Ok, I’ll test it as well next week ;) | 17:57 |
| fungi | i think it's incomplete, but does expose the ability to do direct replies to existing comments at least | 17:57 |
| fungi | and mark resolved and such | 17:58 |
| fungi | though the normal reply feature still uses old-style gerrit review comments | 17:58 |
| fungi | i think it just needs someone with time to implement the remaining bits | 17:59 |
| fungi | (which is not me, sadly) | 17:59 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!