| opendevreview | Matthias Runge proposed openstack/telemetry-tempest-plugin master: Move doc requirements to doc https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/800162 | 07:39 |
|---|---|---|
| tkajinam | mrunge_, I don't know how we ended up in this situation but seems panko repo still has some leftovers ... https://opendev.org/openstack/panko | 08:32 |
| tkajinam | I raised this in #openstack-releases but we might need some manual cleanup to remove anything else than README.rst and .gitreview | 08:33 |
| tkajinam | so far I got no response | 08:33 |
| mrunge_ | tkajinam: oh, oops | 08:54 |
| mrunge_ | no idea how this happened, probably because I made some mistake during the removal | 08:54 |
| tkajinam | mrunge_, I guess another patch came in and some files added by the patch were not deleted during rebase | 08:55 |
| mrunge_ | yeah, that seems possible | 08:55 |
| tkajinam | but it's just a guess. I remember I downloaded a patch once to check all files and confirmed everything is deleted | 08:55 |
| tkajinam | but maybe something has been changed since then | 08:55 |
| mrunge_ | In any case, I'll send a follow-up | 08:56 |
| mrunge_ | good catch tkajinam | 08:56 |
| tkajinam | mrunge_, thanks | 08:56 |
| tkajinam | I was looking at panko repo to find example README.rst to retire another repo :-) | 08:56 |
| tkajinam | and noticed that issue :-( | 08:56 |
| opendevreview | Matthias Runge proposed openstack/panko master: Remove leftovers of retirement https://review.opendev.org/c/openstack/panko/+/800167 | 08:58 |
| mrunge_ | I fear we may have to disable the tests again, then merge the removal and enable tests another time | 08:58 |
| *** mrunge_ is now known as mrunge | 08:59 | |
| manpreetk | mrunge: Hi this is regarding a tacker patch [1]. While migrating to SQLAlchemy 1.4, tacker functional test cases are failing due to python-aodhclient exception. Could you please help in merging aodh patch [2] as tacker depends on this fix. Thanks in advance. | 09:45 |
| manpreetk | [1] https://review.opendev.org/c/openstack/tacker/+/796160/11 | 09:45 |
| manpreetk | [2] https://review.opendev.org/c/openstack/aodh/+/799651 | 09:45 |
| mrunge | manpreetk: looking | 09:45 |
| manpreetk | Thanks | 09:45 |
| mrunge | manpreetk: it seems that we are currently blocked by httpd crashing on ubuntu during tests | 09:46 |
| mrunge | https://zuul.opendev.org/t/openstack/build/6c1795fd98514095b4f8d165b20b2c82/log/controller/logs/apache/error_log.txt#66 | 09:46 |
| mrunge | like core dumping | 09:46 |
| mrunge | the test itself works fine on aodh | 09:46 |
| mrunge | it must be a combination of tempest, tempest-telemetry and ... httpd | 09:47 |
| mrunge | manpreetk: remind me please, why are you blocked by [2] ? | 09:48 |
| opendevreview | Matthias Runge proposed openstack/aodh master: SQLAlchemy url is now immutable https://review.opendev.org/c/openstack/aodh/+/800070 | 09:53 |
| manpreetk | mrunge: Thanks for sharing details. In tacker, while VNF creation we are getting aodhclient exception in heat logs, please find logs https://zuul.opendev.org/t/openstack/build/701fa35fcb97448e808699a5d4672828/log/controller/logs/screen-h-eng.txt?severity=4 | 10:01 |
| manpreetk | mrunge: after applying patch [2], problem resolved for us. | 10:02 |
| mrunge | hmm, let me check that in aodh | 10:02 |
| manpreetk | ok | 10:02 |
| mrunge | manpreetk: you collected a couple of core dumps during that task | 10:04 |
| mrunge | https://zuul.opendev.org/t/openstack/build/701fa35fcb97448e808699a5d4672828/log/controller/logs/apache/error_log.txt | 10:04 |
| mrunge | I wonder what would cause httpd to core dump here | 10:04 |
| opendevreview | Matthias Runge proposed openstack/aodh master: Make aodh tempest jobs non-voting https://review.opendev.org/c/openstack/aodh/+/800174 | 10:07 |
| mrunge | tkajinam: HI, if you are still there, would you think it'd make sense to combine https://review.opendev.org/c/openstack/aodh/+/800070 and https://review.opendev.org/c/openstack/aodh/+/799651/ ? | 10:34 |
| mrunge | they in combination seem to fix the failing tests | 10:35 |
| opendevreview | Matthias Runge proposed openstack/aodh master: Replace oslo_utils.fnmatch with fnmatch https://review.opendev.org/c/openstack/aodh/+/800198 | 10:47 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Replace oslo_utils.fnmatch with fnmatch https://review.opendev.org/c/openstack/aodh/+/799651 | 12:01 |
| tkajinam | mrunge, I though my change is not required to fix gate atm . Is there any change ? | 12:04 |
| tkajinam | mrunge, I mean, iiuc you change should be enough to fix the gate. so we can merge these two separately... which would be better IMO | 12:05 |
| tkajinam | mine is just fixing deprecation warning at this timing. | 12:05 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: Replace oslo_utils.fnmatch with fnmatch https://review.opendev.org/c/openstack/aodh/+/799651 | 12:08 |
| opendevreview | Takashi Kajinami proposed openstack/aodh master: SQLAlchemy url is now immutable https://review.opendev.org/c/openstack/aodh/+/800070 | 12:08 |
| opendevreview | Takashi Kajinami proposed openstack/panko master: Retire panko, remove all contents https://review.opendev.org/c/openstack/panko/+/800213 | 12:13 |
| mrunge | tkajinam: it looks like your change fixes the issue on httpd others are seeing | 12:22 |
| mrunge | and indeed there is a httpd segfault happening during tempest tests, which seem to work with your patch | 12:23 |
| mrunge | I can not see the connection so far | 12:23 |
| mrunge | but if it fixes the issue: fine with me :) | 12:23 |
| opendevreview | Merged openstack/ceilometer master: Moving IRC network reference to OFTC https://review.opendev.org/c/openstack/ceilometer/+/799931 | 12:45 |
| tkajinam | mrunge, yeah . so if this passes the gate then let's merge these separately https://review.opendev.org/c/openstack/aodh/+/800070 | 13:04 |
| tkajinam | if it fails merge the merged version | 13:04 |
| mrunge | tkajinam: the merged version passes, the patches separately fail | 13:04 |
| mrunge | you see they fix 1/2 of the failures each | 13:05 |
| mrunge | I hope you're not mad with me if I'm just approving the merged patch | 13:05 |
| tkajinam | yeah but it's still interesting... as I mentioned mine is supposed to fix deprecation warning and not intended to fix any breakage | 13:05 |
| mrunge | indeed, there is something really strange going on, and I can not imagine how your patch would fix a core dump with httpd | 13:06 |
| mrunge | (but it does!) | 13:06 |
| tkajinam | mrunge, do you mind giving another try for separate patches ? if https://review.opendev.org/c/openstack/aodh/+/800070 fails again, I totally agree with you | 13:06 |
| mrunge | I don't mind | 13:07 |
| mrunge | no life depends on this getting merged today or Monday (or so) | 13:07 |
| tkajinam | :-) | 13:08 |
| mrunge | it just failed again | 13:08 |
| tkajinam | mrunge, +1ed the merged version | 13:11 |
| mrunge | thank you tkajinam | 13:11 |
| mrunge | I'd really like to understand why just getting rid of the deprecation notice makes such a difference | 13:11 |
| tkajinam | yeah | 13:12 |
| tkajinam | I have abandoned one of separated patches I submitted | 13:13 |
| tkajinam | the other one is yours so I can't abandon it | 13:13 |
| mrunge | I'll abandon that asap | 13:14 |
| mrunge | and thank you for submitting a patch to clean up panko left-overs | 13:14 |
| tkajinam | np. I didn't notice you already posted one | 13:14 |
| tkajinam | it seems we should make the job noop again to make it in | 13:14 |
| mrunge | yes, exactly that's what I'm going to do | 13:15 |
| tkajinam | mrunge, could you check the comment on my change ? https://review.opendev.org/c/openstack/panko/+/800213 | 13:18 |
| tkajinam | I think the same is applied to yours. I abandoned mine as duplicate but that comment should be addressed IMO | 13:19 |
| mrunge | good catch, yes | 13:19 |
| opendevreview | Matthias Runge proposed openstack/panko master: Remove leftovers of retirement https://review.opendev.org/c/openstack/panko/+/800167 | 13:22 |
| opendevreview | Merged openstack/aodh master: Replace oslo_utils.fnmatch with fnmatch https://review.opendev.org/c/openstack/aodh/+/800198 | 14:16 |
| opendevreview | Merged openstack/aodh master: Merge notifier opts https://review.opendev.org/c/openstack/aodh/+/787741 | 16:28 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!