| opendevreview | Erno Kuvaja proposed openstack/telemetry-tempest-plugin master: Add basic admin tests for Aodh https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/916616 | 08:34 |
|---|---|---|
| tkajinam | jokke, do you have time to review this ? This is caught often in puppet ci https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/914656 | 08:35 |
| tkajinam | and also it'd be nice if I can ask for your attention for https://review.opendev.org/c/openstack/aodh/+/909094 . the stable branch job has been broken but that fix has been pending on you (because of that -2) | 08:36 |
| jokke | tkajinam: will get eyes on those | 11:09 |
| jokke | tkajinam: yes, we still don't have the full test job configuration even for master so I'm not confortable backporting stuff that is not fully tested | 11:10 |
| jokke | to the extent we have tests I meant | 11:10 |
| tkajinam | jokke, what kind of tests we need for this. the functional job in stable/2023.1 is consistently failing and that change is proven to fix the current failure. If you want that some remaining work is completed before backporting any then that's file, but note that nothing can be backported to aodh stable branches until at least that specific change is backported | 12:06 |
| tkajinam | correction not stable/2023.2 but stable/2023.1 . though stable/2023.1 is also broken and needs the same fix | 12:07 |
| tkajinam | and Idk what is "the remaining work" which needs to be done in master. I may probably abandon that backport because I don't know when you think "we" are ready. | 12:09 |
| tkajinam | I mean any backports to stable/2023.2, 2023.1 and zed are all blocked because of failing functional job, and we need that backport to fix the jobs. so until all pending work which I don't know is done in master you can't backport changes to these branches | 12:12 |
| tkajinam | we do run these tests in CI. that's why the job is failing (the job is running the mysql tests in postgresql deployment now without that change). | 12:17 |
| tkajinam | I've abandon the patch | 12:18 |
| tkajinam | you can restore it if needed but I don't want it kept for further period if we have no clear timeline. | 12:19 |
| opendevreview | Merged openstack/telemetry-tempest-plugin master: Ensure both severities are used in test data https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/914656 | 12:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!