| zigo | Hi there! After the global req patch for awscli passed, now our awscli patch in Ceilometer is saying: | 08:25 |
|---|---|---|
| zigo | ERROR: Could not find a global requirements entry to match package prometheus_client. If the package is already included in the global list, the name or platform markers there may not match the local settings. | 08:25 |
| zigo | ERROR: Requirement for package 'botocore' has no lower bound | 08:25 |
| zigo | While I can easily copy/past the global-requirements.txt for botocore, I do not know what to do with the prometheus_client error, which is unrelated to what we've done. Is someone on this already ? | 08:25 |
| frickler | zigo: g-r lists prometheus-client, while upper-constraints has prometheus_client. the former seems to be the "official" name? not sure how this was passing CI earlier, though | 08:31 |
| zigo | It's with a dash, not underscore, indeed: https://pypi.org/project/prometheus-client/ | 08:36 |
| zigo | If you put underscore, it redirects. | 08:36 |
| zigo | Probably it has been renamed ? | 08:36 |
| opendevreview | Thomas Goirand proposed openstack/ceilometer master: Replace request-aws by awscurl https://review.opendev.org/c/openstack/ceilometer/+/964757 | 08:38 |
| zigo | Hopefully, this new patch version will now pass CI ! :) | 08:38 |
| frickler | there's still the botocore failure, but getting better it seems ;) | 09:05 |
| opendevreview | Thomas Goirand proposed openstack/ceilometer master: Replace request-aws by awscurl https://review.opendev.org/c/openstack/ceilometer/+/964757 | 10:40 |
| zigo | It passes now ! :) | 10:43 |
| opendevreview | Merged openstack/grian-ui master: Avoid conflicting number https://review.opendev.org/c/openstack/grian-ui/+/960967 | 14:12 |
| opendevreview | Merged openstack/ceilometer master: Change size units from MB/GB to MiB/GiB https://review.opendev.org/c/openstack/ceilometer/+/962455 | 15:44 |
| mrunge | zigo, thank you for your patch. I saw you dropped a couple of mocks, why there were not necessary anymore? | 15:51 |
| zigo | I believe they were specific to using requests-aws, though if you think they are necessary, I'd appreciate a 2nd look. | 15:52 |
| zigo | I'm not the author of the patch, it's more my colleague, I can ask him what he thinks of it. | 15:52 |
| zigo | While I'm not sure of the unit tests, my colleague tested his code against a real rados GW, so we know his code is in order. | 15:53 |
| zigo | Maybe some functional tests would be nicer, but do we even have a rados GW in our CI ? | 15:53 |
| mrunge | I think it is being mocked | 16:09 |
| mrunge | so, no functional test for rados GW in CI | 16:09 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!