| *** apoorvad has quit IRC | 00:58 | |
| *** rfolco has quit IRC | 02:12 | |
| *** rfolco has joined #openstack-third-party-ci | 02:13 | |
| *** rfolco has quit IRC | 02:17 | |
| *** asselin_ has joined #openstack-third-party-ci | 02:28 | |
| *** asselin__ has quit IRC | 02:29 | |
| *** asselin_ has quit IRC | 04:41 | |
| *** asselin_ has joined #openstack-third-party-ci | 10:37 | |
| *** asselin_ has quit IRC | 10:43 | |
| *** rfolco has joined #openstack-third-party-ci | 11:00 | |
| *** rfolco has quit IRC | 11:00 | |
| *** mjturek1 has quit IRC | 12:54 | |
| *** rfolco has joined #openstack-third-party-ci | 13:57 | |
| *** asselin_ has joined #openstack-third-party-ci | 14:24 | |
| *** apoorvad has joined #openstack-third-party-ci | 15:42 | |
| *** ja3 has joined #openstack-third-party-ci | 17:06 | |
| *** ja3 has quit IRC | 17:26 | |
| asselin | krtaylor, mmedvede you guys familiar with this? https://review.openstack.org/#/c/304683/5 | 18:06 |
|---|---|---|
| krtaylor | asselin, yes, that's a tool to allocate nodes for ironic CI testing | 18:07 |
| krtaylor | asselin, Mike is in my team | 18:07 |
| asselin | ok cool | 18:07 |
| krtaylor | Mike and Mark, actually | 18:08 |
| krtaylor | asselin, any comments you have would be appreciated! | 18:08 |
| mmedvede | asselin: yes, that is a tool similar to nodepool in functionality, but on entirely other level | 18:08 |
| asselin | ok...will come back to it. promised mmedvede reviews for his stuff a long time ago... | 18:09 |
| krtaylor | Thanks! | 18:10 |
| mmedvede | asselin: do not drown in my patches, they are refactoring, so hard to follow. Just look at overall direction - do they improve code, or make it worse? | 18:10 |
| asselin | mmedvede, ok will do | 18:10 |
| *** asselin_ has quit IRC | 18:16 | |
| *** krtaylor has quit IRC | 18:20 | |
| *** krtaylor has joined #openstack-third-party-ci | 18:29 | |
| *** apoorvad has quit IRC | 19:24 | |
| *** rfolco has quit IRC | 21:01 | |
| asselin | mmedvede, ok went through all your ciwatch patches. | 21:10 |
| mmedvede | asselin: thank you very much | 21:11 |
| asselin | mmedvede, ok...I see now where you got the ciwatchapp from : zuulApp which is just the configs & logging | 21:19 |
| mmedvede | asselin: yeah, I just commented on the first review | 21:21 |
| asselin | mmedvede, in zuul code, though, all the other classes extend that | 21:21 |
| mmedvede | asselin: the name is bad | 21:21 |
| asselin | class Server(zuul.cmd.ZuulApp): | 21:21 |
| asselin | ok will read the comments | 21:21 |
| mmedvede | yes, I tried not to use inheritance when it is not absolutely necessary | 21:21 |
| mmedvede | imo, it makes things harder to parse | 21:22 |
| mmedvede | and too implicit | 21:22 |
| asselin | ok, no need to rename. | 21:25 |
| asselin | ping me after you go through them and I'll remove my -1s for those | 21:26 |
| mmedvede | asselin: ok. Very good reviews so far | 21:26 |
| mmedvede | asselin: I went over your reviews. All good points, thanks a lot. I'll see how reasonable it is to update the patches and rebase the series. | 21:46 |
| asselin | ok sure | 21:48 |
| *** rfolco has joined #openstack-third-party-ci | 22:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!