Friday, 2013-09-27

*** krow has joined #openstack-trove00:05
*** matsuhashi has joined #openstack-trove00:28
*** agliodbs has joined #openstack-trove00:35
agliodbshowdy!  <-- Josh Berkus00:35
*** nosnos has joined #openstack-trove00:38
*** rnirmal has quit IRC00:39
*** krow has quit IRC00:42
*** krow has joined #openstack-trove00:46
*** krow has quit IRC01:01
*** agliodbs has quit IRC01:04
*** radez_g0n3 is now known as radez01:29
*** krow has joined #openstack-trove01:31
SlickNikhello Josh / agliodbs!01:34
*** erkules_ has joined #openstack-trove01:35
*** krow has quit IRC01:35
*** erkules has quit IRC01:37
*** jaishanker has joined #openstack-trove01:49
*** amcrn has quit IRC01:52
*** yogeshmehra has joined #openstack-trove02:49
*** yogeshmehra has quit IRC02:54
*** krow has joined #openstack-trove03:09
*** krow has quit IRC03:13
*** matsuhashi has quit IRC03:15
*** amytron has quit IRC03:18
*** jaishanker has quit IRC03:23
haomaiwangping hub_cap03:29
*** yogeshmehra has joined #openstack-trove03:51
openstackgerritErik Redding proposed a change to openstack/trove: Moved create_instance DNS attempt to post-prepare  https://review.openstack.org/4818803:51
*** yogeshmehra has quit IRC03:56
*** matsuhashi has joined #openstack-trove03:56
*** radez is now known as radez_g0n304:03
*** josh__ has joined #openstack-trove04:05
*** josh__ is now known as agliodbs04:05
*** krow has joined #openstack-trove04:15
*** krow has quit IRC04:37
*** yogeshmehra has joined #openstack-trove04:51
*** yogeshmehra has quit IRC04:57
*** yogeshmehra has joined #openstack-trove05:00
*** SushilKM has joined #openstack-trove05:01
*** SushilKM has quit IRC05:05
*** SushilKM has joined #openstack-trove05:06
*** krow has joined #openstack-trove05:07
*** adrian_otto has joined #openstack-trove05:15
*** dmakogon_ has joined #openstack-trove05:17
*** Kapil has joined #openstack-trove05:22
openstackgerritMichael Basnight proposed a change to openstack/python-troveclient: Massive refactoring to the troveclient. - WIP until further notice.  https://review.openstack.org/4857605:26
*** yogeshmehra has quit IRC05:27
*** agliodbs has quit IRC05:36
*** yogeshmehra has joined #openstack-trove05:41
*** yogeshmehra has quit IRC05:43
*** krow has quit IRC05:46
*** josh__ has joined #openstack-trove05:47
*** josh__ is now known as agliodbs05:47
*** krow has joined #openstack-trove05:49
*** adrian_otto has quit IRC06:03
*** SushilKM has quit IRC06:09
*** agliodbs has quit IRC06:09
*** SnowDust has joined #openstack-trove07:00
*** SnowDust has quit IRC07:03
*** SnowDust has joined #openstack-trove07:09
*** SnowDust has joined #openstack-trove07:09
*** krow has quit IRC07:15
*** yogesh has quit IRC07:16
SnowDustanyone to help with heat implementation07:26
SnowDust?07:26
SnowDusthub_cap: u thr buddy ?07:26
SnowDustSlickNik: can u help ?07:26
*** ashestakov_ has joined #openstack-trove07:49
*** dmakogon_ has quit IRC07:56
openstackgerritIllia Khudoshyn proposed a change to openstack/trove: Extract generic part of GA code from MySQL specific modules  https://review.openstack.org/4843508:18
*** krow has joined #openstack-trove08:29
*** erkules_ is now known as erkules08:44
openstackgerritDenis M. proposed a change to openstack/trove: Update statuses on GA timeout  https://review.openstack.org/4572308:59
*** rushiagr has joined #openstack-trove09:17
openstackgerritIllia Khudoshyn proposed a change to openstack/trove: Extract generic part of GA code from MySQL specific modules  https://review.openstack.org/4843509:27
*** rushiagr has quit IRC09:35
*** rushiagr has joined #openstack-trove09:38
*** krow has quit IRC09:44
*** rushiagr has quit IRC09:59
*** rushiagr has joined #openstack-trove10:01
openstackgerritDenis M. proposed a change to openstack/trove: Trove DNS refactoring.  https://review.openstack.org/4564410:02
*** Kapil has quit IRC10:24
*** Kapil has joined #openstack-trove10:25
*** esmute has quit IRC10:37
openstackgerritIllia Khudoshyn proposed a change to openstack/trove: Extract generic part of GA code from MySQL specific modules  https://review.openstack.org/4843510:44
*** esmute has joined #openstack-trove10:46
*** matsuhashi has quit IRC10:52
*** ikhudoshyn has quit IRC11:02
*** dmakogon has quit IRC11:03
*** ikhudoshyn has joined #openstack-trove11:08
*** ikhudoshyn has quit IRC11:11
*** ikhudoshyn has joined #openstack-trove11:12
*** ashestakov_ has quit IRC11:21
*** ashestakov_ has joined #openstack-trove11:24
*** matsuhashi has joined #openstack-trove11:44
*** rushiagr has quit IRC11:52
*** ashestakov_ has quit IRC12:00
*** matsuhashi has quit IRC12:01
*** pdmars has joined #openstack-trove12:03
*** matsuhashi has joined #openstack-trove12:10
*** matsuhashi has quit IRC12:11
*** radez_g0n3 is now known as radez12:34
*** matsuhashi has joined #openstack-trove12:35
*** Kapil has quit IRC12:41
*** SushilKM has joined #openstack-trove12:43
*** jrodom has joined #openstack-trove12:51
*** jrodom has joined #openstack-trove12:51
*** haomaiwang has quit IRC13:04
*** haomaiwang has joined #openstack-trove13:05
openstackgerritIllia Khudoshyn proposed a change to openstack/trove: Extract generic part of GA code from MySQL specific modules  https://review.openstack.org/4843513:12
*** SushilKM has quit IRC13:15
*** nosnos has quit IRC13:15
*** robertmyers has joined #openstack-trove13:19
*** adrian_otto has joined #openstack-trove13:24
*** jcru has joined #openstack-trove13:28
*** robertmyers has quit IRC13:40
*** djohnstone has joined #openstack-trove13:44
*** robertmyers has joined #openstack-trove13:50
*** amytron has joined #openstack-trove13:52
*** adrian_otto has quit IRC14:03
*** SnowDust has quit IRC14:08
*** ashestakov_ has joined #openstack-trove14:13
*** rnirmal has joined #openstack-trove14:13
*** shakayumi has joined #openstack-trove14:15
*** dmakogon has joined #openstack-trove14:16
*** KennethWilke has joined #openstack-trove14:20
*** datsun180b has joined #openstack-trove14:23
*** adrian_otto has joined #openstack-trove14:24
*** shakayumi has quit IRC14:28
*** Barker has joined #openstack-trove14:30
dmakogonanybody home ?14:36
*** SushilKM has joined #openstack-trove14:37
*** aj_ has joined #openstack-trove14:41
*** adrian_otto has quit IRC14:49
*** matsuhashi has quit IRC14:51
*** Nate2 has joined #openstack-trove14:53
datsun180ba few of us14:55
dmakogonjenkins doesn't working at all14:56
*** adrian_otto has joined #openstack-trove15:05
*** tanisdl has joined #openstack-trove15:07
*** adrian_otto has quit IRC15:08
datsun180bi haven't looked at -infra lately, maybe they're talking about it15:17
*** SushilKM has quit IRC15:26
*** jmontemayor has joined #openstack-trove15:33
*** SushilKM has joined #openstack-trove15:37
*** adrian_otto has joined #openstack-trove15:53
*** jodom has joined #openstack-trove16:04
*** Barker has quit IRC16:06
*** jrodom has quit IRC16:08
*** jodom has quit IRC16:18
*** jrodom has joined #openstack-trove16:18
*** josh_513 has joined #openstack-trove16:22
*** josh_513 is now known as agliodbs16:22
*** tanisdl has quit IRC16:22
*** dmakogon_ has joined #openstack-trove16:36
*** SushilKM has quit IRC16:39
*** Barker has joined #openstack-trove16:53
*** yogeshmehra has joined #openstack-trove16:58
yogeshmehraping hub_cap16:58
*** dmakogon__ has joined #openstack-trove16:59
*** paul_lodronio has joined #openstack-trove17:08
openstackgerritDan Nguyen proposed a change to openstack/trove: Added server_id to my.cnf template logic  https://review.openstack.org/4720617:19
aj_hi. I am new to openstack. I have worked with drizzle database as a part of gsoc. I would like to contribute to trove. Can anybody suggest some beginner level tasks?17:26
*** SnowDust has joined #openstack-trove17:28
esphello aj_ you probably want to talk to hub_cap for tasks but have had a chance to look through the wiki and set up your environment yet?17:31
espaj_: https://wiki.openstack.org/wiki/Trove https://wiki.openstack.org/wiki/Trove#Installation_and_Deployment17:34
juiceashestakov_: what is the latest with the many flavors of flavor17:35
ashestakov_juice: mean?17:35
juicejust wondering where you are at with getting some consistency on our use of flavor17:36
juiceref vs id vs uuid17:36
ashestakov_as i checked, trove gets id from flavorRef and pushes to nova, i not sure why trove have deals with refs17:37
ashestakov_i propose to change apischema to allow uuid instad/addition to refs17:38
ashestakov_and remove validation on list17:38
juicefor backwards compatibility it would need to be "in addition to"17:38
cweidHey are any of you having troubles using the default redstack setup? All of my instances keep falling into ERROR status. It seems to be related to a volume prov error. Here is the gist https://gist.github.com/cweidenkeller/673214817:39
cweidNot sure if any of you have seen that before I am just stumped..17:39
ashestakov_cweid: can you look to cinder logs?17:41
ashestakov_juice: flavors get method is not implemented in cli, why?17:41
juiceoversite17:42
juiceor is that oversight17:43
ashestakov_juice: so we can skip validation in flavors list17:43
juiceare there any parameters for flavor list17:43
ashestakov_no17:44
ashestakov_it gets flavors from nova as is17:44
juiceso there would be no validation on that17:44
juiceashestakov_: so i was just reviewing nova's api and at least through the cli there is no exposure of the UUID for the flavor17:49
ashestakov_https://github.com/openstack/python-novaclient/blob/master/novaclient/v1_1/flavors.py#L13317:51
ashestakov_hub_cap vipul SlickNik around?17:53
vipulashestakov_: what's up17:54
ashestakov_vipul: can you start to review my changes for service_types?17:54
vipulashestakov_: Yes I can take a look today17:54
juiceashestakov_: there is also not a uuid field in the "instance_types" (flavor) table in nova17:54
juiceashestakov_: have you tried passing in "auto" to see if this indeed does what the documentation says it will do?17:56
ashestakov_juice: yep, you should specify flavor object, which can be retrived here https://github.com/openstack/python-novaclient/blob/master/novaclient/v1_1/flavors.py#L11217:56
ashestakov_here is my flavors17:58
ashestakov_nova flavor-list17:58
ashestakov_+--------------------------------------+---------------+-----------+------+-----------+------+-------+-------------+-----------+17:58
ashestakov_| ID                                   | Name          | Memory_MB | Disk | Ephemeral | Swap | VCPUs | RXTX_Factor | Is_Public |17:58
ashestakov_+--------------------------------------+---------------+-----------+------+-----------+------+-------+-------------+-----------+17:58
ashestakov_| 1                                    | m1.tiny       | 512       | 0    | 0         |      | 1     | 1.0         | True      |17:58
ashestakov_| 2                                    | m1.small      | 2048      | 20   | 0         |      | 1     | 1.0         | True      |17:58
ashestakov_| 3                                    | m1.medium     | 4096      | 40   | 0         |      | 2     | 1.0         | True      |17:58
ashestakov_| 5                                    | m1.xlarge     | 16384     | 160  | 0         |      | 8     | 1.0         | True      |17:58
ashestakov_| 7b67e99a-4289-48d7-819f-e55875343e05 | m1.small_disk | 1024      | 10   | 1         |      | 2     | 1.0         | True      |17:58
ashestakov_| 91961aa7-ab31-429c-8d8f-8578d0cc213c | m1.large      | 8192      | 80   | 1         |      | 4     | 1.0         | True      |17:58
ashestakov_+--------------------------------------+---------------+-----------+------+-----------+------+-------+-------------+-----------+17:58
juiceashestakov_: there's the proof :)17:58
juiceok well it seems that you do INDEED need to open up the flavor show to allow for uuid type17:59
ashestakov_i just want to use it, i can specify href on instance create, but why i cannot specify just uuid17:59
juicechange it in two places - change it in instance create AND flavor show17:59
ashestakov_and as i said before trove-cli flavor list fails on my env18:00
juiceas it does on mine18:01
juiceand I do not have UUIDs for flavor IDs - so there must be something else going on18:01
juicelooks like you may have found yourself a bug to fix :)18:02
juiceashestakov_: hold that last comment - my trove/nova env is not in a stable state.18:03
*** krow has joined #openstack-trove18:03
ashestakov_juice: when you do edit flavor in horizon, do it change id to uuid on you env?18:04
juiceashestakov_: i only use the cli or curl directly.  I haven't used horizon in some time18:05
juicealso after restarting my trove/nova stack, I can successfully get the flavors from trove cli18:05
hub_capashestakov_ hey im around, and plz gist stuff like that lol18:06
ashestakov_hey, sure :)18:07
hub_capso yes horizon is putting flavors as uuid's18:07
hub_capits not necessary persay, but horizon is18:07
hub_capso as long as it doesnt break compatibility we sholud be able to lift the "ban" on string (uuid) for flavor id18:07
juiceashestakov_: confirmed that flavor with UUID ID will cause flavor list to choke18:07
ashestakov_there is issue with flavor tests...18:10
hub_capthere are probably multiple issues w/ the app18:10
hub_capweve always behaved like the flavors are ints18:10
hub_capif horizon is inserting them as uuid's i think its safe to assume thats the "expected behavior" in openstack now18:10
ashestakov_it creating fake flavor in fake nove with id of int, but when it gets id from flavorRef="https://localhost:8779/v1.0/2500/flavors/1" - value is string, and couldnt be found18:11
juiceashestakov_: look at flavor/views.py line 34 - that's not good18:11
juicehub_cap: ashestakov_: it is all stored as varchar but it either expects and int or "auto" which it then generates a UUID18:12
ashestakov_juice: i fixed that one in my change18:13
*** dmakogon__ has quit IRC18:14
*** dmakogon_ has quit IRC18:14
hub_capauto is a trove thing right?18:15
*** ppenjoy has joined #openstack-trove18:15
*** dmakogon_ has joined #openstack-trove18:15
ppenjoyhi guys I have  volume that is stock in Deleted in horizon  , how can I delete it ?  here my database : http://paste.openstack.org/show/47611/  the record is : c4b1212b-0257-492b-b6bb-9cec09562e2118:15
*** dmakogon__ has joined #openstack-trove18:15
ashestakov_looks like flavor id should be always string18:16
ashestakov_hub_cap: auto?18:16
hub_cap"auto" being the option to store the varchar (what juice said)18:17
ashestakov_do you mean in novaclient on flavor create?18:18
juiceyes18:20
juicei just tried creating a flavor with an ID value = "bobcat" and nova didn't complain18:20
juiceso basically it CAN be anything18:20
juicedo we want to ALLOW anything is the question18:21
ashestakov_not anything, only id, uuid, refs18:21
juicehaving said that, if nova does not place any restriction and we do, we will caused impedance mismatches18:21
juice./redstack nova-client flavor-create jrh.xl bobcat 512 1 118:22
juicenova created the flavor for me just fine18:22
cweidYeah so if you disable trove_volume_support everything works ok.18:22
cweidGonna dig into the cinder logs to see what is shakin'18:22
cweidI assume this is a problem with devstack.18:23
*** dmakogon__ has quit IRC18:24
SnowDusthub_cap: can u help me with the concept of "heatkey" in /trove/trove/taskmanager/models.py18:24
*** dmakogon_ has quit IRC18:24
ashestakov_there is question, should we support id as int(), maybe just string with number?18:24
*** krow has quit IRC18:24
*** dmakogon_ has joined #openstack-trove18:24
SnowDustor anyone else there ?18:25
SnowDustits been a FRY DAY since i started looking at HEAT ..in trove !18:26
SnowDustanyone thr to help me ..save my skin :)18:27
yogeshmehraSnowdust: i can help you18:27
SnowDust:) omg !18:27
yogeshmehraGot through it...18:27
SnowDustkewl18:27
SnowDustlets take it private then18:28
yogeshmehrayup18:28
juiceashestakov_: my opinion is that we should not restrict it at all but document it as either a UUID or Int (without validation).18:29
ashestakov_juice: can you link me this doc?18:30
hub_capSnowDust: hi18:30
*** tanisdl has joined #openstack-trove18:30
dmakogon_hi 2 all18:31
dmakogon_guys, does anyone knows what happaning with jenkins ?18:31
dmakogon_today it failed a lot time18:32
hub_capdmakogon_ yes the gate is failing pretty steadily18:32
hub_capthere are 2 critical bugs causing almost every gate to fail18:32
hub_caphttp://status.openstack.org/rechecks/18:32
dmakogon_gates are not failing18:32
openstackgerritDan Nguyen proposed a change to openstack/trove: Fixed method signature _create_server_volume_heat  https://review.openstack.org/4853518:32
ashestakov_hub_cap: can you start to review service types?18:32
hub_capand they are asking to not recheck (as per a email)18:32
hub_capashestakov_ sure18:32
hub_capcan u link it to me?18:32
juiceashestakov_: https://github.com/openstack/database-api/tree/master/apidocs18:33
juicethere is also a dbapi repo somewhere18:33
ashestakov_hub_cap: i just want to follow fail-fast strategy :)18:33
dmakogon_hub_cap: gates are not starting18:33
hub_cap+1 ashestakov_18:33
hub_cap:)18:33
dmakogon_hub_cap: almost all day18:33
hub_capthey are overloaded18:33
juiceashestakov_: here https://github.com/openstack/database-api/blob/master/openstack-database-api/src/markdown/database-api-v1.md18:33
hub_caphttp://status.openstack.org/zuul/18:33
ashestakov_juice: so, there id is string18:34
ashestakov_and we should not use int()18:35
SnowDusthub_cap : :) good to see u back .. !18:35
SnowDusti wanted to ask / share a  bug in trove/trove/taskmanager/models.py18:35
hub_capSnowDust: i know ive been gone for a while geeeeeez :P18:36
hub_capSnowDust: what is it?18:36
*** djohnstone has quit IRC18:36
*** djohnstone has joined #openstack-trove18:36
SlickNikhey guys.18:36
hub_capashestakov_ i think we had a reason to do that a while ago (but im not sure if its a valid reason... i think it was a rackspace reason based on bugs in the QE depbartment)18:37
hub_cap*department18:37
SnowDust_create_server_volume_heat called with 6 arguments18:37
SnowDustbut defined with 518:37
SnowDustAZ  in call is extra ..18:37
ashestakov_hub_cap: can we change it to string now?18:37
juicehey slicknik18:37
SnowDusti didnt know the intention so could not file / fix  that ..18:37
hub_capSnowDust: thats a bug18:37
hub_capi saw a review for it18:37
hub_caphttps://review.openstack.org/#/c/48535/18:38
hub_capthat one right?18:38
hub_caphttps://review.openstack.org/#/c/48535/2/trove/taskmanager/models.py SnowDust18:38
SlickNikWanted to mention that I'm gonna be out most of the day today.18:38
hub_capok i have to go get lunch.. ill be back in ~30 min18:38
hub_capcool SlickNik im just getting back lol (after lunch)18:39
SnowDusthmm ..18:39
SnowDustso AZ got included ..18:39
ashestakov_hub_cap: https://review.openstack.org/#/c/47934/18:39
ashestakov_hub_cap: https://review.openstack.org/#/c/47936/18:39
hub_capthx ashestakov18:39
ashestakov_i added tests to client, but pypy and py33 fails18:40
hub_capSnowDust: its a new review from esp it just got uploaded last night18:40
ashestakov_not sure coz my changes18:40
hub_capashestakov_ check other reviews18:40
hub_capi dont think we gate pypy and py33 yet18:40
hub_capok im going18:40
hub_capto lunch!!!!18:40
hub_capill be back in ~3018:40
SnowDustyeah .. i shared that 24 hours ago :)18:40
hub_capahhhhhhhhhhh SnowDust nice thank you!18:40
esphub_cap: eat something healthy18:40
*** ppenjoy has left #openstack-trove18:41
dmakogon_guys, please, take a look https://review.openstack.org/#/c/4572318:41
dmakogon_and this https://review.openstack.org/#/c/45708/18:41
dmakogon_https://review.openstack.org/#/c/47541/18:41
dmakogon_https://review.openstack.org/#/c/47543/18:42
SnowDustyes .. eat healthy :)18:42
dmakogon_https://review.openstack.org/#/c/45075/18:42
espSnowDust: sorry about that bug, that was bad.  I missed it original patch.18:42
SnowDustesp: welcome .. sweat and "heat" .. both worthy :)18:44
espSnowDust: lol18:44
*** adrian_otto has quit IRC18:44
SnowDustesp and hub_cap .. we havent documented the "heatkey" thing anywhere ..18:46
SnowDusteven not in the code ..18:46
SnowDustno one knows by reading code that there should be a keypair with name "heatkey" to make HEAT work18:47
SnowDustpls correct me if i am wrong18:47
dmakogon_guys, have you ever though about replacing exec-style code in guestagent/pkg.py to python-apt, python-yum code ?18:47
espSnowDust: yeah I didn't know much about it.  but got help from Ilya Sviridov18:48
SnowDustyeah .. can we NOW .. do some comments in code atleast :)18:48
SnowDustit was a good joyride ..4 me .. around heatkey18:48
espdmakogon: not sure anyone has looked into that as far as I knw18:49
yogeshmehrasnowdust: http://docs.openstack.org/developer/heat/getting_started/on_devstack.html18:50
espyogeshmehra: nice!18:50
yogeshmehrathis describes heatkey but within heat standalone, out of trove18:50
dmakogon_esp: https://blueprints.launchpad.net/trove/+spec/provide-improved-guestagent-packaging-install-system-without-execs18:50
dmakogon_but i've got some issues with user permissions18:51
dmakogon_if anyone would like to help, it would be appreciable18:52
espprobably a good topic for the next meeting or mailing list :)18:55
dmakogon_esp: probably18:59
espin generally seems like a good improvement though.  I just don't know enough about that part of the code.19:00
dmakogon_esp: it is enough easy19:03
*** vipul is now known as vipul-away19:03
dmakogon_esp: just package managing execs19:03
dmakogon_sudo apt-get install, sudo yum install19:03
espyep19:04
espdoesn't seem too bad19:04
dmakogon_execs in code is not so good19:04
dmakogon_non-production style19:04
datsun180biirc it's rsynced in or baked into the image, but packaging opens the door for upgrades for example19:13
datsun180bstress on "iirc"19:16
SnowDustbye@buddies19:20
SnowDustthnx all19:20
dmakogon_datsun180b: +1 for upgrades19:22
*** amcrn has joined #openstack-trove19:29
*** SnowDust has quit IRC19:33
*** amytron has quit IRC19:33
*** jmontemayor has quit IRC19:45
*** djohnstone1 has joined #openstack-trove19:51
openstackgerritAndrey Shestakov proposed a change to openstack/trove: Add support of UUID in flavors Removed int() conversion from flavors  https://review.openstack.org/4873519:51
*** djohnstone2 has joined #openstack-trove19:53
*** djohnstone2 has left #openstack-trove19:53
*** djohnstone has quit IRC19:53
*** djohnstone1 has quit IRC19:55
*** Barker has quit IRC19:57
cp16nethrm i dont understand why changing the flavors to strings20:00
cp16netdoes not compute to me20:00
cp16netashestakov_: can you explain?20:00
cp16neti caught part of the convo i think about horizon20:00
*** vipul-away is now known as vipul20:01
cp16netvipul: hello20:01
ashestakov_cp16net: we discussed before20:01
ashestakov_cp16net: nova uses strings for id/uuid, and is not possible to convert uuid to int()20:02
cp16netashestakov_: so this is specifically around flavors right?20:03
cp16netfrom the change i see20:03
ashestakov_cp16net: yes20:03
cp16netbut trove handles its own flavors20:03
cp16netdo flavors have uuid's that nova expects?20:04
ashestakov_cp16net: own flavors?20:04
ashestakov_cp16net: https://github.com/openstack/trove/blob/master/trove/flavor/models.py#L40 it gets flavors from nova20:05
cp16netdid something change?20:06
cp16neton the nova side?20:07
ashestakov_cp16net: nova uses uuid in some cases, but trove doesnt supports it20:07
ashestakov_please read chat log about this20:08
hub_capya we need to make sure the flavor/service_type code is also updated to accept this20:08
cp16neti see that nova flavors are "strings"20:08
cp16netof integers20:08
amcrnashestakov_: Either the bug and/or the patch-set commit message should explain this, that way you don't have to refer people to chat logs :)20:09
juicecp16net: there is no restriction on what nova accepts for flavors20:10
juiceit is by CONVENTION only that we have seen only integer-compatible values and uuids20:10
cp16netso i recall reading something about setting any flavor id you want?20:12
juiceyes you can specify any value for a flavor id20:12
cp16nethmm is that considered the expected behavior of nova flavors?20:13
juiceI was suggesting that since flavors are managed by nova AND that nova place zero restriction on the flavors that we (trove) as consumers should not enforce validations on it20:13
yogeshmehrajuice: +120:13
cp16netjuice: right i agree20:13
cp16neti am not wondering if that is expected from nova though20:14
cp16neti've just not heard of that behavior before and curious about the motivation20:14
cp16netfor having id='goofy werid flavor name that is really an id'20:15
juicecp16net: can't say for certain whether this is by design in nova.20:18
cp16netjuice: how did you create your own id for a flavor?20:18
juicenova flavor-create <name> <id> <ram> <disk> <?>20:19
juiceid is required - the only special feature is that if you specify the string "auto" it will generate a UUID for that value20:20
juiceother than that, it's all fair game20:20
cp16nethmmm weird20:20
*** dmakogon_ has quit IRC20:20
cp16netok20:21
cp16netso i think that makes sense to me20:22
juiceif they ever put validation on the flavor then we can do likewise or just pass through to their validation.20:23
juicealso, I was suggesting that we don't advertise "crazy ass flavor id" value in the documentation and keep all examples with ints or uuid20:24
ashestakov_i think we should make validation easy, just type: string, len:...20:24
hub_capcp16net: fwiw, horizon ui is, by default, creating uuid backed flavors20:26
cp16netoh that makes sense why its showing up there20:27
cp16neti found this... https://github.com/openstack/trove/commit/b93ea02cf9de6a9b206d4116f6ba7c243001e77520:28
cp16neti was trying to cross reference the reason we did this20:29
hub_capright cp16net and i think i had to revert something w/ it20:29
cp16nethttps://github.com/openstack/trove/commit/c8c788e92dfd0d781d5bcfb506b92462b3ef9ae020:30
hub_caphrm maybe it wasnt this20:30
cp16netyeah i dont want to cause a contract change20:31
*** jodom has joined #openstack-trove20:31
cp16netthats all i can see20:32
cp16netit seems like we should support ints as well as the strings20:33
hub_capya well its not a contract change20:33
cp16netjust the comm between nova and trove should use strings20:33
cp16netfor flavors20:33
hub_capif it was "dissalowing" it, id see it as a contract change20:33
cp16nethttps://review.openstack.org/#/c/48735/1/trove/common/apischema.py20:33
hub_capbut it is, technically removing validation for a int20:33
cp16netthat is removing the integrations20:33
cp16neterrr...20:33
cp16netintegers20:33
*** adrian_otto has joined #openstack-trove20:34
hub_capjuice: can we do int|uuid in jsonschema?20:34
juicewe can do that but keep in mind this isn't a json request its just a url GET20:34
cp16netmaybe even just cast the input to str to be sure it is throughout the rest of the system20:34
cp16neti see in the tests all the api inputs changed to strings20:35
hub_capjuice: im talking about passing it in to the create20:35
juiceinstance create?20:35
hub_capim asuming json schema is validating its an int ya?20:35
hub_capsure flavor_id=some-uuid20:35
*** jrodom has quit IRC20:36
juicewe can def open up the validation in instance create20:36
hub_capso to me, thats the only validation we should have20:36
hub_capthe rest is just, as juice said, url's20:36
cp16netyeah20:36
cp16netthat makes sense20:36
juicehub_cap: ashestakov_ and I were mostly looking at the flavor controller which handles the flavor list/show commands20:36
juicewe have validations in there that cast the value to int20:37
juicewe also have a conversion in the flavor/view which takes all ids and converts them to ints20:37
ashestakov_juice: i fixed it in my change20:37
ashestakov_https://review.openstack.org/#/c/48735/20:38
*** aj_ has quit IRC20:38
ashestakov_but i forgot about sql schema20:38
juiceashestakov_: i understand but I was just giving hub_cap the complete footprint of flavor ids in our API20:38
juiceashestakov_: where do we keep flavor_id in our db (not nova's db)?20:38
ashestakov_juice: in instance table20:39
ashestakov_its int(11)20:39
juiceis that ID for the nova.instance_type.id (which is also int) or is that supposed to be nova.instance_type.flavorid20:41
juicethe latter being varchar20:41
juicelooks like it is supposed to be mapped to instance_types.flavorid (varchar)20:42
juicewhich means that field would need to change as well20:42
cp16netyeah looks like it20:43
hub_capashestakov_ also there is another change for service_types/flavors, im sure its an int too20:45
yogeshmehraservicetype/flavor mapping takes it as int right now20:45
ashestakov_hub_cap: where?20:45
hub_capits not merged20:46
hub_capwe will jsut have to notify the developer20:46
yogeshmehrano, it is abanodoned anyways coz we redefined the "Registration" based strategy20:46
yogeshmehrai'll let sushilKM know20:46
hub_capyogeshmehra: cool20:46
hub_capyogeshmehra: i also got a ping from jaishanker, who is offline now20:46
hub_capto talk about https://review.openstack.org/#/c/41024/20:47
hub_capcan you tell him that we should maybe clean up the versions code instead of testing stuff that we may not be using?20:47
yogeshmehrayeah, he wanted some details around it...lemme check20:47
hub_caphttps://github.com/openstack/cinder/blob/master/cinder/version.py20:47
yogeshmehratrue,20:47
hub_capits considerably different20:47
yogeshmehraok...20:48
yogeshmehrai'll see to it20:48
hub_cap<320:48
yogeshmehrahub_cap: slight digression...20:48
yogeshmehrathe heat based instance creation...20:49
yogeshmehramy instance never comes ACTIVE... :-)20:50
yogeshmehrastuck in BUILD20:50
datsun180byogeshmehra: shot in the dark, wonder if your instance can't get a line out20:50
datsun180bsudo iptables -t nat -A POSTROUTING -s 10.0.0.0/24 -o eth0 -j MASQUERADE look familiar?20:51
ashestakov_just for clarity, ill replace field type in db and remove validation from flafors except string(255) ?20:51
amcrnyogeshmehra: what does first-boot.log show on the guest? I had the same issue, and it was because the guest image was old and didn't have the heat-client dependency20:51
yogeshmehraamcrn: this is a complete fresh build20:52
amcrnah, disregard then :)20:52
yogeshmehrasudo iptables..yeah all done20:52
datsun180bthat's from the host and not the instance, right20:53
ashestakov_hub_cap: juice cp16net ?20:54
datsun180bthe telltale sign in the guestagent log would be that apt-get update failed and timed out20:54
juiceyes ashestakov_?20:54
juiceoh I see20:54
juiceyes but it also sounds like hub_cap wants to put UUID validation on the instance create for flavor id20:55
juicecurrently we have int and ref20:55
ashestakov_its done now in current change20:55
juicebut I don't know if it is worth having any validation on flavor list/show since it is pass through and read-only20:55
juicebut if you create a flavor in nova that does not conform to uuid or int, then you cannot use it to create an instance in trove20:56
ashestakov_yep20:56
juicekinda quirky but this is probably a corner case20:56
ashestakov_i think if nova going this way, we should support it20:57
juiceoh and ashestakov_ you are also removing the conversions in the views for flavor yes?20:57
ashestakov_yes20:57
ashestakov_hub_cap?21:01
juiceashestakov_21:02
juicelooks like hub_cap is busy21:03
juicego ahead and make the changes21:03
cp16netjuice: ashestakov_ i am on board with the change as long as it doesnt stop the instance create/resize from working with ints if passed in from the api21:03
juiceworst case is we have to remove the validations around flavor_id in instance create.  adding one validation for UUID to the existing set is straightforward21:03
cp16neti notcied that you removed the integer schema and that raised a flag to me21:04
juicenope it won't do that cp16net so we are good there21:04
cp16netjuice: ok21:04
cp16netthen i guess i was all concerned over nothing...21:05
cp16net:-P21:05
cp16netnot the first time...21:05
ashestakov_hm, how it will upgrade table field?21:05
juiceit's friday - your nerves are probably frazzled21:05
cp16nethahah21:05
juiceyou need to create a db migration for that21:05
ashestakov_yep, but should it convert existing rows to varchar?21:06
juiceit will need to since this can be applied to an existing db21:08
juicecan you do an alter table and change the datatype for a column?21:09
ashestakov_i think it can, but is it possible to convert int data to varchar?21:10
*** pdmars has quit IRC21:10
*** rnirmal has quit IRC21:11
*** robertmyers has quit IRC21:11
juicesure just not the other way around … in all cases21:11
ashestakov_ok, will research and do tomorrow or monday, i falling sleep now21:13
ashestakov_have good day and weekend :)21:13
*** ashestakov_ has quit IRC21:14
*** vipul is now known as vipul-away21:15
*** jcru has quit IRC21:17
*** vipul-away is now known as vipul21:28
*** yogeshmehra has quit IRC21:53
*** yogesh has joined #openstack-trove21:54
*** dmakogon has quit IRC21:56
*** dmakogon has joined #openstack-trove21:56
*** yogesh has quit IRC21:58
*** yogesh has joined #openstack-trove21:58
*** yogesh has quit IRC22:03
hub_capwhew back22:05
datsun180bhub_cap: just in time for all of the austin office to be gone22:11
hub_capLOL22:11
hub_captook niece to the airport22:11
datsun180bthink i'll take off now too, got conductor just about where i want it now22:12
hub_capnoice22:12
hub_capjuice: yall finished talking about the stuff above?22:13
datsun180bgot the rpc stuff nailed down, but 1. it appears the hb are only happening every 3 minutes and 2. can't seem to connect to the db, have to track that down22:13
datsun180bat least next week i'll have an update worth looking at so i can get some help22:14
*** adrian_otto has quit IRC22:14
*** paul_lodronio has left #openstack-trove22:15
hub_capsweet22:18
hub_capgreat news datsun180b22:18
datsun180bi think i'm just missing the db creds, i've got the connection details in the conf so i'll have to figure out what other parts of the rain dance i'm missing22:18
espdatsun180b: nice!22:19
datsun180band i need to figure out why conductor's only acting every 3 minutes22:19
datsun180bbut that's work for some sucker with my name come monday morning! have a good weekend22:22
*** datsun180b has quit IRC22:22
*** jrodom has joined #openstack-trove22:31
juicehub_cap: yes we are22:49
juicewait there was one question outstanding22:50
juiceyou want to still keep the restriction on flavor_id to uuid or int or full ref while used in the context of instance create, correct?22:50
hub_capwell...22:53
hub_capi mean nova will barf if we dont pass it something22:53
hub_capthat it knows about22:53
hub_capso maybe we dont put a restriction at all22:53
*** jrodom has quit IRC22:55
*** amcrn has quit IRC23:38
*** KennethWilke has quit IRC23:53
*** yogeshmehra has joined #openstack-trove23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!