Tuesday, 2013-10-22

*** vipul-away is now known as vipul00:10
*** matsuhashi has joined #openstack-trove00:21
*** yogeshmehra has quit IRC00:35
*** shakayumi has quit IRC00:36
*** jrodom has quit IRC00:41
*** shakayumi has joined #openstack-trove00:42
*** tanisdl has quit IRC00:46
*** nosnos has joined #openstack-trove00:52
*** jrodom has joined #openstack-trove00:53
*** radez_g0n3 is now known as radez01:01
*** haomaiwang has joined #openstack-trove01:12
*** adrian_otto has quit IRC01:12
*** yidclare has quit IRC01:13
*** erkules_ has joined #openstack-trove01:18
*** erkules has quit IRC01:20
*** jrodom has quit IRC01:38
*** haomaiwang has quit IRC01:39
*** SlickNik has quit IRC01:42
*** SlickNik has joined #openstack-trove01:43
*** mmcdaris has quit IRC01:50
cp16netyeah that hub_cap guy wont see this either. :-P02:03
hub_capbish plz02:03
*** jasonb365 has joined #openstack-trove02:05
*** haomaiwang has joined #openstack-trove02:06
cp16nethah02:10
cp16net<3 you02:10
hub_cap:P02:14
*** SlickNik has quit IRC02:14
jasonb365late night love?02:14
*** SlickNik has joined #openstack-trove02:15
*** radez is now known as radez_g0n302:16
hub_capjasonb365: hey.. 3's a crowd ;)02:22
*** krow has joined #openstack-trove02:23
openstackgerritKui Shi proposed a change to openstack/python-troveclient: Fix unicode issue  https://review.openstack.org/5195402:25
*** SushilKM__ has joined #openstack-trove02:52
*** SushilKM__ has quit IRC03:06
*** citizengrey has joined #openstack-trove03:09
*** SushilKM__ has joined #openstack-trove03:21
*** SushilKM__ has quit IRC03:25
*** krow has quit IRC03:26
*** krow has joined #openstack-trove03:31
*** krow has quit IRC03:35
*** adrian_otto has joined #openstack-trove03:37
*** krow has joined #openstack-trove03:38
*** amytron has joined #openstack-trove03:49
*** haomaiwang has quit IRC04:07
*** haomaiwang has joined #openstack-trove04:08
*** jasonb365 has quit IRC04:11
*** haomaiwang has quit IRC04:12
*** krow has quit IRC04:14
*** jasonb365 has joined #openstack-trove04:16
*** amytron has quit IRC04:16
*** krow has joined #openstack-trove04:33
*** krow has quit IRC04:46
*** krow has joined #openstack-trove04:56
*** amytron has joined #openstack-trove05:00
*** adrian_otto has quit IRC05:01
*** haomaiwang has joined #openstack-trove05:01
*** matsuhashi has quit IRC05:01
*** matsuhashi has joined #openstack-trove05:02
*** matsuhashi has quit IRC05:02
*** matsuhashi has joined #openstack-trove05:03
*** haomaiwang has quit IRC05:03
*** SlickNik has quit IRC05:07
*** SlickNik has joined #openstack-trove05:08
*** haomaiwang has joined #openstack-trove05:11
*** dmakogon has joined #openstack-trove05:21
*** jasonb365 has quit IRC05:24
*** vipul has quit IRC05:25
*** vipul has joined #openstack-trove05:26
*** amytron has quit IRC05:31
*** ashestakov has joined #openstack-trove05:34
*** matsuhashi has quit IRC05:35
*** matsuhashi has joined #openstack-trove05:36
*** matsuhashi has quit IRC05:36
*** matsuhashi has joined #openstack-trove05:37
dmakogonvipul, ping05:38
*** ashestakov has quit IRC05:39
*** haomaiwang has quit IRC05:39
*** haomaiwa_ has joined #openstack-trove05:39
dmakogonvipul, i've answered to you complains about guestagent refactoring, it would be nice to hear anything from you)))05:39
*** juice__ has joined #openstack-trove05:40
*** juice__ has quit IRC05:40
*** juice__ has joined #openstack-trove05:41
*** juice__ has quit IRC05:42
*** SushilKM__ has joined #openstack-trove05:46
*** yogeshmehra has joined #openstack-trove05:46
*** SushilKM__ has quit IRC05:50
*** haomaiwang has joined #openstack-trove05:57
*** haomaiwa_ has quit IRC06:00
*** vipul is now known as vipul-away06:00
*** ashestakov has joined #openstack-trove06:03
*** yogeshmehra has quit IRC06:04
*** vipul-away is now known as vipul06:05
dmakogonvipul, have you read that ?)))06:07
*** SlickNik has quit IRC06:14
*** SlickNik has joined #openstack-trove06:15
*** yogeshmehra has joined #openstack-trove06:16
*** haomaiwa_ has joined #openstack-trove06:17
*** krow has quit IRC06:20
*** haomaiwang has quit IRC06:21
*** krow has joined #openstack-trove06:25
*** PradeepChandani has joined #openstack-trove06:25
*** mmcdaris has joined #openstack-trove06:32
*** haomaiwang has joined #openstack-trove06:48
*** haomaiwa_ has quit IRC06:52
*** krow has quit IRC07:10
*** krow has joined #openstack-trove07:24
*** ashestakov has quit IRC07:25
*** haomaiwang has quit IRC07:54
*** yogeshmehra has quit IRC07:57
*** SushilKM__ has joined #openstack-trove08:25
*** ashestakov has joined #openstack-trove08:47
*** ppenjoy has joined #openstack-trove09:07
*** ppenjoy has left #openstack-trove09:07
*** haomaiwang has joined #openstack-trove09:33
*** haomaiwang has quit IRC09:44
*** radez_g0n3 is now known as radez10:00
*** krow has quit IRC10:29
*** erkules_ is now known as erkules10:32
openstackgerritDenis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database  https://review.openstack.org/5266610:37
*** dukhlov has joined #openstack-trove10:38
*** krow has joined #openstack-trove11:00
*** haomaiwang has joined #openstack-trove11:00
*** krow has quit IRC11:08
*** radez is now known as radez_g0n311:14
*** krow has joined #openstack-trove11:36
*** krow has quit IRC11:45
*** pdmars has joined #openstack-trove12:03
*** krow has joined #openstack-trove12:12
*** krow has quit IRC12:16
*** demorris has joined #openstack-trove12:17
*** nosnos has quit IRC12:27
*** nosnos has joined #openstack-trove12:28
*** haomaiwa_ has joined #openstack-trove12:28
*** demorris has quit IRC12:30
*** haomaiwang has quit IRC12:31
*** nosnos has quit IRC12:32
*** krow has joined #openstack-trove12:43
*** krow has quit IRC12:47
*** jcru has joined #openstack-trove12:54
*** amytron has joined #openstack-trove12:56
*** kevinconway has quit IRC12:56
*** kevinconway has joined #openstack-trove13:05
*** robertmyers has joined #openstack-trove13:09
*** krow has joined #openstack-trove13:31
openstackgerritDenis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database  https://review.openstack.org/5188413:32
openstackgerritDenis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database  https://review.openstack.org/5188413:33
*** krow has quit IRC13:35
*** Barker has joined #openstack-trove13:36
*** adrian_otto has joined #openstack-trove13:49
*** radez_g0n3 is now known as radez13:58
*** mmcdaris has quit IRC14:02
*** demorris has joined #openstack-trove14:04
*** SushilKM__ has quit IRC14:06
*** krow has joined #openstack-trove14:12
*** jasonb365 has joined #openstack-trove14:20
*** krow has quit IRC14:21
openstackgerritDenis M. proposed a change to openstack/trove: Security groups workflow update  https://review.openstack.org/5094414:30
*** datsun180b has joined #openstack-trove14:37
*** Nate2 has quit IRC14:39
*** Nate1 has joined #openstack-trove14:42
*** krow has joined #openstack-trove14:42
*** datsun180b has quit IRC14:44
*** datsun180b has joined #openstack-trove14:44
datsun180bsheesh, we have two pages of reviews14:44
*** krow has quit IRC14:47
openstackgerritDenis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database  https://review.openstack.org/5188414:50
*** matsuhashi has quit IRC14:58
*** matsuhashi has joined #openstack-trove14:59
*** jasonb365 has quit IRC15:00
away_dudehub_cap, if we are going to use only heat, why do we need to use dib, we can use heat image builder with help of jeos15:02
*** jasonb365 has joined #openstack-trove15:03
*** matsuhashi has quit IRC15:03
*** jmontemayor has joined #openstack-trove15:04
*** tanisdl has joined #openstack-trove15:09
*** radez is now known as radez_g0n315:11
*** krow has joined #openstack-trove15:13
*** radez_g0n3 is now known as radez15:14
*** krow has quit IRC15:18
*** rnirmal has joined #openstack-trove15:26
*** haomaiwa_ has quit IRC15:34
*** krow has joined #openstack-trove15:44
*** krow has quit IRC15:48
*** KennethWilke has joined #openstack-trove15:55
*** demorris has quit IRC15:58
*** grapex has joined #openstack-trove16:05
*** grapex has quit IRC16:05
*** grapex has joined #openstack-trove16:06
*** demorris has joined #openstack-trove16:06
*** SushilKM__ has joined #openstack-trove16:11
*** krow has joined #openstack-trove16:15
*** krow has quit IRC16:20
*** radez is now known as radez_g0n316:22
*** radez_g0n3 is now known as radez16:23
openstackgerritAndrey Shestakov proposed a change to openstack/python-troveclient: Support datastore types  https://review.openstack.org/4793616:25
*** dmakogon has quit IRC16:34
*** dukhlov has quit IRC16:35
*** krow has joined #openstack-trove16:45
*** yidclare has joined #openstack-trove16:46
*** rnirmal has quit IRC16:48
openstackgerritJoe Cruz proposed a change to openstack/trove: Add Backup/Restore Checksum Validation  https://review.openstack.org/5316516:50
openstackgerritAndrey Shestakov proposed a change to openstack/trove: Add support of datastore types this changes depends on new version of troveclient, which is not megged yet and tests will dont pass  https://review.openstack.org/4793416:52
ashestakovhub_cap: grapex vipul SlickNik ^ ^16:53
openstackgerritRobert Myers proposed a change to openstack/trove: Add tests for hosts mgmt commands  https://review.openstack.org/5271316:56
grapexashestakov: I'll try to look at that soon. Thanks!16:57
openstackgerritCraig Vyvial proposed a change to openstack/trove: adding configuration group support  https://review.openstack.org/5316817:00
cp16netoh shit17:00
*** ashestakov has quit IRC17:00
*** amytron has quit IRC17:03
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management  https://review.openstack.org/5316917:04
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management  https://review.openstack.org/5316917:13
*** yogeshmehra has joined #openstack-trove17:14
hub_capat a conference today, im not really here fwiw if anyone tries to get ahold of me17:15
cp16nethub_cap: ^^^17:17
juicehub_cap: can you look at 4 reviews today?17:17
cp16netbam!17:17
juice:P17:17
hub_capjuice: yes of course, hold your breath17:17
cp16netBender: This is the worst kind of discrimination - the kind against me!17:17
*** krow has quit IRC17:17
hub_capcp16net: nice. im not gonna look @ it17:18
hub_capi trust u, ill just -2 it now17:18
* juice is turning blue17:18
hub_capjuice: is becoming grapejuice17:19
*** krow has joined #openstack-trove17:21
juiceha…ha……ha - you so funny hub_cap :)17:24
* hub_cap is hilarious17:27
*** arborism has joined #openstack-trove17:28
*** arborism is now known as amcrn17:28
openstackgerritMichael Basnight proposed a change to openstack/python-troveclient: Fixing copyright and license headers  https://review.openstack.org/5317617:29
*** ashestakov has joined #openstack-trove17:29
hub_capSlickNik: vipul grapex  ^ ^ we need to get this reviewed and merged cuz of the debian ftp master email chain going out17:30
hub_capvipul:  SlickNik i only saw one 2 files w HP in the copyright. if u need to add more plz add and push to this branch quickly this am17:31
grapexhub_cap: Did auth need to move as part of this particular commit?17:36
hub_capgrapex: auth was unused. i forgot to remove it. so i guess technically not, if u like i can post a followup commit w/ it17:36
hub_capi did some cleanup along w/ the copyright "stuff"17:36
grapexhub_cap: I +2'd, but if you could make it two commits that would be cool17:37
grapexI know this has been talked about a lot on the mailing list so I don't want to impede it17:37
*** grapex has quit IRC17:40
*** Barker has quit IRC17:40
*** grapex has joined #openstack-trove17:41
*** grapex has quit IRC17:41
*** Barker has joined #openstack-trove17:41
openstackgerritMichael Basnight proposed a change to openstack/python-troveclient: Removing unused files with new client  https://review.openstack.org/5317917:48
openstackgerritMichael Basnight proposed a change to openstack/python-troveclient: Fixing copyright and license headers  https://review.openstack.org/5317617:48
vipulhub_cap: so that patch only contains the files missing the copyright?17:49
hub_capvipul: now it does17:49
hub_capi just broke it up into 2  commits17:49
hub_capthe 2nd commit removes a few files that were unused17:50
hub_capok break brb17:50
vipulhub_cap: I'll add HP copyright to files where we had some contributinos17:51
*** krow has quit IRC17:54
*** jasonb365 has quit IRC17:59
openstackgerritRobert Myers proposed a change to openstack/trove: Add tests for hosts mgmt commands  https://review.openstack.org/5271318:00
*** jasonb365 has joined #openstack-trove18:01
*** grapex has joined #openstack-trove18:02
hub_capvipul: plz do18:05
hub_capvipul: can u be present at the openstack project status meeting today for me?18:07
vipulwhen's that?18:07
hub_capvipul: 2100 UTC18:08
*** SushilKM__ has quit IRC18:08
vipulhub_cap: :p making me convert that18:08
hub_cap2pm cdt18:08
hub_capno im nice ;)18:08
vipulOk so 12 my time :P18:08
hub_capSHT18:08
hub_cappdt18:08
hub_cap2pm pdt18:08
hub_capsry18:08
vipulyou so confusing18:08
vipulok i'll be there18:08
hub_capvipul: i maaaaay be back18:09
hub_capits lunch time for the conference (well its at the end, im not 100% sure ill be around tho)18:09
hub_capif im back ill hit uup18:09
vipulyou're still at some conf?18:09
hub_capa diffrent conf18:10
hub_caplast wk was redis, this wk is ansible, im learning more than anything else at this one18:10
hub_capsry its only today18:10
vipulyea it's the latest cool kid18:10
hub_capgot a free pass, so i came... i think itll make its way into heat in some form or fashion18:10
hub_capso id like to understand it18:11
vipulcool - it's in the bay?18:11
*** amytron has joined #openstack-trove18:12
hub_capits _at_ the rax office18:12
hub_caphard to say no18:12
openstackgerritVipul Sabhaya proposed a change to openstack/python-troveclient: Fixing copyright and license headers  https://review.openstack.org/5317618:21
*** cweid has joined #openstack-trove18:31
*** SnowDust has joined #openstack-trove18:31
*** jasonb365 has quit IRC18:33
*** demorris has quit IRC18:35
*** jasonb365 has joined #openstack-trove18:36
*** mmcdaris has joined #openstack-trove18:37
SlickNikvipul: thanks for pushing out the HP copyrights.18:43
*** vipul is now known as vipul-away18:46
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management  https://review.openstack.org/5316918:56
*** jrodom has joined #openstack-trove18:58
*** mmcdaris has quit IRC19:01
*** mmcdaris has joined #openstack-trove19:02
*** adrian_otto has quit IRC19:03
*** dmakogon has joined #openstack-trove19:04
*** cweid has quit IRC19:10
*** cweid has joined #openstack-trove19:10
*** cweid has quit IRC19:13
*** cweid has joined #openstack-trove19:13
*** shakayumi has quit IRC19:18
*** shakayumi has joined #openstack-trove19:21
*** shakayumi has quit IRC19:26
imsplitbitreplication and clustering19:46
imsplitbithub_cap: ^^19:46
imsplitbitvipul-away: ^^19:46
imsplitbitSlickNik: ^^19:46
imsplitbitgrapex: ^^19:46
imsplitbiterr-body ^^19:46
imsplitbitI just want all your minds on replication and clustering19:47
openstackgerritA change was merged to openstack/python-troveclient: Fixing copyright and license headers  https://review.openstack.org/5317619:50
*** Barker has quit IRC19:56
*** Barker has joined #openstack-trove20:03
*** paul_lodronio has joined #openstack-trove20:12
ashestakovimsplitbit: wiki for clustering is true for now?20:12
dmakogonashestakov, you mean complete ?20:14
imsplitbitashestakov: it is WIP20:15
imsplitbitbut ready for discussion20:15
imsplitbitit's complete enough to start really thinking through some edge cases20:15
imsplitbitsome of the smaller calls aren't stubbed out with examples20:16
imsplitbitbut I feel like the gist of the message is clear20:16
imsplitbitso if it isn't then we can talk it out on the ML and I can clarify20:16
*** mmcdaris has quit IRC20:19
ashestakovimsplitbit: i didnt read updated version yet, but i want to know what kind of mysql replication will implemented20:26
*** demorris has joined #openstack-trove20:28
ashestakovashestakov: master-slave, master-master (active-active, active-passive), galera?20:28
ashestakovwill it support multiple replicas with master, or replica of replica20:29
*** vipul-away is now known as vipul20:31
vipulimsplitbit: So the multi-master example at the top.. how does one create that20:40
vipulimsplitbit: Is it the same as what's defined for repllication at the bottom (create instance 1, creates another instance, as separate calls)20:40
*** radez is now known as radez_g0n320:42
dmakogonvipul, hi20:43
vipulhola dmakogon20:43
dmakogonvipul, have you read my comment ?20:43
vipuldmakogon: Yes - and I am wondering why we decided against having a common interface for Guest manager20:44
vipulI am not saying we have an interface that throws NotImlemented() everywhere20:45
vipulI'm saying we have a single entry point...20:45
dmakogonvipul, what would be the value-add of suggested by you change ?20:45
vipulIt would be a contract that every typed manager would know to implement20:46
vipulcurrently.. that contract is defined for every typed manager20:46
vipulso if you're writing something for Cassandra - you look at the procedures implmeneted in mysql/manager and essentially copy them20:47
hub_capvipul: ib here20:47
vipulhub_cap: thanks dude.. saves me from going there20:47
hub_capya its gonna be planning for the summit hour20:47
hub_capmight still be worth a read20:47
vipulOk i'll be on20:47
vipuldmakogon: there are also common things.. take for example the prepare() method..20:48
dmakogonvipul, contract - https://github.com/openstack/trove/blob/master/trove/guestagent/api.py20:48
vipuldmakogon: every service needs to worry about handling the volume20:48
dmakogonvipul, we already have nice plugins in GA20:48
vipuldmakogon: tell me how you'd handle formatting, mounting a volume that's presented to the Guest, without duplicating the code in all managers20:49
dmakogonvipul, manager is atomic unit in database handling20:49
ashestakovimsplitbit: vipul: can we discuss clustering in ML?20:49
vipuldmakogon: elaborate20:50
*** demorris has quit IRC20:50
dmakogonvipul, you suggesting another layer which would not do anything, only delegates calls20:50
vipuldmakogon: for the most part yes - but it could also do common things before delegating20:51
vipuldmakogon: such as taking care of prepareing the volume for the db20:51
dmakogonvipul, with python duck-typing it would be another file, not even interface in terms of interfaces(java)20:51
*** ashestakov has quit IRC20:52
dmakogonvipul, there is one or two such functions, they could be externalized into guestagent/common20:52
dmakogonvipul, but not in whole new layer of call delegating20:53
*** Barker has quit IRC20:53
dmakogonvipul, each import by name/class/module is heavy20:53
vipulit's a one time cost though20:54
dmakogonvipul, but not we are avoiding it, be telling that datastore manager is atomic and cannot be part of something and vice versa20:55
dmakogonvipul, my typo, now we avoiding it20:56
*** jasonb365 has quit IRC20:58
dmakogonvipul, so my point is that we already have contract described by GA API, we propaply have few funtions that can be common, conclusion: we don't need another layer, we need to separate common stuff ant this common stuff is much less then threshold for a whole new layer21:00
dmakogonvipul, i can be agreed when we would have versioning21:00
dmakogonvipul, under each manager we would have to rule how to act with this on that version of datastore21:01
*** Barker has joined #openstack-trove21:01
dmakogonvipul, do we came into agreement ?21:02
vipuldmakogon: I'm ok with leaving it as is.. there is value in making a Manager self-contained21:02
vipulthere is also value in having a single entry point where common things can be handled by the framework21:02
vipulrather than having every manager have to also deal with the same problem21:03
dmakogonvipul, yes, that is what i said)21:03
dmakogonvipul, good to see that we are agreed21:03
*** pdmars has quit IRC21:04
dmakogonvipul, now there is one more thing, review21:04
vipulI won't hold up your patch on this - but I think we need to discuss maybe at tomorrow's meeting21:04
dmakogonvipul, could it pass through ?21:04
dmakogonvipul, maybe21:04
dmakogonvipul, i'll prepare some statements and would go through code to see what could be separated to common stuff of GA21:05
hub_capthere is a lot of common code, preparing the volume if psesent21:06
hub_capthe fact that it "installs", "adds configuration data", and "restarts if needed"21:06
dmakogonhub_cap, each manager has those func21:07
dmakogonhub_cap, but they are dictated by API21:07
*** SnowDust has quit IRC21:07
dmakogonhub_cap, i said that we do not need new layer of abstraction since python is duck-typing lang and has no interfaces at all21:09
hub_capnot true21:09
hub_capif we can reduce the common code ot being executed in one place, that is best21:09
dmakogonhub_cap, please explain21:09
hub_capthen you have a bug in one place rather than N, one for each service21:09
hub_capand in this case there is common code for all managers21:10
hub_capvolume being one common thing21:10
dmakogonhub_cap, hm i see21:10
hub_capif we find a bug in the volume provisioning, we have to fix it for every impl right now21:10
dmakogonhub_cap, but (!) guestagent developed that specific way when exceptions are happening in managers21:11
hub_capand if we wanted to turn off volume provisioining for a particular service that code could still reside in the common prepare code21:11
hub_capim not sure that matters... im just sayign a bug is in one place, rather than 321:11
dmakogonwith another abstract layer we would delegate wrong call to imported manager21:11
dmakogonso, we still have N errors21:11
hub_capthats another bug21:12
hub_capand it can be fixed in 1 place21:12
*** mmcdaris has joined #openstack-trove21:13
vipulhub_cap: +1 i think a single entry point is ideal21:13
dmakogonvipul, hub_cap : API layer should deal with that kind of use cases21:14
vipulwhich api layer21:14
hub_capapi layer is executed from the tasmgr21:14
dmakogonvipul, hub_cap: manager doesn't know anything about volume support at all21:15
dmakogonso, taskmanager should deal with that usecases21:15
hub_capzigo: around?21:16
hub_capdmakogon: it sends down a flag to the prepare, i believe21:16
dmakogonhub_cap, vipul: until we would not have full use cases list we don't need single entry point21:16
vipuldmakogon: taskmanager can't do anything with the volume, it's local to the guest21:16
hub_capunless u are saying the taskmgr must send sync calls to the guest to wait for a volume to provision, and then to install mysql (sync) etc21:16
hub_capis that what you mean?21:17
dmakogonhub_cap, https://github.com/openstack/trove/blob/master/trove/guestagent/api.py#L215-L21721:17
hub_capright that sends a async call to the guest21:18
dmakogonvipul, taskmanager creates volumes21:18
hub_capto do "installing"21:18
vipuldmakogon: it creates the volume via a Nova API... but it can't format / move data onto that volume21:18
hub_capwhat you are proposing when u say "taskmanager should deal with that usecases" is that the taskmgr now has to send sync messages to the guest to complete the pieces of prepare, for instance if it needs to prov a volume21:18
hub_capvipul: yes i mean to say format21:19
hub_capsry21:19
dmakogonhub_cap, how single entry point would deal with it ? how it would help /21:20
dmakogon?21:20
hub_capsec21:20
hub_caphttps://github.com/openstack/trove/blob/master/trove/guestagent/manager/mysql.py#L9621:21
hub_capthat code will be common to all prepare() methods21:21
vipulthere would be a single place where that logic would be executed... and then the remaining provisionng would be delegated to the typed manager21:21
dmakogonhub_cap, it could be done with common func, we don't need whole new layer for that21:22
hub_capand each new impl will have to copy the code from the impl before, even if its one line21:23
hub_capit still makes you have "extra" code21:23
dmakogonhub_cap, it would be separate func https://github.com/openstack/trove/blob/master/trove/guestagent/manager/mysql.py#L95-L11121:23
dmakogonhub_cap, do you agreed for that ?21:24
dmakogon*with that21:24
hub_capi agree it should be, but if now lets say we add a second thing every manager does21:24
hub_caplike port changing, for instance21:24
hub_capand installing configuration files21:25
hub_capthen u have 3 things that are, like you say, separate functions21:25
hub_capand every manager has to have all 3 as the first 3 things it does21:25
hub_capand we decide to refactor the App and AppStatus, now we have to update all the impls (im not exactly sure the state of the differences there but im just making a point)21:26
dmakogonif API supports it - managers should have it21:26
hub_capim just saying that a bunch of the logic / code in the prepare method, in particular, is common across impls21:26
*** krow has joined #openstack-trove21:27
dmakogonhub_cap, yes, i'm agree, but this is not the reason to elaborate another abstraction layer21:27
hub_capi disagree. if there is code that is common to the behavior of the guest application, it does not need to be in every impl21:28
hub_capeven as common methods21:28
dmakogonhub_cap, for now its a code re-usability issue21:28
dmakogonhub_cap, and duplicating21:28
dmakogonhub_cap, i agree with that, 100%21:29
dmakogonhub_cap, we need less code and more usage of it21:29
hub_cap++21:30
dmakogonhub_cap, seems like we finally came into suggestion, yes ?21:31
hub_capim not sure we are in agreement.. can u summarize in a gist for me? Im in the weekly openstack project meeting21:34
*** vipul is now known as vipul-away21:37
openstackgerritEd Cranford proposed a change to openstack/trove-integration: Adds conductor to redstack start and stop  https://review.openstack.org/5269321:38
*** vipul-away is now known as vipul21:39
dmakogonhub_cap, https://gist.github.com/crazymac/710870721:44
dmakogonvipul, https://gist.github.com/crazymac/710870721:44
hub_capwow vipul the design summit and the conference are 1600ft (500m) away from each other21:46
datsun180bnice use of sig figs in your conversion21:46
*** kui has joined #openstack-trove21:47
kuiHow to deal with reddwarf failure?    https://review.openstack.org/#/c/51954/21:48
hub_cap:)21:48
hub_caphi kui i can help21:48
hub_capi can restart that job21:48
datsun180bi'll retrigger if you're not already doing it21:49
hub_capdatsun180b: plz do21:49
hub_capwe were voting on one or two scheds for the conference21:49
datsun180bjust looking over the console21:49
*** yogeshme_ has joined #openstack-trove21:50
kuiThanks you21:50
datsun180b404 on a flavor 4? strange21:50
hub_capkui: thank you for contributing to troveclient21:51
hub_capive got a review that deletes xml.py and auth.py in troveclient/21:51
kuiMy pleasure21:51
hub_capbut it might land after your patches do21:51
dmakogonhub_cap, https://review.openstack.org/#/c/50944/21:51
hub_capso dont worry about updatign those21:51
dmakogonhub_cap, could you please review that one at your meeting-free time ?21:53
hub_capyes ill review today dmakogon21:53
datsun180bi didn't think hub_cap had any time he didn't spend in a meeting anymore21:53
dmakogonhub_cap, thanks for that, ;)21:53
dmakogondatsun180b, overtiming ?21:54
datsun180bsee he's not jabbing back because he's in a meeting now c:21:54
*** robertmyers has quit IRC21:54
hub_caphehe ya21:55
dmakogonok )21:55
hub_capand scheduling our summit sessions21:55
dmakogonoh, summit =(21:55
hub_capyup21:56
dmakogoncu guys tomorrow21:56
kuiShould we add description in https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures for the reddwarf failure ?21:56
datsun180bdidn't get any feedback on my proposal for "Why we in Trove are better than everyone else at everything, including kung fu"21:56
dmakogondatsun180b, it that for me ?21:56
datsun180bno that was my imaginary summit proposal21:56
dmakogonah21:57
datsun180bguess they figured i'd need more than an hour to detail why we're so great. probably need another hour just to teach everyone the theme song21:57
dmakogondatsun180b, i'd like to discuss it with blackjack and women21:58
datsun180bdmakogon: great idea! you know what, forget the summit21:58
hub_caplol21:58
datsun180bwhere's craig's <Bender> when you need him21:59
dmakogondatsun180b, probably gone ?21:59
dmakogonso, nevermind21:59
hub_capBender: Compare your lives to mine and then kill yourself!21:59
datsun180bthere we go21:59
* dmakogon gone to bed21:59
hub_capcu22:00
*** dmakogon is now known as dmakogon_sleepy22:00
*** vipul is now known as vipul-away22:00
datsun180bkui worth a shot, our "recheck no bug" is a bad habit corrected too late22:01
*** ni791393 has joined #openstack-trove22:02
kuireddwarf is separated from jenkins, "recheck no bug" has no effect for reddwarf22:03
datsun180boh you mean the job that i had to retrigger?22:03
*** ni791393 has left #openstack-trove22:03
*** amcrn has quit IRC22:03
hub_capkui: correct. we have not yet put the reddwarf tests into the -infra teams jenkins yet22:03
hub_capits my priority though to do it, but it requires a good bit of pre-work22:04
datsun180bsee if i stall enough someone who knows what they're talking about will show up22:04
datsun180bin the meantime i don't mind retriggering these things to help while i can22:04
kuiCan developer trigger reddwarf freely when there is failure ?22:04
datsun180bno, you have to be in an old group whose existence and membership are under discussion22:05
*** dmakogon_sleepy has quit IRC22:05
hub_capthey cant yet but they should be able to when we migrate to -infra running it22:05
kuiOK, got it.22:07
*** KennethWilke has quit IRC22:09
*** arborism has joined #openstack-trove22:09
*** harlowja_ has joined #openstack-trove22:10
*** yogeshme_ has quit IRC22:11
*** yogeshmehra has quit IRC22:11
*** harlowja has quit IRC22:11
*** vipul-away is now known as vipul22:12
*** arborism is now known as amcrn22:16
*** Barker has quit IRC22:23
*** paul_lodronio has quit IRC22:24
*** krow has quit IRC22:30
*** mmcdaris has quit IRC22:30
*** datsun180b has quit IRC22:34
*** harlowja_ has quit IRC22:35
*** harlowja has joined #openstack-trove22:35
*** amytron has quit IRC22:37
*** jrodom has quit IRC22:40
*** Bo_Chen has joined #openstack-trove22:47
*** harlowja_ has joined #openstack-trove22:57
*** harlowja has quit IRC22:59
*** krow has joined #openstack-trove23:00
*** krow has quit IRC23:09
*** jrodom has joined #openstack-trove23:11
openstackgerritMichael Basnight proposed a change to openstack/python-troveclient: Removing unused files with new client  https://review.openstack.org/5317923:14
*** jcru has quit IRC23:25
*** jmontemayor has quit IRC23:28
hub_capvipul: SlickNik i must go for travel back to berkeley, plz review your summit talks, and put a bit more meat and potatoes to them. ill create the etherpads and we can make sure to add topics to them. grapex ill create that etherpad for u too23:34
*** jodom has joined #openstack-trove23:34
hub_cappeace all23:34
SlickNikalright, hub_cap.23:35
SlickNiklater23:35
*** jrodom has quit IRC23:39
*** Bo_Chen has quit IRC23:42
*** yogeshmehra has joined #openstack-trove23:48
*** vipul is now known as vipul-away23:51
*** matsuhashi has joined #openstack-trove23:53
*** tanisdl has quit IRC23:54
*** vipul-away is now known as vipul23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!