*** amytron has joined #openstack-trove | 00:04 | |
*** kui has quit IRC | 00:05 | |
*** radez is now known as radez_g0n3 | 00:12 | |
*** amcrn has quit IRC | 00:28 | |
*** yogeshmehra has quit IRC | 00:35 | |
*** amytron has quit IRC | 00:41 | |
*** nosnos has joined #openstack-trove | 00:49 | |
*** adrian_otto has quit IRC | 00:52 | |
*** Bo_Chen has quit IRC | 01:02 | |
*** erkules_ has joined #openstack-trove | 01:13 | |
*** erkules has quit IRC | 01:16 | |
*** tanisdl has quit IRC | 01:28 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add optional ip address filter for hiding ips https://review.openstack.org/53766 | 01:36 |
---|---|---|
*** robertmyers has joined #openstack-trove | 01:39 | |
*** kui has joined #openstack-trove | 02:00 | |
*** kui has quit IRC | 02:00 | |
*** anteaya has quit IRC | 02:23 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add optional ip address filter for hiding ips https://review.openstack.org/53766 | 02:40 |
*** lnxnut has joined #openstack-trove | 02:43 | |
*** robertmy_ has joined #openstack-trove | 02:44 | |
*** robertmyers has quit IRC | 02:44 | |
*** haomaiwang has joined #openstack-trove | 03:01 | |
*** haomaiwang has quit IRC | 03:02 | |
*** haomaiwang has joined #openstack-trove | 03:02 | |
*** mmcdaris has joined #openstack-trove | 03:07 | |
*** robertmy_ has quit IRC | 03:16 | |
*** robertmyers has joined #openstack-trove | 03:16 | |
*** adrian_otto has joined #openstack-trove | 03:20 | |
*** robertmyers has quit IRC | 03:22 | |
*** haomaiwang has quit IRC | 03:23 | |
*** demorris has joined #openstack-trove | 03:25 | |
mordred | hub_cap: upgrade your MySQL install place | 03:56 |
mordred | please | 03:56 |
mordred | vipul: your MySQLs aren't 5.1 are they? | 03:56 |
*** demorris has quit IRC | 04:09 | |
*** erkules_ is now known as erkules | 04:12 | |
*** lnxnut has quit IRC | 04:22 | |
*** amytron has joined #openstack-trove | 04:33 | |
*** yogeshmehra has joined #openstack-trove | 04:57 | |
*** amytron has quit IRC | 05:09 | |
*** ashestakov has joined #openstack-trove | 05:19 | |
*** adrian_otto has quit IRC | 05:23 | |
*** adrian_otto has joined #openstack-trove | 05:31 | |
*** SushilKM has joined #openstack-trove | 05:44 | |
*** denis_makogon has joined #openstack-trove | 05:51 | |
*** adrian_otto has quit IRC | 05:52 | |
*** ashestakov has quit IRC | 05:58 | |
*** yogeshmehra has quit IRC | 06:07 | |
*** matsuhashi has joined #openstack-trove | 06:07 | |
*** yogeshmehra has joined #openstack-trove | 07:08 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/python-troveclient: Usage String has Positionals after Optionals https://review.openstack.org/53792 | 07:16 |
*** matsuhashi has quit IRC | 07:18 | |
*** matsuhashi has joined #openstack-trove | 07:18 | |
*** arborism has joined #openstack-trove | 07:18 | |
*** arborism is now known as amcrn | 07:18 | |
*** SnowDust has joined #openstack-trove | 07:18 | |
SnowDust | ANY REVIEWERS THERE TO HELP ? Externalisation of heat template https://review.openstack.org/53499 | 07:19 |
SnowDust | ANY REVIEWERS THERE TO HELP ? Externalisation of heat template https://review.openstack.org/53499 | 07:19 |
SnowDust | ikhudoshyn: isviridov: https://review.openstack.org/53499 | 07:32 |
SnowDust | dmakogon : https://review.openstack.org/53499 | 07:33 |
*** mmcdaris has quit IRC | 07:42 | |
SnowDust | mordred : https://review.openstack.org/53499 | 07:43 |
SnowDust | vipul : https://review.openstack.org/53499 | 07:43 |
*** mmcdaris has joined #openstack-trove | 07:43 | |
SnowDust | esp: https://review.openstack.org/53499 | 07:43 |
SnowDust | denis_makogon: https://review.openstack.org/53499 | 07:44 |
SnowDust | AGiardini: https://review.openstack.org/53499 | 07:44 |
denis_makogon | SnowDust, only one complain | 07:56 |
denis_makogon | SnowDust, we discuss it yesterday | 07:56 |
denis_makogon | SnowDust, keyname, we dont need it | 07:57 |
denis_makogon | SnowDust, would you mind to update the review | 07:57 |
denis_makogon | and then it will be finished | 07:57 |
denis_makogon | SnowDust, i suppose we are ok with that))) | 07:58 |
SnowDust | hello | 07:58 |
SnowDust | have questions .. as yesterday | 07:58 |
SnowDust | why not add port 22 in the sec group | 07:58 |
SnowDust | than removing the key | 07:58 |
SnowDust | and making the key configurable in a a new blueprint | 07:59 |
SnowDust | as i mentioned in TODO | 07:59 |
SnowDust | denis_makogon : :) plz let me know your thoughts | 08:00 |
denis_makogon | SnowDust, we discuss SSHing along time ago, and community decided to avoid usage of it | 08:01 |
denis_makogon | that is why should stay same line with others | 08:01 |
denis_makogon | until we would see huge need of it, it would not implement it | 08:02 |
denis_makogon | because, somehow it's a security breach | 08:02 |
denis_makogon | SnowDust, to be totally precise, could you give me an use-case of ssh access need while working with databases ? | 08:03 |
denis_makogon | SnowDust, i'll be available soon | 08:07 |
*** denis_makogon has quit IRC | 08:09 | |
*** yogeshmehra has quit IRC | 08:28 | |
*** SnowDust has quit IRC | 08:34 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/python-troveclient: user-list Databases Value is JSON vs a String https://review.openstack.org/53810 | 08:41 |
*** matsuhashi has quit IRC | 08:46 | |
*** matsuhashi has joined #openstack-trove | 08:46 | |
*** amcrn has quit IRC | 09:15 | |
*** matsuhashi has quit IRC | 09:34 | |
*** ashestakov has joined #openstack-trove | 09:34 | |
*** matsuhashi has joined #openstack-trove | 09:34 | |
*** matsuhashi has quit IRC | 09:39 | |
*** mmcdaris has quit IRC | 09:39 | |
*** aignatov has quit IRC | 09:45 | |
*** aignatov has joined #openstack-trove | 09:46 | |
*** SnowDust has joined #openstack-trove | 09:53 | |
SnowDust | dmakogon : there | 09:53 |
dmakogon | SnowDust, somewhere))) | 09:53 |
SnowDust | u asked about a usecase for ssh right ? | 09:53 |
SnowDust | it was security flaw when the same key was the entry point to boxes ... hardcoded | 09:54 |
SnowDust | but .. if its being generated by customer himself then its not | 09:54 |
SnowDust | thats why i told in my TODO that key should be configurable | 09:54 |
SnowDust | usecase .. is all those rainy days .. when your remoting fails ( using api ) | 09:55 |
SnowDust | but .. as the community is agains ssh .. will remove simply | 09:55 |
SnowDust | we can include it again .. :D | 09:55 |
SnowDust | when key is configurable .. | 09:55 |
SnowDust | against* | 09:56 |
SnowDust | dmakogon : any comments .. ? | 09:56 |
dmakogon | reading ... | 09:56 |
dmakogon | until trove would any of databases like HBase/Hive which build upon Hadoop and sharing data via SSH, we don't need it | 09:58 |
dmakogon | easy)) | 09:58 |
ashestakov | SnowDust: i think ssh access should be available only for operator | 10:03 |
SnowDust | ashestakov : who operator here ? | 10:16 |
SnowDust | the project admin right ( loggin from dashboard or cli ) | 10:17 |
SnowDust | ? | 10:17 |
ashestakov | SnowDust: i mean dbaas provider | 10:17 |
ashestakov | i not sue is good idea to allow user do something on instance | 10:18 |
ashestakov | but for maintenance access is must | 10:18 |
SnowDust | hmm .. as its an abstracted service .. | 10:18 |
SnowDust | yeah ..that was my point ashestakov | 10:19 |
SnowDust | and thankyou for your review ashestakov !! | 10:19 |
SnowDust | so ..what do u think now dmakogon ? | 10:19 |
ashestakov | as it works now - you can set you key through userdata | 10:19 |
SnowDust | but .. we can also have .. provided public key in the image itself ... | 10:20 |
SnowDust | and that brings us back to dmakogon's suggestion | 10:20 |
SnowDust | to remove the key .. | 10:20 |
SnowDust | from current implementation | 10:21 |
ashestakov | looks like need to remove it, but first need to make "userdata" resource configurable | 10:23 |
SnowDust | but why user data.. just keep the public key in authorized_keys during the image building time | 10:24 |
SnowDust | and then provider logs in using that | 10:25 |
SnowDust | when needed | 10:25 |
*** matsuhashi has joined #openstack-trove | 10:27 | |
*** nosnos has quit IRC | 10:31 | |
ashestakov | it works if using pre-builded images | 10:32 |
ashestakov | need to keep support of vanilla images as well | 10:32 |
SnowDust | vanilla dont have trove .. | 10:35 |
ashestakov | trove can be installed by userdata, same as repos, deps and another configurations | 10:43 |
SnowDust | ok lets blueprint then | 10:44 |
SnowDust | isviridov | 10:45 |
SnowDust | there ? | 10:45 |
ashestakov | SnowDust: is already blueprinted and implemented before heat integration | 10:45 |
*** matsuhashi has quit IRC | 10:46 | |
SnowDust | i thought heat template UserData grammer | 10:46 |
SnowDust | but may be i dont know | 10:46 |
*** matsuhashi has joined #openstack-trove | 10:47 | |
SnowDust | isviridov : 5 min chat ? | 10:47 |
isviridov | SnowDust, here | 10:49 |
SnowDust | read ur review | 10:50 |
isviridov | please link to the BP, it was renamed or somethinh | 10:50 |
SnowDust | stack_name = i wanted to make this recognizable and still error free | 10:51 |
*** matsuhashi has quit IRC | 10:51 | |
isviridov | the Q is why we need md5 digest? why not to use the id itself? | 10:51 |
SnowDust | if u read comments .. i have mentioned the name size overflowed .. to 68 chars as was the code before | 10:51 |
SnowDust | u wanted to strip the prefix " trove " ? | 10:52 |
SnowDust | the start of the name should be alphabet as per validation | 10:52 |
SnowDust | and trove .. makes it recognizable | 10:53 |
isviridov | is it limitation of name for heat stack? | 10:54 |
SnowDust | yeah .. if u see the bug .. its clearly mentioned .. | 10:54 |
SnowDust | but the heat developers .. have explained to cap it to 63 chars .. as hostnames cannot be more than that | 10:54 |
SnowDust | so .. to support all that limitation .. | 10:54 |
SnowDust | we needed a modified stack name .. | 10:55 |
SnowDust | trove prefix not removable .. meant .. | 10:55 |
SnowDust | we had to do something to the ID :) | 10:55 |
SnowDust | we .. did a stripped hash .. for the same | 10:55 |
isviridov | can we use instance name for stack naming? the name we are using for VMs when creating it with nova? | 10:56 |
isviridov | because we loosing human readable connection | 10:57 |
isviridov | and don't keep it in DB as well | 10:57 |
SnowDust | instance name would have been first choice .. but .. we couldnot implement | 10:57 |
SnowDust | as the same can be repeated .. multiple times in command line | 10:57 |
SnowDust | and that makes stack_name non unique | 10:58 |
isviridov | and that problem is generally solved in OS with id | 10:58 |
isviridov | let us keep that connection in database via stack id if we have such limitation with naming | 11:00 |
isviridov | probably in separate BP | 11:00 |
isviridov | what do you think? | 11:00 |
SnowDust | if u keep stack id .. the stack will error | 11:00 |
SnowDust | for the name overflow ( of instance ) | 11:00 |
dmakogon | isviridov, your complains would be covered by update heat-support | 11:01 |
dmakogon | isviridov, you could write your thoughts at BP whiteboard | 11:01 |
isviridov | SnowDust, keep in database and call the stack by id, not the name | 11:01 |
SnowDust | we need some + thats bottomline LOL .. help ! | 11:02 |
SnowDust | isviridov: i have no reservation , but dmakogon says that reduces readability .. of the instance names | 11:02 |
SnowDust | and thats a valid point | 11:02 |
isviridov | dmakogon, sure let us agree that it is needed or not at all | 11:04 |
isviridov | we handle the nova instances by id, and stacks should be also handled this way otherwise we will always face with that naming problelems | 11:06 |
dmakogon | for now we don't need stack_name or id after prov. | 11:06 |
dmakogon | isviridov, we are on the way do describe full-geat heat-support in trove | 11:06 |
isviridov | dmakogon, SnowDust do you think it should work with ids in future? | 11:08 |
dmakogon | isviridov, alternatives ? | 11:08 |
*** ppenjoy has joined #openstack-trove | 11:09 | |
isviridov | yeap, no way let it be in the next patches | 11:09 |
isviridov | SnowDust, thx for clarification | 11:09 |
SnowDust | lets talk present .. we will need u to do a + in future too isviridov :D | 11:12 |
SnowDust | and then will bring id back | 11:12 |
SnowDust | any more +ve reviews plz .. ! | 11:13 |
isviridov | with pleasure ) | 11:14 |
isviridov | so, name for people, but ids for models | 11:15 |
SnowDust | sure but another blueprint .. not in this | 11:15 |
SnowDust | its just refactoring | 11:15 |
SnowDust | and .. if a bug in the way .. solved it | 11:15 |
SnowDust | this needs to go in .. so that we can bring more ideas | 11:16 |
SnowDust | as urs .. around it .. | 11:16 |
SnowDust | to trove | 11:16 |
SnowDust | so .. do read the commit message | 11:16 |
SnowDust | and do the needful :) | 11:16 |
isviridov | :) | 11:18 |
*** ppenjoy has left #openstack-trove | 11:19 | |
*** matsuhashi has joined #openstack-trove | 11:20 | |
SnowDust | dmakogon : leaving the post .. watch it .. we need to finish it .. | 11:20 |
dmakogon | ok__ | 11:20 |
dmakogon | )) | 11:20 |
*** matsuhashi has quit IRC | 11:23 | |
*** matsuhashi has joined #openstack-trove | 11:24 | |
*** matsuhashi has quit IRC | 11:24 | |
*** matsuhashi has joined #openstack-trove | 11:25 | |
*** haomaiwang has joined #openstack-trove | 11:25 | |
*** matsuhashi has quit IRC | 11:29 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Introduce GA manager mixin https://review.openstack.org/53826 | 11:36 |
*** SnowDust has quit IRC | 11:47 | |
*** SushilKM has quit IRC | 11:57 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Introduce GA manager mixin https://review.openstack.org/53826 | 12:05 |
*** pdmars has joined #openstack-trove | 12:06 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 12:18 |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Introduce GA manager mixin https://review.openstack.org/53826 | 12:31 |
*** anteaya has joined #openstack-trove | 13:09 | |
*** russellb is now known as rustlebee | 13:12 | |
*** demorris has joined #openstack-trove | 13:13 | |
*** adrian_otto has joined #openstack-trove | 13:29 | |
*** rnirmal has joined #openstack-trove | 13:30 | |
*** PradeepChandani has quit IRC | 13:32 | |
*** jcru has joined #openstack-trove | 13:43 | |
*** grapex has joined #openstack-trove | 13:53 | |
*** grapex has quit IRC | 13:53 | |
*** grapex has joined #openstack-trove | 13:54 | |
*** lnxnut has joined #openstack-trove | 13:54 | |
*** ashestakov has quit IRC | 13:58 | |
*** adrian_otto has quit IRC | 14:00 | |
*** Barker has joined #openstack-trove | 14:02 | |
*** ashestakov has joined #openstack-trove | 14:03 | |
*** amytron has joined #openstack-trove | 14:05 | |
*** haomaiwang has quit IRC | 14:06 | |
*** haomaiwang has joined #openstack-trove | 14:06 | |
*** Nate1 has joined #openstack-trove | 14:09 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Introduce GA manager mixin https://review.openstack.org/53826 | 14:10 |
*** haomaiwang has quit IRC | 14:11 | |
*** haomaiwang has joined #openstack-trove | 14:11 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 14:16 |
*** datsun180b has joined #openstack-trove | 14:16 | |
*** robertmyers has joined #openstack-trove | 14:19 | |
*** adrian_otto has joined #openstack-trove | 14:21 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 14:47 |
*** radez_g0n3 is now known as radez | 14:54 | |
ikhudoshyn | dmakogon: https://gist.github.com/ikhudoshyn/7155968 | 14:54 |
*** tanisdl has joined #openstack-trove | 14:54 | |
ikhudoshyn | something like that | 14:55 |
*** tanisdl has quit IRC | 14:55 | |
ikhudoshyn | just a lil'bit simplier. Just a proposal | 14:55 |
*** SnowDust has joined #openstack-trove | 14:56 | |
*** shakayumi has joined #openstack-trove | 14:58 | |
*** radez is now known as radez_g0n3 | 14:58 | |
*** radez_g0n3 is now known as radez | 14:59 | |
*** shakayum_ has joined #openstack-trove | 15:03 | |
*** shakayum_ has quit IRC | 15:04 | |
*** shakayumi has quit IRC | 15:04 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 15:04 |
*** shakayumi has joined #openstack-trove | 15:05 | |
*** adrian_otto has quit IRC | 15:05 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 15:09 |
*** paul_lodronio has joined #openstack-trove | 15:12 | |
*** amytron has quit IRC | 15:16 | |
*** amytron has joined #openstack-trove | 15:16 | |
*** jasonb365 has joined #openstack-trove | 15:22 | |
*** tanisdl has joined #openstack-trove | 15:24 | |
*** adrian_otto has joined #openstack-trove | 15:27 | |
ikhudoshyn | grapex: around? | 15:38 |
ikhudoshyn | grapex: pls re-approve -- https://review.openstack.org/#/c/50597/ -- just added a config | 15:39 |
*** shakayumi has quit IRC | 15:41 | |
*** SnowDust has quit IRC | 15:44 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 15:47 |
dmakogon | hub_cap, grapex, it would be nice to review this one https://review.openstack.org/#/c/51884/ | 15:56 |
*** demorris_ has joined #openstack-trove | 16:01 | |
*** lnxnut_ has joined #openstack-trove | 16:02 | |
*** lnxnut has quit IRC | 16:02 | |
*** demorris has quit IRC | 16:02 | |
*** demorris_ is now known as demorris | 16:04 | |
*** dmakogon has quit IRC | 16:05 | |
*** dmakogon has joined #openstack-trove | 16:06 | |
*** Nate1 has quit IRC | 16:11 | |
*** Nate1 has joined #openstack-trove | 16:12 | |
openstackgerrit | Joe Cruz proposed a change to openstack/trove: Add Backup/Restore Checksum Validation https://review.openstack.org/53165 | 16:12 |
*** Nate1 has quit IRC | 16:12 | |
*** Nate1 has joined #openstack-trove | 16:12 | |
*** Nate1 has joined #openstack-trove | 16:13 | |
*** radez is now known as radez_g0n3 | 16:13 | |
*** Nate1 has left #openstack-trove | 16:16 | |
esmute | Hey grapex, got a question | 16:37 |
esmute | I am looking to add dns designate support to trove and been looking at the rsdns driver. My question is about the hostname. I see that RS hashes the instance-id to use the hash as the name. Is there a reason why you guys choose to hash instead of, say, using the instance id (minus the dashes) as the name? | 16:40 |
esmute | https://github.com/openstack/trove/blob/master/trove/dns/rsdns/driver.py#L210 | 16:40 |
*** SnowDust has joined #openstack-trove | 16:41 | |
demorris | esmute: heads up Tim is in a meeting at the moment, might be slow to respond right now | 16:47 |
esmute | ok.. Thanks demorris | 16:47 |
dmakogon | esmute, are you implementing designate support ? | 16:49 |
esmute | @dmakogon yes | 16:49 |
dmakogon | esmute, have you heard that we decided to wait until heat would allow us to use dns resource ? | 16:50 |
dmakogon | esmute, we decided it along time ago | 16:51 |
dmakogon | esmute, i suppose you should try to help guys in heat to bring new resource | 16:53 |
cp16net | esmute: i think we did that so that it was random and not directly tied to an instance | 16:55 |
cp16net | esmute: because under ther coveres if the instances dies or host we can still use the same dns name just move it to the new instance's ip | 16:55 |
* cp16net thinks thats the reason but doesnt recall all the deatils | 16:56 | |
SnowDust | when u talk a lot of heat .. details becomes deatils .. watch cp16net | 17:01 |
SnowDust | :D | 17:01 |
cp16net | when i talk heat, i melt | 17:02 |
cp16net | lolz | 17:02 |
*** yogeshmehra has joined #openstack-trove | 17:02 | |
*** rnirmal has quit IRC | 17:05 | |
SnowDust | today i see overwhelming attendance | 17:06 |
SnowDust | hi @ all trovesters ! | 17:06 |
SnowDust | lets talk documentation big way ... | 17:06 |
SnowDust | we need documentation help .. | 17:06 |
SnowDust | anyone there ... taking that task ???? | 17:07 |
SnowDust | documentation for trove ?? | 17:10 |
cp16net | i help out here and there | 17:10 |
cp16net | you talking about adding it to the main openstack manuals? | 17:11 |
SnowDust | thats good .. but we need a small sprint .. | 17:11 |
cp16net | i just dont have bndwidth right now to work on it | 17:11 |
SnowDust | i am just talking about ... documentation in the code .. | 17:11 |
SnowDust | and then sphinx it ! | 17:11 |
cp16net | oh | 17:11 |
SnowDust | we are pouring in the code .. but no documentation .. | 17:11 |
cp16net | yah i think there has been laziness there | 17:11 |
SnowDust | and no -1 for it .. when the code goes for review :D | 17:12 |
cp16net | but yes i agree that would be great to add | 17:12 |
cp16net | tru | 17:12 |
SnowDust | we should have -1 for documentation .. | 17:12 |
SnowDust | thats the only way we get it documented ! | 17:12 |
cp16net | i dunno if that should a strict requirment in the code | 17:12 |
SnowDust | should be .. | 17:12 |
SnowDust | django turned up the tables .. with just one good thing .. documentation | 17:13 |
cp16net | i agree it would be helpful | 17:13 |
SnowDust | same is wordpress ... | 17:13 |
SnowDust | i am talking abt .. long lived opensource projects .. | 17:13 |
SnowDust | that made big :) | 17:13 |
cp16net | yeah its a good diea | 17:14 |
cp16net | idea* | 17:14 |
cp16net | i dont deny that | 17:14 |
grapex | esmute: Greetings | 17:17 |
grapex | So- I was never 100% certain why we hashed the dns name rather than using the instance ID. All I remember is that is was *very* important to someone over two years ago. | 17:18 |
grapex | That behavior should be swappable though- IIRC the class where the DNS name is concocted is an independent object from the one which actually provisions DNS. | 17:19 |
grapex | esmute: Please let me know if you have any questions. | 17:19 |
ikhudoshyn | grapex: hi | 17:20 |
grapex | ikhudoshyn: Hello | 17:20 |
ikhudoshyn | grapex: could u pls reappove -- i forgot a conf, my bad | 17:21 |
ikhudoshyn | https://review.openstack.org/#/c/50597/ | 17:21 |
grapex | ikhudoshyn: Sure | 17:22 |
esmute | @grapex Thanks. cp16net answered it for me | 17:22 |
dmakogon | grapex, could you do the same with cassandra ? | 17:22 |
ikhudoshyn | and one more question, its testing. I prepared a tweak for trove-integration. It adds a group of tests and scripts for mongo image | 17:23 |
dmakogon | esmute, tell me your plans for dns | 17:23 |
esmute | dmakogon: I am aware the there will be dns work in heat. But we need this feature soon as we dont know when heat for trove will be ready | 17:23 |
esmute | it would be pretty isolated from the main code as well. Since they addition will just be a new driver | 17:24 |
ikhudoshyn | grapex: but to run tests we need to add redstack kick-start mongodb; redstack int-tests --group=mongodb. The question is, how could we arrange this and not break everything | 17:24 |
grapex | dmakogon: The agreement was there was no need to completely change all DNS code due to Heat. If esmute is creating another driver to fit into the current system I don't see the problem. | 17:24 |
dmakogon | esmute, drive with unit tests and integration test | 17:24 |
grapex | ikhudoshyn: You may want to talk to hub_cap about this as he's so intent on tempest integration. | 17:25 |
dmakogon | grapex, we had talked about not doing anything until heat would do everything for us | 17:25 |
grapex | ikhudoshyn: It sounds like if you adds an argument to kick-start for mongodb it should be an if statement with its own code paths, that won't break anything else in redstack. If that's true I think you can make an argument it should be merged since it doesn't negatively impact anyone else. | 17:26 |
esmute | yes dmakogon. Driver with tests | 17:26 |
grapex | ikhudoshyn: The same thing goes with the new test group. | 17:26 |
grapex | dmakogon: I thought the agreement was to not radically change the existing DNS code until Heat. | 17:27 |
dmakogon | esmute, so, i'm ok, but when heat would do dns, we would remove any dns stuff from trove | 17:27 |
grapex | dmakogon: If someone adds a driver that's just additive and doesn't impact anything. The work should also be minimal. | 17:27 |
*** adrian_otto has quit IRC | 17:27 | |
*** adrian_otto has joined #openstack-trove | 17:27 | |
dmakogon | grapex, i just added dynamic dns driver and received -2 from hub_cap | 17:27 |
grapex | dmakogon: Was that the same pull request I -2'd? My main reason was it did not only add a dynamic dns driver but completely changed how DNS worked. | 17:28 |
grapex | In the process it broke the existing DNS functionality. | 17:28 |
ikhudoshyn | grapex: I actually meant not to replace mysql with mongodb, but to add. like a redstack kick-start mysql; redstack int-tests; redstack kick-start mongodb; redstack int-tests --group=mongodb | 17:29 |
grapex | dmakogon: If there is another pull request that only added a dynamic DNS driver that got -2'd I have not seen it. :( | 17:29 |
grapex | ikhudoshyn: If you only added it | 17:29 |
dmakogon | grapex, they are all abandoned for now =/ | 17:29 |
grapex | and the code is done, go ahead and pull request it and let's see what the wider Trove team thinks | 17:29 |
dmakogon | grapex, esmute i'm ok with designate driver, just add my BP to the review | 17:30 |
ikhudoshyn | grapex: i did. (not changed the job, but prepared group&image) Will consequent call int-tests impact test results? | 17:30 |
esmute | dmakogon: can you link this BP? | 17:30 |
*** SnowDust has quit IRC | 17:31 | |
grapex | dmakogon: Maybe there was a misunderstanding. I personally am ok with adding other DNS drivers (I may or may not speak for vipul SlickNik and hub_cap); the issue was, you had changed much of how DNS provisioning works and broken existing functionality. The changes were fairly far reaching and involved a lot of work- that seemed like a mistake to be taking on right now since Heat will involve more DNS changes anyway. | 17:31 |
ikhudoshyn | grapex: Could u please look https://review.openstack.org/#/c/53378/ | 17:31 |
dmakogon | esmute, https://blueprints.launchpad.net/trove/+spec/designate-dnsaas-support | 17:31 |
dmakogon | grapex, i'm ok with all that you approved, let it be)) | 17:33 |
dmakogon | grapex, https://review.openstack.org/#/c/51884/ |||| https://review.openstack.org/#/c/52666/ could you take a look at this two)) | 17:34 |
dmakogon | it would be very nice | 17:34 |
dmakogon | it would be very nice to see that those two are approved))) | 17:35 |
grapex | dmakogon: I'm reviewing it now | 17:38 |
ikhudoshyn | grapex: thanks, as for hub_cap, i thought he wanted both, and these tests asap, just to make sure it works. Will try to reach him | 17:40 |
ikhudoshyn | cu | 17:40 |
ashestakov | cu | 17:41 |
dmakogon | cu | 17:41 |
*** ashestakov has quit IRC | 17:42 | |
grapex | be back in a bit | 17:44 |
*** radez_g0n3 is now known as radez | 17:45 | |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 17:47 |
vipul | mordred: our mysqls are 5.5 | 17:48 |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 17:48 |
dmakogon | vipul, could you remove your -1 from my review (guestagent refactoring) ? | 17:49 |
dmakogon | vipul, please | 17:49 |
dmakogon | vipul, https://review.openstack.org/#/c/50686/ | 17:49 |
vipul | dmakogon, grapex, esmute: sorry i missed the discussion. It's my understanding that dmakogon is deferring dns until Heat. We need designate support immeidately - which is why esmute is working on it | 17:49 |
dmakogon | vipul, i understood that | 17:50 |
vipul | dmakogon: yep - i'll remove | 17:50 |
dmakogon | vipul, when heat would support dns resource i would re-implement support for trove | 17:50 |
vipul | dmakogon: we need it sooner, so we're doing it now | 17:51 |
dmakogon | vipul, will it be ok ? | 17:51 |
dmakogon | vipul, i know | 17:51 |
dmakogon | vipul, just wondering | 17:51 |
vipul | what do you want to reimplement? | 17:51 |
dmakogon | vipul, dns in trove, but via heat (designate resource in heat) | 17:52 |
vipul | sure, when we're doing all provisioning through Heat.. we can discuss that | 17:53 |
dmakogon | vipul, i thought that we already discussed it, and we came to suggesting that in future we would use everything only via heat, nothing else | 17:54 |
vipul | yea - i believe that's the plan.. will take time to get there | 17:54 |
dmakogon | vipul, that is why i wonder if HP could deal with designate in heat and re-use it in trove | 17:55 |
mordred | vipul: well done | 17:55 |
openstackgerrit | A change was merged to openstack/trove: Provide service type management code structure https://review.openstack.org/50686 | 17:55 |
vipul | dmakogon: what we implement in trove will be optional.. which will allow us to transition to Heat when support exists | 17:57 |
dmakogon | vipul, i know that it would be optional, but when we would do it through heat it would not be optional | 17:58 |
dmakogon | vipul, because of avoiding not so good idea of template generation | 17:58 |
openstackgerrit | A change was merged to openstack/trove: Add tests for hosts mgmt commands https://review.openstack.org/52713 | 17:59 |
dmakogon | vipul, i'd like you to take a look at this bug https://review.openstack.org/#/c/53876/ | 18:00 |
*** mmcdaris has joined #openstack-trove | 18:01 | |
vipul | dmakogon: how does guest agent handle conf_contents being None today? | 18:02 |
*** shakayumi has joined #openstack-trove | 18:02 | |
dmakogon | vipul, it depends on manager implementation | 18:04 |
vipul | dmakogon: it will write an empty file, which is not cool -- since that empty file will replace the one that was originally there | 18:04 |
vipul | dmakogon: sure i'm speaking for the mysql case | 18:04 |
dmakogon | vipul, current mysql manager implementation take configuration and passes it to secure call | 18:04 |
vipul | dmakogon: so what should happen, what are we trying to do by allowing no config to be injected? | 18:05 |
dmakogon | vipul, yes | 18:05 |
dmakogon | i would do that | 18:05 |
dmakogon | config_content would be validated | 18:05 |
dmakogon | if not none: do conf update | 18:06 |
vipul | what use case are you trying to solve? | 18:06 |
dmakogon | vipul, absence of config template | 18:06 |
vipul | you want to have config baked into the image? there are cases that it should remain static? | 18:06 |
vipul | are there data stores where you dont' provide a config? | 18:07 |
dmakogon | vipul, each database already has config after install | 18:07 |
dmakogon | vipul, there is datastores where i don't have to change it massively | 18:07 |
dmakogon | vipul, only one or maybe 2 parameters | 18:08 |
*** ashestakov has joined #openstack-trove | 18:08 | |
vipul | dmakogon: there is nothing about the 'flavor' that would change the config? | 18:08 |
dmakogon | that is why i don't need whole config file | 18:08 |
dmakogon | yup | 18:08 |
dmakogon | there are mechanisms of selfdiscovery | 18:08 |
vipul | ok - i'm fine with supporting that.. it shouldn't break exisitng datastores | 18:09 |
vipul | so please update your patch | 18:09 |
dmakogon | vipul, i would do that | 18:09 |
dmakogon | vipul, to be precise, config absence should not break provisioning | 18:09 |
dmakogon | vipul, that is main goal of fixing that bug | 18:10 |
vipul | dmakogon: sure -- as long as you have other ways of getting the required config there | 18:10 |
dmakogon | vipul, yes | 18:11 |
dmakogon | vipul, parameters for configuration could be retrieved directly from operating system | 18:11 |
dmakogon | vipul, small example https://review.openstack.org/#/c/51884/11/trove/guestagent/datastore/cassandra/system.py --- get_host method | 18:13 |
vipul | dmakogon: i see | 18:14 |
dmakogon | vipul, for cassandra i could ask operating system for almost every parameter that i need | 18:15 |
dmakogon | vipul, but when i need some specific parameter to be changed - i would need Amazon Parameters Group | 18:15 |
esp | grapex: can you take a look at this sucker at your convenience? https://review.openstack.org/#/c/52461/ thx! | 18:25 |
cp16net | pdmars: https://blueprints.launchpad.net/trove/+spec/configuration-management | 18:28 |
*** rnirmal has joined #openstack-trove | 18:29 | |
pdmars | cp16net: updated | 18:29 |
cp16net | thx | 18:31 |
*** lnxnut has joined #openstack-trove | 18:35 | |
esmute | Hey grapex | 18:36 |
*** lnxnut__ has joined #openstack-trove | 18:37 | |
*** lnxnut_ has quit IRC | 18:37 | |
*** lnxnut has quit IRC | 18:40 | |
*** jasonb365 has quit IRC | 18:46 | |
*** jasonb365 has joined #openstack-trove | 18:54 | |
*** radez is now known as radez_g0n3 | 18:56 | |
*** tanisdl has quit IRC | 19:08 | |
*** vipul is now known as vipul-away | 19:08 | |
*** tanisdl has joined #openstack-trove | 19:13 | |
*** vipul-away is now known as vipul | 19:14 | |
datsun180b | i wonder if all our nova screens are supposed to start in /opt/stack/tempest | 19:14 |
datsun180b | probably a missed popd somewhere in a script i bet | 19:14 |
*** arborism has joined #openstack-trove | 19:36 | |
*** arborism is now known as amcrn | 19:36 | |
*** amcrn has quit IRC | 19:41 | |
*** jrodom has joined #openstack-trove | 19:48 | |
*** tanisdl has quit IRC | 19:49 | |
*** arborism has joined #openstack-trove | 19:51 | |
*** arborism is now known as amcrn | 19:51 | |
openstackgerrit | A change was merged to openstack/python-troveclient: Add --bypass-url option to trove client https://review.openstack.org/52461 | 19:52 |
*** ppenjoy has joined #openstack-trove | 19:52 | |
openstackgerrit | Robert Myers proposed a change to openstack/trove-integration: Moving mgmt host tests. https://review.openstack.org/53381 | 19:55 |
vipul | hub_cap: there? | 19:56 |
vipul | SlickNik, grapex: should we push a new version to pypi? | 20:02 |
grapex | vipul: Of the client? | 20:02 |
vipul | yes | 20:02 |
vipul | with the bypass_url fix | 20:02 |
SlickNik | Yeah, I think it's probably a good idea. | 20:02 |
SlickNik | is hub_cap out today? | 20:02 |
*** tanisdl has joined #openstack-trove | 20:03 | |
SlickNik | Wondering if he's around to push the tag, or if one of us needs to do it... | 20:06 |
vipul | haven't heard from him | 20:06 |
SlickNik | Let's give him a few mins. | 20:10 |
SlickNik | If not, I can tag and push. | 20:11 |
*** ppenjoy has quit IRC | 20:13 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove-integration: Add support for minimal MongoDB testing https://review.openstack.org/53378 | 20:18 |
ikhudoshyn | vipul: ^ ^ I added scripts for fedora, could u pls take a look | 20:21 |
*** timfreund has quit IRC | 20:23 | |
*** lnxnut__ has quit IRC | 20:25 | |
SlickNik | okay, gonna tag and push. grapex / vipul, you're good with me pushing out python-troveclient v1.0.2 with the bypass-url fix in it, right? | 20:30 |
esp | cool, thx SlickNik | 20:30 |
vipul | thanks SlickNik | 20:31 |
*** ppenjoy has joined #openstack-trove | 20:31 | |
*** ppenjoy has left #openstack-trove | 20:36 | |
demorris | SlickNik: hub_cap is out the rest of the day | 20:38 |
SlickNik | demorris: Thanks for the heads up! | 20:39 |
*** shakayumi has quit IRC | 20:39 | |
*** yogeshmehra has quit IRC | 20:42 | |
*** yogeshmehra has joined #openstack-trove | 20:42 | |
*** datsun180b has quit IRC | 20:46 | |
*** yogeshmehra has quit IRC | 20:47 | |
*** datsun180b has joined #openstack-trove | 20:49 | |
*** pdmars has quit IRC | 21:03 | |
SlickNik | New python-troveclient v 1.0.3 is out at https://pypi.python.org/pypi/python-troveclient/1.0.3 | 21:13 |
robertmyers | SlickNik: the new arg is not documented :) | 21:15 |
demorris | SlickNik: whats new in this version? | 21:17 |
demorris | it would be good if that page had some basic release notes | 21:17 |
SlickNik | good point robertmyers, I think we forgot to catch the change needed to the .rst file during the code review of https://review.openstack.org/#/c/52461/ | 21:18 |
SlickNik | ^^ esp, can we fix the README.rst to add info about the new arg? | 21:18 |
SlickNik | demorris: This was the only change since 1.0.2 https://review.openstack.org/#/c/52461/ | 21:19 |
demorris | k | 21:19 |
esp | SlickNik: sure | 21:19 |
demorris | is there a way to show that via some release notes? | 21:19 |
robertmyers | +1 | 21:19 |
SlickNik | demorris: the only couple of ways I know to look that up are: | 21:21 |
SlickNik | 1. Look to see if the publisher put any information in the tag's commit message: | 21:21 |
SlickNik | git tag -l -n10 | 21:21 |
SlickNik | For this version this gives you: | 21:21 |
SlickNik | 1.0.3 Releasing v1.0.3 of python-troveclient | 21:21 |
SlickNik | Added support for --bypass-url to use a different trove endpoint | 21:21 |
SlickNik | than the one specified in the catalog. | 21:21 |
SlickNik | 2. Look at the log for the commits between tags: | 21:22 |
SlickNik | git log 1.0.2...1.0.3 | 21:22 |
SlickNik | https://gist.github.com/SlickNik/7162058 | 21:23 |
demorris | that sounds like a lot of work :) | 21:23 |
SlickNik | Perhaps we should put it up on a wiki page somewhere for reference between versions. So you can easily look it up. | 21:24 |
robertmyers | demorris: SlickNik: https://github.com/openstack/python-troveclient/releases | 21:24 |
*** amytron has quit IRC | 21:25 | |
demorris | that's easier! | 21:25 |
demorris | maybe we just have that page linked off the pypi page | 21:25 |
SlickNik | nice find robertmyers. | 21:25 |
robertmyers | I think we can edit those tags too | 21:26 |
SlickNik | Yes, it's a message the tagger puts in when (s)he tags and pushes the release. | 21:26 |
*** demorris has quit IRC | 21:27 | |
robertmyers | I say we add a bit more info there. Yours is pretty good | 21:28 |
SlickNik | esp: can we also add a link to the releases page (https://github.com/openstack/python-troveclient/releases) in the README.rst file when we add info about the —bypass-url option? | 21:28 |
esp | yep | 21:28 |
SlickNik | esp: Thanks! | 21:29 |
esp | there is already this one: _Github: https://github.com/openstack/python-troveclient | 21:30 |
esp | but I can include the other one too | 21:30 |
SlickNik | robertmyers: Agreed. It would be useful for the tag message to be a sort of mini release-notes for the release. | 21:35 |
*** Barker has quit IRC | 21:36 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/python-troveclient: Updated the README file with bypass-url https://review.openstack.org/53960 | 21:36 |
esp | SlickNik: ^ | 21:37 |
SlickNik | thanks! | 21:38 |
*** timfreund has joined #openstack-trove | 21:40 | |
openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Support datastore types https://review.openstack.org/47936 | 21:46 |
*** robertmyers has quit IRC | 21:47 | |
*** jasonb365 has quit IRC | 21:47 | |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests https://review.openstack.org/45116 | 21:47 |
datsun180b | argh! it ALL worked before i rebased with this datastore business | 21:50 |
*** paul_lodronio_ has joined #openstack-trove | 21:54 | |
*** rnirmal_ has joined #openstack-trove | 21:54 | |
*** rnirmal has quit IRC | 21:57 | |
*** rnirmal_ is now known as rnirmal | 21:57 | |
*** paul_lodronio has quit IRC | 21:58 | |
*** paul_lodronio_ is now known as paul_lodronio | 21:58 | |
datsun180b | somehow my requirements got mangled in the gerrit rebase; good thing for git diff HEAD~1 | 22:03 |
*** rnirmal has quit IRC | 22:08 | |
*** paul_lodronio has quit IRC | 22:13 | |
*** paul_lodronio has joined #openstack-trove | 22:13 | |
openstackgerrit | A change was merged to openstack/trove-integration: Adds conductor to redstack start and stop https://review.openstack.org/52693 | 22:39 |
*** paul_lodronio_ has joined #openstack-trove | 22:43 | |
*** shakayumi has joined #openstack-trove | 22:43 | |
openstackgerrit | A change was merged to openstack/trove: Simulates events so run_tests.py executes 10x faster https://review.openstack.org/52490 | 22:43 |
*** grapex has quit IRC | 22:44 | |
*** grapex has joined #openstack-trove | 22:45 | |
*** paul_lodronio has quit IRC | 22:45 | |
*** paul_lodronio_ is now known as paul_lodronio | 22:45 | |
openstackgerrit | A change was merged to openstack/python-troveclient: user-list Databases Value is JSON vs a String https://review.openstack.org/53810 | 22:45 |
*** grapex has quit IRC | 22:50 | |
*** amcrn has quit IRC | 22:59 | |
openstackgerrit | Joe Cruz proposed a change to openstack/trove: Add Backup/Restore Checksum Validation https://review.openstack.org/53165 | 23:07 |
*** jrodom has quit IRC | 23:12 | |
jesusaurus | 23:14 | |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests https://review.openstack.org/45116 | 23:16 |
datsun180b | okay, that better be it | 23:16 |
datsun180b | i'm out | 23:17 |
*** datsun180b has quit IRC | 23:17 | |
*** jcru has quit IRC | 23:17 | |
*** yidclare1 has quit IRC | 23:31 | |
*** mmcdaris has quit IRC | 23:43 | |
*** mmcdaris has joined #openstack-trove | 23:50 | |
*** yogeshmehra has joined #openstack-trove | 23:51 | |
*** denis_makogon has joined #openstack-trove | 23:55 | |
*** yogeshmehra has quit IRC | 23:57 | |
*** yogeshmehra has joined #openstack-trove | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!