| *** grapex has joined #openstack-trove | 00:00 | |
| *** grapex has quit IRC | 00:09 | |
| *** krow has quit IRC | 00:11 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/python-troveclient: Fix Pep8 indentation issues only found with Pep8 1.4.6+ https://review.openstack.org/54855 | 00:13 |
|---|---|---|
| *** amytron has quit IRC | 00:15 | |
| *** coolsvap has quit IRC | 00:15 | |
| *** amcrn has quit IRC | 00:18 | |
| *** krow has joined #openstack-trove | 00:19 | |
| *** matsuhashi has joined #openstack-trove | 00:25 | |
| *** amcrn has joined #openstack-trove | 00:38 | |
| *** krow has quit IRC | 00:56 | |
| *** yidclare has quit IRC | 01:02 | |
| *** nosnos has joined #openstack-trove | 01:09 | |
| *** demorris has joined #openstack-trove | 01:14 | |
| *** krow has joined #openstack-trove | 01:27 | |
| *** krow has quit IRC | 01:32 | |
| *** esp has left #openstack-trove | 01:37 | |
| *** krow has joined #openstack-trove | 01:53 | |
| *** erkules has quit IRC | 02:06 | |
| *** krow has quit IRC | 02:11 | |
| *** erkules has joined #openstack-trove | 02:20 | |
| *** amcrn has quit IRC | 02:30 | |
| *** demorris has quit IRC | 02:30 | |
| *** krow has joined #openstack-trove | 02:42 | |
| *** matsuhashi has quit IRC | 02:43 | |
| *** matsuhashi has joined #openstack-trove | 02:43 | |
| *** matsuhas_ has joined #openstack-trove | 02:44 | |
| *** matsuhashi has quit IRC | 02:44 | |
| *** krow has quit IRC | 03:17 | |
| *** matsuhas_ has quit IRC | 03:20 | |
| *** jcooley_ has joined #openstack-trove | 03:21 | |
| *** matsuhashi has joined #openstack-trove | 03:21 | |
| *** matsuhashi has quit IRC | 03:26 | |
| *** yidclare has joined #openstack-trove | 03:36 | |
| *** haomaiwa_ has joined #openstack-trove | 03:46 | |
| *** haomaiwang has quit IRC | 03:48 | |
| *** krow has joined #openstack-trove | 04:15 | |
| *** matsuhashi has joined #openstack-trove | 04:28 | |
| *** krow has quit IRC | 04:33 | |
| *** rushiagr has joined #openstack-trove | 04:38 | |
| *** shakayumi has joined #openstack-trove | 05:09 | |
| *** yogeshmehra has joined #openstack-trove | 05:22 | |
| *** yogeshmehra has quit IRC | 05:30 | |
| *** yogeshmehra has joined #openstack-trove | 05:31 | |
| *** krow has joined #openstack-trove | 05:46 | |
| *** yogeshmehra has quit IRC | 06:01 | |
| *** yogeshmehra has joined #openstack-trove | 06:25 | |
| *** krow has quit IRC | 06:26 | |
| *** rushiagr has quit IRC | 06:34 | |
| *** krow has joined #openstack-trove | 07:04 | |
| *** krow has quit IRC | 07:47 | |
| *** krow has joined #openstack-trove | 07:49 | |
| *** matsuhashi has quit IRC | 08:08 | |
| *** matsuhashi has joined #openstack-trove | 08:08 | |
| *** matsuhashi has quit IRC | 08:12 | |
| *** matsuhashi has joined #openstack-trove | 08:16 | |
| *** krow has quit IRC | 08:21 | |
| *** matsuhashi has quit IRC | 08:34 | |
| *** krow has joined #openstack-trove | 08:40 | |
| *** yogeshmehra has quit IRC | 08:43 | |
| *** arborism has joined #openstack-trove | 08:51 | |
| *** westmaas_ has joined #openstack-trove | 08:55 | |
| *** westmaas has quit IRC | 08:58 | |
| *** arborism has quit IRC | 09:00 | |
| *** matsuhashi has joined #openstack-trove | 09:02 | |
| *** matsuhashi has quit IRC | 09:10 | |
| *** matsuhashi has joined #openstack-trove | 09:11 | |
| *** matsuhashi has quit IRC | 09:15 | |
| *** haomaiwang has joined #openstack-trove | 09:16 | |
| *** haomaiwa_ has quit IRC | 09:17 | |
| *** matsuhashi has joined #openstack-trove | 09:20 | |
| *** ashestakov has joined #openstack-trove | 09:22 | |
| *** krow has quit IRC | 09:31 | |
| *** krow has joined #openstack-trove | 09:37 | |
| openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Update PEP8 rules https://review.openstack.org/54900 | 10:16 |
| *** ppenjoy has joined #openstack-trove | 10:21 | |
| *** matsuhashi has quit IRC | 10:25 | |
| *** nosnos has quit IRC | 10:32 | |
| *** ppenjoy has left #openstack-trove | 10:45 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 10:52 |
| *** krow has quit IRC | 11:22 | |
| *** mwagner has joined #openstack-trove | 11:28 | |
| *** pdmars has joined #openstack-trove | 12:03 | |
| *** PradeepChandani_ has quit IRC | 12:06 | |
| *** grapex has joined #openstack-trove | 12:20 | |
| *** grapex has quit IRC | 12:21 | |
| *** grapex has joined #openstack-trove | 12:21 | |
| openstackgerrit | A change was merged to openstack/python-troveclient: Support datastore types https://review.openstack.org/47936 | 12:43 |
| *** radez_g0n3 is now known as radez | 12:52 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Add support of datastore types https://review.openstack.org/47934 | 13:01 |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Documentation for datastore types https://review.openstack.org/54921 | 13:08 |
| *** robertmyers has joined #openstack-trove | 13:39 | |
| *** robertmy_ has joined #openstack-trove | 13:41 | |
| *** robertmyers has quit IRC | 13:42 | |
| *** robertmy_ has quit IRC | 13:42 | |
| *** jmontemayor has joined #openstack-trove | 13:43 | |
| *** ppenjoy has joined #openstack-trove | 13:45 | |
| *** robertmy_ has joined #openstack-trove | 13:45 | |
| *** robertmy_ has quit IRC | 13:46 | |
| *** robertmyers has joined #openstack-trove | 13:46 | |
| *** robertmyers has quit IRC | 13:47 | |
| *** robertmyers has joined #openstack-trove | 13:47 | |
| *** demorris has joined #openstack-trove | 13:47 | |
| *** robertmyers has quit IRC | 13:48 | |
| *** robertmyers has joined #openstack-trove | 13:48 | |
| *** robertmyers has quit IRC | 13:51 | |
| *** robertmyers has joined #openstack-trove | 13:52 | |
| *** robertmyers has quit IRC | 13:53 | |
| *** robertm__ has joined #openstack-trove | 13:57 | |
| *** robertm__ has quit IRC | 13:58 | |
| *** robertmyers has joined #openstack-trove | 13:58 | |
| *** robertmyers has quit IRC | 13:59 | |
| *** robertmyers has joined #openstack-trove | 13:59 | |
| *** robertmy_ has joined #openstack-trove | 14:00 | |
| *** robertmyers has quit IRC | 14:00 | |
| *** robertmy_ has quit IRC | 14:03 | |
| *** robertmyers has joined #openstack-trove | 14:03 | |
| *** robertmyers has quit IRC | 14:04 | |
| *** robertmyers has joined #openstack-trove | 14:04 | |
| *** robertmyers has quit IRC | 14:05 | |
| *** robertmyers has joined #openstack-trove | 14:05 | |
| *** robertmyers has quit IRC | 14:06 | |
| *** robertmyers has joined #openstack-trove | 14:06 | |
| *** jcru has joined #openstack-trove | 14:11 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Externalisation of heat template https://review.openstack.org/53499 | 14:29 |
| *** ppenjoy has left #openstack-trove | 14:29 | |
| *** Barker has joined #openstack-trove | 14:36 | |
| *** rnirmal has joined #openstack-trove | 14:38 | |
| *** jcru_ has joined #openstack-trove | 15:05 | |
| *** yidclare has quit IRC | 15:06 | |
| *** jcru has quit IRC | 15:08 | |
| *** datsun180b has joined #openstack-trove | 15:09 | |
| *** jasonb365 has joined #openstack-trove | 15:16 | |
| *** mayfield has quit IRC | 15:16 | |
| *** jcooley_ has quit IRC | 15:17 | |
| *** demorris_ has joined #openstack-trove | 15:34 | |
| *** demorris has quit IRC | 15:36 | |
| *** demorris_ is now known as demorris | 15:36 | |
| openstackgerrit | Dmitriy Ukhlov proposed a change to openstack/trove: Trove instance model refactoring https://review.openstack.org/53346 | 15:36 |
| *** dukhlov has quit IRC | 15:40 | |
| *** jcru_ has quit IRC | 15:41 | |
| *** dukhlov has joined #openstack-trove | 15:43 | |
| *** jcru has joined #openstack-trove | 15:43 | |
| *** jasonb365 has quit IRC | 15:48 | |
| datsun180b | man, i'm getting some goofy failures running my tests locally | 15:50 |
| datsun180b | and install or kick-start is "conveniently" updating our requirements files | 15:52 |
| cp16net | hub_cap: plz review. https://review.openstack.org/#/c/54565/ | 15:55 |
| *** jcru has quit IRC | 15:56 | |
| *** jcru has joined #openstack-trove | 15:57 | |
| *** ashestakov has quit IRC | 16:00 | |
| cp16net | SlickNik: plz review ^^ | 16:01 |
| *** esp has joined #openstack-trove | 16:01 | |
| *** adrian_otto has joined #openstack-trove | 16:01 | |
| cp16net | datsun180b: haha yeah i just noticed that too | 16:01 |
| *** kfox1111 has joined #openstack-trove | 16:09 | |
| kfox1111 | Is anyone actively working on adding mongodb support to trove? | 16:10 |
| datsun180b | i can't name names but i think someone is | 16:13 |
| kevinconway | kfox1111: I'll name names. ikhudoshyn has a commit in at https://review.openstack.org/50597 | 16:24 |
| datsun180b | there you go | 16:24 |
| datsun180b | i said "can't", not "won't" | 16:24 |
| openstackgerrit | A change was merged to openstack/trove: Fix checksum verification exception. https://review.openstack.org/54565 | 16:39 |
| dmakogon | kfox1111, yes ikhudoshyn is working on mongodb | 16:41 |
| *** jcooley_ has joined #openstack-trove | 17:15 | |
| *** yogeshmehra has joined #openstack-trove | 17:16 | |
| *** yidclare has joined #openstack-trove | 17:29 | |
| *** yidclare1 has joined #openstack-trove | 17:29 | |
| *** yidclare has quit IRC | 17:29 | |
| *** coolsvap has joined #openstack-trove | 17:46 | |
| *** shakayumi has quit IRC | 17:50 | |
| *** mayfield has joined #openstack-trove | 17:53 | |
| *** arborism has joined #openstack-trove | 17:55 | |
| *** arborism has quit IRC | 18:02 | |
| *** amcrn has joined #openstack-trove | 18:03 | |
| *** jcooley_ has quit IRC | 18:07 | |
| *** jcooley_ has joined #openstack-trove | 18:08 | |
| *** shakayumi has joined #openstack-trove | 18:10 | |
| *** radez is now known as radez_g0n3 | 18:37 | |
| *** radez_g0n3 is now known as radez | 18:40 | |
| cp16net | dmakogon: ping | 18:42 |
| *** plodronio has joined #openstack-trove | 18:42 | |
| *** plodronio has left #openstack-trove | 18:43 | |
| *** adrian_otto has quit IRC | 18:44 | |
| openstackgerrit | Dmitriy Ukhlov proposed a change to openstack/trove: Trove instance model refactoring https://review.openstack.org/53346 | 18:48 |
| *** dukhlov has quit IRC | 18:49 | |
| *** plodronio has joined #openstack-trove | 18:49 | |
| dmakogon | cp16net, pong | 18:50 |
| *** plodronio has quit IRC | 18:51 | |
| dmakogon | cp16net, i'd like to start ML for configurations, because it need to be discussed | 18:51 |
| *** plodronio has joined #openstack-trove | 18:52 | |
| cp16net | there was a thread already startd there | 18:52 |
| cp16net | you might want to read through it | 18:52 |
| cp16net | dmakogon: but i wanted to ask what the reason is to not fail a create if the default config is not available to pass down | 18:53 |
| cp16net | it seems like there should be a template of the config | 18:54 |
| dmakogon | cp16net, no | 18:54 |
| cp16net | why? | 18:54 |
| dmakogon | cp16net, because database already have config out of box | 18:54 |
| dmakogon | cp16net, templating is optional | 18:54 |
| dmakogon | cp16net, what if i don't what any rendering | 18:55 |
| cp16net | put a blank file | 18:55 |
| cp16net | then it can be used later | 18:55 |
| cp16net | what database are you refering to? | 18:56 |
| dmakogon | cp16net, what sense makes empty file ? | 18:56 |
| dmakogon | cp16net, no matter which database i refer | 18:56 |
| dmakogon | cp16net, this should be optional and provisioning should not got failed because missing config | 18:57 |
| datsun180b | empty config != missing config though | 18:57 |
| datsun180b | if configs are missing there's a problem. if config is empty it's deliberate | 18:58 |
| dmakogon | there is no difference rendered jinja template would be empty | 18:58 |
| cp16net | hmmm | 18:58 |
| cp16net | yeah i think it kinda makes sense | 18:58 |
| dmakogon | so, any way, missing template should not be a reason to fail, empty template should not override out-of-box template | 18:59 |
| dmakogon | this idea perfectly suits to configurations updates | 18:59 |
| cp16net | true | 19:00 |
| cp16net | i think i get | 19:00 |
| cp16net | i think i get it. | 19:00 |
| cp16net | ok then just one issue on your review | 19:00 |
| dmakogon | if i have no template at provisioning - fine, i could update default conf later | 19:00 |
| dmakogon | cp16net, which one ? | 19:00 |
| cp16net | on that review | 19:00 |
| cp16net | dmakogon: yeah that makes sense | 19:01 |
| cp16net | makes it easier to get started with a new db | 19:01 |
| cp16net | dmakogon: https://review.openstack.org/#/c/53876/15/trove/tests/api/databases.py | 19:02 |
| dmakogon | cp16net, your complain - only text formating stuff | 19:04 |
| dmakogon | cp16net, it doesn't change functionality | 19:04 |
| dmakogon | cp16net, until it doesn't cause PEP8 error, i think that this is not the reason for -1 | 19:05 |
| datsun180b | no that's not very readable | 19:05 |
| dmakogon | datsun180b, ok | 19:06 |
| *** adrian_otto has joined #openstack-trove | 19:07 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 19:09 |
| dmakogon | datsun180b, cp16net https://review.openstack.org/#/c/53876/16/trove/tests/api/databases.py | 19:09 |
| dmakogon | is it ok now ? | 19:10 |
| datsun180b | would you mind adding a trailing comma to the last item in those dictionaries? | 19:12 |
| *** demorris has quit IRC | 19:13 | |
| datsun180b | something python that has not many others have, so that in the future adding an item to those lists is only a -1+1 diff | 19:13 |
| *** achampion has joined #openstack-trove | 19:13 | |
| *** demorris has joined #openstack-trove | 19:13 | |
| datsun180b | oh wow this whole review | 19:15 |
| datsun180b | oh those -0+0 changes scared me for a moment | 19:15 |
| kevinconway | dmakogon: can you make those dictionaries fit on one line please? | 19:16 |
| datsun180b | did you find -name *.py | xargs chmod a+x ? | 19:16 |
| kevinconway | just kidding | 19:16 |
| dmakogon | something happened while git review ... | 19:16 |
| datsun180b | /kick kevinconway | 19:17 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 19:17 |
| datsun180b | oh that makes sense | 19:17 |
| dmakogon | please , datsun180b, cp16net, kevinconway take a look at patch #17 | 19:18 |
| datsun180b | looking | 19:18 |
| datsun180b | i see a trailing space on databases.py 98 | 19:18 |
| datsun180b | 99 | 19:18 |
| datsun180b | but i'm not just here for style | 19:18 |
| kevinconway | dmakogon: what IDE / editor do you use? | 19:19 |
| dmakogon | kevinconway, last patch i've done with gedit | 19:20 |
| dmakogon | datsun180b, any complain except L94-102 ?? | 19:20 |
| dmakogon | datsun180b, are you there ?? | 19:21 |
| datsun180b | still looking, i need to actually understand your whole patchset before i sign off on it | 19:21 |
| datsun180b | cmon man you gave me 60 seconds to answer | 19:21 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Absence of conf template issue https://review.openstack.org/53876 | 19:22 |
| kevinconway | dmakogon: i ask because sublimetext2 has options to auto strip trailing whitespace, insert newlines at end of files, and plugins for PEP8 / Flake8 validation as you type | 19:22 |
| dmakogon | kevinconway, k | 19:22 |
| kevinconway | that's what i use anyway | 19:23 |
| kevinconway | i really like it | 19:23 |
| cp16net | i <3 sublimetext | 19:23 |
| datsun180b | you're all heathens, vim is truth and love and the only way | 19:23 |
| datsun180b | when the sun is dark and the world is ash there will still be vim | 19:24 |
| datsun180b | you'll cry out, reaching at me and begging for salvation | 19:24 |
| datsun180b | and i'll look down at you and say :q! | 19:24 |
| dmakogon | datsun180b, 60 secs are out))) | 19:25 |
| datsun180b | i was busy proselytizing | 19:25 |
| kevinconway | datsun180b: that seems inefficient. i always type ESC, Q, q, enter | 19:25 |
| datsun180b | /kick kevinconway | 19:27 |
| dmakogon | datsun180b, ok, i'll be available in 1-1.5h | 19:28 |
| * dmakogon going home | 19:28 | |
| *** adrian_otto has quit IRC | 19:29 | |
| *** mayfield_ has joined #openstack-trove | 19:33 | |
| *** mayfield has quit IRC | 19:35 | |
| *** adrian_otto has joined #openstack-trove | 19:36 | |
| the_real_kp | +1 sublimetext2 | 19:39 |
| *** radez is now known as radez_g0n3 | 19:41 | |
| *** tanisdl has joined #openstack-trove | 19:41 | |
| *** coolsvap has quit IRC | 19:49 | |
| *** demorris_ has joined #openstack-trove | 20:01 | |
| *** demorris has quit IRC | 20:03 | |
| *** demorris_ is now known as demorris | 20:03 | |
| cp16net | the_real_kp: knows whats up | 20:05 |
| *** krow has joined #openstack-trove | 20:22 | |
| *** achampion has quit IRC | 20:25 | |
| *** krow has quit IRC | 20:29 | |
| *** david-lyle has quit IRC | 20:34 | |
| *** rnirmal_ has joined #openstack-trove | 20:40 | |
| *** rnirmal_ has quit IRC | 20:40 | |
| *** rnirmal has quit IRC | 20:42 | |
| *** shakayumi has quit IRC | 20:43 | |
| *** shakayumi has joined #openstack-trove | 20:45 | |
| *** ppenjoy1 has joined #openstack-trove | 20:47 | |
| *** ppenjoy1 has quit IRC | 20:48 | |
| *** ppenjoy2 has joined #openstack-trove | 20:48 | |
| *** rnirmal has joined #openstack-trove | 20:48 | |
| *** adrian_otto_hkg has joined #openstack-trove | 20:54 | |
| *** adrian_otto_hkg has quit IRC | 20:56 | |
| *** plodronio has quit IRC | 20:57 | |
| *** Barker has quit IRC | 20:59 | |
| *** pdmars has quit IRC | 21:02 | |
| *** mayfield_ has quit IRC | 21:05 | |
| *** plodronio has joined #openstack-trove | 21:05 | |
| *** cweid has quit IRC | 21:09 | |
| *** denis_makogon has joined #openstack-trove | 21:13 | |
| *** Barker has joined #openstack-trove | 21:14 | |
| denis_makogon | datsun180b, cp16net ping | 21:16 |
| datsun180b | polo | 21:19 |
| *** robertmyers has quit IRC | 21:19 | |
| cp16net | denis_makogon: pong | 21:21 |
| denis_makogon | cp16net, have you looked at whole workflow of config swapping ? | 21:24 |
| denis_makogon | cp16net, if you do, that you should know that (in my patch) if outcome content is none, then 1st swapping would be skipped, it means that guestagent would relay on default my.cnf, guestagent would make a line-by-line copy of it and would add admin creds | 21:26 |
| *** ppenjoy2 has quit IRC | 21:27 | |
| denis_makogon | so, in my patch, 1st and 2nd config swapping are independent | 21:27 |
| denis_makogon | datsun180b, take a look at comments on #17 | 21:28 |
| datsun180b | i didn't hear a "please" in there | 21:29 |
| datsun180b | but okay | 21:29 |
| datsun180b | i'm worried that the TMP_MYCNF now has two ways to come into being and one of those ways is a little more nebulous than the other | 21:30 |
| denis_makogon | datsun180b, sorry, i'm a bit busy, was typing quickly =/ | 21:30 |
| denis_makogon | but those ways are independent | 21:31 |
| denis_makogon | each of methods doesn't relay on existance of TMP_MYCNF | 21:32 |
| datsun180b | if config_contents is false/null, then 695-67 don't run | 21:32 |
| denis_makogon | datsun180b, when i was looking at code, i also was a bit confused | 21:32 |
| denis_makogon | datsun180b, yes | 21:33 |
| datsun180b | i see what's going on | 21:33 |
| denis_makogon | datsun180b, please tell | 21:34 |
| datsun180b | gah this whole tmp-mycnf thing is goofy | 21:34 |
| datsun180b | i think what you've got is right | 21:34 |
| denis_makogon | sure ? | 21:35 |
| datsun180b | well let me resolve another issue first and i can devote my attention | 21:35 |
| denis_makogon | ok, anyway, datsun180b thanks | 21:35 |
| cp16net | hrm | 21:37 |
| cp16net | denis_makogon: i see what you are saying about reading and writing it again | 21:39 |
| denis_makogon | cp16net, good | 21:41 |
| denis_makogon | cp16net, any suggestions ? | 21:41 |
| cp16net | only one i see is the gate failed due to instance didnt go active | 21:42 |
| cp16net | and i thinks its because of something in the code you changed... | 21:43 |
| cp16net | on a completely different note reguarding python | 21:44 |
| cp16net | https://gist.github.com/cp16net/7272410 | 21:44 |
| denis_makogon | cp16net, sometime gate failing | 21:44 |
| cp16net | i dont understand why a dictionary hasattr fails | 21:44 |
| cp16net | but getting the attr is successful | 21:44 |
| denis_makogon | easy)) | 21:45 |
| cp16net | so the attr exists | 21:45 |
| denis_makogon | single kee isn't a class attr | 21:45 |
| denis_makogon | as i know even whole set is not class attr | 21:45 |
| denis_makogon | *jey | 21:45 |
| denis_makogon | *key | 21:45 |
| denis_makogon | if you need to perforn checks, it would be better to use dict.values(), dict.keys() | 21:46 |
| denis_makogon | or even haskey() | 21:46 |
| cp16net | oh.... | 21:46 |
| denis_makogon | i don't remember about hasvalue() | 21:47 |
| denis_makogon | but it easy to implement)) | 21:47 |
| cp16net | thats for an object | 21:47 |
| cp16net | not a dict | 21:47 |
| denis_makogon | dict is object | 21:47 |
| denis_makogon | cp16net, i suggest you to take a look at dict impl at Py27 and Py33-35 | 21:48 |
| cp16net | i think i was just doing things all wrong | 21:48 |
| denis_makogon | and, i personaly love, itertools | 21:48 |
| denis_makogon | this lib is amazing | 21:48 |
| *** rnirmal has quit IRC | 21:48 | |
| cp16net | ok that makes life much better | 21:49 |
| cp16net | i fixed it | 21:49 |
| cp16net | it was related to using Checks | 21:49 |
| cp16net | in my tests | 21:50 |
| denis_makogon | good) | 21:51 |
| cp16net | btw using the dcit get() is not always a good thing | 21:54 |
| cp16net | i think this espcially in tests | 21:54 |
| cp16net | its better to raise the attr not found exception and see the error than checking for None after you get | 21:54 |
| cp16net | when i was using the dict['key'] for the configuration rules is because the data structure is hard coded | 21:55 |
| cp16net | and keys are expected | 21:56 |
| denis_makogon | cp16net, get is faster then ['fgdfgdfg'[ | 21:56 |
| cp16net | really? | 21:56 |
| *** grapex has quit IRC | 21:56 | |
| denis_makogon | yes | 21:56 |
| cp16net | interesting | 21:56 |
| cp16net | it would take more code to handle the None that comes back tho | 21:57 |
| denis_makogon | as i know Py3x is going to give default dict method higher priority | 21:57 |
| denis_makogon | cp16net, you could use haskey, keys, value, items | 21:58 |
| denis_makogon | they are preferable | 21:58 |
| denis_makogon | about handling, process of hanling would be identical to each dict, you could wrap logic into separate method and then just call it | 21:59 |
| denis_makogon | trove already has one such func | 22:00 |
| denis_makogon | it called _log_and_raise | 22:00 |
| denis_makogon | i suppose | 22:00 |
| datsun180b | what | 22:03 |
| datsun180b | .get checks the keys first, how can it be faster | 22:03 |
| denis_makogon | you could perform small test | 22:04 |
| cp16net | yeah that doesnt make sense | 22:04 |
| datsun180b | i'm in a sporting mood, i'll do just that | 22:04 |
| denis_makogon | try to .get and [' ']1000000 items | 22:04 |
| denis_makogon | and measure time | 22:04 |
| cp16net | then try the same thing is a missing key | 22:05 |
| denis_makogon | i think difference is in low-level implementation | 22:05 |
| datsun180b | i know how to write profile tests | 22:05 |
| datsun180b | this is my day job | 22:05 |
| denis_makogon | datsun180b, nice))) | 22:05 |
| denis_makogon | didn't know | 22:05 |
| denis_makogon | thats great | 22:05 |
| datsun180b | ouch man | 22:05 |
| cp16net | LOLZ | 22:05 |
| denis_makogon | have anyone looked at C-ext impl ? | 22:06 |
| *** yogeshmehra has quit IRC | 22:08 | |
| *** jcru has quit IRC | 22:08 | |
| *** adrian_otto has quit IRC | 22:12 | |
| datsun180b | https://gist.github.com/ed-/e453833d43724fd0fe96 | 22:16 |
| datsun180b | let's see what happens if i write it so that there's never a miss, just for fun | 22:16 |
| datsun180b | actually on second thought even with the try/except in there use_squares is faster by 2x | 22:18 |
| *** Barker has quit IRC | 22:19 | |
| denis_makogon | what about py33 | 22:21 |
| datsun180b | worth a shot | 22:22 |
| datsun180b | augh i don't have 3.3 on this box | 22:23 |
| *** krow has joined #openstack-trove | 22:24 | |
| *** demorris has quit IRC | 22:26 | |
| datsun180b | on your revew denis_makogon if i'm reading this right you say if config_contents is null/empty in _write_mycnf then what happens is system.MYSQL_CONFIG is used as the base to substitute the admin account details and write to the tmp_mycnf, and then the tmp_mycnf is sudo-copied to the original location? | 22:27 |
| denis_makogon | yes | 22:28 |
| datsun180b | if system.mysql_config was empty or gone or syntactically incorrect whose fault is it when mysql is irrecoverable then? | 22:28 |
| denis_makogon | that is what i said and this is what guestagent does | 22:28 |
| denis_makogon | yes | 22:28 |
| datsun180b | just making sure we're swimming in the same river here | 22:28 |
| denis_makogon | yes, datsun180b we are on the same way | 22:29 |
| denis_makogon | that is why system.mysql_config is not configurable and stores it separate file | 22:30 |
| denis_makogon | *stored | 22:30 |
| datsun180b | i could see this being potentially destructive but you'd have to be able to inject a bogus template file once and then never supply another template | 22:31 |
| datsun180b | but i bet that's hiding behind server configs and not necessarily user input | 22:32 |
| denis_makogon | datsun180b, here comes configuration management | 22:34 |
| *** jmontemayor has quit IRC | 22:34 | |
| denis_makogon | if for some reasons we used default out-of-box config file, than we should update it | 22:34 |
| denis_makogon | even to allow connectivity from any IP | 22:35 |
| denis_makogon | datsun180b, cp16net thanks for nice chat for today, i wish you good weekend, sorry, but i'm out for this week, cu monday | 22:37 |
| * denis_makogon gone until monday | 22:37 | |
| *** krow has quit IRC | 22:37 | |
| *** datsun180b has left #openstack-trove | 22:39 | |
| *** krow has joined #openstack-trove | 22:50 | |
| *** mmcdaris has joined #openstack-trove | 22:57 | |
| *** adrian_otto has joined #openstack-trove | 23:16 | |
| *** plodronio has left #openstack-trove | 23:25 | |
| *** krow has quit IRC | 23:30 | |
| *** krow has joined #openstack-trove | 23:33 | |
| *** yidclare1 has quit IRC | 23:39 | |
| *** krow has quit IRC | 23:42 | |
| *** adrian_otto1 has joined #openstack-trove | 23:48 | |
| *** amcrn has quit IRC | 23:50 | |
| *** adrian_otto1 has quit IRC | 23:52 | |
| *** adrian_otto has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!